From unknown Sat Sep 20 12:49:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35171 <35171@debbugs.gnu.org> To: bug#35171 <35171@debbugs.gnu.org> Subject: Status: 26.1; file-locked-p does not respect file-name-coding-system Reply-To: bug#35171 <35171@debbugs.gnu.org> Date: Sat, 20 Sep 2025 19:49:28 +0000 retitle 35171 26.1; file-locked-p does not respect file-name-coding-system reassign 35171 emacs submitter 35171 Olli Helenius severity 35171 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 10:35:04 2019 Received: (at submit) by debbugs.gnu.org; 6 Apr 2019 14:35:04 +0000 Received: from localhost ([127.0.0.1]:47344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCmPP-0003nj-I9 for submit@debbugs.gnu.org; Sat, 06 Apr 2019 10:35:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCiOL-00081o-CT for submit@debbugs.gnu.org; Sat, 06 Apr 2019 06:17:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:35103) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hCiOG-00066I-4k for submit@debbugs.gnu.org; Sat, 06 Apr 2019 06:17:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCiOE-0005Ss-Lb for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 06:17:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCiOD-00062D-1Q for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 06:17:34 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:44016) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hCiOC-0005zH-LQ for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 06:17:32 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 45C22A189F for ; Sat, 6 Apr 2019 12:17:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id Uz8jRQ6JTqqO for ; Sat, 6 Apr 2019 12:17:17 +0200 (CEST) Date: Sat, 6 Apr 2019 13:17:17 +0300 (EEST) From: Olli Helenius To: bug-gnu-emacs@gnu.org Message-ID: <510095545.132397.1554545837223@office.mailbox.org> Subject: 26.1; file-locked-p does not respect file-name-coding-system MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Medium X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.241.60.215 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 06 Apr 2019 10:35:02 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) The =E2=80=98file-locked-p=E2=80=99 function does not call =E2=80=98ENCODE_= FILE=E2=80=99 on its argument and thus can end up looking for a different file name than that which was generated by =E2=80=98lock-buffer=E2=80=99. Below is an Elisp expressi= on that demonstrates the issue. ;; Returns string "file-locked-p buggy" if the result of file-locked-p ;; is `nil' even when the buffer should be locked. (let ((file-name-coding-system 'latin-1-unix) (create-lockfiles t)) (let ((file (make-temp-file "file-locked-p-=C3=A9=C3=B6-" nil ".txt" "tes= t")) =09(result nil)) (unwind-protect =09(progn =09 (find-file-existing file) =09 (insert "modification") (lock-buffer) =09 (if (eq nil (file-locked-p file)) =09 (setq result "file-locked-p buggy") =09 (setq result "file-locked-p ok")) =09 (save-buffer) =09 (kill-buffer) =09 result) (delete-file file nil)))) See also: http://git.savannah.gnu.org/cgit/emacs.git/tree/src/filelock.c?h=3Demacs-= 26.1#n680 http://git.savannah.gnu.org/cgit/emacs.git/tree/src/filelock.c?h=3Demacs-= 26.1#n829 In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5) of 2019-04-05 built on localhost Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Mark set [3 times] current-kill: Kill ring is empty Making completion list... Configured using: 'configure --prefix=3D/nix/store/1yj0jrwh9yr2h81nl50c88lqn254ylil-emacs-26.1 --with-modules --with-x-toolkit=3Dgtk3 --with-xft CFLAGS=3D-DMAC_OS_X_VERSION_MAX_ALLOWED=3D101200' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES THREADS LIBSYSTEMD Important settings: value of $EMACSLOADPATH: /nix/store/553k4fjrf5d523zrjvm7jmw6zx23cbmf-emac= s-packages-deps/share/emacs/site-lisp: value of $LANG: fi_FI.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /nix/store/553k4fjrf5d523zrjvm7jmw6zx23cbmf-emacs-packages-deps/share/emacs= /site-lisp/elpa/treemacs-20181223.519/treemacs-evil hides /nix/store/553k4f= jrf5d523zrjvm7jmw6zx23cbmf-emacs-packages-deps/share/emacs/site-lisp/elpa/t= reemacs-evil-20181227.747/treemacs-evil /nix/store/553k4fjrf5d523zrjvm7jmw6zx23cbmf-emacs-packages-deps/share/emacs= /site-lisp/elpa/treemacs-20181223.519/treemacs-projectile hides /nix/store/= 553k4fjrf5d523zrjvm7jmw6zx23cbmf-emacs-packages-deps/share/emacs/site-lisp/= elpa/treemacs-projectile-20181227.747/treemacs-projectile /nix/store/553k4fjrf5d523zrjvm7jmw6zx23cbmf-emacs-packages-deps/share/emacs= /site-lisp/elpa/seq-2.20/seq hides /nix/store/1yj0jrwh9yr2h81nl50c88lqn254y= lil-emacs-26.1/share/emacs/26.1/lisp/emacs-lisp/seq /nix/store/553k4fjrf5d523zrjvm7jmw6zx23cbmf-emacs-packages-deps/share/emacs= /site-lisp/elpa/let-alist-1.0.5/let-alist hides /nix/store/1yj0jrwh9yr2h81n= l50c88lqn254ylil-emacs-26.1/share/emacs/26.1/lisp/emacs-lisp/let-alist Features: (shadow sort mail-extr emacsbug message rmc puny seq seq-25 byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm time-date elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 100753 4370) (symbols 48 20340 1) (miscs 40 41 143) (strings 32 28643 993) (string-bytes 1 782458) (vectors 16 12695) (vector-slots 8 452201 6174) (floats 8 55 766) (intervals 56 276 8) (buffers 992 13)) From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 10:55:43 2019 Received: (at 35171) by debbugs.gnu.org; 6 Apr 2019 14:55:43 +0000 Received: from localhost ([127.0.0.1]:47368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCmjP-0004Iu-9g for submit@debbugs.gnu.org; Sat, 06 Apr 2019 10:55:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCmjM-0004Ig-Gn for 35171@debbugs.gnu.org; Sat, 06 Apr 2019 10:55:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCmjG-0005ps-0U; Sat, 06 Apr 2019 10:55:34 -0400 Received: from [176.228.60.248] (port=4819 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hCmjF-0001XN-Gm; Sat, 06 Apr 2019 10:55:33 -0400 Date: Sat, 06 Apr 2019 17:55:24 +0300 Message-Id: <83h8bb9o9v.fsf@gnu.org> From: Eli Zaretskii To: Olli Helenius In-reply-to: <510095545.132397.1554545837223@office.mailbox.org> (message from Olli Helenius on Sat, 6 Apr 2019 13:17:17 +0300 (EEST)) Subject: Re: bug#35171: 26.1; file-locked-p does not respect file-name-coding-system References: <510095545.132397.1554545837223@office.mailbox.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35171 Cc: 35171@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Date: Sat, 6 Apr 2019 13:17:17 +0300 (EEST) > From: Olli Helenius > > The ‘file-locked-p’ function does not call ‘ENCODE_FILE’ on its argument > and thus can end up looking for a different file name than that which > was generated by ‘lock-buffer’. Below is an Elisp expression that > demonstrates the issue. Thanks, fixed on the master branch. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 17:56:54 2019 Received: (at control) by debbugs.gnu.org; 6 Apr 2019 21:56:54 +0000 Received: from localhost ([127.0.0.1]:47558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCtJ0-0005oe-16 for submit@debbugs.gnu.org; Sat, 06 Apr 2019 17:56:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCtIy-0005oS-J7 for control@debbugs.gnu.org; Sat, 06 Apr 2019 17:56:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCtIt-0001gD-Al for control@debbugs.gnu.org; Sat, 06 Apr 2019 17:56:47 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hCtIs-0004Ke-TJ for control@debbugs.gnu.org; Sat, 06 Apr 2019 17:56:47 -0400 Subject: control message for bug 35171 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sat, 06 Apr 2019 17:56:46 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) # 91018ce close 35171 27.1 From unknown Sat Sep 20 12:49:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 05 May 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator