GNU bug report logs - #35155
[PATCH] build-system/cargo: refactor phases to successfully build

Previous Next

Full log

Message #23 received at 35155 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Petkov <ivanppetkov <at> gmail.com>
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 35155 <at> debbugs.gnu.org
Subject: Re: [PATCH] build-system/cargo: refactor phases to successfully build
Date: Sat, 6 Apr 2019 20:05:09 -0700

[Message part 1 (text/plain, inline)]

Hi Chris!

> On Apr 6, 2019, at 7:02 PM, Ivan Petkov <ivanppetkov <at> gmail.com> wrote:
> 
>> 
>>> * guix/build-system/cargo.scm (%cargo-build-system-modules):
>>> Add (json parser)
>> 
>> Nitpick: You're missing a period here, and in a few more sentences in
>> the ChangeLog entry.
> 
> Happy to update. After skimming the contributing guidelines I was left
> with the impression that commit messages are to only include the concrete
> changes that were made, and any additional elaboration should be made
> in code comments.

Please disregard this comment, I had misread your original email.

I’ve attached an updated version of my original patch.

—Ivan

[0001-build-system-cargo-refactor-phases-to-successfully-b.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.