GNU bug report logs - #35141
Add a default action to erc-desktop-notifications to switch to the originating buffer

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alex Murray <murray.alex <at> gmail.com>
Subject: bug#35141: closed (Re: bug#35141: Add a default action to
 erc-desktop-notifications to switch to the originating buffer)
Date: Fri, 12 Apr 2019 12:17:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 35141 <at> debbugs.gnu.org.

-- 
35141: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35141
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Alex Murray <murray.alex <at> gmail.com>
Cc: 35141-done <at> debbugs.gnu.org
Subject: Re: bug#35141: Add a default action to erc-desktop-notifications to
 switch to the originating buffer
Date: Fri, 12 Apr 2019 13:16:41 +0100

Alex Murray <murray.alex <at> gmail.com> writes:

> Done - see attached. Thanks again for your help.
>
> On Fri, 5 Apr 2019 at 21:52, Basil L. Contovounesios <contovob <at> tcd.ie> wrote:
>
>  Otherwise LGTM, but we'll have to wait a few days to give others a
>  chance to comment.

Thanks, pushed to master[1].  I made minor edits to the commit message
to follow CONTRIBUTE guidelines and to make it slightly more accurate
and less redundant.

[1: 6dc4c722af]: Pop to originating erc buffer when clicking desktop notification
  2019-04-12 13:08:28 +0100
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6dc4c722af4e5f9f189631638700cd1fb3cc2edb

If you're interested in making further contributions, I would recommend
starting the copyright assignment process.  See CONTRIBUTE and (info
"(emacs) Copyright Assignment") for details.

Thanks,

-- 
Basil

[Message part 3 (message/rfc822, inline)]

From: Alex Murray <murray.alex <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Add a default action to erc-desktop-notifications to switch to the
 originating buffer
Date: Thu, 4 Apr 2019 17:02:24 +1030

[Message part 4 (text/plain, inline)]

Attached is a patch which converts erc-desktop-notifications.el to
lexical-binding and adds a default action to the generated notifications so
that when they are clicked we automatically switch to the originating
buffer.

[Message part 5 (text/html, inline)]

[0001-Switch-to-originating-erc-buffer-when-clicking-deskt.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.