GNU bug report logs - #35141
Add a default action to erc-desktop-notifications to switch to the originating buffer

Previous Next

Full log

Message #21 received at 35141 <at> debbugs.gnu.org (full text, mbox):

From: Alex Murray <murray.alex <at> gmail.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 35141 <at> debbugs.gnu.org
Subject: Re: bug#35141: Add a default action to erc-desktop-notifications to
 switch to the originating buffer
Date: Sat, 6 Apr 2019 20:22:38 +1030

[Message part 1 (text/plain, inline)]

Done - see attached. Thanks again for your help.

On Fri, 5 Apr 2019 at 21:52, Basil L. Contovounesios <contovob <at> tcd.ie>
wrote:

> Alex Murray <murray.alex <at> gmail.com> writes:
>
> > Thanks for the review - see attached for an updated version based on
> your feedback.
>
> I just tried byte-compiling the patched file and got the following
> warning:
>
>   ELC      erc/erc-desktop-notifications.elc
>   In toplevel form:
>   erc/erc-desktop-notifications.el:74:1:
>   Warning: Unused lexical argument ‘proc’
>
> Since this arises because of lexical-binding, could you please also add
> an underscore to the name of the PROC argument in
> erc-notifications-PRIVMSG?
>
> Otherwise LGTM, but we'll have to wait a few days to give others a
> chance to comment.
>
> Thanks,
>
> --
> Basil
>

[Message part 2 (text/html, inline)]

[0001-Switch-to-originating-erc-buffer-when-clicking-deskt.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.