GNU bug report logs - #35141
Add a default action to erc-desktop-notifications to switch to the originating buffer

Previous Next

Package: emacs;

Reported by: Alex Murray <murray.alex <at> gmail.com>

Date: Thu, 4 Apr 2019 12:38:02 UTC

Severity: wishlist

Tags: patch

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Alex Murray <murray.alex <at> gmail.com>
Cc: 35141 <at> debbugs.gnu.org
Subject: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer
Date: Fri, 05 Apr 2019 12:22:41 +0100

Alex Murray <murray.alex <at> gmail.com> writes:

> Thanks for the review - see attached for an updated version based on your feedback.

I just tried byte-compiling the patched file and got the following
warning:

  ELC      erc/erc-desktop-notifications.elc
  In toplevel form:
  erc/erc-desktop-notifications.el:74:1:
  Warning: Unused lexical argument ‘proc’

Since this arises because of lexical-binding, could you please also add
an underscore to the name of the PROC argument in
erc-notifications-PRIVMSG?

Otherwise LGTM, but we'll have to wait a few days to give others a
chance to comment.

Thanks,

-- 
Basil
This bug report was last modified 6 years and 41 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.