From unknown Sat Jun 21 10:33:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35141 <35141@debbugs.gnu.org> To: bug#35141 <35141@debbugs.gnu.org> Subject: Status: Add a default action to erc-desktop-notifications to switch to the originating buffer Reply-To: bug#35141 <35141@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:33:27 +0000 retitle 35141 Add a default action to erc-desktop-notifications to switch t= o the originating buffer reassign 35141 emacs submitter 35141 Alex Murray severity 35141 wishlist tag 35141 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 08:37:49 2019 Received: (at submit) by debbugs.gnu.org; 4 Apr 2019 12:37:49 +0000 Received: from localhost ([127.0.0.1]:43765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC1cr-0006pH-7r for submit@debbugs.gnu.org; Thu, 04 Apr 2019 08:37:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBvvf-0004Mu-2F for submit@debbugs.gnu.org; Thu, 04 Apr 2019 02:32:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:42507) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBvvZ-0000yc-Qz for submit@debbugs.gnu.org; Thu, 04 Apr 2019 02:32:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBvvY-00044k-OF for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2019 02:32:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBvvX-0000w5-O2 for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2019 02:32:44 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:36228) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBvvX-0000r3-7l for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2019 02:32:43 -0400 Received: by mail-wm1-x32b.google.com with SMTP id h18so1791486wml.1 for ; Wed, 03 Apr 2019 23:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=F73NlmReMIZH+H1sZoDbWlyrjG+HUh/6W8435zrQ4Bo=; b=W9aDPrjcR3p1Fsrhnriz6EMfcjVCplbQ+/2jEHi2/9ED9nBXtlFrEYTcpdpUC23OBY bZAApoyMCUE/bo5PS1pxHfPocqftCmA7UCGPT52KzHCZzdpheQ4KI5twe7Nbj82csNLw oz9hlWVSUdhZ+zrrPOxnCN2r/oJb1eTj0sRjW7JF9DQZuJ7kI8DZw3QZZc2csN5J1pwx eqK+lmn1wn7CS/KJo3k5cCS867CFfR5smaeDCnybqStZqYmfkcvAOVN4TPjd2Wa+wQRQ Oean30ai51RSNpq1GkKf7hb4M6E4BXcfel5Rr3xvBmjhpPz5Yx+hBcxL0Zr0QkSzD9Hi LYLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=F73NlmReMIZH+H1sZoDbWlyrjG+HUh/6W8435zrQ4Bo=; b=BkCUQEFgWGDUh0YSCrNAvcOwCQmWlagaSOljLxzG31RWlZrcPzz1WyUHNdW7uSmaXg TgM10x9+sOxZmhyoOdKXp7i9xY1eNoFhM+c87fcNQyW/CwtHwpHmmK1M7LI+OQDMTSNh RHffH9spXIL5daDFEOyotUhHOicL61SAmKrPuEqwbhTnL9f6u/T4XiwlUoi5YdbwUXzA 0xwz8w/z3XDwFdEBIH0DAyLh0FkU4GbhuN/Waxf90TdlsH488OpxIHj8n17xQv+cHcLd chqG1h+1BI+iKAl+nwX1D7a81SJs3j5eF35A6ttsvvmpaiyIYiyQnT7zof8aWUaHxG9l 2T8Q== X-Gm-Message-State: APjAAAU2q+DSgc3HUDxGE9Vtyg4hb2KpD+XP1YcBOVsJvhiK3hX/V92B eDYB9BXWIyIW0Ehdkl7pjK+tzAe4XHarBcS3rFQx/v8x X-Google-Smtp-Source: APXvYqyT8EJIC6Qo4z51BzLoAIyqatfa9IDEWAE983+d0emESdLpQFYz7ukiqoWCmoc6GpFTUSR56aQqVhyyXt3bUgo= X-Received: by 2002:a1c:6783:: with SMTP id b125mr2667697wmc.41.1554359561069; Wed, 03 Apr 2019 23:32:41 -0700 (PDT) MIME-Version: 1.0 From: Alex Murray Date: Thu, 4 Apr 2019 17:02:24 +1030 Message-ID: Subject: Add a default action to erc-desktop-notifications to switch to the originating buffer To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000007dc7570585ae893a" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32b X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 04 Apr 2019 08:37:47 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --0000000000007dc7570585ae893a Content-Type: multipart/alternative; boundary="0000000000007dc7540585ae8938" --0000000000007dc7540585ae8938 Content-Type: text/plain; charset="UTF-8" Attached is a patch which converts erc-desktop-notifications.el to lexical-binding and adds a default action to the generated notifications so that when they are clicked we automatically switch to the originating buffer. --0000000000007dc7540585ae8938 Content-Type: text/html; charset="UTF-8"
Attached is a patch which converts erc-desktop-notifications.el to lexical-binding and adds a default action to the generated notifications so that when they are clicked we automatically switch to the originating buffer.
--0000000000007dc7540585ae8938-- --0000000000007dc7570585ae893a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Switch-to-originating-erc-buffer-when-clicking-deskt.patch" Content-Disposition: attachment; filename="0001-Switch-to-originating-erc-buffer-when-clicking-deskt.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ju29jc7y0 RnJvbSA1MmI2MzI3MmVlZDhhYWFmY2Q5MzFlODMzYWQwMDZkZDQyNWQ2NTEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IE11cnJheSA8bXVycmF5LmFsZXhAZ21haWwuY29tPgpE YXRlOiBUaHUsIDQgQXByIDIwMTkgMTY6NDk6NDggKzEwMzAKU3ViamVjdDogW1BBVENIXSBTd2l0 Y2ggdG8gb3JpZ2luYXRpbmcgZXJjIGJ1ZmZlciB3aGVuIGNsaWNraW5nIGRlc2t0b3AKIG5vdGlm aWNhdGlvbgoKKiBsaXNwL2VyYy9lcmMtZGVza3RvcC1ub3RpZmljYXRpb25zLmVsOiBTd2l0Y2gg dG8gbGV4aWNhbC1iaW5kaW5nIGFuZAogIGFkZCBhIGRlZmF1bHQgYWN0aW9uIHRvIHRoZSBkZXNr dG9wIG5vdGlmaWNhdGlvbiB3aGljaCBzd2l0Y2hlcyB0bwogIHRoZSBidWZmZXIgZnJvbSB3aGlj aCB0aGUgbm90aWZpY2F0aW9uIG9yaWdpbmF0ZWQuIEFzIHN1Y2ggY2xpY2tpbmcKICBvbiB0aGUg bm90aWZpY2F0aW9uIG5vdyBhdXRvbWF0aWNhbGx5IHN3aXRjaGVzIHRvIHRoYXQgYnVmZmVyLgot LS0KIENoYW5nZUxvZy4zICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgNyArKysrKysrCiBs aXNwL2VyYy9lcmMtZGVza3RvcC1ub3RpZmljYXRpb25zLmVsIHwgMTggKysrKysrKysrKysrLS0t LS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvQ2hhbmdlTG9nLjMgYi9DaGFuZ2VMb2cuMwppbmRleCAyMzVjOGJiMTgwLi4z ODE5ZDZiNGZlIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cuMworKysgYi9DaGFuZ2VMb2cuMwpAQCAt MSwzICsxLDEwIEBACisyMDE5LTA0LTA0ICBBbGV4IE11cnJheSAgPG11cnJheS5hbGV4QGdtYWls LmNvbT4KKworCSogbGlzcC9lcmMvZXJjLWRlc2t0b3Atbm90aWZpY2F0aW9ucy5lbDogVXNlIGxl eGljYWwtYmluZGluZy4KKwkoZXJjLW5vdGlmaWNhdGlvbnMtbm90aWZ5KTogQWRkIGEgZGVmYXVs dCBhY3Rpb24gdG8KKwlub3RpZmljYXRpb25zIHdoaWNoIHN3aXRjaGVzIHRvIHRoZSBidWZmZXIg ZnJvbSB3aGljaCB0aGUKKwlub3RpZmljYXRpb24gb3JpZ2luYXRlZC4KKwogMjAxOS0wMy0yMCAg RWxpIFphcmV0c2tpaSAgPGVsaXpAZ251Lm9yZz4KIAogCUltcHJvdmUgaW5kZXhpbmcgb2YgdGhl IHVzZXIgbWFudWFsCmRpZmYgLS1naXQgYS9saXNwL2VyYy9lcmMtZGVza3RvcC1ub3RpZmljYXRp b25zLmVsIGIvbGlzcC9lcmMvZXJjLWRlc2t0b3Atbm90aWZpY2F0aW9ucy5lbAppbmRleCA1NmI5 MzkyNWNlLi5jMWI4MTJjMTE5IDEwMDY0NAotLS0gYS9saXNwL2VyYy9lcmMtZGVza3RvcC1ub3Rp ZmljYXRpb25zLmVsCisrKyBiL2xpc3AvZXJjL2VyYy1kZXNrdG9wLW5vdGlmaWNhdGlvbnMuZWwK QEAgLTEsNCArMSw0IEBACi07OyBlcmMtZGVza3RvcC1ub3RpZmljYXRpb25zLmVsIC0tIFNlbmQg bm90aWZpY2F0aW9uIG9uIFBSSVZNU0cgb3IgbWVudGlvbnMKKzs7IGVyYy1kZXNrdG9wLW5vdGlm aWNhdGlvbnMuZWwgLS0gU2VuZCBub3RpZmljYXRpb24gb24gUFJJVk1TRyBvciBtZW50aW9ucyAt Ki0gbGV4aWNhbC1iaW5kaW5nOnQgLSotCiAKIDs7IENvcHlyaWdodCAoQykgMjAxMi0yMDE5IEZy ZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgogCkBAIC01OSwxMSArNTksMTcgQEAKIFRoaXMg d2lsbCByZXBsYWNlIHRoZSBsYXN0IG5vdGlmaWNhdGlvbiBzZW50IHdpdGggdGhpcyBmdW5jdGlv bi4iCiAgIChkYnVzLWlnbm9yZS1lcnJvcnMKICAgICAoc2V0cSBlcmMtbm90aWZpY2F0aW9ucy1s YXN0LW5vdGlmaWNhdGlvbgotICAgICAgICAgIChub3RpZmljYXRpb25zLW5vdGlmeSA6YnVzIGVy Yy1ub3RpZmljYXRpb25zLWJ1cwotCQkJCTp0aXRsZSAoeG1sLWVzY2FwZS1zdHJpbmcgbmljaykK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOmJvZHkgKHhtbC1lc2NhcGUtc3RyaW5n IG1zZykKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOnJlcGxhY2VzLWlkIGVyYy1u b3RpZmljYXRpb25zLWxhc3Qtbm90aWZpY2F0aW9uCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDphcHAtaWNvbiBlcmMtbm90aWZpY2F0aW9ucy1pY29uKSkpKQorICAgICAgICAgIChs ZXQgKChjaGFubmVsIChjdXJyZW50LWJ1ZmZlcikpKQorICAgICAgICAgICAgKG5vdGlmaWNhdGlv bnMtbm90aWZ5IDpidXMgZXJjLW5vdGlmaWNhdGlvbnMtYnVzCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgOnRpdGxlIChmb3JtYXQgIiVzIGluICVzIgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh4bWwtZXNjYXBlLXN0cmluZyBuaWNr KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChidWZm ZXItbmFtZSBjaGFubmVsKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6Ym9k eSAoeG1sLWVzY2FwZS1zdHJpbmcgbXNnKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDpyZXBsYWNlcy1pZCBlcmMtbm90aWZpY2F0aW9ucy1sYXN0LW5vdGlmaWNhdGlvbgorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDphcHAtaWNvbiBlcmMtbm90aWZpY2F0aW9u cy1pY29uCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOmFjdGlvbnMgJygiZGVm YXVsdCIgIlN3aXRjaCB0byBidWZmZXIiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDpvbi1hY3Rpb24gIycobGFtYmRhIChpZCBhY3Rpb24pCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN3aXRjaC10by1idWZmZXIgY2hhbm5lbCkp KSkpKSkKIAogKGRlZnVuIGVyYy1ub3RpZmljYXRpb25zLVBSSVZNU0cgKHByb2MgcGFyc2VkKQog ICAobGV0ICgobmljayAoY2FyIChlcmMtcGFyc2UtdXNlciAoZXJjLXJlc3BvbnNlLnNlbmRlciBw YXJzZWQpKSkpCi0tIAoyLjE3LjEKCg== --0000000000007dc7570585ae893a-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 22:13:14 2019 Received: (at 35141) by debbugs.gnu.org; 5 Apr 2019 02:13:14 +0000 Received: from localhost ([127.0.0.1]:44898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCELx-0006Eb-5f for submit@debbugs.gnu.org; Thu, 04 Apr 2019 22:13:13 -0400 Received: from mail-ed1-f51.google.com ([209.85.208.51]:37346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCELu-0006EO-Pw for 35141@debbugs.gnu.org; Thu, 04 Apr 2019 22:13:11 -0400 Received: by mail-ed1-f51.google.com with SMTP id v21so4084580edq.4 for <35141@debbugs.gnu.org>; Thu, 04 Apr 2019 19:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=40XskszhKpPFCb99xtA6qsnE6bBQxGxt1SDYAS9mK/w=; b=DVPhxRTIN7m/0m1SZRsVr9qGrMKSoualKGGkNVAi3VNHzkwJ87MX/kjaLLYFUB4Wfh pUb2R26jgDZDDfUQ1tBLjWRq8dyNMWKwj5Yc0FVIlKaeybQ5EeWgLpj0mmYq9IpfRUN6 IFF9F5Oz9XCUa9CnyrH76917RiFXwLQPeIh+jmrii/ldeLlifKjAuLxmtSfbV1FwNpoL l5OPvBlQlQEs9whu9tySYWdjHnEtRQE+DGNUfpbNKhkPvVZ5nOezg76x6I1K6ME6LXzP F8q1f+2WyCAThTmjxHJirIvmNV+qQmQtA/e7BayRMG3ZrUZrmJXMzhPoEUM1B0dNqKiL CfJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=40XskszhKpPFCb99xtA6qsnE6bBQxGxt1SDYAS9mK/w=; b=JtgAhfXi8K0McjBcKPc+R/NuUVo0cUNTfwnenGei3OHZ18kD3ocmkNk+P6Zj6511WR IFsbZyyohSuP3vMGt0mmMvq5+VBXnXYg0fFmeOD6LqHPtngQY6u5pzYJo6XvaGU4F6uZ jtzixcwrhpjMatsrGE5UHltjmbMvEhStbGohyLBYF0kxkNIlBKGy22APFZ+QpnnU+PJU O8mqTK/UynqZ795PRknj8nanXqUHMlgw+9Sr2eJ63Rpm/cOkqqAS5J9YdfyoLF8rhYkD d9O8JEVPk757hY5RaV8VJQjXZ7BV+EMECVsnCtjfOVRApY0tNpRhYcyquzBmSaYiWJz5 s7+A== X-Gm-Message-State: APjAAAVcXvcDMcPQk7xHCEd7Z01b3zn68fULD1LQnSU9P6UX1NHAGYoG tX1fjKX057SF0xKh3u5mCRabPg== X-Google-Smtp-Source: APXvYqwtR5blEI5RbHnhSw6Oz4Ot/lOMyQMkRagQ9PGrHTRsBVnIOGlq2Zapns4ci5IEHVTmIVaVrA== X-Received: by 2002:a17:906:364f:: with SMTP id r15mr5591137ejb.215.1554430384949; Thu, 04 Apr 2019 19:13:04 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:20c2:134e:4f3a:683a]) by smtp.gmail.com with ESMTPSA id s3sm3783227ejk.17.2019.04.04.19.13.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Apr 2019 19:13:03 -0700 (PDT) From: "Basil L. Contovounesios" To: Alex Murray Subject: Re: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer References: Date: Fri, 05 Apr 2019 03:13:02 +0100 In-Reply-To: (Alex Murray's message of "Thu, 4 Apr 2019 17:02:24 +1030") Message-ID: <87wok919ox.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35141 Cc: 35141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Murray writes: > Attached is a patch which converts erc-desktop-notifications.el to > lexical-binding and adds a default action to the generated > notifications so that when they are clicked we automatically switch to > the originating buffer. SGTM. > From 52b63272eed8aaafcd931e833ad006dd425d6512 Mon Sep 17 00:00:00 2001 > From: Alex Murray > Date: Thu, 4 Apr 2019 16:49:48 +1030 > Subject: [PATCH] Switch to originating erc buffer when clicking desktop > notification > > * lisp/erc/erc-desktop-notifications.el: Switch to lexical-binding and > add a default action to the desktop notification which switches to > the buffer from which the notification originated. As such clicking > on the notification now automatically switches to that buffer. Please mention the name of the function changed: * lisp/erc/erc-desktop-notifications.el: Switch to lexical-binding. (erc-notifications-notify): Add ... Unless you have completed your copyright assignment for contributions to Emacs, the commit message should also include: Copyright-paperwork-exempt: yes For more details, see the file CONTRIBUTE. > diff --git a/ChangeLog.3 b/ChangeLog.3 > index 235c8bb180..3819d6b4fe 100644 > --- a/ChangeLog.3 > +++ b/ChangeLog.3 > @@ -1,3 +1,10 @@ > +2019-04-04 Alex Murray > + > + * lisp/erc/erc-desktop-notifications.el: Use lexical-binding. > + (erc-notifications-notify): Add a default action to > + notifications which switches to the buffer from which the > + notification originated. > + > 2019-03-20 Eli Zaretskii > > Improve indexing of the user manual ChangeLog files are no longer maintained by hand, but rather generated from Git commit messages. > diff --git a/lisp/erc/erc-desktop-notifications.el b/lisp/erc/erc-desktop-notifications.el > index 56b93925ce..c1b812c119 100644 > --- a/lisp/erc/erc-desktop-notifications.el > +++ b/lisp/erc/erc-desktop-notifications.el > @@ -59,11 +59,17 @@ > This will replace the last notification sent with this function." > (dbus-ignore-errors > (setq erc-notifications-last-notification > - (notifications-notify :bus erc-notifications-bus > - :title (xml-escape-string nick) > - :body (xml-escape-string msg) > - :replaces-id erc-notifications-last-notification > - :app-icon erc-notifications-icon)))) > + (let ((channel (current-buffer))) > + (notifications-notify :bus erc-notifications-bus > + :title (format "%s in %s" > + (xml-escape-string nick) > + (buffer-name channel)) No need for buffer-name; you can pass buffers directly to "%s". > + :body (xml-escape-string msg) > + :replaces-id erc-notifications-last-notification > + :app-icon erc-notifications-icon > + :actions '("default" "Switch to buffer") > + :on-action #'(lambda (id action) > + (switch-to-buffer channel))))))) This should instead be something like the following: (lambda (&rest _) (pop-to-buffer channel)) In particular, lambdas don't need to be quoted with #', pop-to-buffer is far better behaved than switch-to-buffer, and unused argument names should either start with an underscore or be omitted. Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 23:22:37 2019 Received: (at 35141) by debbugs.gnu.org; 5 Apr 2019 03:22:37 +0000 Received: from localhost ([127.0.0.1]:44941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCFR5-000826-NE for submit@debbugs.gnu.org; Thu, 04 Apr 2019 23:22:36 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:50415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCFR3-00081s-HF for 35141@debbugs.gnu.org; Thu, 04 Apr 2019 23:22:34 -0400 Received: by mail-wm1-f47.google.com with SMTP id z11so5203101wmi.0 for <35141@debbugs.gnu.org>; Thu, 04 Apr 2019 20:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yd+NnSI+PlOVMNRywMb5Wn1MADSmykQpg/v0t2jk298=; b=qrQ/NwjnOJ6mD88aNoVustqi9YySmQWddhREKQnYLdgIjkCRNJMvraOYELdn6MyX6Y GXgw4B9D0wtwRgIE1t1C7coXnkmmsmFGR+kLxgtVcAMK0QqXkKd5hTOtEAMFjbxSp/Ut 6h52jQuMvaaECVJN0nowaviaDNlGMXFwm0Sh4ByH5yjLMbgG+txn6iPE4pd1Csao7tIM EYtk7a63wYbuWEz5nYQomBAHV5RWzyd9wT0/QtXOZElCP+do3x4dyZTgtJ+T1RebQ9aX BergRnwF8ANnATWB2NTj3kVh7mmRbi6iYUyonR5z8inGOwZxO1CchffrpcGvfh7ArSkK yDJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yd+NnSI+PlOVMNRywMb5Wn1MADSmykQpg/v0t2jk298=; b=AiPnTPa2w0wf6DJ7ffZ3lYEHH5+b5Ra8wVYgbIlxOILf6wOVDPRbIPymfzON+yl4t7 7+D/zhARexHJAc166e8S4yG+KiC6ZXVxmhv6vGIziXwDTu4MIZDORWkS97kXNnf9B8nC CIfyXI1L7qLDN7yMHVe6NmmglXPsKYCOZJr7lFySp4gFraWr0YftQC1o/2YJd6Akml5x JieG9WSc4EFLz0yXHVmKPKHeeKnQ5K606eY9Wqr2AXtTF9SLjKFZFqj2fZGbC10brhwH VVHke9yC87ccU+SHthBiKbdHRVxmS7OP4yvhZ2c7Dom/6BMk9iV6Mq7GJstFNGvJBUzc kpIw== X-Gm-Message-State: APjAAAWkMdgQfz1JUZ8IJxleSSN2LTqY3LrinxeTGVIDAu+6qvqTib/s ihm5vPO/+EEOiR7KnlRbTY8iHA3PFxTFhXV/Pjc= X-Google-Smtp-Source: APXvYqxUOFAnzmhng5Y9O6u0uemSQpGRKx6Z4hFUqDCiT+4eaULAHTtiCz2wyWUUbOqsqn4cgydYDWTkKakL1nH5zR4= X-Received: by 2002:a1c:a8d3:: with SMTP id r202mr6433058wme.106.1554434547397; Thu, 04 Apr 2019 20:22:27 -0700 (PDT) MIME-Version: 1.0 References: <87wok919ox.fsf@tcd.ie> In-Reply-To: <87wok919ox.fsf@tcd.ie> From: Alex Murray Date: Fri, 5 Apr 2019 13:52:10 +1030 Message-ID: Subject: Re: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer To: "Basil L. Contovounesios" Content-Type: multipart/mixed; boundary="0000000000000650d90585bfffeb" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35141 Cc: 35141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000650d90585bfffeb Content-Type: multipart/alternative; boundary="0000000000000650d60585bfffe9" --0000000000000650d60585bfffe9 Content-Type: text/plain; charset="UTF-8" Hi Basil, Thanks for the review - see attached for an updated version based on your feedback. Cheers, Alex On Fri, 5 Apr 2019 at 12:43, Basil L. Contovounesios wrote: > Alex Murray writes: > > > Attached is a patch which converts erc-desktop-notifications.el to > > lexical-binding and adds a default action to the generated > > notifications so that when they are clicked we automatically switch to > > the originating buffer. > > SGTM. > > > From 52b63272eed8aaafcd931e833ad006dd425d6512 Mon Sep 17 00:00:00 2001 > > From: Alex Murray > > Date: Thu, 4 Apr 2019 16:49:48 +1030 > > Subject: [PATCH] Switch to originating erc buffer when clicking desktop > > notification > > > > * lisp/erc/erc-desktop-notifications.el: Switch to lexical-binding and > > add a default action to the desktop notification which switches to > > the buffer from which the notification originated. As such clicking > > on the notification now automatically switches to that buffer. > > Please mention the name of the function changed: > > * lisp/erc/erc-desktop-notifications.el: Switch to lexical-binding. > (erc-notifications-notify): Add ... > > Unless you have completed your copyright assignment for contributions to > Emacs, the commit message should also include: > > Copyright-paperwork-exempt: yes > > For more details, see the file CONTRIBUTE. > > > diff --git a/ChangeLog.3 b/ChangeLog.3 > > index 235c8bb180..3819d6b4fe 100644 > > --- a/ChangeLog.3 > > +++ b/ChangeLog.3 > > @@ -1,3 +1,10 @@ > > +2019-04-04 Alex Murray > > + > > + * lisp/erc/erc-desktop-notifications.el: Use lexical-binding. > > + (erc-notifications-notify): Add a default action to > > + notifications which switches to the buffer from which the > > + notification originated. > > + > > 2019-03-20 Eli Zaretskii > > > > Improve indexing of the user manual > > ChangeLog files are no longer maintained by hand, but rather generated > from Git commit messages. > > > diff --git a/lisp/erc/erc-desktop-notifications.el > b/lisp/erc/erc-desktop-notifications.el > > index 56b93925ce..c1b812c119 100644 > > --- a/lisp/erc/erc-desktop-notifications.el > > +++ b/lisp/erc/erc-desktop-notifications.el > > @@ -59,11 +59,17 @@ > > This will replace the last notification sent with this function." > > (dbus-ignore-errors > > (setq erc-notifications-last-notification > > - (notifications-notify :bus erc-notifications-bus > > - :title (xml-escape-string nick) > > - :body (xml-escape-string msg) > > - :replaces-id > erc-notifications-last-notification > > - :app-icon erc-notifications-icon)))) > > + (let ((channel (current-buffer))) > > + (notifications-notify :bus erc-notifications-bus > > + :title (format "%s in %s" > > + (xml-escape-string > nick) > > + (buffer-name channel)) > > No need for buffer-name; you can pass buffers directly to "%s". > > > + :body (xml-escape-string msg) > > + :replaces-id > erc-notifications-last-notification > > + :app-icon erc-notifications-icon > > + :actions '("default" "Switch to > buffer") > > + :on-action #'(lambda (id action) > > + (switch-to-buffer > channel))))))) > > This should instead be something like the following: > > (lambda (&rest _) > (pop-to-buffer channel)) > > In particular, lambdas don't need to be quoted with #', pop-to-buffer is > far better behaved than switch-to-buffer, and unused argument names > should either start with an underscore or be omitted. > > Thanks, > > -- > Basil > --0000000000000650d60585bfffe9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Basil,

Thanks for the review - see a= ttached for an updated version based on your feedback.

=
Cheers,
Alex


On Fri, 5 Apr 2019 at 12:43= , Basil L. Contovounesios <contovob@t= cd.ie> wrote:
Alex Murray <murray.alex@gmail.com> writes:

> Attached is a patch which converts erc-desktop-notifications.el to
> lexical-binding and adds a default action to the generated
> notifications so that when they are clicked we automatically switch to=
> the originating buffer.

SGTM.

> From 52b63272eed8aaafcd931e833ad006dd425d6512 Mon Sep 17 00:00:00 2001=
> From: Alex Murray <murray.alex@gmail.com>
> Date: Thu, 4 Apr 2019 16:49:48 +1030
> Subject: [PATCH] Switch to originating erc buffer when clicking deskto= p
>=C2=A0 notification
>
> * lisp/erc/erc-desktop-notifications.el: Switch to lexical-binding and=
>=C2=A0 =C2=A0add a default action to the desktop notification which swi= tches to
>=C2=A0 =C2=A0the buffer from which the notification originated. As such= clicking
>=C2=A0 =C2=A0on the notification now automatically switches to that buf= fer.

Please mention the name of the function changed:

* lisp/erc/erc-desktop-notifications.el: Switch to lexical-binding.
(erc-notifications-notify): Add ...

Unless you have completed your copyright assignment for contributions to Emacs, the commit message should also include:

Copyright-paperwork-exempt: yes

For more details, see the file CONTRIBUTE.

> diff --git a/ChangeLog.3 b/ChangeLog.3
> index 235c8bb180..3819d6b4fe 100644
> --- a/ChangeLog.3
> +++ b/ChangeLog.3
> @@ -1,3 +1,10 @@
> +2019-04-04=C2=A0 Alex Murray=C2=A0 <murray.alex@gmail.com>
> +
> +=C2=A0 =C2=A0 =C2=A0* lisp/erc/erc-desktop-notifications.el: Use lexi= cal-binding.
> +=C2=A0 =C2=A0 =C2=A0(erc-notifications-notify): Add a default action = to
> +=C2=A0 =C2=A0 =C2=A0notifications which switches to the buffer from w= hich the
> +=C2=A0 =C2=A0 =C2=A0notification originated.
> +
>=C2=A0 2019-03-20=C2=A0 Eli Zaretskii=C2=A0 <eliz@gnu.org>
>=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Improve indexing of the user manual

ChangeLog files are no longer maintained by hand, but rather generated
from Git commit messages.

> diff --git a/lisp/erc/erc-desktop-notifications.el b/lisp/erc/erc-desk= top-notifications.el
> index 56b93925ce..c1b812c119 100644
> --- a/lisp/erc/erc-desktop-notifications.el
> +++ b/lisp/erc/erc-desktop-notifications.el
> @@ -59,11 +59,17 @@
>=C2=A0 This will replace the last notification sent with this function.= "
>=C2=A0 =C2=A0 (dbus-ignore-errors
>=C2=A0 =C2=A0 =C2=A0 (setq erc-notifications-last-notification
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (notifications-notify :bus erc-not= ifications-bus
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0:title (xml-escape-string nick)
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :body (xml-escape-string msg) > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :replaces-id erc-notifications-l= ast-notification
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :app-icon erc-notifications-icon= ))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((channel (current-buffer)))<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (notifications-notify :bus = erc-notifications-bus
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :title (format "%s i= n %s"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(xml-escape-string nick)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(buffer-name channel))

No need for buffer-name; you can pass buffers directly to "%s".
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :body (xml-escape-string = msg)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :replaces-id erc-notifica= tions-last-notification
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :app-icon erc-notificatio= ns-icon
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :actions '("defa= ult" "Switch to buffer")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :on-action #'(lambda = (id action)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(switch-to-buffer channel)))))))

This should instead be something like the following:

=C2=A0 (lambda (&rest _)
=C2=A0 =C2=A0 (pop-to-buffer channel))

In particular, lambdas don't need to be quoted with #', pop-to-buff= er is
far better behaved than switch-to-buffer, and unused argument names
should either start with an underscore or be omitted.

Thanks,

--
Basil
--0000000000000650d60585bfffe9-- --0000000000000650d90585bfffeb Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Switch-to-originating-erc-buffer-when-clicking-deskt.patch" Content-Disposition: attachment; filename="0001-Switch-to-originating-erc-buffer-when-clicking-deskt.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ju3i5rp10 RnJvbSBmMjJlYWQ2YTU4NDU1N2RlYWEwNGEyNDZiMjI1NzRhZWQzOGFhYzNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IE11cnJheSA8bXVycmF5LmFsZXhAZ21haWwuY29tPgpE YXRlOiBUaHUsIDQgQXByIDIwMTkgMTY6NDk6NDggKzEwMzAKU3ViamVjdDogW1BBVENIXSBTd2l0 Y2ggdG8gb3JpZ2luYXRpbmcgZXJjIGJ1ZmZlciB3aGVuIGNsaWNraW5nIGRlc2t0b3AKIG5vdGlm aWNhdGlvbgoKKiBsaXNwL2VyYy9lcmMtZGVza3RvcC1ub3RpZmljYXRpb25zLmVsOiBTd2l0Y2gg dG8gbGV4aWNhbC1iaW5kaW5nLgogIChlcmMtbm90aWZpY2F0aW9ucy1ub3RpZnkpIEFkZCBhIGRl ZmF1bHQgYWN0aW9uIHRvIHRoZSBkZXNrdG9wCiAgbm90aWZpY2F0aW9uIHdoaWNoIHN3aXRjaGVz IHRvIHRoZSBidWZmZXIgZnJvbSB3aGljaCB0aGUKICBub3RpZmljYXRpb24gb3JpZ2luYXRlZC4g QXMgc3VjaCBjbGlja2luZyBvbiB0aGUgbm90aWZpY2F0aW9uIG5vdwogIGF1dG9tYXRpY2FsbHkg c3dpdGNoZXMgdG8gdGhhdCBidWZmZXIuIChCdWcjMzUxNDEpCgpDb3B5cmlnaHQtcGFwZXJ3b3Jr LWV4ZW1wdDogeWVzCi0tLQogbGlzcC9lcmMvZXJjLWRlc2t0b3Atbm90aWZpY2F0aW9ucy5lbCB8 IDE4ICsrKysrKysrKysrKy0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyks IDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lcmMvZXJjLWRlc2t0b3Atbm90aWZp Y2F0aW9ucy5lbCBiL2xpc3AvZXJjL2VyYy1kZXNrdG9wLW5vdGlmaWNhdGlvbnMuZWwKaW5kZXgg NTZiOTM5MjVjZS4uNDA0NjM5OTk2OSAxMDA2NDQKLS0tIGEvbGlzcC9lcmMvZXJjLWRlc2t0b3At bm90aWZpY2F0aW9ucy5lbAorKysgYi9saXNwL2VyYy9lcmMtZGVza3RvcC1ub3RpZmljYXRpb25z LmVsCkBAIC0xLDQgKzEsNCBAQAotOzsgZXJjLWRlc2t0b3Atbm90aWZpY2F0aW9ucy5lbCAtLSBT ZW5kIG5vdGlmaWNhdGlvbiBvbiBQUklWTVNHIG9yIG1lbnRpb25zCis7OyBlcmMtZGVza3RvcC1u b3RpZmljYXRpb25zLmVsIC0tIFNlbmQgbm90aWZpY2F0aW9uIG9uIFBSSVZNU0cgb3IgbWVudGlv bnMgLSotIGxleGljYWwtYmluZGluZzp0IC0qLQogCiA7OyBDb3B5cmlnaHQgKEMpIDIwMTItMjAx OSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KIApAQCAtNTksMTEgKzU5LDE3IEBACiBU aGlzIHdpbGwgcmVwbGFjZSB0aGUgbGFzdCBub3RpZmljYXRpb24gc2VudCB3aXRoIHRoaXMgZnVu Y3Rpb24uIgogICAoZGJ1cy1pZ25vcmUtZXJyb3JzCiAgICAgKHNldHEgZXJjLW5vdGlmaWNhdGlv bnMtbGFzdC1ub3RpZmljYXRpb24KLSAgICAgICAgICAobm90aWZpY2F0aW9ucy1ub3RpZnkgOmJ1 cyBlcmMtbm90aWZpY2F0aW9ucy1idXMKLQkJCQk6dGl0bGUgKHhtbC1lc2NhcGUtc3RyaW5nIG5p Y2spCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpib2R5ICh4bWwtZXNjYXBlLXN0 cmluZyBtc2cpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpyZXBsYWNlcy1pZCBl cmMtbm90aWZpY2F0aW9ucy1sYXN0LW5vdGlmaWNhdGlvbgotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICA6YXBwLWljb24gZXJjLW5vdGlmaWNhdGlvbnMtaWNvbikpKSkKKyAgICAgICAg ICAobGV0ICgoY2hhbm5lbCAoY3VycmVudC1idWZmZXIpKSkKKyAgICAgICAgICAgIChub3RpZmlj YXRpb25zLW5vdGlmeSA6YnVzIGVyYy1ub3RpZmljYXRpb25zLWJ1cworICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIDp0aXRsZSAoZm9ybWF0ICIlcyBpbiAlcyIKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoeG1sLWVzY2FwZS1zdHJpbmcg bmljaykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj aGFubmVsKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpib2R5ICh4bWwtZXNj YXBlLXN0cmluZyBtc2cpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOnJlcGxh Y2VzLWlkIGVyYy1ub3RpZmljYXRpb25zLWxhc3Qtbm90aWZpY2F0aW9uCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgOmFwcC1pY29uIGVyYy1ub3RpZmljYXRpb25zLWljb24KKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6YWN0aW9ucyAnKCJkZWZhdWx0IiAiU3dp dGNoIHRvIGJ1ZmZlciIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOm9uLWFj dGlvbiAobGFtYmRhICgmcmVzdCBfKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAocG9wLXRvLWJ1ZmZlciBjaGFubmVsKSkpKSkpKQogCiAoZGVmdW4gZXJj LW5vdGlmaWNhdGlvbnMtUFJJVk1TRyAocHJvYyBwYXJzZWQpCiAgIChsZXQgKChuaWNrIChjYXIg KGVyYy1wYXJzZS11c2VyIChlcmMtcmVzcG9uc2Uuc2VuZGVyIHBhcnNlZCkpKSkKLS0gCjIuMTcu MQoK --0000000000000650d90585bfffeb-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 07:22:52 2019 Received: (at 35141) by debbugs.gnu.org; 5 Apr 2019 11:22:52 +0000 Received: from localhost ([127.0.0.1]:45103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCMvr-0004uZ-Mx for submit@debbugs.gnu.org; Fri, 05 Apr 2019 07:22:51 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:41139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCMvp-0004uL-GC for 35141@debbugs.gnu.org; Fri, 05 Apr 2019 07:22:50 -0400 Received: by mail-ed1-f65.google.com with SMTP id u2so750189eds.8 for <35141@debbugs.gnu.org>; Fri, 05 Apr 2019 04:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=CDGPaTQIuwgihIg2dEw57bV4OKlFLnEY3iekta3DhyA=; b=rufOncvyQdh2qXv5Oq3KQsn62+497cb79xrKV6dBHDuH5Tc/o5aDAoAIW5Mg4E8D5o tNwuSvspU6vGsMKGX5/KNnm6WDNaGrjS23uyB9H5PEfJ+ETN3qPZZXzq+tZsU5PSBZ1C 4Pshrdg8xH7C6u1GtHOhPEdZIeL0LBLRWa4iSkST9XAyPcQ08yvsfaqZYBLKCJ6x6qBR bmi6KeuXQZQAGkEnxtmfDICVeQVNhqTLHUpe6Y+mD+vrdm1sQ3MqT8tFEdrdll7jgKOu VE9d3jK+kOEry2prcQjL+WK5YAseZB2mY+/Hx/dEVf36Dx5iabKLJvnrm3G18phg8n3x 7MyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=CDGPaTQIuwgihIg2dEw57bV4OKlFLnEY3iekta3DhyA=; b=lF/uXchRYv8NBF4+Uliw8VkchouZYs6JMvI4xo8PTAv93BWBttTCGvrCqLHUiTPIzy O3Tiz0vMw5/z0wTvkSBpRTbJQeCCm1tosVtMBpaNhznkkoq8+LStIf+hKdW4triCW0V3 k8ZGvhfHxaWAw1Ea/vEUA21NtFabdluurxSpXs2Acfkzm6g3nsQgWqp9obhKjXPtKh2P G97VFftC6dcSU4dRCcn/mBJC63Q2NLGGuToT7AHUe2L1N0G1wuutSm9fwimFHY17vpAQ /wTxFDuGRd1Mds7oDFngrpXaS1GOMEhYSRStgbcOcwcf2ckgwSY+usaFoC/FOEQ7/sNE h2SA== X-Gm-Message-State: APjAAAWzaAnRQ+uTkauDVSr/1ooZPSt6wMXsUew93jO2pvllcxfHapSj fuYQ7SoogYYDzu/yNSvIab6Ugg== X-Google-Smtp-Source: APXvYqxmdhEqT0HAfy6bHQyyOhNAzN5jjeozA1K2SZ4YmGBIA9afO1U8W6jgP5Gsz0+siqNrgeYqOg== X-Received: by 2002:a17:906:c52:: with SMTP id t18mr6834038ejf.53.1554463363674; Fri, 05 Apr 2019 04:22:43 -0700 (PDT) Received: from localhost (86-41-18-45-dynamic.agg3.crz.crz-crz.eircom.net. [86.41.18.45]) by smtp.gmail.com with ESMTPSA id m20sm3032532ejz.72.2019.04.05.04.22.42 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Apr 2019 04:22:42 -0700 (PDT) From: "Basil L. Contovounesios" To: Alex Murray Subject: Re: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer References: <87wok919ox.fsf@tcd.ie> Date: Fri, 05 Apr 2019 12:22:41 +0100 In-Reply-To: (Alex Murray's message of "Fri, 5 Apr 2019 13:52:10 +1030") Message-ID: <87d0m08zni.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35141 Cc: 35141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Murray writes: > Thanks for the review - see attached for an updated version based on your= feedback. I just tried byte-compiling the patched file and got the following warning: ELC erc/erc-desktop-notifications.elc In toplevel form: erc/erc-desktop-notifications.el:74:1: Warning: Unused lexical argument =E2=80=98proc=E2=80=99 Since this arises because of lexical-binding, could you please also add an underscore to the name of the PROC argument in erc-notifications-PRIVMSG? Otherwise LGTM, but we'll have to wait a few days to give others a chance to comment. Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 07:36:19 2019 Received: (at control) by debbugs.gnu.org; 5 Apr 2019 11:36:19 +0000 Received: from localhost ([127.0.0.1]:45112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCN8t-0007Hc-Bc for submit@debbugs.gnu.org; Fri, 05 Apr 2019 07:36:19 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:43805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCN8r-0007HO-RV for control@debbugs.gnu.org; Fri, 05 Apr 2019 07:36:18 -0400 Received: by mail-qt1-f179.google.com with SMTP id v32so6876426qtc.10 for ; Fri, 05 Apr 2019 04:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=hUfU8G2Rgt99UJHcRwR8JM154KriEJnlj+I02DUDxPw=; b=UhcwhWu9fHl/Xon9oHDdpmA9YRF308NcwVwdwLJS7EKT2euVY8XP0/dkrKADYOc7IY T+hI/hZpENA7bTx8v/8iAQp4LP3jMJJQSDIQbTh/VurSKMm5ylbbU8Y0xGwn4Q4IdHKx nwo5Hb/hzC6gDfj5L+rqwwVtP7WHd1QWrmChO4qL/gIfCfrUWPknnsn+UN8qVD/IxI8o qdYt0B7V+WHHqlImq1hYAtgKx2BHZVIFi6jY4Vt3Dwg2atDaA9B1KWBx7g2LxZjcMhse ogvaxeenrhFzp5mBnOe8lPzG64PQPu+wSqQxkgRGUdFr6xuOnb7DBmt6Ufayko2Bhmae e6yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=hUfU8G2Rgt99UJHcRwR8JM154KriEJnlj+I02DUDxPw=; b=uW3qBWIYlrT28nT7k3vrQZ6Jpb/wSnvbPXwZB5rISqAf/o7ZvQZc9mErNY3HJhEIWJ KNYsxAyBfr0hlhaGvVjkT+lK5NVkLxgryr3q1zDrizA4/h1ZVbI7u9F3tCEH+LHItG69 1G49OC7fbRNqXE4LdDqSu6Y8b3dQA0dGR93X26WpZVqnLKRvikMtsqj/364ieQzbBlND DGm9cNAl55iGpOhGwGmnPHGltgWORRuhSSFpO44pZVVk5ymT5KsbYNl8mAj6Khpyl+i1 qH9FjCHFpqaSGTpEComjLh5cKjwVM8ohAtdqEUV+nnQvVRw1PaKUtyLOX7IkBhlEZq6m JGTg== X-Gm-Message-State: APjAAAUS3TaMfzauExAmLxRtP39BBhPVbaYAKOksVFbvAukev35UKRsE XGUEPTeP4pIPNitOAx3Jxyiz4lMk X-Google-Smtp-Source: APXvYqyTMnQzxLiA60iUS3tzu6tT367F7YTrXxuBoYqpVUVp5Di4Pbuq+dGx+7NtJh69I9/fxkAK3w== X-Received: by 2002:a0c:afd4:: with SMTP id t20mr9774328qvc.128.1554464171924; Fri, 05 Apr 2019 04:36:11 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id t69sm11291258qke.38.2019.04.05.04.36.10 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Apr 2019 04:36:11 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #35141 Date: Fri, 05 Apr 2019 07:36:10 -0400 Message-ID: <87tvfcd6qd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 35141 wishlist tags 35141 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 05:53:04 2019 Received: (at 35141) by debbugs.gnu.org; 6 Apr 2019 09:53:04 +0000 Received: from localhost ([127.0.0.1]:46572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCi0V-0007RN-Uw for submit@debbugs.gnu.org; Sat, 06 Apr 2019 05:53:04 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:34580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCi0T-0007Qp-E3 for 35141@debbugs.gnu.org; Sat, 06 Apr 2019 05:53:02 -0400 Received: by mail-wr1-f54.google.com with SMTP id p10so10696800wrq.1 for <35141@debbugs.gnu.org>; Sat, 06 Apr 2019 02:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yLX7FX3vkH/EilWBzQWgRJ3Z1bMZuQ90184dyESlRaA=; b=fv/ROPIADg42EV2M0EFDg9CZvtHnBRq9aRr1Oa6Z2ZYWL0zyQZx5R/UqkmtoPjBblJ Em/eFAbl0i9bkADTxtv+bicKCK4mEBKaxkuJzV2Ku8FqY+8LmdGMkOE32HQw3rSU7BAU nNJ34zKUsmOipr7/JJCxO/ssjhwQs7am4/vLUjSfyU0u3sEluK3MDuOofksHa3C1tBvU ZFM7umlLIZTVym6bKgRWR0RjzM1e+10vg9xHC3JYvI3fD6SHHjstZAxsySp9hKV5GUCy BK8AFngyktuY/q9Bac+IFzzV02LyzLnq9gimNPmjTnnYsmAEc/K2ZtMvX0rEuQqU8N2P 1gHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yLX7FX3vkH/EilWBzQWgRJ3Z1bMZuQ90184dyESlRaA=; b=rG3h1f4IZI+w3QRlVS6Hh5Ca7K3K1xR146NeluviujprlSDz2/ccPOXAw/Rt41xdj8 vWy8q9pmWVafq3jF230/pu1vFn+5EbWd7QJ6jle9mhZ/RwYzqMpZEdSOdkW7NY4aGzNp lrI9voZEGZrQv2FLI8q9WUTKiuPKxMUumDuejqf4pPQ8bVpEIZ0G76V8LTVOYimxUykD pUhdGwtwVBS9051+03m8rej6sOHEYhfEBBaL7W7gj6m1QEwMEWVI5mLqwn34gb96ngXu 9k068RjpGDdoh2IuTCQuIMXDTNaJ+vMUqZok08glM37NS2+PCK+8rN12dvHzcHKKfLCd tDkA== X-Gm-Message-State: APjAAAWNAJo+oX0WuO4c/RjPuf5jI+V2Qd67n+jus+mAs7nrIT44tALA VyX9YA3rGw1tHWoT+CjONCDf1eNi6bnykqJzXQ4= X-Google-Smtp-Source: APXvYqz8D42P4ku0uLxFT+QXvdGfvZL1LArrF0MAv+GuPX1dWo8r36BsFni202AnN8BaRJI07+28AyPV7vClgsjIcpw= X-Received: by 2002:a5d:634c:: with SMTP id b12mr11886947wrw.203.1554544375248; Sat, 06 Apr 2019 02:52:55 -0700 (PDT) MIME-Version: 1.0 References: <87wok919ox.fsf@tcd.ie> <87d0m08zni.fsf@tcd.ie> In-Reply-To: <87d0m08zni.fsf@tcd.ie> From: Alex Murray Date: Sat, 6 Apr 2019 20:22:38 +1030 Message-ID: Subject: Re: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer To: "Basil L. Contovounesios" Content-Type: multipart/mixed; boundary="000000000000466dc70585d99188" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35141 Cc: 35141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000466dc70585d99188 Content-Type: multipart/alternative; boundary="000000000000466dbe0585d99186" --000000000000466dbe0585d99186 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Done - see attached. Thanks again for your help. On Fri, 5 Apr 2019 at 21:52, Basil L. Contovounesios wrote: > Alex Murray writes: > > > Thanks for the review - see attached for an updated version based on > your feedback. > > I just tried byte-compiling the patched file and got the following > warning: > > ELC erc/erc-desktop-notifications.elc > In toplevel form: > erc/erc-desktop-notifications.el:74:1: > Warning: Unused lexical argument =E2=80=98proc=E2=80=99 > > Since this arises because of lexical-binding, could you please also add > an underscore to the name of the PROC argument in > erc-notifications-PRIVMSG? > > Otherwise LGTM, but we'll have to wait a few days to give others a > chance to comment. > > Thanks, > > -- > Basil > --000000000000466dbe0585d99186 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Done - see attached. Thanks again for your help.
On Fr= i, 5 Apr 2019 at 21:52, Basil L. Contovounesios <contovob@tcd.ie> wrote:
Alex Murray <murray.alex@gmail.com> writes:

> Thanks for the review - see attached for an updated version based on y= our feedback.

I just tried byte-compiling the patched file and got the following
warning:

=C2=A0 ELC=C2=A0 =C2=A0 =C2=A0 erc/erc-desktop-notifications.elc
=C2=A0 In toplevel form:
=C2=A0 erc/erc-desktop-notifications.el:74:1:
=C2=A0 Warning: Unused lexical argument =E2=80=98proc=E2=80=99

Since this arises because of lexical-binding, could you please also add
an underscore to the name of the PROC argument in
erc-notifications-PRIVMSG?

Otherwise LGTM, but we'll have to wait a few days to give others a
chance to comment.

Thanks,

--
Basil
--000000000000466dbe0585d99186-- --000000000000466dc70585d99188 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Switch-to-originating-erc-buffer-when-clicking-deskt.patch" Content-Disposition: attachment; filename="0001-Switch-to-originating-erc-buffer-when-clicking-deskt.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ju5bkksn0 RnJvbSA1ODY3N2I0OTNiYThmYmRjMzJiZTdlNzc2MzQ2M2I2YzZjYzU5YTBkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IE11cnJheSA8bXVycmF5LmFsZXhAZ21haWwuY29tPgpE YXRlOiBUaHUsIDQgQXByIDIwMTkgMTY6NDk6NDggKzEwMzAKU3ViamVjdDogW1BBVENIXSBTd2l0 Y2ggdG8gb3JpZ2luYXRpbmcgZXJjIGJ1ZmZlciB3aGVuIGNsaWNraW5nIGRlc2t0b3AKIG5vdGlm aWNhdGlvbgoKKiBsaXNwL2VyYy9lcmMtZGVza3RvcC1ub3RpZmljYXRpb25zLmVsOiBTd2l0Y2gg dG8gbGV4aWNhbC1iaW5kaW5nLgogIChlcmMtbm90aWZpY2F0aW9ucy1ub3RpZnkpIEFkZCBhIGRl ZmF1bHQgYWN0aW9uIHRvIHRoZSBkZXNrdG9wCiAgbm90aWZpY2F0aW9uIHdoaWNoIHN3aXRjaGVz IHRvIHRoZSBidWZmZXIgZnJvbSB3aGljaCB0aGUKICBub3RpZmljYXRpb24gb3JpZ2luYXRlZC4g QXMgc3VjaCBjbGlja2luZyBvbiB0aGUgbm90aWZpY2F0aW9uIG5vdwogIGF1dG9tYXRpY2FsbHkg c3dpdGNoZXMgdG8gdGhhdCBidWZmZXIuIChCdWcjMzUxNDEpCgpDb3B5cmlnaHQtcGFwZXJ3b3Jr LWV4ZW1wdDogeWVzCi0tLQogbGlzcC9lcmMvZXJjLWRlc2t0b3Atbm90aWZpY2F0aW9ucy5lbCB8 IDIyICsrKysrKysrKysrKysrLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25z KCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZXJjL2VyYy1kZXNrdG9wLW5v dGlmaWNhdGlvbnMuZWwgYi9saXNwL2VyYy9lcmMtZGVza3RvcC1ub3RpZmljYXRpb25zLmVsCmlu ZGV4IDU2YjkzOTI1Y2UuLjQxYjc0MjAzMjAgMTAwNjQ0Ci0tLSBhL2xpc3AvZXJjL2VyYy1kZXNr dG9wLW5vdGlmaWNhdGlvbnMuZWwKKysrIGIvbGlzcC9lcmMvZXJjLWRlc2t0b3Atbm90aWZpY2F0 aW9ucy5lbApAQCAtMSw0ICsxLDQgQEAKLTs7IGVyYy1kZXNrdG9wLW5vdGlmaWNhdGlvbnMuZWwg LS0gU2VuZCBub3RpZmljYXRpb24gb24gUFJJVk1TRyBvciBtZW50aW9ucworOzsgZXJjLWRlc2t0 b3Atbm90aWZpY2F0aW9ucy5lbCAtLSBTZW5kIG5vdGlmaWNhdGlvbiBvbiBQUklWTVNHIG9yIG1l bnRpb25zIC0qLSBsZXhpY2FsLWJpbmRpbmc6dCAtKi0KIAogOzsgQ29weXJpZ2h0IChDKSAyMDEy LTIwMTkgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCiAKQEAgLTU5LDEzICs1OSwxOSBA QAogVGhpcyB3aWxsIHJlcGxhY2UgdGhlIGxhc3Qgbm90aWZpY2F0aW9uIHNlbnQgd2l0aCB0aGlz IGZ1bmN0aW9uLiIKICAgKGRidXMtaWdub3JlLWVycm9ycwogICAgIChzZXRxIGVyYy1ub3RpZmlj YXRpb25zLWxhc3Qtbm90aWZpY2F0aW9uCi0gICAgICAgICAgKG5vdGlmaWNhdGlvbnMtbm90aWZ5 IDpidXMgZXJjLW5vdGlmaWNhdGlvbnMtYnVzCi0JCQkJOnRpdGxlICh4bWwtZXNjYXBlLXN0cmlu ZyBuaWNrKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6Ym9keSAoeG1sLWVzY2Fw ZS1zdHJpbmcgbXNnKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6cmVwbGFjZXMt aWQgZXJjLW5vdGlmaWNhdGlvbnMtbGFzdC1ub3RpZmljYXRpb24KLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgOmFwcC1pY29uIGVyYy1ub3RpZmljYXRpb25zLWljb24pKSkpCi0KLShk ZWZ1biBlcmMtbm90aWZpY2F0aW9ucy1QUklWTVNHIChwcm9jIHBhcnNlZCkKKyAgICAgICAgICAo bGV0ICgoY2hhbm5lbCAoY3VycmVudC1idWZmZXIpKSkKKyAgICAgICAgICAgIChub3RpZmljYXRp b25zLW5vdGlmeSA6YnVzIGVyYy1ub3RpZmljYXRpb25zLWJ1cworICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDp0aXRsZSAoZm9ybWF0ICIlcyBpbiAlcyIKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoeG1sLWVzY2FwZS1zdHJpbmcgbmlj aykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFu bmVsKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpib2R5ICh4bWwtZXNjYXBl LXN0cmluZyBtc2cpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOnJlcGxhY2Vz LWlkIGVyYy1ub3RpZmljYXRpb25zLWxhc3Qtbm90aWZpY2F0aW9uCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgOmFwcC1pY29uIGVyYy1ub3RpZmljYXRpb25zLWljb24KKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6YWN0aW9ucyAnKCJkZWZhdWx0IiAiU3dpdGNo IHRvIGJ1ZmZlciIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOm9uLWFjdGlv biAobGFtYmRhICgmcmVzdCBfKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAocG9wLXRvLWJ1ZmZlciBjaGFubmVsKSkpKSkpKQorCisoZGVmdW4gZXJjLW5v dGlmaWNhdGlvbnMtUFJJVk1TRyAoX3Byb2MgcGFyc2VkKQogICAobGV0ICgobmljayAoY2FyIChl cmMtcGFyc2UtdXNlciAoZXJjLXJlc3BvbnNlLnNlbmRlciBwYXJzZWQpKSkpCiAgICAgICAgICh0 YXJnZXQgKGNhciAoZXJjLXJlc3BvbnNlLmNvbW1hbmQtYXJncyBwYXJzZWQpKSkKICAgICAgICAg KG1zZyAoZXJjLXJlc3BvbnNlLmNvbnRlbnRzIHBhcnNlZCkpKQotLSAKMi4xNy4xCgo= --000000000000466dc70585d99188-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 12 08:16:57 2019 Received: (at 35141-done) by debbugs.gnu.org; 12 Apr 2019 12:16:57 +0000 Received: from localhost ([127.0.0.1]:55562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEv72-0001re-Sy for submit@debbugs.gnu.org; Fri, 12 Apr 2019 08:16:57 -0400 Received: from mail-ed1-f46.google.com ([209.85.208.46]:38688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEv6z-0001rQ-Py for 35141-done@debbugs.gnu.org; Fri, 12 Apr 2019 08:16:54 -0400 Received: by mail-ed1-f46.google.com with SMTP id d13so8144638edr.5 for <35141-done@debbugs.gnu.org>; Fri, 12 Apr 2019 05:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0NtxtMVKshdujoWQ5YjQ7GJi3Ky7acOc9WLLgwAIdMo=; b=g+LrLrzuv5ovPeVs8fUR/EkpwqnY7j/43PHKMUJ5GxMOiFqk1G7k60bdBr00JtTrRt 2J+Nv8fZPS6QQ9UAFHvj9HsJxBdqI2xkUuivQ4xHGlkYTZ84bUkx82T9T5rq0UD0QTMr HYESBQoWC2E9cin51LaOYsuDygOVFVjRDkAymJfS+etk+3k82dq1mLEkB7wCGI/qMBhF sxGDu+pbA4k9tim2/B7wpbJH/w1TlHXy6BZwAuoE9ZHXU2R0OfFhNXPqyP+3tfcPwDpr 7BHW9zMAWp1OlYin9eMcje7i+cX27oXTlZUk9pEetSwuwfm+ZTcIl5cKq7xMMu1WwutR UqfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0NtxtMVKshdujoWQ5YjQ7GJi3Ky7acOc9WLLgwAIdMo=; b=KC5wraJ9Nhy/xm2mxXrny5e0iWQ8xZb75wMWWc8xqM02VQSdV1DhFLQXm2078D1aVQ 7k+JIozjXRXufizxWryx52wmCVPgKK+ggj3goxVPWcDZrtRwvBly9Zym1CMPpy9xCnLS IrmEXvA3nj0nUgHXWI+8PVSLIrksdaH1jHq2ptdvjGsBvXmIN05xZXpehKMoI4xX2Ui4 BekKtmMrALZ/wIxuXjoSVx09533UMNWoYZwPW48WpJP5ve9P+7+ZBGtlfDtJ1ouG+LMq x6OGD0FaI2qb/25JZF0TpFI7zyC4duQKAE4xxX6vvs+ujzhwZUXEVjWTDpwdgaB25XDt yySQ== X-Gm-Message-State: APjAAAXt4zjK0Ml2AcdCMw41t5U2LPPBnDvDtvBTNHtRRdQ1NuD6+uq7 i88XLQa+NEAxQ0mk+CIAmtsY4Q== X-Google-Smtp-Source: APXvYqw9ADd9l3t8fEjjkv683k6lczJtFQUg+xkrUXw1D9FvaON+Xr5u+O2QXh1zK2ocAvd3AlBwng== X-Received: by 2002:a50:b8a2:: with SMTP id l31mr35549841ede.83.1555071407911; Fri, 12 Apr 2019 05:16:47 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id h9sm320304edw.20.2019.04.12.05.16.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 12 Apr 2019 05:16:46 -0700 (PDT) From: "Basil L. Contovounesios" To: Alex Murray Subject: Re: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer References: <87wok919ox.fsf@tcd.ie> <87d0m08zni.fsf@tcd.ie> Date: Fri, 12 Apr 2019 13:16:41 +0100 In-Reply-To: (Alex Murray's message of "Sat, 6 Apr 2019 20:22:38 +1030") Message-ID: <87imvjctau.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35141-done Cc: 35141-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Murray writes: > Done - see attached. Thanks again for your help. > > On Fri, 5 Apr 2019 at 21:52, Basil L. Contovounesios wrote: > > Otherwise LGTM, but we'll have to wait a few days to give others a > chance to comment. Thanks, pushed to master[1]. I made minor edits to the commit message to follow CONTRIBUTE guidelines and to make it slightly more accurate and less redundant. [1: 6dc4c722af]: Pop to originating erc buffer when clicking desktop notification 2019-04-12 13:08:28 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6dc4c722af4e5f9f189631638700cd1fb3cc2edb If you're interested in making further contributions, I would recommend starting the copyright assignment process. See CONTRIBUTE and (info "(emacs) Copyright Assignment") for details. Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 08:17:37 2019 Received: (at 35141-done) by debbugs.gnu.org; 14 Apr 2019 12:17:37 +0000 Received: from localhost ([127.0.0.1]:60087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFe4m-0008NA-LP for submit@debbugs.gnu.org; Sun, 14 Apr 2019 08:17:36 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:44946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFe4k-0008Mv-Bj for 35141-done@debbugs.gnu.org; Sun, 14 Apr 2019 08:17:34 -0400 Received: by mail-wr1-f49.google.com with SMTP id y7so18014494wrn.11 for <35141-done@debbugs.gnu.org>; Sun, 14 Apr 2019 05:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VDJDxn/zLWKLMm+CqPs40GWIXnZc5vyYJGrnHZvWIro=; b=dIKqauvxIVgt+ZtWXvj0WBC/zd9XWMgIPxITMMxtR8kTvKJwcYDsgniXyEXSlqRuz/ cUG4QhBj+ptlwoTl/aI9enjSC305XCJ13j3jY5MS2yeXp/UUEcE/ZqNJ3iCL0+D3P3gO oiialCliYPVoE+LLKUbBbOxM+4TC3mX+am/RKkXtPvC/Is8T5UXG3DeBKyPTBRRJhOeL T6XU0WdYtvBE+hUFTEQucmW+iohhwO2lKPfGfgkfVnDlkaLFl3fVixQSLDEg7yc1lunZ QPjraDjIPB/3eH0560FeGy0tUilRwtXRFMFDD0ozAOfUWlfBXQc5c0qEmsb3pFixpNOM kt7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VDJDxn/zLWKLMm+CqPs40GWIXnZc5vyYJGrnHZvWIro=; b=TQb8ecnlTTfL551+POcIU5J5PJExgF1c0XK9zG3o8+bat8Tx/50C5AzWEtJayWQh7Y 6lccpwWHkSLdmDr4ZkhYmP95orP/OAFvzGp5A11BR8E4dhHFo6kSh0/VJtvHNv4bgzRt RPajRxZ5B/zEzBhBWCfz/Rg3252LxNnqxPC/aQRIDK0rWi1PLiBlDnWiqrQ28LLBiFVi iJ5qWPXWpGs+TjBI1dANW+lsVYMxMZr3By4QFfNnES8jgZorfztuEGFQwDB3Rahq24hy fokS8nDCqLybr07MHFsaXM0wAcNLy5QLK/ksbtIajyQkQcVccBqC6OlOhgikpucM3ta0 ULEg== X-Gm-Message-State: APjAAAWROyszXu3d6geMnprfj5giZyje75M4ZUbbPxwTzKVrvd7JyWNG 425OebFMMwIUXkYpceMTLjpUuIvilKIKWVPA0cs= X-Google-Smtp-Source: APXvYqxfJLjLb3Vk7CR/mOyjLgLf4h2MHcQ4dSp/7xurJrocJOvXJ+QlBe3JsEUL6KfyMuRizPStPPI+utJ5zTb5H7U= X-Received: by 2002:a5d:634c:: with SMTP id b12mr19294846wrw.203.1555244248395; Sun, 14 Apr 2019 05:17:28 -0700 (PDT) MIME-Version: 1.0 References: <87wok919ox.fsf@tcd.ie> <87d0m08zni.fsf@tcd.ie> <87imvjctau.fsf@tcd.ie> In-Reply-To: <87imvjctau.fsf@tcd.ie> From: Alex Murray Date: Sun, 14 Apr 2019 21:47:12 +0930 Message-ID: Subject: Re: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer To: "Basil L. Contovounesios" Content-Type: multipart/alternative; boundary="000000000000f6f51f05867c844e" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35141-done Cc: 35141-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f6f51f05867c844e Content-Type: text/plain; charset="UTF-8" Thanks! On Fri, 12 Apr 2019 at 21:46, Basil L. Contovounesios wrote: > Alex Murray writes: > > > Done - see attached. Thanks again for your help. > > > > On Fri, 5 Apr 2019 at 21:52, Basil L. Contovounesios > wrote: > > > > Otherwise LGTM, but we'll have to wait a few days to give others a > > chance to comment. > > Thanks, pushed to master[1]. I made minor edits to the commit message > to follow CONTRIBUTE guidelines and to make it slightly more accurate > and less redundant. > > [1: 6dc4c722af]: Pop to originating erc buffer when clicking desktop > notification > 2019-04-12 13:08:28 +0100 > > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6dc4c722af4e5f9f189631638700cd1fb3cc2edb > > If you're interested in making further contributions, I would recommend > starting the copyright assignment process. See CONTRIBUTE and (info > "(emacs) Copyright Assignment") for details. > > Thanks, > > -- > Basil > --000000000000f6f51f05867c844e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks!

On Fri, 12 Apr 2019 at 21:46, Basil L. Contovounesi= os <contovob@tcd.ie> wrote:
Alex Murray <murray.alex@gmail.= com> writes:

> Done - see attached. Thanks again for your help.
>
> On Fri, 5 Apr 2019 at 21:52, Basil L. Contovounesios <contovob@tcd.ie> wrote:
>
>=C2=A0 Otherwise LGTM, but we'll have to wait a few days to give ot= hers a
>=C2=A0 chance to comment.

Thanks, pushed to master[1].=C2=A0 I made minor edits to the commit message=
to follow CONTRIBUTE guidelines and to make it slightly more accurate
and less redundant.

[1: 6dc4c722af]: Pop to originating erc buffer when clicking desktop notifi= cation
=C2=A0 2019-04-12 13:08:28 +0100
=C2=A0 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D6dc4c722af4e5f= 9f189631638700cd1fb3cc2edb

If you're interested in making further contributions, I would recommend=
starting the copyright assignment process.=C2=A0 See CONTRIBUTE and (info "(emacs) Copyright Assignment") for details.

Thanks,

--
Basil
--000000000000f6f51f05867c844e-- From unknown Sat Jun 21 10:33:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 13 May 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator