From unknown Sun Jun 22 11:45:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Apr 2019 03:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 35133@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155434737113857 (code B ref -1); Thu, 04 Apr 2019 03:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Apr 2019 03:09:31 +0000 Received: from localhost ([127.0.0.1]:43562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBsks-0003bQ-WE for submit@debbugs.gnu.org; Wed, 03 Apr 2019 23:09:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBskq-0003bC-TM for submit@debbugs.gnu.org; Wed, 03 Apr 2019 23:09:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:45425) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBskl-0001eD-Lr for submit@debbugs.gnu.org; Wed, 03 Apr 2019 23:09:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBskk-0001ZV-KY for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 23:09:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBsh9-0001VD-0J for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 23:05:39 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:39196) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBsh8-0001RF-Jd for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 23:05:38 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3434JhR031205 for ; Thu, 4 Apr 2019 03:05:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=xGXB4Yvl4MHtXcIkSY0Z2mgQVkNAUIEWsDaPlJBxS6g=; b=1t7d9xYq0mLF9mCdrGjWkZI+kyFeI1gbyCXGNrkI7LmACurTanBbfZBfX7emh1QVzx8d cU2fK86EaUqxs2CwnZlIkjmmlCf1Ca40rnh39k4dLV6foRpyJ0CY7HvP3gE+JPQo3mvG Pn69IOkA9AXxUdvT8BOqo8IEAFDrj9/78fRpGhDNVFSK7r4PfxVr8eb7QSmyhnoulQL4 hRumczQK9vRzdoUvgTqTtdnQDalKN95NbCopmwLd9fkD0Ud4yFboZQnvK+DLVO8EAZf1 pvvzYobFMD9l1AeGJ9NjLsFhOPUK4I7dI4v1vb/LTkZEC0w8QHBU4lgwMvAnzSKpKlke 2g== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2rj13qcdj4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 04 Apr 2019 03:05:35 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3435Ne2115285 for ; Thu, 4 Apr 2019 03:05:34 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2rm9mjcwrh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 04 Apr 2019 03:05:34 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x3435X6l030974 for ; Thu, 4 Apr 2019 03:05:33 GMT MIME-Version: 1.0 Message-ID: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> Date: Wed, 3 Apr 2019 20:05:32 -0700 (PDT) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4822.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9216 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904040020 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9216 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904040020 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.85 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 1. Use `M-x customize-option' for each of these: (defcustom foo 42 "Foo..." :type '(restricted-sexp :tag "Positive integer" :match-alternatives ((lambda (x) (and (natnump x) (not (zerop x)= )))) :value ignore)) (defcustom bar 42 "Bar..." :type '(choice (restricted-sexp :tag "Positive integer" :match-alternatives ((lambda (x) (and (natnump x) (not (= zerop x))))) :value ignore))) The `:tag' has no effect for `foo' - there is no label. I think that according to the doc it should have the same effect as for `bar'. 2. In addition, a reasonable and helpful enhancement for `choice' would be to not show `Value Menu' at all if there is only one choice available (i.e., when that button/menu is a no-op). In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-30 Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea Windowing system distributor `Microsoft Corp.', version 10.0.17134 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From unknown Sun Jun 22 11:45:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Dec 2020 14:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 35133@debbugs.gnu.org, Mauro Aranda Received: via spool by 35133-submit@debbugs.gnu.org id=B35133.160752552310950 (code B ref 35133); Wed, 09 Dec 2020 14:53:01 +0000 Received: (at 35133) by debbugs.gnu.org; 9 Dec 2020 14:52:03 +0000 Received: from localhost ([127.0.0.1]:33243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn0p1-0002qY-D7 for submit@debbugs.gnu.org; Wed, 09 Dec 2020 09:52:03 -0500 Received: from quimby.gnus.org ([95.216.78.240]:38868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn0oy-0002pz-SP for 35133@debbugs.gnu.org; Wed, 09 Dec 2020 09:52:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KsEe4OEtGDnKkqyPNUsgeCHEfdCbmeChFYMmz+6auPU=; b=rZlGgQQXiBQrUnuTEXqopypwB4 9LaZNyT2HR2tDbPqZOxI1S/N8HeGkKIB9C6tKKVOLyWAbda3AkMBC+vKqOmkKEs1XbPpT8+fX9Hz7 h7D0QhvS6CKIQEAOr/Up9CVjdoddyYTc6lvQYJn+wobPbNz4Yo9BzTGfGJemnfx/VUNo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kn0op-0002Ez-Ok; Wed, 09 Dec 2020 15:51:54 +0100 From: Lars Ingebrigtsen References: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> X-Now-Playing: Yves Tumor's _Heaven To A Tortured Mind_: "Hasdallen Lights" Date: Wed, 09 Dec 2020 15:51:50 +0100 In-Reply-To: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> (Drew Adams's message of "Wed, 3 Apr 2019 20:05:32 -0700 (PDT)") Message-ID: <87360f2fsp.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > 1. Use `M-x customize-option' for each of these: > > (defcustom foo 42 > "Foo..." > :type '(restricted-sexp > :tag "Positive integer" > :match-alternatives ((lambda (x) (and (natnump x) (not (zerop [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > 1. Use `M-x customize-option' for each of these: > > (defcustom foo 42 > "Foo..." > :type '(restricted-sexp > :tag "Positive integer" > :match-alternatives ((lambda (x) (and (natnump x) (not (zerop x))))) > :value ignore)) > > (defcustom bar 42 > "Bar..." > :type '(choice (restricted-sexp > :tag "Positive integer" > :match-alternatives ((lambda (x) (and (natnump x) (not (zerop x))))) > :value ignore))) > > The `:tag' has no effect for `foo' - there is no label. I think that > according to the doc it should have the same effect as for `bar'. I can confirm that this behaviour is still present in Emacs 28. Mauro, if you have time, could you take a look at this? > 2. In addition, a reasonable and helpful enhancement for `choice' would > be to not show `Value Menu' at all if there is only one choice > available (i.e., when that button/menu is a no-op). Makes sense. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 11:45:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Dec 2020 22:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 35133@debbugs.gnu.org, Drew Adams Received: via spool by 35133-submit@debbugs.gnu.org id=B35133.160755286818010 (code B ref 35133); Wed, 09 Dec 2020 22:28:02 +0000 Received: (at 35133) by debbugs.gnu.org; 9 Dec 2020 22:27:48 +0000 Received: from localhost ([127.0.0.1]:36455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn7w3-0004gQ-Vz for submit@debbugs.gnu.org; Wed, 09 Dec 2020 17:27:48 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:42272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn7w2-0004gD-QG for 35133@debbugs.gnu.org; Wed, 09 Dec 2020 17:27:47 -0500 Received: by mail-wr1-f54.google.com with SMTP id m5so3437329wrx.9 for <35133@debbugs.gnu.org>; Wed, 09 Dec 2020 14:27:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h6ythBasB+UbSInIUEKNyouJwuO7uyVmb0+Qjk0fy3k=; b=SwMsOce+/xN4miGpmN0/nGyusV7c9udHNoOZKmOnAmO5ZwqogQeR/qzsPfq/YlSIFk CFL+lu8usIJ9z6c0f7474lwUuWv0tXsUH1l1uVcN6ovpo8MsdZS0FCAa8WNmfI3Q1bZe 1smWP+aIWbjR0f5XHDwMVzp2ScUcX0IG6mYyePt+wiRCr9f147KNfjM+N2r6JQLHBqbP AjP7h3cu4XX9cokDvytzen46EI0t71QwCz4GHoK5VH3KNI4lATVIlp2gSJ9usB8KFGmp L3bwRuBBbvoiqfV35wLBc6ZqfA0cKhtN8+sWBAEkzP07ydTXEDho4o6nDOZYOwcUa8CW HxmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h6ythBasB+UbSInIUEKNyouJwuO7uyVmb0+Qjk0fy3k=; b=RegnOHbhBiQdZwIjf+tdf5QapjZEWXALSfRXjHauxmo6j4hi7D2eHh3tM+iDaTnTvy +gZW0mAhDPEWQiMChXy5TFxsQA1MzNyCE2DQ1fuEJkvcit/f2OEzIdTMYWIrV85ExEt2 aGLN6SZrgUAqaseXwVEmAqDEl1M31htKgwOaKRialDhEHza3kxB/WcTWTfIn1OzNtpS/ 59ZvWmrN/4i3qa4CYK2hLdWl/HIZbDqUUSn5swui8z2qjNjKzaJ+jCNpQyZZCnfdhAsF pNOInFqAlqRVjs7EDaAFu6AdazD8bPf8QM35pRBAyJrIwGijEbP1tLMRjIHnIknFj4QB dE0g== X-Gm-Message-State: AOAM530d1frWbZvL5z/UMotgYMJ2ZQqa1ABmXTidJbSHubDMLDBeq2jE nRD7pOhwqK25QpS33PBaxOQOSHU9ld6BAuYXxtk= X-Google-Smtp-Source: ABdhPJx+ztz3jsLm8BxjCCdCs1bKHhuKZKcGp/ZYpEiixdroMIWkDRB9kIWPrPC0cxv8eZk0+PnYpYG267XVk1TCSyA= X-Received: by 2002:a5d:61ca:: with SMTP id q10mr4998366wrv.124.1607552860889; Wed, 09 Dec 2020 14:27:40 -0800 (PST) MIME-Version: 1.0 References: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> <87360f2fsp.fsf@gnus.org> In-Reply-To: <87360f2fsp.fsf@gnus.org> From: Mauro Aranda Date: Wed, 9 Dec 2020 19:27:31 -0300 Message-ID: Content-Type: multipart/alternative; boundary="0000000000003b247005b60f9178" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003b247005b60f9178 Content-Type: text/plain; charset="UTF-8" > Drew Adams writes: > > > 1. Use `M-x customize-option' for each of these: > > > > (defcustom foo 42 > > "Foo..." > > :type '(restricted-sexp > > :tag "Positive integer" > > :match-alternatives ((lambda (x) (and (natnump x) (not (zerop x))))) > > :value ignore)) > > > > (defcustom bar 42 > > "Bar..." > > :type '(choice (restricted-sexp > > :tag "Positive integer" > > :match-alternatives ((lambda (x) (and (natnump x) (not (zerop x))))) > > :value ignore))) > > > > The `:tag' has no effect for `foo' - there is no label. I think that > > according to the doc it should have the same effect as for `bar'. > > I can confirm that this behaviour is still present in Emacs 28. Mauro, > if you have time, could you take a look at this? Not much time until the weekend, I'm afraid. Dropping the tag is intentional, in custom-variable-value-create: (push (widget-create-child-and-convert widget type :format value-format ^^^^^^^^^^^^^^^^^^^ :value value) children)) I suppose we could stop overriding the :format property, but for some widgets overriding it might make sense. For example, for the choice widget, deleting the :format value-format line would create the following: Foo: Choice: [Value Menu] The-Tag: Which isn't good, IMO. Other customization types I can think of that we should pay attention if we go with this change would be: repeat, set and radio. I think that those three, if we print their tag, won't give too much valuable information about the variable. I mean, we'd end up with something like this: Foo: Repeat: [INS] [DEL] Something [INS] And any user may ask what does "repeat" mean. Maybe changing the tags to something slightly more useful is all we need, and with this change the Custom buffer will show the customization type of the variable to the user, which looks like a win to me. What do you think about the "problematic" tags? --0000000000003b247005b60f9178 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Drew Adams <drew.adams@oracle.com> writes:
>
> = > 1. Use `M-x customize-option' for each of these:
> >
&= gt; > (defcustom foo 42
> > =C2=A0 "Foo..."
> &= gt; =C2=A0 :type '(restricted-sexp
> > =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 :tag "Positive integer"
> > =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 :match-alternatives ((lambda (x) (and (natnump x) =C2= =A0(not (zerop x)))))
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :valu= e ignore))
> >
> > (defcustom bar 42
> > =C2=A0 = "Bar..."
> > =C2=A0 :type '(choice (restricted-sexp<= br>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= :tag "Positive integer"
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :match-alternatives ((lambda (x) (and (= natnump x) =C2=A0(not (zerop x)))))
> > =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :value ignore)))
> >
>= ; > The `:tag' has no effect for `foo' - there is no label.=C2= =A0 I think that
> > according to the doc it should have the same = effect as for `bar'.
>
> I can confirm that this behaviour= is still present in Emacs 28.=C2=A0 Mauro,
> if you have time, could= you take a look at this?

Not much time until the weekend, I'm a= fraid.

Dropping the tag is intentional, in custom-variable-value-cre= ate:
(push (widget-create-child-and-convert
=C2=A0 =C2=A0widget ty= pe
=C2=A0 =C2=A0:format value-format
=C2=A0 =C2=A0 ^^^^^^^^^^^^^^^= ^^^^
=C2=A0 =C2=A0:value value)
=C2=A0 children))

I supp= ose we could stop overriding the :format property, but for some
widgets = overriding it might make sense.=C2=A0 For example, for the choice
widget= , deleting the :format value-format line would create the
following:
=
Foo: Choice: [Value Menu] The-Tag:

Which isn't good, IMO.=C2= =A0 Other customization types I can think of that we
should pay attentio= n if we go with this change would be: repeat, set and
radio.

I think that those three, if we print their tag, = won't give too much
valuable information about the variable.=C2=A0 = =C2=A0I mean, we'd end up with
something like this:

Foo= : Repeat:
[INS] [DEL] Something
[INS]

And any user may ask wha= t does "repeat" mean.=C2=A0 Maybe changing the tags
to somethi= ng slightly more useful is all we need, and with this change
the Custom = buffer will show the customization type of the variable to
the user, whi= ch looks like a win to me.=C2=A0 What do you think about the
"probl= ematic" tags?
--0000000000003b247005b60f9178-- From unknown Sun Jun 22 11:45:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Dec 2020 23:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda , Lars Ingebrigtsen Cc: 35133@debbugs.gnu.org Received: via spool by 35133-submit@debbugs.gnu.org id=B35133.160755678024060 (code B ref 35133); Wed, 09 Dec 2020 23:33:01 +0000 Received: (at 35133) by debbugs.gnu.org; 9 Dec 2020 23:33:00 +0000 Received: from localhost ([127.0.0.1]:36529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn8x9-0006Fz-NI for submit@debbugs.gnu.org; Wed, 09 Dec 2020 18:32:59 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:51990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn8x8-0006Fm-Jw for 35133@debbugs.gnu.org; Wed, 09 Dec 2020 18:32:59 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B9NPNh4164877; Wed, 9 Dec 2020 23:32:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=sL/qnFf9gCa71ghptm6C1G+TQiMDcZa6ppMR2QxwAQw=; b=FgcrsgPtmX0t8tM8FRhzPiCG3rpEIkCM6rlC1GftT9VSdumteLNRTRQrqnTGYHBjj3UG Ct7KOH31FSRmcYPdM/tWOThXfGEDT+PPHYzCeSrkeChCPOJBBc7jniFTk2MGSqbOzddf kmFBiEUYwj1Rs7jhu/uFTqE7ESUe8o2utMZ3Qc/69geo3oeKw5s8k6i2jiPbljVBPcmv C4VaJai2CCJUSP2R4ptkRQMkwYNQ2l/lAZOG1j3IIrjL0lNkYhCAl7pKdHsMU0mR0qy3 82jeiUmtzy1RwaB1an4+xc4iYwImnwyfbltfBwhzndA2xRS8m660Q0jJ0QIXQT7SgxXa Wg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 35825mavfg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 09 Dec 2020 23:32:52 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B9NUqJ8168106; Wed, 9 Dec 2020 23:30:52 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 358ksqt9fw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Dec 2020 23:30:52 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0B9NUhcb003540; Wed, 9 Dec 2020 23:30:43 GMT MIME-Version: 1.0 Message-ID: <3bae30db-9eb9-4185-b549-1cdfd60efc59@default> Date: Wed, 9 Dec 2020 15:30:43 -0800 (PST) From: Drew Adams References: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> <87360f2fsp.fsf@gnus.org> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9830 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=949 suspectscore=0 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012090162 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9830 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=959 clxscore=1011 priorityscore=1501 mlxscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012090161 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Not much time until the weekend, I'm afraid. > > Dropping the tag is intentional, in custom-variable-value-create: > (push (widget-create-child-and-convert >=C2=A0 =C2=A0widget type >=C2=A0 =C2=A0:format value-format >=C2=A0 =C2=A0 ^^^^^^^^^^^^^^^^^^^ >=C2=A0 =C2=A0:value value) >=C2=A0 children)) > > I suppose we could stop overriding the :format property, but for some > widgets overriding it might make sense.=C2=A0 For example, for the choice > widget, deleting the :format value-format line would create the > following: > > Foo: Choice: [Value Menu] The-Tag: > > Which isn't good, IMO.=C2=A0 Other customization types I can think of tha= t we > should pay attention if we go with this change would be: repeat, set and > radio. > > I think that those three, if we print their tag, won't give too much > valuable information about the variable.=C2=A0 =C2=A0I mean, we'd end up = with > something like this: > > Foo: Repeat: > [INS] [DEL] Something > [INS] > > And any user may ask what does "repeat" mean.=C2=A0 Maybe changing the ta= gs > to something slightly more useful is all we need, and with this change > the Custom buffer will show the customization type of the variable to > the user, which looks like a win to me.=C2=A0 What do you think about the > "problematic" tags? Thanks for looking into this Mauro. I'd suggest handling this in two stages: 1. Take care of what is clearly, or pretty clearly, straightforward. 2. Think about how to handle other cases. ____ But in general, for defcustom I think I'm in favor of allowing the realization of a :tag, regardless of whether using it might be problematic sometimes. After all, using :tag is optional. If the result isn't helpful, someone won't use it. But I guess you're asking about default tags? What happens if there's no default :tag for some widget (such as `repeat') but when you use the widget you provide a :tag? Would that be possible? IOW, maybe a :tag for `repeat' isn't useful by default, but maybe adding a :tag when you use some `repeat' could be useful. (For the problematic cases, maybe the tag text should be shown without the trailing colon? Maybe it depends on where the tag is placed and how long the string is.) Anyway, for now at least, #1 would be great. Thx. From unknown Sun Jun 22 11:45:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Dec 2020 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 35133@debbugs.gnu.org, Lars Ingebrigtsen Received: via spool by 35133-submit@debbugs.gnu.org id=B35133.160769565912912 (code B ref 35133); Fri, 11 Dec 2020 14:08:02 +0000 Received: (at 35133) by debbugs.gnu.org; 11 Dec 2020 14:07:39 +0000 Received: from localhost ([127.0.0.1]:40601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knj59-0003MA-6Q for submit@debbugs.gnu.org; Fri, 11 Dec 2020 09:07:39 -0500 Received: from mail-qt1-f180.google.com ([209.85.160.180]:40719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knj57-0003Lz-VL for 35133@debbugs.gnu.org; Fri, 11 Dec 2020 09:07:38 -0500 Received: by mail-qt1-f180.google.com with SMTP id n12so776156qti.7 for <35133@debbugs.gnu.org>; Fri, 11 Dec 2020 06:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:references:date:in-reply-to :user-agent:mime-version; bh=IEFEjLos5lnKt1yz8c5boEBfTdXlrX46GVGnrrODbzA=; b=hoe+6QIRTf0tPRuqc68Yx3VuQ/C+soDIYI557J2ICVcFriuLFUTs1YIxhbRy8G7/wV La0anv+CguvdObkrwYCgjqRDovZm9I3i3EAM9teYcXQFeYXBuIVoRxdUlYq8hdAoRcZc 6d//EhnRf/6rfZ7O2YjhEFsuwfhaHS+/S01Sywhenp/5Z6p4zLPJ3E6bGUOSeGjDCPX9 Bv9U7m1GENNn8bKZQAQQDFpSwI7CQMnkdmoYSBA0zDGg4z3ycMuT9GYpEXTTz3jEWECb eec8Kqkk3fYD0PnQYVji7IjYS7IU2bTLNHI7bg/o5S9IZrUp9yHahc8FhnKtB8xf+54m FV2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:references:date :in-reply-to:user-agent:mime-version; bh=IEFEjLos5lnKt1yz8c5boEBfTdXlrX46GVGnrrODbzA=; b=cx3I/cMw240jPSmqs0vZYqLhxXKJAZRfpyYvabgJJtzVlU0XhM6g193EjGeVmB/fav feFGxK8BFbXquywzgTscWE4Bwvd+OdDaptHwR9Sd9ljXCoigfUGu6rAjs68ZpSFiwEFE XY4VBGPNhpmKT0hHJyYRGiz1PMsn1plTgT4tIaBypQ7ureu/h92tHEmHSVcd+O5h2ge4 Uoz9M9C3DcGYfx8lLCTDAlBx9+JKxHx3R2IYfUPp/mTPgaj7hxKHDz6EVmgcI9dr7fC3 S5i4A0w6scy5qRdwOhEVhI/U5aCUEQlqwNs8Y5IvW57g1dc3Zma+KcxiQCKi19WcqRF2 mPlg== X-Gm-Message-State: AOAM5327lOV/XVHlzlf5+hk8CSbgoei4gVfVZGz8qP9NaklbGvgC6Wa5 VU6urzFin12HHuTwz+AuCFjfhkrt+YBT3A== X-Google-Smtp-Source: ABdhPJwpEj4QkYmvRIculGZW+g4Qg7sf2lr1n2qKRCUExlUn5e4VLGxC3ysmX7lywx09ol4DENEYwA== X-Received: by 2002:ac8:729a:: with SMTP id v26mr15955156qto.53.1607695651997; Fri, 11 Dec 2020 06:07:31 -0800 (PST) Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id h25sm2748412qkh.122.2020.12.11.06.07.30 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Dec 2020 06:07:31 -0800 (PST) Message-ID: <5fd37d23.1c69fb81.261a.9f56@mx.google.com> X-Google-Original-Message-ID: <87eejw8mkj.fsf@maurooaranda@gmail.com> From: Mauro Aranda References: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> <87360f2fsp.fsf@gnus.org> <3bae30db-9eb9-4185-b549-1cdfd60efc59@default> Date: Fri, 11 Dec 2020 11:05:48 -0300 In-Reply-To: <3bae30db-9eb9-4185-b549-1cdfd60efc59@default> (Drew Adams's message of "Wed, 9 Dec 2020 15:30:43 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > Thanks for looking into this Mauro. > > I'd suggest handling this in two stages: > > 1. Take care of what is clearly, or pretty clearly, > straightforward. > 2. Think about how to handle other cases. > ____ > > But in general, for defcustom I think I'm in favor of > allowing the realization of a :tag, regardless of > whether using it might be problematic sometimes. I agree with you. It's just that since it's an intentional behavior (or at least looks like that), I wanted to make sure we don't miss any potentially annoying side effects. > But I guess you're asking about default tags? What > happens if there's no default :tag for some widget > (such as `repeat') but when you use the widget you > provide a :tag? Would that be possible? IOW, maybe > a :tag for `repeat' isn't useful by default, but > maybe adding a :tag when you use some `repeat' could > be useful. Indeed, I was worried about the default tags. But then I realized that we already show the "Repeat" tag, when the repeat is part of a choice type, so it looks like my worries are void. Same goes for the choice widget inside any other grouping widget. > (For the problematic cases, maybe the tag text should be > shown without the trailing colon? Maybe it depends on > where the tag is placed and how long the string is.) I think it's better to keep the colon. > Anyway, for now at least, #1 would be great. Thx. AFAICS, we should be able to do #1 without trouble, by removing the :format value-format line, and accounting for the space after the tag when creating the item. From unknown Sun Jun 22 11:45:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Dec 2020 14:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: 35133@debbugs.gnu.org, Drew Adams Received: via spool by 35133-submit@debbugs.gnu.org id=B35133.160769712922691 (code B ref 35133); Fri, 11 Dec 2020 14:33:01 +0000 Received: (at 35133) by debbugs.gnu.org; 11 Dec 2020 14:32:09 +0000 Received: from localhost ([127.0.0.1]:40687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knjSq-0005tg-UE for submit@debbugs.gnu.org; Fri, 11 Dec 2020 09:32:09 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knjSn-0005lm-8n for 35133@debbugs.gnu.org; Fri, 11 Dec 2020 09:32:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=y02ToGpHOPHSf3zygbtbhwyJdXm9DJNFHvGe+etH8l4=; b=NjRn6u10N/ghYSClRhcr9+C7Ht wb+BUZ7dYs+xNZ8fcqUfCIzivNWgJV7eJZz1genQVChdCPFoukYkryjpYkAA0mhpx2/CV2/LV8wFe TVY9TELGzlDqrDgu8WOZ52hbv9MrIdFKqNg0joSe9UR00RtIEuWGvkt5P2n1lQcRf2Nc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knjSW-0003QB-0E; Fri, 11 Dec 2020 15:31:58 +0100 From: Lars Ingebrigtsen References: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> <87360f2fsp.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX7bDxOZ1OdqVDV c0b/////GX2jAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QMCw4QDW0d2tIAAAGVSURBVDjLdZOJsYUg DEUjNGBIA4INgPTf279Z0Lf9zDg6OWS7QSLixjRK3Tc2K3POTrAsdFGlxMnBiUddlKS1dozO2YG+ JDHRaGaFCY7KZRNN/AB8Vt4Ty7bDpeAyt4MDhwEq+ggAQ2u8Uy4ZJ4aCdIOKbpKgw1EVtFq8CABG QmnS5gDCcJBtBHu9gfofGFx/g9yHgjoWKKUWDALdDFjM8Q2yAiGdQ0EzsKl+mJw7PQMOXQFm3KCL gah+KkAyjQjgId3BJlDLU3lIFQfptDkdaAyzAzK5F5g0xwLTTTuxyKSzko+iV0WBXhel2uxJcSVW XvQ/repxa+jVPRsuR6EUwOrotm0sPDkAzl7NiqmimXfflwFLDZ+1GIvSz2YLxcWxLoS2AEUB0jsY UR0N7ewgyQcQA4f+Dib7Armw3xorriCKX7zE0Tq0RifiMDhk4nfqn0BcPgnPA9gV7yFvN3AMP3uV vhZiB6KRw5XmB/RXcC2QNMcD4me3iAXEr+I3KFja4BtcD7i90e4N6hsoLxHtNtPtt/0BL0RR8q+q zVgAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTItMTFUMTQ6MTY6MTMrMDA6MDBY5T/zAAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIwLTEyLTExVDE0OjE2OjEzKzAwOjAwKbiHTwAAAABJRU5ErkJggg== X-Now-Playing: Sacred Paws's _Run Around The Sun_: "What's So Wrong" Date: Fri, 11 Dec 2020 15:31:46 +0100 In-Reply-To: (Mauro Aranda's message of "Wed, 9 Dec 2020 19:27:31 -0300") Message-ID: <875z58bei5.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > I suppose we could stop overriding the :format property, but for some > widgets overriding it might make sense. For example, for the choice > widget, deleting the :format value-format line would cre [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > I suppose we could stop overriding the :format property, but for some > widgets overriding it might make sense. For example, for the choice > widget, deleting the :format value-format line would create the > following: > > Foo: Choice: [Value Menu] The-Tag: > > Which isn't good, IMO. Yeah, that doesn't look optimal... > Other customization types I can think of that we should pay attention > if we go with this change would be: repeat, set and radio. > > I think that those three, if we print their tag, won't give too much > valuable information about the variable. I mean, we'd end up with > something like this: > > Foo: Repeat: > [INS] [DEL] Something > [INS] > > And any user may ask what does "repeat" mean. Maybe changing the tags > to something slightly more useful is all we need, and with this change > the Custom buffer will show the customization type of the variable to > the user, which looks like a win to me. Sounds good to me, if I understand you correctly (which I may very well not do). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 11:45:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Dec 2020 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 35133@debbugs.gnu.org Received: via spool by 35133-submit@debbugs.gnu.org id=B35133.160770637817279 (code B ref 35133); Fri, 11 Dec 2020 17:07:01 +0000 Received: (at 35133) by debbugs.gnu.org; 11 Dec 2020 17:06:18 +0000 Received: from localhost ([127.0.0.1]:42808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knls1-0004Ud-OM for submit@debbugs.gnu.org; Fri, 11 Dec 2020 12:06:18 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:36416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knlrt-0004UC-U4 for 35133@debbugs.gnu.org; Fri, 11 Dec 2020 12:06:15 -0500 Received: by mail-qk1-f175.google.com with SMTP id 186so9067909qkj.3 for <35133@debbugs.gnu.org>; Fri, 11 Dec 2020 09:06:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:references:date:in-reply-to :user-agent:mime-version; bh=b1AjasSt29V1GqqXsgJDptEjQILPdyaYJBco+fkPLSk=; b=onMAQo2IgNmlSKP1iRf9BAA1cKDiiDtdilbn/JNCf/daMPMOMm23RN8f6QCmW3Y1uc PELYG259MffA0c590d6yuaWhR4XjPEzMQBxZxG+LUonlZAXvAQUYXLGgqjfBxv2YGJao Wtqio2SCAfNsrPgx9f2Spv6df9tAi7RW2zJ9H5NBpzxyXRI/H+e1Nx79lwieQ9udb/gK C+ZgjH0cNy6my8IalwRSPo23Sq9rdrrDrFS7QZQra1me+tEjgfNbbklGieIUIMUTH1uh lE1DwOYesRXzIaL6xuZrnq5sksLrWBToBfI5zJ4GGr43iFk/4zWpXJ33SUStH4ase0cP QSiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:references:date :in-reply-to:user-agent:mime-version; bh=b1AjasSt29V1GqqXsgJDptEjQILPdyaYJBco+fkPLSk=; b=eopgWR5ds+3fqLqvkRLO5W2fmwJX/OPQWvoITJV0JUVnbb27zcDFlUXCERUSV26SA8 aTTk6DCGm4CgeMFmUaiJnYQ4dcy5jS4/R3PXGUN24t4dZkzuhPMcPbrPM13XyypceGX2 xksuGkUpNbbPsHlaI8RFCiokGZwHDkWJ+WpjI9IYGqQf0XOU6sqIJ318JQq9UJV51PWs 4B3zz0CvEDnXmApL3hThlxUVJf2GHb/u7jWszOcHULNQjUdpQLLneNBACWT9NZJ19jXV P17GwhbxJIBqjPuZvzi0jBlDavWJir+ih/Mn8Hu5SIYQolkekSU0FljckuxHkqpXLd9H ofcg== X-Gm-Message-State: AOAM5315QkpS9ap+qATmWMCEkReQXFJ21kXFZj4qqEwfEJWii+O/Q0oM rwSlN8SKFYswJ7f+8QbDPgC9GD1mowHVbg== X-Google-Smtp-Source: ABdhPJxz8eKXjqz8b0MfcI4F3QIosEpfsS4HXNOwJ5TKZukCqBz8JjK86paVMYfGPVm9XOLXAxaeGQ== X-Received: by 2002:a05:620a:788:: with SMTP id 8mr836514qka.224.1607706364009; Fri, 11 Dec 2020 09:06:04 -0800 (PST) Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id k188sm7417430qkd.98.2020.12.11.09.06.02 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Dec 2020 09:06:03 -0800 (PST) Message-ID: <5fd3a6fb.1c69fb81.a2b39.49ef@mx.google.com> X-Google-Original-Message-ID: <87k0to6znr.fsf@maurooaranda@gmail.com> From: Mauro Aranda References: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> <87360f2fsp.fsf@gnus.org> <875z58bei5.fsf@gnus.org> Date: Fri, 11 Dec 2020 14:06:00 -0300 In-Reply-To: <875z58bei5.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 11 Dec 2020 15:31:46 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> I suppose we could stop overriding the :format property, but for some >> widgets overriding it might make sense. For example, for the choice >> widget, deleting the :format value-format line would create the >> following: >> >> Foo: Choice: [Value Menu] The-Tag: >> >> Which isn't good, IMO. > > Yeah, that doesn't look optimal... Earlier today I sent a message saying we already show it that way when the choice widget is part of another grouping widget. And I can't figure out a nice way to show it, while being backward compatible... So I suggest the attached patch, and if the Choice: [Value Menu] text turns out to be really annoying, we can explore some other way of fixing it. (If you want, I can send a tentative untested example of how a less backward compatible change would look like). >> Other customization types I can think of that we should pay attention >> if we go with this change would be: repeat, set and radio. >> >> I think that those three, if we print their tag, won't give too much >> valuable information about the variable. I mean, we'd end up with >> something like this: >> >> Foo: Repeat: >> [INS] [DEL] Something >> [INS] >> >> And any user may ask what does "repeat" mean. Maybe changing the tags >> to something slightly more useful is all we need, and with this change >> the Custom buffer will show the customization type of the variable to >> the user, which looks like a win to me. > > Sounds good to me, if I understand you correctly (which I may very well > not do). Similarly to the choice widget, we already show "Repeat" and such things in other situations, so I'd say my initial worries should not be taken into account. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Stop-dropping-the-tag-when-creating-the-custom-varia.patch Content-Description: Bug35133 patch >From f0d69b47349fd23fd06a8f1c5f54ca3bfcfc6522 Mon Sep 17 00:00:00 2001 From: Mauro Aranda Date: Fri, 11 Dec 2020 13:07:21 -0300 Subject: [PATCH] Stop dropping the tag when creating the custom-variable widget * lisp/cus-edit.el (custom-variable-value-create): Obey the specified tag format when creating the variable tag, but stop dropping the tag format for the variable's type widget, since the tag can be used to give useful information to the user about the variable. (Bug#35133) --- lisp/cus-edit.el | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el index 3a36cb0237..041f13b420 100644 --- a/lisp/cus-edit.el +++ b/lisp/cus-edit.el @@ -2734,11 +2734,15 @@ custom-variable-value-create buttons) (insert " ") (let* ((format (widget-get type :format)) - tag-format value-format) - (unless (string-match ":" format) + tag-format) + ;; We used to drop the widget tag when creating TYPE, passing + ;; everything after the colon (including whitespace characters + ;; after it) as the :format for TYPE. We don't drop the tag + ;; anymore, but we should keep an immediate whitespace character, + ;; if present, and it's easier to do it here. + (unless (string-match ":\\s-?" format) (error "Bad format")) (setq tag-format (substring format 0 (match-end 0))) - (setq value-format (substring format (match-end 0))) (push (widget-create-child-and-convert widget 'item :format tag-format @@ -2753,7 +2757,6 @@ custom-variable-value-create buttons) (push (widget-create-child-and-convert widget type - :format value-format :value value) children)))) (unless (eq custom-buffer-style 'tree) -- 2.29.2 --=-=-=-- From unknown Sun Jun 22 11:45:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Dec 2020 17:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: 35133@debbugs.gnu.org, Lars Ingebrigtsen Received: via spool by 35133-submit@debbugs.gnu.org id=B35133.160770760619182 (code B ref 35133); Fri, 11 Dec 2020 17:27:01 +0000 Received: (at 35133) by debbugs.gnu.org; 11 Dec 2020 17:26:46 +0000 Received: from localhost ([127.0.0.1]:42832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knmBp-0004zJ-VZ for submit@debbugs.gnu.org; Fri, 11 Dec 2020 12:26:46 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:40848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knmBn-0004z3-FY for 35133@debbugs.gnu.org; Fri, 11 Dec 2020 12:26:44 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BBHO4pB194340; Fri, 11 Dec 2020 17:26:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=eLEknOQF/2dOwW1j0f/k55gidbrIulzBT9w1NRtKONw=; b=xV81zg/QAE8bUNrZf06WiNZnQl9E6UhJcQTOlN+gUckqz3ZQRUPGMYvJfzDgM7LJGNHd yBqU53FQ0miWJaTOMBpT9aSXTIWRvZGCEI/BlMaI8qhkRmVKOPBhpUs67PaqvCM1H2ik j2WmC6lLxRYISLOge/+NsavxkEa4saP0UyaXIvdL4tiCy7KyUVOCmgmUkQ4orJB49e4g JO2seW2FfvDXdrHnx7lYNcGXJc/ZoJvGKn8v5Wgg1vUPoF2tul0H3rVcIiEmHZJ1luRX J/mpHNQWWltutuBPN7n7ynii9nAwFd4fxCeWJOzorp5G4lxkdzNTVwH8fIjD24Lco7EA 0g== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 3581mrbqbh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 11 Dec 2020 17:26:37 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BBHPtXx151889; Fri, 11 Dec 2020 17:26:37 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 358m549j66-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 11 Dec 2020 17:26:37 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BBHQZpa027486; Fri, 11 Dec 2020 17:26:36 GMT MIME-Version: 1.0 Message-ID: <732f3a1d-5277-4053-8a45-bed8ec0b68d6@default> Date: Fri, 11 Dec 2020 09:26:34 -0800 (PST) From: Drew Adams References: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> <87360f2fsp.fsf@gnus.org> <3bae30db-9eb9-4185-b549-1cdfd60efc59@default> <5fd37d23.1c69fb81.261a.9f56@mx.google.com> In-Reply-To: <5fd37d23.1c69fb81.261a.9f56@mx.google.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9832 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=996 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012110117 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9832 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 impostorscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012110117 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I have confidence that whatever you decide to do will be an improvement. T= hanks for working on this. From unknown Sun Jun 22 11:45:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Dec 2020 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: 35133@debbugs.gnu.org Received: via spool by 35133-submit@debbugs.gnu.org id=B35133.160777079424065 (code B ref 35133); Sat, 12 Dec 2020 11:00:02 +0000 Received: (at 35133) by debbugs.gnu.org; 12 Dec 2020 10:59:54 +0000 Received: from localhost ([127.0.0.1]:44004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ko2cz-0006G5-R0 for submit@debbugs.gnu.org; Sat, 12 Dec 2020 05:59:54 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ko2cy-0006Fq-33 for 35133@debbugs.gnu.org; Sat, 12 Dec 2020 05:59:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=//E5U0/okczuYDmjgc3w9tQhtnHuSyDHZjWPwW8xJNk=; b=nYoMiyz4SmakKYRcZRVbea3cTs G6eWa5HPUga8xwVM9Ghv9YArJeHRWwiIVvpznrNsU8IUQESVjfsy5qwH4ZFc+ExQJYNHQVT24FDyF kI9g5djY0hlhVfahHXHnOhK8GTm/g9qU4JtDlhLzWoVEKLRmTLWaM97KbdehIO0Mhgsw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ko2cp-0004hV-Ek; Sat, 12 Dec 2020 11:59:45 +0100 From: Lars Ingebrigtsen References: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> <87360f2fsp.fsf@gnus.org> <875z58bei5.fsf@gnus.org> <5fd3a6fb.1c69fb81.a2b39.49ef@mx.google.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUnOIxpZGiik0cu QkGRcTBfWCuQipn////0LwWVAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QMDAo6NMetDpcAAAGmSURB VDjL3ZLbkSMhDEVxBsPYzb+pngCmZAUwXgigjRQAP+Qfwl7xsD1VG8Gq3W24B0kI5Nz/bf7f8meM 7kz0Lp38hztBT45gftrHyX/+HD7GuA9Ap66fvZcvEegxdaBavqFjUOS49/UGuCjs8EjGWGNAUlan GbIIvsP3MRySkyyZIbMB4hTvXd8dj0BetECf27v0HHO8A8i1j4OBMqs4cyG+X18eqtOdhG77tb6D Wrv7Xm4JIPjqZQLva/ObGhjej155aDXU1rZcHmmGVdEOWvMA6Y/qNXgLgKqxXQOwzQqaoUTVZRl6 O/8C4lIKT5DzBGoeCrEGy5GeHgiL7Q6HsCHwKvaSo9O+qxaaRT78u8fMgSktgJt5hrJz/F5dsefi pCzdP1mNmVaOLkMlvKFZs7HWYJmPjUwct4M7c/eIerCLUnqH0aFkh0PWV9ZAJg9UyM7GTte6iabZ SBcoeHjoN+hsnVbs2E1lthya0F7aO5NHUwMofheB+FVsogPwiLuNvz51I+XSzMpMPhbM6cuc7b6P Uv/K+jpe4M3yCKWMxUxFmZaK9y/k9ctSdr/JEgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMi0x MlQxMDo1ODo1MiswMDowMD25p+gAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTItMTJUMTA6NTg6 NTIrMDA6MDBM5B9UAAAAAElFTkSuQmCC X-Now-Playing: Shopping's _All Or Nothing_: "Initiative" Date: Sat, 12 Dec 2020 11:59:42 +0100 In-Reply-To: <5fd3a6fb.1c69fb81.a2b39.49ef@mx.google.com> (Mauro Aranda's message of "Fri, 11 Dec 2020 14:06:00 -0300") Message-ID: <87k0tn70ip.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > Similarly to the choice widget, we already show "Repeat" and such things > in other situations, so I'd say my initial worries should not be taken > into account. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > Similarly to the choice widget, we already show "Repeat" and such things > in other situations, so I'd say my initial worries should not be taken > into account. [...] > * lisp/cus-edit.el (custom-variable-value-create): Obey the specified > tag format when creating the variable tag, but stop dropping the tag > format for the variable's type widget, since the tag can be used to > give useful information to the user about the variable. (Bug#35133) I've not tested it, but the patch makes sense to me -- go ahead and push. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 11:45:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op References: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Dec 2020 13:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 35133@debbugs.gnu.org Received: via spool by 35133-submit@debbugs.gnu.org id=B35133.16078674695827 (code B ref 35133); Sun, 13 Dec 2020 13:52:02 +0000 Received: (at 35133) by debbugs.gnu.org; 13 Dec 2020 13:51:09 +0000 Received: from localhost ([127.0.0.1]:47774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koRmH-0001Vo-Ii for submit@debbugs.gnu.org; Sun, 13 Dec 2020 08:51:09 -0500 Received: from mail-qt1-f180.google.com ([209.85.160.180]:37762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koRmF-0001V7-RP; Sun, 13 Dec 2020 08:51:08 -0500 Received: by mail-qt1-f180.google.com with SMTP id z9so10072400qtn.4; Sun, 13 Dec 2020 05:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:in-reply-to:date:mime-version; bh=BC3t6CsRAYs98X9rneTj9H9eOtrewbqo+QtTd1V5LX0=; b=aB8zVZPhsudWEPxEJJFJNjzKBR+RGLd/8bTQHkUOc3LD5hmfdR6ioqzyJTeoOf6huz srKR0kh4cUvXC20MBOVXzmeK6nANKbNuigIZnFgSuJay0J+IwE+L3yl10TmlyzLTZFjk i7S1xvLbC5iOS8elZyNpBIdFuIEOl/yYtB76eR5UUxV2fY8hlhRoCh9+NJQPHTGdJlqx LCKDyokUerJYwWM9M50uhHK5RiQ/mL7V2YCl1yLY95L1kGQcRvqd3WlSLXlAdgYO5IvH Zctz7ggIt/ogJhQYl0xKMCn7V1S857+YPQkku/Pz2Hddby1ASze/txf8pOa10+4RphpV uVkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:in-reply-to:date :mime-version; bh=BC3t6CsRAYs98X9rneTj9H9eOtrewbqo+QtTd1V5LX0=; b=ngDA96l1ifRvrPT9ETJdzlY1vr65djnDN4FB5xPYrYsQaguezl2TidBSPmC3/D35ct 2JlECFY4873I31LDMk7ta3GQbbaZI63ip0kfJau1lvD/mODPTjLWYDqY7tArxNhjjSEl wr4mYqaI3qQsaf7pO50IJOC5tCaCVEhvhtVwam28TnC3H6NtifW5bKQrop5yVHZENmZJ poQ8oZp9uY4M7Ecnur8OdrMlsz/3yTbY7hq3I9mcfo+URE1QHZuvd3ND4tykFBgXbIy+ AjYYSJHfX94R0Y4qS/DzE/IOiD28drjEL+L+SUCoXBnoK9JHtBdmD5pFBRKMQOxlJl8i 68bw== X-Gm-Message-State: AOAM533YbQlltyjfQvd6tuiJjCQJ+0THSIj0GHPoTq3lam6ijRRALup+ +Z/xOJx6X1pgJMp+oDUNPwiS7OxG6kMpgw== X-Google-Smtp-Source: ABdhPJyQbR5SH9TmaWjw4htI1SP+sAxi9c7CQDXaVgJu87v9eV6TfrQn38RMdU5zxXEhyx3Rh0m9Pw== X-Received: by 2002:ac8:4b54:: with SMTP id e20mr26397923qts.236.1607867461685; Sun, 13 Dec 2020 05:51:01 -0800 (PST) Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id c65sm13187671qkf.47.2020.12.13.05.50.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 13 Dec 2020 05:51:00 -0800 (PST) Message-ID: <5fd61c44.1c69fb81.60ef4.b778@mx.google.com> X-Google-Original-Message-ID: <87o8ix4xxa.fsf@maurooaranda@gmail.com> From: Mauro Aranda In-Reply-To: <87k0tn70ip.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 12 Dec 2020 11:59:42 +0100) Date: Sun, 13 Dec 2020 10:50:57 -0300 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35133 fixed close 35133 28.1 quit Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> Similarly to the choice widget, we already show "Repeat" and such things >> in other situations, so I'd say my initial worries should not be taken >> into account. > > [...] > >> * lisp/cus-edit.el (custom-variable-value-create): Obey the specified >> tag format when creating the variable tag, but stop dropping the tag >> format for the variable's type widget, since the tag can be used to >> give useful information to the user about the variable. (Bug#35133) > > I've not tested it, but the patch makes sense to me -- go ahead and push. Thanks. Pushed, and closing.