From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 18:16:37 2019 Received: (at submit) by debbugs.gnu.org; 3 Apr 2019 22:16:37 +0000 Received: from localhost ([127.0.0.1]:43372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBoBQ-00054h-Sm for submit@debbugs.gnu.org; Wed, 03 Apr 2019 18:16:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBoBO-00054S-JU for submit@debbugs.gnu.org; Wed, 03 Apr 2019 18:16:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:60166) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBoBD-0001xY-OO for submit@debbugs.gnu.org; Wed, 03 Apr 2019 18:16:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBoBC-00053E-Ds for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 18:16:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBoB6-0001p6-9v for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 18:16:18 -0400 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]:36917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBoAy-0001NW-RI for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 18:16:12 -0400 Received: by mail-io1-xd2b.google.com with SMTP id x7so285136ioh.4 for ; Wed, 03 Apr 2019 15:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unitn.it; s=google; h=mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=OPinw9qUpzDnaZqHWkAEI7IFpyxcCxHKlNydOnjACfY=; b=S2uyDYCDBskBEpyCZBYcw7td+No4Lxv604WBLZiGfyUgInb8N047mmKo7x7UMtWfTu EPuP2UjTdqtvUumDJu1rtTfyL7uudJYPAGnKdjMlCXdl+0YNS+gkKAjlJT5zpA4wFZqJ 6XvLz6OdOSxSkUvlTk3sNu9c/mOk1cFjYYCpo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=OPinw9qUpzDnaZqHWkAEI7IFpyxcCxHKlNydOnjACfY=; b=b/bmOFM+im77CDFRlHVh8JG9tV/2ORSD+yTdZLgesqdM0o/RGyUqQzsdN79PERqU2I 1R/0GmfdmLxUiwJEmmFZEORFIAzjN63lf6JKgzOEISrzCTYm1KL6h3kVAAw3zivIgOPY Y5Md57zxzIgKMSRd+1vvI2352O6YAVfbXVhrs7Wl35Zt+tC3eBJa2jEH4Ec5pWJx/l4B u9W2apzBBxjb7IoiwaNyKw2K3K+byVlqKOVQ9rrfd0jAeQqDOVBH2WC3kIVchLytfSnV IpNvLWu2qR7oIU0Pad8KLw2Q7ZGiWIbSTinQtS0nw+WeHSSuG29ceIV4vtxfxsoyjXEi jCSw== X-Gm-Message-State: APjAAAVljK7tuP8IQJv4VxTUXBVXqU7vlgO0sO++zB5QyI5+Vu/64Ywf i6/EEaPXq2uSqhY7V5ofDGY+CU7O5BxBKVj8ccPEPlL4dQ== X-Google-Smtp-Source: APXvYqwozRqHFaLFiXg56ME+F5FsUE49fYh2gTAW+Upyl78fUaQkenZYaE38YBOqRqD2gJvKIvEPIoMAxgBekWoCK9c= X-Received: by 2002:a6b:cd89:: with SMTP id d131mr1971773iog.213.1554329752003; Wed, 03 Apr 2019 15:15:52 -0700 (PDT) MIME-Version: 1.0 From: Tadeus Prastowo Date: Thu, 4 Apr 2019 00:15:41 +0200 Message-ID: Subject: 27.0.50; desktop-save no longer saves register containing frameset To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d2b X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Stefan Monnier , emacs-devel X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) $ emacs -Q C-x C-f x.txt Hello world! C-x C-s C-x 3 C-x 2 C-x r f =3D C-x 1 M-x desktop-save RET RET yes RET C-x C-c $ emacs -Q M-x desktop-read RET C-x r j =3D The echo area says: Register doesn=E2=80=99t contain a buffer position or c= onfiguration Compare this with Emacs 26.1 that has the correct behavior: $ emacs-26.1 -Q C-x C-f x.txt Another hello world! C-x C-s C-x 3 C-x 2 C-x r f =3D C-x 1 M-x desktop-save RET RET yes RET C-x C-c $ emacs-26.1 -Q M-x desktop-read RET C-x r j =3D I get the saved frameset back, which contains three windows. The problem can be traced to the following commit (the committer is CC-ed): -- 8< ----------------------------- commit cd1d9e79f74f137511d49eb9b0ae7ba750ba6c3c Author: Stefan Monnier Date: Mon Dec 25 22:51:23 2017 -0500 * lisp/register.el: Use cl-generic (registerv): Make it a "normal"struct. (registerv-make): Declare obsolete. (register-val-jump-to, register-val-describe, register-val-insert): New generic functions. (jump-to-register, describe-register-1, insert-register): Use them. * lisp/emacs-lisp/cl-generic.el: Prefill a combination of struct+typeof= . (cl--generic-prefill-dispatchers): Allow a list of specializers. -- 8< ----------------------------- The offending diff is shown below: -- 8< ----------------------------- diff --git a/lisp/register.el b/lisp/register.el index 23eefd0..0fdcd51 100644 --- a/lisp/register.el +++ b/lisp/register.el @@ -39,9 +39,7 @@ (registerv (:constructor nil) (:constructor registerv--make (&optional data print-func jump-func insert-func)) - (:copier nil) - (:type vector) - :named) + (:copier nil)) (data nil :read-only t) (print-func nil :read-only t) (jump-func nil :read-only t) -- 8< ----------------------------- Specifically, because type vector is dropped, frameset.el in its using of registerv-make to save a frameset results in register-alist item that is no longer a vector (C-h v register-alist shows `(61 . #s(registerv :data [[frameset 1...' in 27.0.50, not `(61 . [registerv [[frameset 1...' that is shown in Emacs 26.1). Since it is no longer a vector, desktop.el upon desktop-save does not serialize the item in a format that can be recognized by register.el after desktop-read. Since the offending commit deprecates the use of registerv-make, this bug can be easily be killed by making frameset.el define function `register-val-insert' that saves a frameset as a vector, modifying function `frameset-to-register' accordingly. @Stefan: could you do that, please? Thank you. --=20 Best regards, Tadeus From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 18:32:31 2019 Received: (at submit) by debbugs.gnu.org; 3 Apr 2019 22:32:31 +0000 Received: from localhost ([127.0.0.1]:43387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBoQn-0005Ty-Df for submit@debbugs.gnu.org; Wed, 03 Apr 2019 18:32:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBoQk-0005Ti-Rh for submit@debbugs.gnu.org; Wed, 03 Apr 2019 18:32:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:47944) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBoQb-0000zh-4A for submit@debbugs.gnu.org; Wed, 03 Apr 2019 18:32:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBoQZ-00006b-NW for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 18:32:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBoQX-0000q5-8p for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 18:32:14 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:38320) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBoQD-0007uT-RQ; Wed, 03 Apr 2019 18:31:55 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x33MOkYX026860; Wed, 3 Apr 2019 22:31:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=aBroA4//GzTiPQT4OF5OoflMywnUnEUyDrqEucBbNH8=; b=POpRy0UvkXeUk4rW/m+3jc0iHT22Tz/eyavAcuSy6pO7oMB25MNLABPDlFAlsDFXbhCC 10fJGRy1O6f/gmxkoIzXhZG9vhXxFnGxn35/NdHcKqecyf8xyqYfTrUQghDV5bVF0ywx y/6pA8SWRUCyZ/JBvo90T3dUS02fBkCKyQbVn1T6jp1j/95XqUYvI0DN8V6loqK5WJiL pNUk0fnGG+LQqrPGd8nQcVCTGudWiyEzYuxCwFzzHAops74cONvykmiTFmtdxMk2Xm2x FoDS0mP0K3k8xeAMt0f0vK6BGNhCWKbhb/yQP/wgKONrukES2d3/ms0/e2xoF/77QtAi 6Q== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2rhyvtbvce-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Apr 2019 22:31:24 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x33MUDot191326; Wed, 3 Apr 2019 22:31:24 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2rm8f5c4pu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Apr 2019 22:31:24 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x33MVLhc021504; Wed, 3 Apr 2019 22:31:22 GMT MIME-Version: 1.0 Message-ID: <39199730-3703-4ef8-8a96-8f8bffd626c9@default> Date: Wed, 3 Apr 2019 15:31:21 -0700 (PDT) From: Drew Adams To: Tadeus Prastowo , bug-gnu-emacs@gnu.org Subject: RE: 27.0.50; desktop-save no longer saves register containing frameset References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4822.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9216 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=808 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904030148 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9216 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=859 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904030148 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.86 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Stefan Monnier , emacs-devel X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Please do not send this to both the bug list and emacs-devel. Choose one. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 13:48:22 2019 Received: (at 35131-done) by debbugs.gnu.org; 4 Apr 2019 17:48:22 +0000 Received: from localhost ([127.0.0.1]:44654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC6TO-0006II-08 for submit@debbugs.gnu.org; Thu, 04 Apr 2019 13:48:22 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:55538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC6TL-0006IA-Ot for 35131-done@debbugs.gnu.org; Thu, 04 Apr 2019 13:48:20 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x34HmG6o011798; Thu, 4 Apr 2019 13:48:17 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 2C1BAAE275; Thu, 4 Apr 2019 13:48:16 -0400 (EDT) From: Stefan Monnier To: Tadeus Prastowo Subject: Re: bug#35131: 27.0.50; desktop-save no longer saves register containing frameset Message-ID: References: Date: Thu, 04 Apr 2019 13:48:16 -0400 In-Reply-To: (Tadeus Prastowo's message of "Thu, 4 Apr 2019 00:15:41 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6518=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6518> : inlines <7047> : streams <1817703> : uri <2825898> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35131-done Cc: 35131-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Tadeus Prastowo writes: > $ emacs -Q > C-x C-f x.txt > Hello world! > C-x C-s > C-x 3 > C-x 2 > C-x r f =3D > C-x 1 > M-x desktop-save RET RET yes RET > C-x C-c > $ emacs -Q > M-x desktop-read RET > C-x r j =3D > The echo area says: Register doesn=E2=80=99t contain a buffer position or= configuration Thanks for the straightforward testcase. I installed the patch below which seems to fix it, Stefan diff --git a/lisp/desktop.el b/lisp/desktop.el index acabde5eb2..97c057e201 100644 --- a/lisp/desktop.el +++ b/lisp/desktop.el @@ -856,6 +856,19 @@ desktop--v2s `',(cdr el) (cdr el))) pass1))) (cons 'may `[,@(mapcar #'cdr pass1)])))) + ((and (recordp value) (symbolp (aref value 0))) + (let* ((pass1 (let ((res ())) + (dotimes (i (length value)) + (push (desktop--v2s (aref value i)) res)) + (nreverse res))) + (special (assq nil pass1))) + (if special + (cons nil `(record + ,@(mapcar (lambda (el) + (if (eq (car el) 'must) + `',(cdr el) (cdr el))) + pass1))) + (cons 'may (apply #'record (mapcar #'cdr pass1)))))) ((consp value) (let ((p value) newlist From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 13:57:40 2019 Received: (at 35131) by debbugs.gnu.org; 4 Apr 2019 17:57:40 +0000 Received: from localhost ([127.0.0.1]:44667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC6cO-0006WH-C4 for submit@debbugs.gnu.org; Thu, 04 Apr 2019 13:57:40 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:34965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC6cL-0006W1-Tg for 35131@debbugs.gnu.org; Thu, 04 Apr 2019 13:57:38 -0400 Received: by mail-oi1-f178.google.com with SMTP id j132so2670789oib.2 for <35131@debbugs.gnu.org>; Thu, 04 Apr 2019 10:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=RHqJOK79/VWzaoj0Z+GenlnXJucz0ULJ3mE3Y7hBg+Q=; b=U2uTTlJQicZqaqvpUxQYx2oWTZfENHdHQJY440FT15PTvJ5ZvN6nJb1LXP1Frr3B3W 9kV8kV5KOtt4H8gG0ZLko5R9h4h1qwmm49GaV2scVk1DwGHu0Nms4lmeEE5Qx9sgfkGQ UXVxBQtHRO57NHfPSl0l/j5UlRdrLksQC3AUz1cL0EEAQ+BBmi+dxvt8Qf5KmPtlkvmF IDVcClpXwqPaSe8Opuv6rS0DikrTXTp06fAw+fXsI6pQO7/InuOHV00xVSVIx3pkHsye y4Sn89cMJK/58lQcovXfb3VwE04fbwwE2VvvC6c+imO4NhwvnTl/oC/JM/4qgRNJPyAx 5Yig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=RHqJOK79/VWzaoj0Z+GenlnXJucz0ULJ3mE3Y7hBg+Q=; b=eLSIerhavz6HSvGYbiR/c7yJKjrQTDsanse7kYWQoNaYbQ3KcBj7gcIKr8NB/C1DrG 0UlZZkVKnRi4Rax0XQc8Dyp2Ppj8CUbWGuoR1SPvSuBdxbpDqqdb9f0//ZlpVAYSM2T3 T0Xfn7aNiKqaTgHB9e6p/NaNF02tvnwX8kkYU7pPDZ0fTehrhPJG0TEYxxyrZHtq7GAR bpQXMKEE76va8I0F6jZXuVUeBTL0eVor5fbUZf+RiIW3mNQ8MGEAU2Bf1tonYS5bCeLw v+d2cCCeEQ9rO4Rh5xVQE/lCf3ABtN5s8Qtvq5ZN21tc9XoXAZCh3pG2Oe7xZkx/LYk0 UuBw== X-Gm-Message-State: APjAAAWZ5ErDl++1SoYM+wgUc4n4IWO93CgvxqY1JiBP/cN2H1xgKr12 nKjLNlAIvYz4TIMHAW0uSOdYyJ4QPto6DEDZk1vkcQ== X-Google-Smtp-Source: APXvYqx+7hvWhtc31dLmc04ZL7RGes8hApX5xkyJEgo1TJqh6s/XJbXXpyuOs490SOch/N0rSJP6+kRxq8p2unqRYFQ= X-Received: by 2002:aca:bf08:: with SMTP id p8mr4074443oif.173.1554400650689; Thu, 04 Apr 2019 10:57:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Noam Postavsky Date: Thu, 4 Apr 2019 13:57:20 -0400 Message-ID: Subject: Re: bug#35131: 27.0.50; desktop-save no longer saves register containing frameset To: 35131@debbugs.gnu.org, Stefan Monnier , tadeus.prastowo@unitn.it Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35131 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 4 Apr 2019 at 13:49, Stefan Monnier wrote: > + (let* ((pass1 (let ((res ())) > + (dotimes (i (length value)) > + (push (desktop--v2s (aref value i)) res)) > + (nreverse res))) Isn't this just (mapcar #'desktop--v2s value)? From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 14:37:26 2019 Received: (at 35131-done) by debbugs.gnu.org; 4 Apr 2019 18:37:26 +0000 Received: from localhost ([127.0.0.1]:44677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC7Er-0007YL-SJ for submit@debbugs.gnu.org; Thu, 04 Apr 2019 14:37:26 -0400 Received: from mail-it1-f172.google.com ([209.85.166.172]:50787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC7Ep-0007Y6-HA for 35131-done@debbugs.gnu.org; Thu, 04 Apr 2019 14:37:24 -0400 Received: by mail-it1-f172.google.com with SMTP id q14so5430986itk.0 for <35131-done@debbugs.gnu.org>; Thu, 04 Apr 2019 11:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unitn.it; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=su+JkxImWNVK/C51SXOf4DjWVzhgeUnJpaRjSLttDnQ=; b=nw0glKiJ0IM3Yna5O2PiiYCIZgP+fYxvi/SiDvagKswu3vY0vRZF6iMW05B90Ifnzc pPf0j7AdgiTQHx5THl4icNG1rHGPMkJg78h/knjN4bcY8iU+m2wqDEv30OOsMq5RDLzv jvKFxOprUR45y9sNDXuyZqDbQ95CHjhGcWxzY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=su+JkxImWNVK/C51SXOf4DjWVzhgeUnJpaRjSLttDnQ=; b=VQtukR6pOP0aW2V/wn3ItB5olTssprVW+VbwJuGy148KJFNgnAMKq4EO20D9WTOT79 Akt0n7Lxyd+3l7MMDoNnDw2V7urTwcwF/pZ1ROKruhK1xTEvkfUu2hLVsl28zldPVcdo iErJOBBW8YSSSERHkAREnUgpdN60L7isQ2IhX/rXYfU713otCK7tTRqD/i5RsFyMeLIt hEeHtbDmcvk133Vl/08IM22dUPzJmtcaA3SJzayN5RfgGmyDbnLeNBUUILvALvoW/IPz 7+7aU6eFSroFbpLZSROGrZZMid6DXFxIinqmohyqG2XHJ+tIBta8//CzgjS3IPTlnWlU Y9zg== X-Gm-Message-State: APjAAAXS0Svn2ab3qfZ9+97cZFuLqPklxS56HzXlgCZHSx46p0Pix/CN FvLRVSmUXMeRFO3UI1K9Iu3mfhlekpRvE92Oscp0 X-Google-Smtp-Source: APXvYqx3eUUs6eskHJohWTRtNrzgvZlfdvI5rcc+UzwpApuVLwk/IyG9eVttuLwaseA7jJvEwDodnDtrdDgf0qIVs7c= X-Received: by 2002:a24:50cc:: with SMTP id m195mr5336745itb.160.1554403036549; Thu, 04 Apr 2019 11:37:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tadeus Prastowo Date: Thu, 4 Apr 2019 20:37:03 +0200 Message-ID: Subject: Re: bug#35131: 27.0.50; desktop-save no longer saves register containing frameset To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35131-done Cc: 35131-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Apr 4, 2019 at 7:48 PM Stefan Monnier wrote: > I installed the patch below which seems to fix it, > > > Stefan > > > diff --git a/lisp/desktop.el b/lisp/desktop.el > index acabde5eb2..97c057e201 100644 > --- a/lisp/desktop.el > +++ b/lisp/desktop.el > @@ -856,6 +856,19 @@ desktop--v2s > `',(cdr el) (cdr el))) > pass1))) > (cons 'may `[,@(mapcar #'cdr pass1)])))) > + ((and (recordp value) (symbolp (aref value 0))) > + (let* ((pass1 (let ((res ())) > + (dotimes (i (length value)) > + (push (desktop--v2s (aref value i)) res)) > + (nreverse res))) > + (special (assq nil pass1))) > + (if special > + (cons nil `(record > + ,@(mapcar (lambda (el) > + (if (eq (car el) 'must) > + `',(cdr el) (cdr el))) > + pass1))) > + (cons 'may (apply #'record (mapcar #'cdr pass1)))))) > ((consp value) > (let ((p value) > newlist I confirm that the patch solves the reported bug. Thank you very much for your quick response, Stefan. I really appreciate it. -- Best regards, Tadeus From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 16:30:26 2019 Received: (at 35131) by debbugs.gnu.org; 4 Apr 2019 20:30:26 +0000 Received: from localhost ([127.0.0.1]:44735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC90C-0002D4-Vf for submit@debbugs.gnu.org; Thu, 04 Apr 2019 16:30:25 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:37091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC906-0002Cm-Ar for 35131@debbugs.gnu.org; Thu, 04 Apr 2019 16:30:22 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x34KUFRr003073; Thu, 4 Apr 2019 16:30:16 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 66537AE27B; Thu, 4 Apr 2019 16:30:15 -0400 (EDT) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#35131: 27.0.50; desktop-save no longer saves register containing frameset Message-ID: References: Date: Thu, 04 Apr 2019 16:30:15 -0400 In-Reply-To: (Noam Postavsky's message of "Thu, 4 Apr 2019 13:57:20 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6518=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6518> : inlines <7047> : streams <1817713> : uri <2825977> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35131 Cc: 35131@debbugs.gnu.org, tadeus.prastowo@unitn.it X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> + (let* ((pass1 (let ((res ())) >> + (dotimes (i (length value)) >> + (push (desktop--v2s (aref value i)) res)) >> + (nreverse res))) > Isn't this just (mapcar #'desktop--v2s value)? (mapcar #'identity (record 'sm-foo 1 2 3)) ==> nil -- Stefan From unknown Thu Sep 11 18:37:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 May 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator