From unknown Wed Jul 09 01:55:10 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35121 <35121@debbugs.gnu.org> To: bug#35121 <35121@debbugs.gnu.org> Subject: Status: [debbugs.el] debbugs-make-control-message doesn't always ask for version Reply-To: bug#35121 <35121@debbugs.gnu.org> Date: Wed, 09 Jul 2025 08:55:10 +0000 retitle 35121 [debbugs.el] debbugs-make-control-message doesn't always ask = for version reassign 35121 emacs submitter 35121 Noam Postavsky severity 35121 minor tag 35121 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 09:20:46 2019 Received: (at submit) by debbugs.gnu.org; 3 Apr 2019 13:20:46 +0000 Received: from localhost ([127.0.0.1]:42192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBfor-00067W-Bm for submit@debbugs.gnu.org; Wed, 03 Apr 2019 09:20:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBfop-00067K-Vs for submit@debbugs.gnu.org; Wed, 03 Apr 2019 09:20:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:54405) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBfok-0000FV-Lr for submit@debbugs.gnu.org; Wed, 03 Apr 2019 09:20:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBfoj-0000Ov-Hr for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 09:20:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBfoi-00009g-DP for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 09:20:37 -0400 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:41128) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBfog-0008W7-NE for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 09:20:35 -0400 Received: by mail-qk1-x72f.google.com with SMTP id o129so10080876qke.8 for ; Wed, 03 Apr 2019 06:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=DSLljZ6VhSK0pDmVJ/YksLfFfP8FJpjfQaZbZgOk21U=; b=Y1cMQ5d4yk6ElfO0pJq/Q9x+xOY0qpAhGvqwt9MgNsaKw9pB8gU+uer+G1RmVJpnyP AxUrm3uBYxCWPHJkd7VnxPDzVMhJv2cZUmd/aM0cJ/KxL7VkXtRKriTPGTCE2lXBRuB2 RMyQtTbn5sFC1qqY0GgSQxmWGrLow2yMSFPRdL06aGv5niHqq8dhWOUOX9VfWemCUivj Ic4G8kPR3mK8FV/G1TebcFE/ZJCMWi39edPuVB+LtSHFf1K9oc1QDoAhvEHQJtqrhsaa LewYshd03s6zTyVoTC6TXrW5JTDnnf+hB6uFXGYZQuQCj9bdIQfSPpuMME+gdIB/QXof 8T2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=DSLljZ6VhSK0pDmVJ/YksLfFfP8FJpjfQaZbZgOk21U=; b=ODBHMLRNPoyhqMYW0ht7kSmU6hqyS0JDV9Ik/ba4T7+DgCGXYyLW/fMKzryRecDmcO Ifo2RCDcnsvIuKR/ma9IuFi5yrMY2q84Nw3QWKuc66dJrdF0qUg4bkHHmfxYLuu5si9r XYNRgKUqqq5otBabSpwl6GBjiOZRnr8sjOWwUuLU3it25h2FdkyXzx9/7bEaCToLOgHx 61EnWo8sCgbr4cTYfwA3L+aIT6Cg1xYb13w9qpSDVtCT/z3I9psTAoN7zCwoVdaGcS9K 5e6yvk3kz24zVaSX8/wdTCxy3MWUaNCGi0UPSI7KkDXBcFyAUDnU7W84B8ZGlZZ0od/r 1tkA== X-Gm-Message-State: APjAAAX+Af4n3E3jICcdyX44s2Kjky0OxmLpJmdX3k9eNyREL2c5QGgg Iz8kSILc7+yNnuCTFCXE+ibd6sUE X-Google-Smtp-Source: APXvYqxo+ouveqii1ieCA05Ef4ExdtfvXKyRVzX3T4DWEWl1YdI6a46evaQbyuvKuDVw+QwNCiKSGQ== X-Received: by 2002:a37:2c82:: with SMTP id s124mr53654462qkh.286.1554297632723; Wed, 03 Apr 2019 06:20:32 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m73sm8063592qke.95.2019.04.03.06.20.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 06:20:31 -0700 (PDT) From: Noam Postavsky To: bug-gnu-emacs@gnu.org Subject: [debbugs.el] debbugs-make-control-message doesn't always ask for version Date: Wed, 03 Apr 2019 09:20:30 -0400 Message-ID: <87h8bffco1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::72f X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Severity: minor Tags: patch When using debbugs-make-control-message to make a "done" or "fixed" control message from a message-mode buffer, it doesn't ask for for a version number. That's because (debbugs-gnu-current-status) returns nil outside the *Bugs* buffer, so the (member "emacs" (cdr (assq 'package status))) check always fails. I think it should be okay to fallback to cache, or debbugs-get-status if the cache is empty, right? By the way, I wonder if we should ask for version even if the package is not Emacs (obviously the initial-input suggestion only works for Emacs), surely other packages have versions too? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Try-harder-to-debbugs-status-if-d-g-current-statu.patch Content-Description: patch >From fbaec0d15b816892c5f774ea9cfdfa6536956d8e Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 3 Apr 2019 09:03:13 -0400 Subject: [PATCH v1] Try harder to debbugs status if d-g-current-status missing * packages/debbugs/debbugs-gnu.el (debbugs-gnu-make-control-message): Fallback to debbugs-cache-data or debbugs-get-status if debbugs-gnu-current-status returns nil, otherwise we fail to ask for version number when fixing/finding/closing/etc Emacs bugs from a message-mode buffer. --- packages/debbugs/debbugs-gnu.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el index 33860c2d5..8f914d5c1 100644 --- a/packages/debbugs/debbugs-gnu.el +++ b/packages/debbugs/debbugs-gnu.el @@ -1586,7 +1586,9 @@ (defun debbugs-gnu-make-control-message (message bugid &optional reverse buffer) current-prefix-arg (when (derived-mode-p 'message-mode) (current-buffer))))) - (let* ((status (debbugs-gnu-current-status)) + (let* ((status (or (debbugs-gnu-current-status) + (gethash bugid debbugs-cache-data) + (debbugs-get-status bugid))) (version (if (and (member message '("close" "done" -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 15:48:28 2019 Received: (at 35121) by debbugs.gnu.org; 3 Apr 2019 19:48:28 +0000 Received: from localhost ([127.0.0.1]:43245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBls4-0007rV-Fv for submit@debbugs.gnu.org; Wed, 03 Apr 2019 15:48:28 -0400 Received: from mout.gmx.net ([212.227.15.15]:53865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBls1-0007rI-Ey for 35121@debbugs.gnu.org; Wed, 03 Apr 2019 15:48:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1554320898; bh=zGQZgDhDGFG4xYzhpf0rsWpnN6Rpi9lLgXkbMyKvnr8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=AywEoIXy2IYIpTo41gaBhuViexZwox2vvr/C1Yyealk73YCj3wtTcSMQZ0hk3H32q ykVOJkykLlGoREalZSmy3OxEEd9faE5Fc+6105ii4a/KjoUuazJ2RJZGNcRPC5cGDZ w6vxxCD6BUw5gyb/WIoiP8u4+dl/fVUnPNJ/E9cc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([213.220.156.208]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MPlsg-1hGjgW1vsY-0052QL; Wed, 03 Apr 2019 21:48:18 +0200 From: Michael Albinus To: Noam Postavsky Subject: Re: bug#35121: [debbugs.el] debbugs-make-control-message doesn't always ask for version References: <87h8bffco1.fsf@gmail.com> Date: Wed, 03 Apr 2019 21:48:17 +0200 In-Reply-To: <87h8bffco1.fsf@gmail.com> (Noam Postavsky's message of "Wed, 03 Apr 2019 09:20:30 -0400") Message-ID: <87k1gakgzi.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:UohOBOOallOby3RCEiMDl3q8JgHYXfrMBvzNp7iDuXvAIAEWlqP QKsr3nfhA40I2Bjrlj9njnG9D5b1nSPHFhxlgQAWiyR8adr9pbYMRnzZaKFOecqsBPmymX0 iDlsT2OxHohgsZ2XXUrzO8GRERs25B4qyfuWnwQF+m27XralQBZIwz+0lmeXedlDHpN94vt h2B/+iZMfQGqIL71Ej5Tw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:MT3poCeTwJw=:+X4W2Tc30PPMGzKEGDdcVn R4oO+RB+9hiooQhQk5imtlgOjm+KlhcmXI4SjIj3uZObroaL+QtIva6d6jX/WnFTz/4eGzwxd +X5LdRCqZe482reWQw119myN8sxVcklymoJSRRYC89u2yTEfyjgBbuAkHzieSzgzmRmlksPz+ 22WngevajNKLRDRO/zIwCXm2iaNo6V4P8pof8lXOrbYxaL5DEUAizJVazs7/vmf+954CMSl6C rpi7nFmCve9LXBu1IYoAd8XImclxW7laqNbPiuLdCJKUXEsLsFHCvJxKGwtOoyeER6n0KOH/f 1WQReT1ZC/71162rpBgLBybUZqYvjzSfPIEAgpAcyAqObfjrD9pMSVzwhZ02LIbzJDaKV+iZx jdLK6k4d5opWIRSBVF3ERs7y1BCin61uUnWPXCcR60SshhUuubAWMPMtaZJzWqFWlTOlZCm1n SiESlE7eAYW6OqxmQV19uMV9kH+jaDPj/FvgxcxezuCfkX96qgiKUqRSUslR2E/KmI/zMNxx2 RfVVfLmVJefw3P/bWa1/CPkOHrC0nM5yI8ZRc/lSs4/+p86K04TDeub/xpWu0JjwULH+vg+2r BwJwPg9njCHlt24CoySja0FYRN+eX25xjN3NYxJE1/PF47wYli/IUFKmNyTWV1FY5DOoKVETc BUz5owSDywhKuKRrxv6SPfTkgGvHop5jkelndIs4YKA5/1tSTr6NU6/zCVGdqoQ3syQIFb4f2 tFbQYup1V53mzPCIIZPbKK8Lmj2MUkzTcGuNZief0qVL6l/nfFBJpsmLzf/uGd1Qg3DLgugPJ WxC+yZcMNi3p4ra7RfdiwiYorp9ao03ByAd07zY/hTHZS7yG41IVQsmZQj9cJM7rKZg3c8T6a FH5H7cZaVjLYYpImkysFWAMKEZeBYdMXfbgcbsJMKjEpb0WF4jDTAfQKOk1TZ0ePigeQkgNlT E7V6Adh8YGQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35121 Cc: 35121@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Noam Postavsky writes: Hi Noam, > When using debbugs-make-control-message to make a "done" or "fixed" > control message from a message-mode buffer, it doesn't ask for for a > version number. That's because (debbugs-gnu-current-status) returns nil > outside the *Bugs* buffer, so the (member "emacs" (cdr (assq 'package > status))) check always fails. > > I think it should be okay to fallback to cache, or debbugs-get-status if > the cache is empty, right? Yes. Your patch LGTM. > By the way, I wonder if we should ask for version even if the package is > not Emacs (obviously the initial-input suggestion only works for Emacs), > surely other packages have versions too? I would suppose so. But in order to get feedback, you might ask on the ML. People using debbugs.el for other projects but Emacs are lurking there. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 19:51:34 2019 Received: (at 35121) by debbugs.gnu.org; 3 Apr 2019 23:51:34 +0000 Received: from localhost ([127.0.0.1]:43442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBpfK-00010V-JS for submit@debbugs.gnu.org; Wed, 03 Apr 2019 19:51:34 -0400 Received: from mail-qt1-f177.google.com ([209.85.160.177]:40603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBpfH-00010B-TB; Wed, 03 Apr 2019 19:51:32 -0400 Received: by mail-qt1-f177.google.com with SMTP id x12so1178424qts.7; Wed, 03 Apr 2019 16:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vSOHO9iMVEq+NhwegrK1Owsuz5cCLZ44w8I2AcOTwNA=; b=bA4HPR7uzGVfMIpHUf8M4C9Wx82s51+9fvZvCb7UKAqnl7gm0F6yloO8f3Y7okyU9m 2jJMeNUZOiodU+MpVyHT1svoHsITv2PzK8u/PkwZqYClQ6i3KNHHWU3RDrruaMKC9aDT JZGSD82eJh+0jPhRLKUMEOI1d8r9gpJUyVaB7H9fg5d9xA3xIwdkql7wFqNxe7kVEUao Pm5dMRkd9E4GBqDInXapG1QMNtUIx+gqYShY8TjCDcTO7rNBBZcwXmw0Hb3xKy3Satal z4zRumd9vvPjzVRd9M6vn47c/g+5NXW+osgSWhUWJcoaI8Ib3uqWCZSDrSfJNqHk0OZY oDpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=vSOHO9iMVEq+NhwegrK1Owsuz5cCLZ44w8I2AcOTwNA=; b=RW+XlkER7HxnA0PGaBYhqPqYK6ICAEAKeOluNS/P1C8x3xMKupPi/1o51OOkkDu9f/ uiuKt2AB77M52UnEyufc8SxRTubsP+wQTVfNbnruAcD3U0VmErM6Q1CHkn7eVl9ti+1f z4RlEIqeEN2wTD/SrjgL0c622XwNHBHxjg0Fgl34djNbZPL0baim69qDkG/mm2dfgCO+ H6+dgI1y7mof99N/isFDj0yMWF386wTI0GED/VJ1s1y50GZtSVkHOe6RfGhMxf5o9PFn YACbiU82P1+2cA50T6yuDYGDkAl3+HYVKeRKt15xrmJ9mBX2BWTzNDfxq0DTmY2BKErD NROA== X-Gm-Message-State: APjAAAXuEweTy3x+/UYElRtkbpk+bYymTgmNBAaxS7tTTzQ6TCuiwhvN JxZha6CS8+yVrd7Tt/JCOsdo35O/ X-Google-Smtp-Source: APXvYqwab83TBWXKTOQz82dey1Yq1rV5jGUjQPVxk23c0GCqDVz3I+dzpFQqlRLUb+Gfoovf2PPQjQ== X-Received: by 2002:aed:3622:: with SMTP id e31mr2513766qtb.97.1554335485985; Wed, 03 Apr 2019 16:51:25 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q30sm11404578qtk.85.2019.04.03.16.51.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 16:51:24 -0700 (PDT) From: Noam Postavsky To: Michael Albinus Subject: Re: bug#35121: [debbugs.el] debbugs-make-control-message doesn't always ask for version References: <87h8bffco1.fsf@gmail.com> <87k1gakgzi.fsf@gmx.de> Date: Wed, 03 Apr 2019 19:51:23 -0400 In-Reply-To: <87k1gakgzi.fsf@gmx.de> (Michael Albinus's message of "Wed, 03 Apr 2019 21:48:17 +0200") Message-ID: <87bm1mfy10.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35121 Cc: 35121@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35121 fixed close 35121 quit Michael Albinus writes: >> I think it should be okay to fallback to cache, or debbugs-get-status if >> the cache is empty, right? > > Yes. Your patch LGTM. Pushed. [1: 1a6a4a33a]: 2019-04-03 19:46:11 -0400 Search further if d-g-cur-status is nil (Bug#35121) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1a6a4a33a0933152d21e4da5ba052704bd292aec> >> By the way, I wonder if we should ask for version even if the package is >> not Emacs (obviously the initial-input suggestion only works for Emacs), >> surely other packages have versions too? > > I would suppose so. But in order to get feedback, you might ask on the > ML. People using debbugs.el for other projects > but Emacs are lurking there. Okay, I've sent a message, we'll see if anyone bites. From unknown Wed Jul 09 01:55:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 02 May 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator