From unknown Tue Jul 08 17:24:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35117 <35117@debbugs.gnu.org> To: bug#35117 <35117@debbugs.gnu.org> Subject: Status: [PATCH] build-system/python: Move the check phase after the install phase. Reply-To: bug#35117 <35117@debbugs.gnu.org> Date: Wed, 09 Jul 2025 00:24:21 +0000 retitle 35117 [PATCH] build-system/python: Move the check phase after the i= nstall phase. reassign 35117 guix-patches submitter 35117 Maxim Cournoyer severity 35117 normal tag 35117 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 00:24:12 2019 Received: (at submit) by debbugs.gnu.org; 3 Apr 2019 04:24:12 +0000 Received: from localhost ([127.0.0.1]:42015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBXRb-0005lo-RN for submit@debbugs.gnu.org; Wed, 03 Apr 2019 00:24:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBXRZ-0005lY-NG for submit@debbugs.gnu.org; Wed, 03 Apr 2019 00:24:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:52386) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBXRU-0007PX-Dq for submit@debbugs.gnu.org; Wed, 03 Apr 2019 00:24:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBXRT-0000XV-8g for guix-patches@gnu.org; Wed, 03 Apr 2019 00:24:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBXRS-0007OZ-42 for guix-patches@gnu.org; Wed, 03 Apr 2019 00:24:03 -0400 Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]:41825) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBXRR-0007O4-Oz for guix-patches@gnu.org; Wed, 03 Apr 2019 00:24:02 -0400 Received: by mail-io1-xd35.google.com with SMTP id v10so12912617iom.8 for ; Tue, 02 Apr 2019 21:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=qg4nbj22wemS7pdzEnMhhJVbiSC2JS/lEYmUNoTszoo=; b=o1UbGfuvT/ySuSFLD2rzdaGwJ3DMWBnozcEkN+79hV0LGpqowiOiVwW3bpbKCsNvsQ NYP/tUiZV95B71eeeh5B743OdrTBo9EoFJFO7DP12yFljAQHXl5pnAB6ihj4IOtPGt1w T2ns+qkGczB11EpyqGESCVALGkWj/WN7fx9lLQIlcVe8LakDkJlT4B/umI920AnYUmZ8 gLhkpvYVYg0Ci8Jp3hMbY2sZ5cq1yN0TXrmz2Neg4QVArN097doBUR3J07RG6v4RRdDT gtrbxwRaATfdeezwGufkRTHqfxOmBf4vDBNBPC70hm1IFpiXONZ0yOsyHZTHAt1vBbTd Kthg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=qg4nbj22wemS7pdzEnMhhJVbiSC2JS/lEYmUNoTszoo=; b=rp++YbGmF4qJPxSoGgPlgllrAtdfAbK8zj8evc8eO9C4sgXwgLVD69KoflpZNUO88f Y8frjxthrDjumJfBB891jqQXLKYE94peWk4iBzBhpolAf7weqi85KaeaaAPKv7APvha6 OVDXSPSZqRT5kZsMcqCvFM4nnryW41qDN4zH1ELqHp3DavyB2muaRgFN0Sud6SQPNu95 7gQFAN7K2OvgdEctM9dwcwTQcPiFkBb7zlVT4Uo7vE5H7BljTeeNnOFszUHce/4gxIAZ WIJqIVgkGCNIIiViJQkbp9jgchHGyN4c6awvze26FDUAWG8kal2gFBbkhPqZSgCzKP9T 2doQ== X-Gm-Message-State: APjAAAXnjHtCaJYvpS0VouOGbqUrLKJukN4ojEmTujEToUriRmot8VwX d301lYyg9wt7JRseSpGPsc4lBYsi X-Google-Smtp-Source: APXvYqzOmz9lO7wNhnCYsb4gvhSXvxlNhtD3Z2QDo+Nd1MsLSHTvEWAin1MevEBQpb1y19SSZqd6Jw== X-Received: by 2002:a5d:8594:: with SMTP id f20mr334903ioj.38.1554265440634; Tue, 02 Apr 2019 21:24:00 -0700 (PDT) Received: from kwak ([2607:f2c0:94b4:fa00::235]) by smtp.gmail.com with ESMTPSA id a16sm7890409itj.15.2019.04.02.21.23.59 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Apr 2019 21:23:59 -0700 (PDT) From: Maxim Cournoyer To: guix-patches Subject: [PATCH] build-system/python: Move the check phase after the install phase. Date: Wed, 03 Apr 2019 00:23:58 -0400 Message-ID: <87v9zv7m3l.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d35 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello! This fixes a (rare?) Python reproducibility problem that was discovered when packaging PyGithub (see patch submission at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35116). You can try running a --check --no-grafts -K on the python-pygithub package, before and after the fix to see the result. Thanks, Maxim --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-build-system-python-Move-the-check-phase-after-the-i.patch Content-Transfer-Encoding: quoted-printable From=206fdd6b942b1cddc25bab89b9e256a5dc83d89d35 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Wed, 3 Apr 2019 00:09:20 -0400 Subject: [PATCH] build-system/python: Move the check phase after the install phase. A reproducibility problem was discovered while packaging python-pygithub wh= ere the bytecode produced by running the tests would interfere with the result = of the install phase byte compilation. Moving the check phase after the insta= ll phase solves the problem. * guix/build/python-build-system.scm (%standard-phases): Add comment, move the check phase after the install phase. =2D-- guix/build/python-build-system.scm | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-s= ystem.scm index 5bb0ba49d5..9a1a95111a 100644 =2D-- a/guix/build/python-build-system.scm +++ b/guix/build/python-build-system.scm @@ -251,16 +251,21 @@ installed with setuptools." #t) =20 (define %standard-phases =2D ;; 'configure' phase is not needed. + ;; The build phase only builds C extensions and copies the Python source= s, + ;; while the install phase byte-compiles and copies them to the prefix + ;; directory. The tests are run after the install phase because otherwi= se + ;; the cached .pyc generated during the tests execution seem to interfere + ;; with the byte compilation of the install phase. (modify-phases gnu:%standard-phases (add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-198= 0) (add-after 'ensure-no-mtimes-pre-1980 'enable-bytecode-determinism enable-bytecode-determinism) (delete 'bootstrap) =2D (delete 'configure) =2D (replace 'install install) =2D (replace 'check check) + (delete 'configure) ;not needed (replace 'build build) + (delete 'check) ;moved after the install phase + (replace 'install install) + (add-after 'install 'check check) (add-after 'install 'wrap wrap) (add-before 'strip 'rename-pth-file rename-pth-file))) =20 =2D-=20 2.20.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAlykNV4ACgkQEmDkZILm NWKfrQ//Z6b54U9zWwbsI7oeCzxgae+MYZd9sGdGlNuRaKC1e2fBSjL7y4uLpY5z TTVLPZm9kPNr0dhnZBLS08ihVLs5+8ku/H1e9lbXR4nxSc50t3XfnS3Lm7lzturv FvFd4ACOatV6ueymuYjGtUuuLERPjOfeYGasnVV2Wz8+Rq4TdjpCcQUzZnJhR2+s oBd7c8p0s8jR3UeZFInBDvMeelyR/YcYQeBIeopMGtCKMMev/x2DVwoDHsiUn5EA PTH9DtK6Z2Dgoij2wsnqgb2CrAUFzC+FSvP9sAIk2POJ2XpjolB5nZGc9/B7vDAN 4IbHzQJ8IExFHtTD7ITW+U6ITLNE/378sJRrXuLiIBPQSdBFs3tcZJPW4GV1mcw/ z9lty4YzKDaMlZiI9zFTW0PxFIvoUnNda0009anAWewK88Yzbok1pX/Idouhbr4D 46KiKEQn1MMdXnZPDS+OAwkOcHxagEeu/6tZQyKmSKXxaCn8vMzoHU9bTLAh5xai hK6r4/bGkBeyk0oSxsJzsUOAW91c22wQAhg85vfpLFa15zkbMO6kU416ExS2gFl4 s5ifj1Z8pGed92KUbrb3ueL58wT10th6UpTf6PvmRki8tpHYTPIkzP9CdqxkNL1P 0EKQ3txFNc6GuLjIdvj+81CMwJ9Igfy2XNGZ4SOKnoS472chSAE= =iOOB -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 19 09:48:03 2019 Received: (at 35117-done) by debbugs.gnu.org; 19 Apr 2019 13:48:03 +0000 Received: from localhost ([127.0.0.1]:43584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHTs3-0001qL-6j for submit@debbugs.gnu.org; Fri, 19 Apr 2019 09:48:03 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:42999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHTs1-0001pr-Hh for 35117-done@debbugs.gnu.org; Fri, 19 Apr 2019 09:48:01 -0400 Received: by mail-qk1-f193.google.com with SMTP id b74so2945781qkg.9 for <35117-done@debbugs.gnu.org>; Fri, 19 Apr 2019 06:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=f4QmxFN1b4CteeIK0Xr0L+gsTQYuwd2VYQBOML8d/Fg=; b=WdScd+OaQmD4nEZlDudfloQv291ujqqHCvLGdVzq6eB4adBKhpjKPnfIhrlTRoxIa7 mVd2WURQAzSj7Xx+ZsLc4QG14t2FNiLvK/6VmAmtMm5i03zXfY07DgDA4EDoPYDDjFrB n8H8S2HuRHesULiNjqU3RiYxN8lWWNrfQTqJxww/or+RtxtJcjmj++UtwaTX1SlVguZ2 8g/ArGolZPrnD8r/ELKgqb4HPNNs9ux6DBKhjCRGmeRsvQIz6g227ZMd7XEqpu1fyHpp VeIPLxRcgEtmxy7ereRRFbAJF6p1zH7WQYQk1ictiWPA6DzEYOHNriKiVISp+xLyHS8B K0hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=f4QmxFN1b4CteeIK0Xr0L+gsTQYuwd2VYQBOML8d/Fg=; b=Ilm28f6QlzC0L5e+vJi6ld75eqOTwM2aqfJfPrJSSmEUER8AYIy1Ww0TSODsEoincJ 2GCYkxThvyBwWpguhU9yqwisTnwzKyZoW/lX4xFy1MysjZzCM60ImiRa82dpT4DRc4ng jkyI5vrZjDqMW0WwspV80BXkVjn7enI+2oONIZ8TFcvdQRKfrdGlL3U5fiCnkDkPgnzD pT2hrbz8aZYXP4EaQPsKJOBcPjtUpyec/AbIveo9pw6bHRj9TSbVnqJfYcHx/bvNM+cd 9OJbjxYLNdjmpwg6ks5w887/dforxtJEdQv4vnFkvEFVCOLA4SolhfBL045TW+1LV4lb Q9yg== X-Gm-Message-State: APjAAAUqp40haNARMFsKFRsFdbRPAtg4LGuczqPwg/ijs5+VlISou6j3 63+cStVy7WRMWQi99dts1+ukYD6D X-Google-Smtp-Source: APXvYqxW53EoRP6Cdb+8D5hVTVav6myUeBXSymhIIxNJVgEe7pRYLOGUbPR3D/9Zi7fk3SMjD2drXg== X-Received: by 2002:ae9:e909:: with SMTP id x9mr3185144qkf.130.1555681675944; Fri, 19 Apr 2019 06:47:55 -0700 (PDT) Received: from kwak (dsl-153-151.b2b2c.ca. [66.158.153.151]) by smtp.gmail.com with ESMTPSA id k41sm3304718qtc.89.2019.04.19.06.47.54 for <35117-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 06:47:54 -0700 (PDT) From: Maxim Cournoyer To: 35117-done@debbugs.gnu.org Subject: Re: [bug#35117] [PATCH] build-system/python: Move the check phase after the install phase. References: <87v9zv7m3l.fsf@gmail.com> Date: Fri, 19 Apr 2019 09:47:53 -0400 In-Reply-To: <87v9zv7m3l.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 03 Apr 2019 00:23:58 -0400") Message-ID: <87r29yrtrq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35117-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Maxim Cournoyer writes: > Hello! > > This fixes a (rare?) Python reproducibility problem that was discovered > when packaging PyGithub (see patch submission at > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35116). > > You can try running a --check --no-grafts -K on the python-pygithub > package, before and after the fix to see the result. > > Thanks, > > Maxim I went ahead and pushed this to core-updates with commit 6bbb37a545. Closing. Maxim From unknown Tue Jul 08 17:24:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 18 May 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator