Subject: [bug#35110] [PATCH v2 1/2] Add (guix build-system linux-module).

From: Ludovic Courtès <[email-masked]>
Date: Thu, 11 Apr 2019 12:50:42 +0200

Hi Danny,

Danny Milosavljevic <[email-masked]> skribis:

> * guix/build/linux-module-build-system.scm: New file.
> * guix/build-system/linux-module.scm: New file.
> * Makefile.am (MODULES): Add them.

Awesome!

> +(define* (configure #:key inputs #:allow-other-keys)
> +  #t)
> +;  (let ((source (string-append (assoc-ref inputs "linux")
> +;                               "/Module.symvers")))
> +;    (if (file-exists? source)
> +;        (install-file source out-lib-build))
> +;    #t))

I think you should either remove this comment or add an explanation
and/or a TODO.

Could you also add a note in doc/guix.texi under “Build Systems”?

Otherwise LGTM, thank you!

Ludo’.