GNU bug report logs - #35058
[PATCH] Use display-graphic-p in more cases

Previous Next

Full log

Message #50 received at 35058 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alex <agrambot <at> gmail.com>
Cc: 35058 <at> debbugs.gnu.org
Subject: Re: bug#35058: [PATCH] Use display-graphic-p in more cases
Date: Fri, 05 Apr 2019 21:51:43 +0300

> From: Alex <agrambot <at> gmail.com>
> Cc: 35058 <at> debbugs.gnu.org
> Date: Fri, 05 Apr 2019 10:35:33 -0600
> 
> Okay, here's a new set of patches (excluding the same logb patch).

Thanks, this LGTM, with a couple of nits:

> +** CUA mode
> +
> +*** New defcustom 'cua-rectangle-terminal-modifier-key'

Please add a period at the end of this sentence.

> +This defcustom is used instead of forcing the modifier key to

I'd say "allows to customize the modifier key ..." instead of "is used
instead of ...".

Also, please mark this entry with "---", as it doesn't need to be
documented in any manuals.  (The other NEWS entry as well.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.