GNU bug report logs - #35052
[PATCH] `tex-current-defun-name' matches the wrong title

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35052 in the body.
You can then email your comments to 35052 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] `tex-current-defun-name' matches the wrong title
Date: Sat, 30 Mar 2019 21:30:02 +0100

[Message part 1 (text/plain, inline)]

Hi all,

please consider this LaTeX file with the latex-mode provided by Emacs
(not AUCTeX).

--8<---------------cut here---------------start------------->8---
\documentclass{article}

\begin{document}

\section{Emacs}

\subsection*[Emacs is the extensible, customizable, self-documenting
real-time display editor]{Emacs is the extensible, customizable,
  self-documenting real-time display editor}

\end{document}
--8<---------------cut here---------------end--------------->8---

In that buffer, eval (goto-char 68) and hit `C-x 4 a'.  Emacs enters the
first section (section{Emacs}) into the ChangeLog buffer.  I think
`tex-current-defun-name' could be more cautious like
`lisp-current-defun-name' is.  A possible patch is attached.  I will add
something like this also to AUCTeX since it currently doesn't set
`add-log-current-defun-function' at all.

Any comments welcome.

Best, Arash

[0001-Match-the-correct-sectioning-command.patch (text/x-patch, attachment)]

Message #8 received at 35052 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: 35052 <at> debbugs.gnu.org
Subject: Re: bug#35052: [PATCH] `tex-current-defun-name' matches the wrong
 title
Date: Sun, 31 Mar 2019 17:31:31 +0300

> From: Arash Esbati <arash <at> gnu.org>
> Date: Sat, 30 Mar 2019 21:30:02 +0100
> 
> --8<---------------cut here---------------start------------->8---
> \documentclass{article}
> 
> \begin{document}
> 
> \section{Emacs}
> 
> \subsection*[Emacs is the extensible, customizable, self-documenting
> real-time display editor]{Emacs is the extensible, customizable,
>   self-documenting real-time display editor}
> 
> \end{document}
> --8<---------------cut here---------------end--------------->8---
> 
> In that buffer, eval (goto-char 68) and hit `C-x 4 a'.  Emacs enters the
> first section (section{Emacs}) into the ChangeLog buffer.  I think
> `tex-current-defun-name' could be more cautious like
> `lisp-current-defun-name' is.  A possible patch is attached.

I don't use TeX mode, so I don't really mind, but please note that the
current behavior is consistent with Texinfo mode's equivalent: it also
detects only the @node in which point is located.

Message #11 received at 35052 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 35052 <at> debbugs.gnu.org
Subject: Re: bug#35052: [PATCH] `tex-current-defun-name' matches the wrong
 title
Date: Sun, 31 Mar 2019 22:29:43 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> I don't use TeX mode, so I don't really mind, but please note that the
> current behavior is consistent with Texinfo mode's equivalent: it also
> detects only the @node in which point is located.

Thanks for your response.  You are right, the behavior in Texinfo mode
is the same, but I think the better implementation is in
`lisp-current-defun-name' which I tried to follow.  I don't use TeX mode
either, so I'm fine if you say "keep it as is" and we close this one.

While we're at it: "bug#34790: LaTeX mode \href bug" is actually an
AUCTeX issue which is already resolved.  I didn't want to close it as
I'm not a regular in this list (not even sure if I could do it).  Can
you please close that report as well?  TIA.

Best, Arash

Message #14 received at 35052 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: 35052 <at> debbugs.gnu.org
Subject: Re: bug#35052: [PATCH] `tex-current-defun-name' matches the wrong
 title
Date: Mon, 01 Apr 2019 07:09:14 +0300

> From: Arash Esbati <arash <at> gnu.org>
> Cc: 35052 <at> debbugs.gnu.org
> Date: Sun, 31 Mar 2019 22:29:43 +0200
> 
> While we're at it: "bug#34790: LaTeX mode \href bug" is actually an
> AUCTeX issue which is already resolved.  I didn't want to close it as
> I'm not a regular in this list (not even sure if I could do it).  Can
> you please close that report as well?  TIA.

You can always close a bug by sending email to
NNNN-done <at> debbugs.gnu.org, where NNNN is the bug number.

Message #19 received at 35052-done <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 35052-done <at> debbugs.gnu.org
Subject: Re: bug#35052: [PATCH] `tex-current-defun-name' matches the wrong
 title
Date: Mon, 01 Apr 2019 21:21:26 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Arash Esbati <arash <at> gnu.org>
>> Cc: 35052 <at> debbugs.gnu.org
>> Date: Sun, 31 Mar 2019 22:29:43 +0200
>> 
>> While we're at it: "bug#34790: LaTeX mode \href bug" is actually an
>> AUCTeX issue which is already resolved.  I didn't want to close it as
>> I'm not a regular in this list (not even sure if I could do it).  Can
>> you please close that report as well?  TIA.
>
> You can always close a bug by sending email to
> NNNN-done <at> debbugs.gnu.org, where NNNN is the bug number.

I wasn't sure if *I*'m allowed to that.  I've closed #34790 and I'm
closing this one as well.  Again, thanks for your attention.

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.