GNU bug report logs - #35041
tee: use STDIN_FILENO instead of 0

Previous Next

Package: coreutils;

Reported by: Martin Castillo <castilma <at> uni-bremen.de>

Date: Fri, 29 Mar 2019 18:18:02 UTC

Severity: normal

Done: Pádraig Brady <P <at> draigBrady.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Martin Castillo <castilma <at> uni-bremen.de>
Subject: bug#35041: closed (Re: bug#35041: tee: use STDIN_FILENO instead of 0)
Date: Sat, 30 Mar 2019 22:10:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#35041: tee: use STDIN_FILENO instead of 0

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 35041 <at> debbugs.gnu.org.

-- 
35041: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35041
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Pádraig Brady <P <at> draigBrady.com>
To: Martin Castillo <castilma <at> uni-bremen.de>, 35041-done <at> debbugs.gnu.org
Subject: Re: bug#35041: tee: use STDIN_FILENO instead of 0
Date: Sat, 30 Mar 2019 15:09:51 -0700
On 29/03/19 11:16, Martin Castillo wrote:
> I was reading through tee.c and saw
> 231:      bytes_read = read (0, buffer, sizeof buffer);
> 
> Maybe it should read
> read(STDIN_FILENO, buffer, sizeof buffer);
> ?
> 
> Greetings,
> Martin Castillo

Pushed:
https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=ba36d51

marking this as done.

thanks,
Pádraig

[Message part 3 (message/rfc822, inline)]
From: Martin Castillo <castilma <at> uni-bremen.de>
To: bug-coreutils <at> gnu.org
Subject: tee: use STDIN_FILENO instead of 0
Date: Fri, 29 Mar 2019 19:16:41 +0100
I was reading through tee.c and saw
231:      bytes_read = read (0, buffer, sizeof buffer);

Maybe it should read
read(STDIN_FILENO, buffer, sizeof buffer);
?

Greetings,
Martin Castillo
-- 
GPG: 7FDE 7190 2F73 2C50 236E  403D CC13 48F1 E644 08EC



This bug report was last modified 6 years and 56 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.