GNU bug report logs - #35033
[PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#35033: closed ([PATCH] gnu: mpv: Set absolute path to
 'youtube-dl'.)
Date: Mon, 08 Apr 2019 08:31:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 08 Apr 2019 10:29:54 +0200
with message-id <87lg0k2931.fsf <at> gnu.org>
and subject line Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
has caused the debbugs.gnu.org bug report #35033,
regarding [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
35033: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35033
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Timo Eisenmann <eisenmann <at> fn.de>
To: guix-patches <at> gnu.org
Cc: Timo Eisenmann <eisenmann <at> fn.de>
Subject: [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
Date: Thu, 28 Mar 2019 21:00:54 +0100

* gnu/packages/video.scm (mpv)[arguments]: Add phase 'patch-paths' to
substitute in the absolute path to 'youtube-dl'.
---
 gnu/packages/video.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 55a1931530..3c5ade55a3 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1326,6 +1326,13 @@ SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
     (arguments
      '(#:phases
        (modify-phases %standard-phases
+         (add-after
+          'unpack 'patch-paths
+          (lambda* (#:key inputs #:allow-other-keys)
+            (let ((ytdl (assoc-ref inputs "youtube-dl")))
+              (substitute* "player/lua/ytdl_hook.lua"
+                (("\"youtube-dl\",")
+                 (string-append "\"" ytdl "/bin/youtube-dl\","))))))
          (add-before
           'configure 'setup-waf
           (lambda* (#:key inputs #:allow-other-keys)
-- 
2.21.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Timo Eisenmann <eisenmann <at> fn.de>
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 35033-done <at> debbugs.gnu.org
Subject: Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
Date: Mon, 08 Apr 2019 10:29:54 +0200

Hello,

Timo Eisenmann <eisenmann <at> fn.de> skribis:

> On Wed, 03 Apr 2019 22:24:12 +0200
> Ludovic Courtès <ludo <at> gnu.org> wrote:

[...]

>> I think it’s a case where it may be more appropriate to look for
>> ‘youtube-dl’ in $PATH because ‘youtube-dl’ is updated frequently.
>> 
>> WDYT?
>
> I think we should make mpv's youtube-dl feature work by default instead
> of requiring the user to install youtube-dl into their profile.

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

> We normally don't require the user to install dependencies such as
> youtube-dl into the profile. I think we should retain that behaviour
> even in this case with mpv. It would mean fewer surprises for the
> user. If I'm guessing correctly, mpv doesn't require a lot of effort to
> rebuild.

Alright, that makes sense (and indeed, mpv builds very quickly.)

I added a #t at the end of the phase and committed.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.