From unknown Fri Jun 13 16:52:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35033 <35033@debbugs.gnu.org> To: bug#35033 <35033@debbugs.gnu.org> Subject: Status: [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'. Reply-To: bug#35033 <35033@debbugs.gnu.org> Date: Fri, 13 Jun 2025 23:52:15 +0000 retitle 35033 [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'. reassign 35033 guix-patches submitter 35033 Timo Eisenmann severity 35033 normal tag 35033 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 15:04:17 2019 Received: (at submit) by debbugs.gnu.org; 28 Mar 2019 19:04:17 +0000 Received: from localhost ([127.0.0.1]:34746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9aK0-00045d-ST for submit@debbugs.gnu.org; Thu, 28 Mar 2019 15:04:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9aJz-00045O-4f for submit@debbugs.gnu.org; Thu, 28 Mar 2019 15:04:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:54680) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9aJu-0001kp-0M for submit@debbugs.gnu.org; Thu, 28 Mar 2019 15:04:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9aJt-0006Gh-2J for guix-patches@gnu.org; Thu, 28 Mar 2019 15:04:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9aJs-0001kS-5b for guix-patches@gnu.org; Thu, 28 Mar 2019 15:04:09 -0400 Received: from mout0.freenet.de ([2001:748:100:40::2:2]:55336) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h9aJr-0001jx-U3 for guix-patches@gnu.org; Thu, 28 Mar 2019 15:04:08 -0400 Received: from [195.4.92.164] (helo=mjail1.freenet.de) by mout0.freenet.de with esmtpa (ID eisenmann@fn.de) (port 25) (Exim 4.90_1 #2) id 1h9aJm-00052u-PT for guix-patches@gnu.org; Thu, 28 Mar 2019 20:04:02 +0100 Received: from [::1] (port=47620 helo=mjail1.freenet.de) by mjail1.freenet.de with esmtpa (ID eisenmann@fn.de) (Exim 4.90_1 #2) id 1h9aJm-0005SR-Om for guix-patches@gnu.org; Thu, 28 Mar 2019 20:04:02 +0100 Received: from sub4.freenet.de ([195.4.92.123]:49880) by mjail1.freenet.de with esmtpa (ID eisenmann@fn.de) (Exim 4.90_1 #2) id 1h9aHV-0002hP-D2 for guix-patches@gnu.org; Thu, 28 Mar 2019 20:01:41 +0100 Received: from p200300d403edff0053193646953a2512.dip0.t-ipconnect.de ([2003:d4:3ed:ff00:5319:3646:953a:2512]:44334 helo=localhost.localdomain) by sub4.freenet.de with esmtpsa (ID eisenmann@fn.de) (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (port 587) (Exim 4.90_1 #2) id 1h9aHV-0006Qw-9p; Thu, 28 Mar 2019 20:01:41 +0100 From: Timo Eisenmann To: guix-patches@gnu.org Subject: [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'. Date: Thu, 28 Mar 2019 21:00:54 +0100 Message-Id: <20190328200054.8306-1-eisenmann@fn.de> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Originated-At: 2003:d4:3ed:ff00:5319:3646:953a:2512!44334 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:748:100:40::2:2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit Cc: Timo Eisenmann X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/video.scm (mpv)[arguments]: Add phase 'patch-paths' to substitute in the absolute path to 'youtube-dl'. --- gnu/packages/video.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 55a1931530..3c5ade55a3 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -1326,6 +1326,13 @@ SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.") (arguments '(#:phases (modify-phases %standard-phases + (add-after + 'unpack 'patch-paths + (lambda* (#:key inputs #:allow-other-keys) + (let ((ytdl (assoc-ref inputs "youtube-dl"))) + (substitute* "player/lua/ytdl_hook.lua" + (("\"youtube-dl\",") + (string-append "\"" ytdl "/bin/youtube-dl\",")))))) (add-before 'configure 'setup-waf (lambda* (#:key inputs #:allow-other-keys) -- 2.21.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 16:24:22 2019 Received: (at 35033) by debbugs.gnu.org; 3 Apr 2019 20:24:22 +0000 Received: from localhost ([127.0.0.1]:43271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBmQo-0000Iq-15 for submit@debbugs.gnu.org; Wed, 03 Apr 2019 16:24:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBmQm-0000Ia-Om for 35033@debbugs.gnu.org; Wed, 03 Apr 2019 16:24:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBmQh-0003Fo-04; Wed, 03 Apr 2019 16:24:15 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34126 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hBmQg-000089-DU; Wed, 03 Apr 2019 16:24:14 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timo Eisenmann Subject: Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'. References: <20190328200054.8306-1-eisenmann@fn.de> Date: Wed, 03 Apr 2019 22:24:12 +0200 In-Reply-To: <20190328200054.8306-1-eisenmann@fn.de> (Timo Eisenmann's message of "Thu, 28 Mar 2019 21:00:54 +0100") Message-ID: <87imvurg5v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35033 Cc: 35033@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Timo, Timo Eisenmann skribis: > * gnu/packages/video.scm (mpv)[arguments]: Add phase 'patch-paths' to > substitute in the absolute path to 'youtube-dl'. I think it=E2=80=99s a case where it may be more appropriate to look for =E2=80=98youtube-dl=E2=80=99 in $PATH because =E2=80=98youtube-dl=E2=80=99 = is updated frequently. WDYT? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 16:36:52 2019 Received: (at 35033) by debbugs.gnu.org; 3 Apr 2019 20:36:52 +0000 Received: from localhost ([127.0.0.1]:43283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBmcu-0000cO-Gi for submit@debbugs.gnu.org; Wed, 03 Apr 2019 16:36:52 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:60556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBmcr-0000cE-Gf for 35033@debbugs.gnu.org; Wed, 03 Apr 2019 16:36:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QhobN2DOlxUNU0p8kDz8EMKoEu+i2igwWmlGklwjjuM=; b=GP21u8m2gt9KEmT79+tDSDbph sf5YCpINsQJEwjnPAFN7oYhXciyzfUBwv6KT0FtPtqdMVNiX9zd+2rceS5Z9FJ4kHiRfRLxZJ/08A RM0rsLbh/mh2EseTHkEfu0F6y7pHDvYWrnCbATqNbsJII8JI2CZM4pu9Cyn4pyrx6gmEc=; Received: from [49.206.14.41] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hBmcn-0007c0-Mo; Thu, 04 Apr 2019 02:06:45 +0530 From: Arun Isaac To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'. In-Reply-To: <20190328200054.8306-1-eisenmann@fn.de> References: <20190328200054.8306-1-eisenmann@fn.de> Date: Thu, 04 Apr 2019 02:06:31 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35033 Cc: 35033@debbugs.gnu.org, Timo Eisenmann X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain We normally don't require the user to install dependencies such as youtube-dl into the profile. I think we should retain that behaviour even in this case with mpv. It would mean fewer surprises for the user. If I'm guessing correctly, mpv doesn't require a lot of effort to rebuild. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlylGU8ACgkQLiXui2GA K7PkJQf7Bep3/KujDY7SSxl3UQsNk0dKWVSMXNrcs3imcjK1MGDylmvYWHT3wRRw zRII0kaEU3FLjbOl0nRlMSK7rQxk04OakhLR6pCDXp5pguUIlNQ6lwVdUxcF6Kai Ew8qf5dYK2jMFSmdsAO28TxAfqz/CiJz/jCWZ0wr/0LuahTxq9lEDnEHt1SUzZ0A wYzCZXjfgTD4MDKcSWaKw2f+PlTHI5o/gCE3ejzS/MoYHL9O8owWps0LUQwlBnV7 Gthbqp2BQ5hAyJAqNdNNfjkPzAkcTByhpelxgI2SnWjAS9d/eQZN8DI0r47oDI2s MFWliNfVTS7BqNg3sF6mSe8CmKNXfw== =NVrA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 18:51:10 2019 Received: (at 35033) by debbugs.gnu.org; 3 Apr 2019 22:51:10 +0000 Received: from localhost ([127.0.0.1]:43407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBoir-0005vk-UJ for submit@debbugs.gnu.org; Wed, 03 Apr 2019 18:51:10 -0400 Received: from mout2.freenet.de ([195.4.92.92]:43918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBoin-0005vW-MV for 35033@debbugs.gnu.org; Wed, 03 Apr 2019 18:51:06 -0400 Received: from [195.4.92.165] (helo=mjail2.freenet.de) by mout2.freenet.de with esmtpa (ID eisenmann@fn.de) (port 25) (Exim 4.90_1 #2) id 1hBoil-0000e0-LL; Thu, 04 Apr 2019 00:51:03 +0200 Received: from [::1] (port=50918 helo=mjail2.freenet.de) by mjail2.freenet.de with esmtpa (ID eisenmann@fn.de) (Exim 4.90_1 #2) id 1hBoil-0005az-KX; Thu, 04 Apr 2019 00:51:03 +0200 Received: from sub6.freenet.de ([195.4.92.125]:46156) by mjail2.freenet.de with esmtpa (ID eisenmann@fn.de) (Exim 4.90_1 #2) id 1hBogO-00030K-Pj; Thu, 04 Apr 2019 00:48:36 +0200 Received: from p200300d403cbd400c494435359d0cc17.dip0.t-ipconnect.de ([2003:d4:3cb:d400:c494:4353:59d0:cc17]:35792 helo=localhost) by sub6.freenet.de with esmtpsa (ID eisenmann@fn.de) (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256) (port 587) (Exim 4.90_1 #2) id 1hBogO-0007DI-Ho; Thu, 04 Apr 2019 00:48:36 +0200 Date: Thu, 4 Apr 2019 00:48:34 +0200 From: Timo Eisenmann To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'. Message-ID: <20190404004834.454c6be1@fn.de> In-Reply-To: <87imvurg5v.fsf@gnu.org> References: <20190328200054.8306-1-eisenmann@fn.de> <87imvurg5v.fsf@gnu.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originated-At: 2003:d4:3cb:d400:c494:4353:59d0:cc17!35792 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35033 Cc: 35033@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 03 Apr 2019 22:24:12 +0200 Ludovic Court=C3=A8s wrote: > Hi Timo, >=20 > Timo Eisenmann skribis: >=20 > > * gnu/packages/video.scm (mpv)[arguments]: Add phase 'patch-paths' > > to substitute in the absolute path to 'youtube-dl'. >=20 > I think it=E2=80=99s a case where it may be more appropriate to look for > =E2=80=98youtube-dl=E2=80=99 in $PATH because =E2=80=98youtube-dl=E2=80= =99 is updated frequently. >=20 > WDYT? I think we should make mpv's youtube-dl feature work by default instead of requiring the user to install youtube-dl into their profile. That being said if, for some reason, someone does not want to update mpv and still use a newer version of youtube-dl, they can do so by linking the youtube-dl binary into mpv's config dir (by default: ~/.config/mpv). >=20 > Thanks, > Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 04:30:06 2019 Received: (at 35033-done) by debbugs.gnu.org; 8 Apr 2019 08:30:06 +0000 Received: from localhost ([127.0.0.1]:48978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDPfJ-00085u-2P for submit@debbugs.gnu.org; Mon, 08 Apr 2019 04:30:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDPfH-00084w-Fe for 35033-done@debbugs.gnu.org; Mon, 08 Apr 2019 04:30:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDPfB-0008BD-4p; Mon, 08 Apr 2019 04:29:57 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=50016 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hDPf9-0004qA-Gr; Mon, 08 Apr 2019 04:29:55 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timo Eisenmann Subject: Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'. References: <20190328200054.8306-1-eisenmann@fn.de> <87imvurg5v.fsf@gnu.org> <20190404004834.454c6be1@fn.de> Date: Mon, 08 Apr 2019 10:29:54 +0200 In-Reply-To: <20190404004834.454c6be1@fn.de> (Timo Eisenmann's message of "Thu, 4 Apr 2019 00:48:34 +0200") Message-ID: <87lg0k2931.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35033-done Cc: Arun Isaac , 35033-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Timo Eisenmann skribis: > On Wed, 03 Apr 2019 22:24:12 +0200 > Ludovic Court=C3=A8s wrote: [...] >> I think it=E2=80=99s a case where it may be more appropriate to look for >> =E2=80=98youtube-dl=E2=80=99 in $PATH because =E2=80=98youtube-dl=E2=80= =99 is updated frequently. >>=20 >> WDYT? > > I think we should make mpv's youtube-dl feature work by default instead > of requiring the user to install youtube-dl into their profile. Arun Isaac skribis: > We normally don't require the user to install dependencies such as > youtube-dl into the profile. I think we should retain that behaviour > even in this case with mpv. It would mean fewer surprises for the > user. If I'm guessing correctly, mpv doesn't require a lot of effort to > rebuild. Alright, that makes sense (and indeed, mpv builds very quickly.) I added a #t at the end of the phase and committed. Thank you! Ludo=E2=80=99. From unknown Fri Jun 13 16:52:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 May 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator