From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 18:48:20 2019 Received: (at submit) by debbugs.gnu.org; 27 Mar 2019 22:48:20 +0000 Received: from localhost ([127.0.0.1]:33653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9HLH-0001zv-TB for submit@debbugs.gnu.org; Wed, 27 Mar 2019 18:48:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9Gwb-0007l2-Ey for submit@debbugs.gnu.org; Wed, 27 Mar 2019 18:22:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:35215) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9GwU-0000WD-In for submit@debbugs.gnu.org; Wed, 27 Mar 2019 18:22:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9GwT-0004ho-L2 for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 18:22:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9GwS-0000V5-Aw for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 18:22:41 -0400 Received: from mail.brumlow.io ([66.187.75.170]:34210) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9GwS-0000UU-0k for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 18:22:40 -0400 Received: from saturn (c-73-115-80-253.hsd1.tx.comcast.net [73.115.80.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.brumlow.io (Postfix) with ESMTPSA id 49C16140235 for ; Wed, 27 Mar 2019 17:22:38 -0500 (CDT) User-agent: mu4e 1.1.0; emacs 27.0.50 From: Michael Brumlow To: bug-gnu-emacs@gnu.org Subject: [PATCH 1/1] htmlfontify-buffer read-only text Date: Wed, 27 Mar 2019 17:22:27 -0500 Message-ID: <877eck0xgc.fsf@brumlow.io> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.187.75.170 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 27 Mar 2019 18:48:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed When trying to htmlfontify read only text I ran into a issue when trying to copy a read only ERC buffer. It failed because the text copied had the property of being read only. I found where hfy-fontify-buffer tries to remove the text properties but fails to do so because the text is read only. By adding (inhibit-read-only t) in the let statement at the top of the function I was able to correct this issue. Patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=htmlfontify.diff Content-Description: htmlfontify read-only fix diff --git a/lisp/htmlfontify.el b/lisp/htmlfontify.el index 9fc029ec58..131d719fad 100644 --- a/lisp/htmlfontify.el +++ b/lisp/htmlfontify.el @@ -1652,7 +1652,8 @@ hfy-fontify-buffer SRCDIR, if set, is the directory being htmlfontified. FILE, if set, is the file name." (if srcdir (setq srcdir (directory-file-name srcdir))) - (let* ( (html-buffer (hfy-buffer)) + (let* ( (inhibit-read-only t) + (html-buffer (hfy-buffer)) (css-sheet nil) (css-map nil) (invis-ranges nil) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 14:10:50 2019 Received: (at 35025) by debbugs.gnu.org; 23 Jun 2019 18:10:50 +0000 Received: from localhost ([127.0.0.1]:54532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf6wz-0006Yr-SN for submit@debbugs.gnu.org; Sun, 23 Jun 2019 14:10:50 -0400 Received: from quimby.gnus.org ([80.91.231.51]:44838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf6wx-0006Yf-7U for 35025@debbugs.gnu.org; Sun, 23 Jun 2019 14:10:48 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf6wu-0000LZ-AU; Sun, 23 Jun 2019 20:10:46 +0200 From: Lars Ingebrigtsen To: Michael Brumlow Subject: Re: bug#35025: [PATCH 1/1] htmlfontify-buffer read-only text References: <877eck0xgc.fsf@brumlow.io> Date: Sun, 23 Jun 2019 20:10:44 +0200 In-Reply-To: <877eck0xgc.fsf@brumlow.io> (Michael Brumlow's message of "Wed, 27 Mar 2019 17:22:27 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Brumlow writes: > When trying to htmlfontify read only text I ran into a issue when > trying to copy a read only ERC buffer. It failed because the text > copied had the property of being read only. I found where > hf [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35025 Cc: 35025@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Brumlow writes: > When trying to htmlfontify read only text I ran into a issue when > trying to copy a read only ERC buffer. It failed because the text > copied had the property of being read only. I found where > hfy-fontify-buffer tries to remove the text properties but fails to do > so because the text is read only. > > By adding (inhibit-read-only t) in the let statement at the top of the > function I was able to correct this issue. Thanks; applied to Emacs 27. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 14:10:57 2019 Received: (at control) by debbugs.gnu.org; 23 Jun 2019 18:10:57 +0000 Received: from localhost ([127.0.0.1]:54535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf6x7-0006ZI-6H for submit@debbugs.gnu.org; Sun, 23 Jun 2019 14:10:57 -0400 Received: from quimby.gnus.org ([80.91.231.51]:44852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf6x5-0006Z9-By for control@debbugs.gnu.org; Sun, 23 Jun 2019 14:10:55 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf6x2-0000Lg-SY for control@debbugs.gnu.org; Sun, 23 Jun 2019 20:10:54 +0200 Date: Sun, 23 Jun 2019 20:10:52 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #35025 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 35025 fixed close 35025 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35025 fixed close 35025 27.1 quit From unknown Sat Aug 16 18:46:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 22 Jul 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator