From unknown Sun Jun 15 10:56:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35022: 26.1; Load order of custom-autoload, custom-load-symbol, custom-loads is backward? Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Mar 2019 19:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35022 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 35022@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155371596515628 (code B ref -1); Wed, 27 Mar 2019 19:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Mar 2019 19:46:05 +0000 Received: from localhost ([127.0.0.1]:33561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9EUv-000440-BM for submit@debbugs.gnu.org; Wed, 27 Mar 2019 15:46:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9EUt-00043G-S8 for submit@debbugs.gnu.org; Wed, 27 Mar 2019 15:46:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:33272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9EUo-0005DU-IM for submit@debbugs.gnu.org; Wed, 27 Mar 2019 15:45:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9EUn-0005HM-6n for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 15:45:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9EUl-0005Ah-Uh for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 15:45:57 -0400 Received: from mail-it1-x12c.google.com ([2607:f8b0:4864:20::12c]:50503) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h9EUl-00059L-FB for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 15:45:55 -0400 Received: by mail-it1-x12c.google.com with SMTP id m137so2137081ita.0 for ; Wed, 27 Mar 2019 12:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=xwGLgS0g7C7Z+Yvxxg0cIhIvY8+qV8Gd18n3nSP3kkM=; b=CG6wdyqqnxEco50rIMAH9/42nJyiBMoYMW7Xlh03tgPyGOMGfnnC+zR5falXCsV27L fdL/KnBuU6KnLdvnu400wViTodMBruCtZs6VZx/ZIO6v6+IB403WXdr1aE1T8kZAgqHA gZMF3CxMK4TzPtKHKlRjgvrVVwKLYiPr3RFjrcF9y5nd1Ny0OreJraoqVB8PY0dnMHxM 5I61+iZjoZeR2BKDtobEJEF7kkYooh5/M8vFFa8sGEqyeSa1Fo2UPvnVZQhcdcFM1gCl bdLuhUO5BGhJgLEeGKCjGnwmPVKGa00dYtQmBBHJsvVH4tL9p6GGcWJrnFBe431lyHUm GSlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=xwGLgS0g7C7Z+Yvxxg0cIhIvY8+qV8Gd18n3nSP3kkM=; b=ABQv30dXnKCljbFn4Lss9SCypMd2j8muVpzLklmVAXtVuskDYCMHumbHDD0GnZ1W6N bz5rnIGk6ivVHcLUnrqI6fK8k2A/9a8m/ygatbkrFgowvk50xZd+t0dAytgYUb2X+Q49 6Q33+YgV128CfIB5O5KE2buPBi0N52K8K+1loTbLJ1OMrzproaoucqJZLnWGPhYd4zij 26bwY7Dt/N0TxqCPVKLX3jt+nRS2qIWJE+DUyM+f2rEfl+DXCeVIJZEQY8llA96w82wO R9lFl+j9E4rxVpEuC7Z6C6QD+w7srhiWqSMgrFaWGg6rkxri2aOAKenjbriqOAfkssJV JFzQ== X-Gm-Message-State: APjAAAU0caKn+GB/qLOOAQhIpXM/QmPPO3uTWxhAI6GJSasmemBL2pzV PBHfORBKuzp4ppCqYbG6evWKfeIGKV+9sijF5tp3YsW4QEU= X-Google-Smtp-Source: APXvYqyFR7bF6qyZPQKdtpLtO73Ji0ygmKo0i6EVmtHL5l/ubMnh40p90I8NxGIMQJDo5eSXbqzMpayviuktROLFLXM= X-Received: by 2002:a24:6b84:: with SMTP id v126mr5009447itc.136.1553715953435; Wed, 27 Mar 2019 12:45:53 -0700 (PDT) MIME-Version: 1.0 From: Allen Li Date: Wed, 27 Mar 2019 12:45:42 -0700 Message-ID: Content-Type: multipart/mixed; boundary="0000000000007cd87c058518af38" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::12c X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --0000000000007cd87c058518af38 Content-Type: text/plain; charset="UTF-8" I just spent some time tracking down an unexpected behavior in custom autoloads. The custom-autoload function is used in autoloads/loaddef files to set up custom variables. custom-autoload adds a load path to the custom-loads property of a variable. This property is then used in custom-load-symbol to load each of the load paths. The problem is that custom-autoload adds load paths to the front of custom-loads, and custom-load-symbol loads the paths in forward order. This is unexpected because if the site distributes a package foo and the user installs their own version of foo, the site custom-autoload will be called first: ;; Called from site-start (custom-autoload 'foo-some-variable "path/to/site/foo" nil) ;; Called from init.el/package-initialize (custom-autoload 'foo-some-variable "path/to/user/foo" nil) In this case the custom-loads property will be ("path/to/user/foo" "path/to/site/foo") The user version will be loaded first, and the site version will be loaded later, overriding the user version. This behavior is unexpected; the user would expect that their version of foo overrides the site version of foo. Furthermore, this behavior is somewhat non-deterministic; site overrides foo *only if* foo is loaded via setting foo-some-variable with customize. If foo is loaded normally (e.g. with require), then the user version of foo will be loaded in preference to the site verison of foo. I have attached a patch fixing this. Note that this is technically a breaking change; however I really doubt any one is intentionally relying on this behavior. I consider this a bugfix and I think there are probably users who don't realize that they are suffering from this bug because it's so subtle. In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.24), modified by Debian Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Debian GNU/Linux rodete (upgraded from: Ubuntu 14.04 LTS) --0000000000007cd87c058518af38 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Load-custom-variable-dependencies-in-FIFO-order.patch" Content-Disposition: attachment; filename="0001-Load-custom-variable-dependencies-in-FIFO-order.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jtrmcp880 RnJvbSA3MTk1NzNjNDNlY2I2ZTM3ZTJmN2M4MTNkZmNhYjA5Yzg3MDdkNTlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8YXlhdGFuZUBnb29nbGUuY29tPgpEYXRlOiBX ZWQsIDI3IE1hciAyMDE5IDEyOjM5OjI4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gTG9hZCBjdXN0 b20gdmFyaWFibGUgZGVwZW5kZW5jaWVzIGluIEZJRk8gb3JkZXIKClRoZSBjdXN0b20tYXV0b2xv YWQgZnVuY3Rpb24gaXMgdXNlZCBpbiBhdXRvbG9hZHMvbG9hZGRlZiBmaWxlcyB0byBzZXQKdXAg Y3VzdG9tIHZhcmlhYmxlcy4gIGN1c3RvbS1hdXRvbG9hZCBhZGRzIGEgbG9hZCBwYXRoIHRvIHRo ZQpjdXN0b20tbG9hZHMgcHJvcGVydHkgb2YgYSB2YXJpYWJsZS4gIFRoaXMgcHJvcGVydHkgaXMg dGhlbiB1c2VkIGluCmN1c3RvbS1sb2FkLXN5bWJvbCB0byBsb2FkIGVhY2ggb2YgdGhlIGxvYWQg cGF0aHMuCgpUaGUgcHJvYmxlbSBpcyB0aGF0IGN1c3RvbS1hdXRvbG9hZCBhZGRzIGxvYWQgcGF0 aHMgdG8gdGhlIGZyb250IG9mCmN1c3RvbS1sb2FkcywgYW5kIGN1c3RvbS1sb2FkLXN5bWJvbCBs b2FkcyB0aGUgcGF0aHMgaW4gZm9yd2FyZCBvcmRlci4KClRoaXMgaXMgdW5leHBlY3RlZCBiZWNh dXNlIGlmIHRoZSBzaXRlIGRpc3RyaWJ1dGVzIGEgcGFja2FnZSBmb28gYW5kIHRoZQp1c2VyIGlu c3RhbGxzIHRoZWlyIG93biB2ZXJzaW9uIG9mIGZvbywgdGhlIHNpdGUgY3VzdG9tLWF1dG9sb2Fk IHdpbGwgYmUKY2FsbGVkIGZpcnN0OgoKOzsgQ2FsbGVkIGZyb20gc2l0ZS1zdGFydAooY3VzdG9t LWF1dG9sb2FkICdmb28tc29tZS12YXJpYWJsZSAicGF0aC90by9zaXRlL2ZvbyIgbmlsKQo7OyBD YWxsZWQgZnJvbSBpbml0LmVsL3BhY2thZ2UtaW5pdGlhbGl6ZQooY3VzdG9tLWF1dG9sb2FkICdm b28tc29tZS12YXJpYWJsZSAicGF0aC90by91c2VyL2ZvbyIgbmlsKQoKSW4gdGhpcyBjYXNlIHRo ZSBjdXN0b20tbG9hZHMgcHJvcGVydHkgd2lsbCBiZQoKKCJwYXRoL3RvL3VzZXIvZm9vIiAicGF0 aC90by9zaXRlL2ZvbyIpCgpUaGUgdXNlciB2ZXJzaW9uIHdpbGwgYmUgbG9hZGVkIGZpcnN0LCBh bmQgdGhlIHNpdGUgdmVyc2lvbiB3aWxsIGJlCmxvYWRlZCBsYXRlciwgb3ZlcnJpZGluZyB0aGUg dXNlciB2ZXJzaW9uLgoKVGhpcyBiZWhhdmlvciBpcyB1bmV4cGVjdGVkOyB0aGUgdXNlciB3b3Vs ZCBleHBlY3QgdGhhdCB0aGVpciB2ZXJzaW9uIG9mCmZvbyBvdmVycmlkZXMgdGhlIHNpdGUgdmVy c2lvbiBvZiBmb28uICBGdXJ0aGVybW9yZSwgdGhpcyBiZWhhdmlvciBpcwpzb21ld2hhdCBub24t ZGV0ZXJtaW5pc3RpYzsgc2l0ZSBvdmVycmlkZXMgZm9vICpvbmx5IGlmKiBmb28gaXMgbG9hZGVk CnZpYSBzZXR0aW5nIGZvby1zb21lLXZhcmlhYmxlIHdpdGggY3VzdG9taXplLiAgSWYgZm9vIGlz IGxvYWRlZCBub3JtYWxseQooZS5nLiB3aXRoIHJlcXVpcmUpLCB0aGVuIHRoZSB1c2VyIHZlcnNp b24gb2YgZm9vIHdpbGwgYmUgbG9hZGVkIGluCnByZWZlcmVuY2UgdG8gdGhlIHNpdGUgdmVyaXNv biBvZiBmb28uCgoqIGxpc3AvY3VzdG9tLmVsIChjdXN0b20tbG9hZC1zeW1ib2wpOiBMb2FkIHZh cmlhYmxlIGRlcHMgaW4gcmV2ZXJzZSBvcmRlci4KLS0tCiBsaXNwL2N1c3RvbS5lbCB8IDIgKy0K IDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdp dCBhL2xpc3AvY3VzdG9tLmVsIGIvbGlzcC9jdXN0b20uZWwKaW5kZXggZjAxMjU3NDJkMS4uZGE0 MDdiZWU4MyAxMDA2NDQKLS0tIGEvbGlzcC9jdXN0b20uZWwKKysrIGIvbGlzcC9jdXN0b20uZWwK QEAgLTYzOSw3ICs2MzksNyBAQCBjdXN0b20tbG9hZC1zeW1ib2wKICAgICAgIChjb25kaXRpb24t Y2FzZSBuaWwKIAkgIChyZXF1aXJlICdjdXMtc3RhcnQpCiAJKGVycm9yIG5pbCkpCi0gICAgICAo ZG9saXN0IChsb2FkIChnZXQgc3ltYm9sICdjdXN0b20tbG9hZHMpKQorICAgICAgKGRvbGlzdCAo bG9hZCAocmV2ZXJzZSAoZ2V0IHN5bWJvbCAnY3VzdG9tLWxvYWRzKSkpCiAJKGNvbmQgKChzeW1i b2xwIGxvYWQpIChjb25kaXRpb24tY2FzZSBuaWwgKHJlcXVpcmUgbG9hZCkgKGVycm9yIG5pbCkp KQogCSAgICAgIDs7IFRoaXMgaXMgc3Vic3VtZWQgYnkgdGhlIHRlc3QgYmVsb3csIGJ1dCBpdCdz IG11Y2ggZmFzdGVyLgogCSAgICAgICgoYXNzb2MgbG9hZCBsb2FkLWhpc3RvcnkpKQotLSAKMi4y MS4wLjM5Mi5nZjhmNjc4NzE1OWUtZ29vZwoK --0000000000007cd87c058518af38-- From unknown Sun Jun 15 10:56:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35022: 26.1; Load order of custom-autoload, custom-load-symbol, custom-loads is backward? References: In-Reply-To: Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Mar 2019 21:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35022 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 35022@debbugs.gnu.org Received: via spool by 35022-submit@debbugs.gnu.org id=B35022.155372094123052 (code B ref 35022); Wed, 27 Mar 2019 21:10:01 +0000 Received: (at 35022) by debbugs.gnu.org; 27 Mar 2019 21:09:01 +0000 Received: from localhost ([127.0.0.1]:33592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9FnB-0005zg-6U for submit@debbugs.gnu.org; Wed, 27 Mar 2019 17:09:01 -0400 Received: from mail-io1-f42.google.com ([209.85.166.42]:40382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9Fn9-0005zS-Gb for 35022@debbugs.gnu.org; Wed, 27 Mar 2019 17:09:00 -0400 Received: by mail-io1-f42.google.com with SMTP id d201so15367312iof.7 for <35022@debbugs.gnu.org>; Wed, 27 Mar 2019 14:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=XjMu4qIV9DWCu1vCC0kfeiyW5ifHyfhjOEjPoYXzZIs=; b=H7zur7zezjZ1iL6uhGkBoajJ1ECwoiu18Tx2nEWNWBOidtvPZR6RyGdHLPufWy4Ic/ HdPE2jNMTbDX8cJMyfvlHKKfzKFiYzmCgzmsoSQnn9fDcRfaWZHQxomAlb1ea5kw8J7e ij14hQsBRecLgkKWqEGH4v7Z0LFUzk6CKZQUaMP5BuR3iNkYdTfBT4KZMMmGOuqqkfgd Ob87broT+O536eT11I4d3MFG4ZtFICDym1a9c9kVxcKhn11aJH2DbcP+DBQlWl/Q5rV3 y77WaPGW0yS9VFqRW6HBYHegS4RrAo8fT4rJiCCpqnDXp6VhHnxUYadpZbQkS+YxgFH+ E0Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=XjMu4qIV9DWCu1vCC0kfeiyW5ifHyfhjOEjPoYXzZIs=; b=uERVuf4/cEZPbHbZcBk9JThU1sDYlP9yWEJ9Hwr7BiJdhu27YXeW83v3LtPOdx84GL wRxPXRV3g+Kjn0TMHJvjJ21iCODj0yISYZ1D43K2Cy2HX+/FxMmpJ4ayQVoqj8o2+Meb owgbCXvNO49JgZ6xJOvqen0rq0aBQ42HC9KIVDiLSoRXgI/KHSNVVBzaplX1S/ueS8/T FUqBItRQARdDHFojGkSdjOKGgWZKk+7oL+9eYkqNKk+R2/QboL/BVV4bjwjKlJiQB7kS 03jbO9PDTSVt1uzQEnZWzVVYi/RfH4eLsX8e/dGfIfXSbkRJ4hPJXwxbxcG0gwBBgCiK SBbw== X-Gm-Message-State: APjAAAWIszVZIiIq+Va07ZhTkZ3PKPF1wzIimc0z8EHsF3lC09TRUem2 FLJ/LkVZowlDfJzOPyhzuckoO7IHa6MmuiFs0p/DK35u3iU= X-Google-Smtp-Source: APXvYqx+7wDjKj145cQdBM6J4App8MknqtvEg+ZlanuljC84Gtq0B0PCipSpxwZssbqUQ9H84CETelw1nUhM/PcRoPU= X-Received: by 2002:a5d:8d93:: with SMTP id b19mr27857230ioj.54.1553720933411; Wed, 27 Mar 2019 14:08:53 -0700 (PDT) MIME-Version: 1.0 From: Allen Li Date: Wed, 27 Mar 2019 14:08:42 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Please ignore my patch. In my haste, I missed that custom-load-symbol already checks whether a dependency is already loaded, because that logic wasn't firing for my case (where the load path is an actual path rather than a package name). To clarify, the existing code works for this: ;; Called from site-start (custom-autoload 'foo-some-variable "foo" nil) ;; Called from init.el/package-initialize (custom-autoload 'foo-some-variable "foo" nil) But not for this: ;; Called from site-start (custom-autoload 'foo-some-variable "some/path/to/foo" nil) ;; Called from init.el/package-initialize (custom-autoload 'foo-some-variable "foo" nil) I'm not sure yet what the proper approach for my problem is. From unknown Sun Jun 15 10:56:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35022: 26.1; Load order of custom-autoload, custom-load-symbol, custom-loads is backward? Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Apr 2019 01:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35022 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: 35022@debbugs.gnu.org Received: via spool by 35022-submit@debbugs.gnu.org id=B35022.155494766914680 (code B ref 35022); Thu, 11 Apr 2019 01:55:01 +0000 Received: (at 35022) by debbugs.gnu.org; 11 Apr 2019 01:54:29 +0000 Received: from localhost ([127.0.0.1]:53726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEOv7-0003od-GG for submit@debbugs.gnu.org; Wed, 10 Apr 2019 21:54:29 -0400 Received: from mail-qk1-f177.google.com ([209.85.222.177]:34761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEOv5-0003oI-JW; Wed, 10 Apr 2019 21:54:28 -0400 Received: by mail-qk1-f177.google.com with SMTP id n68so2541033qka.1; Wed, 10 Apr 2019 18:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Ptw9LPvdNaTSTSXCH6+HDdgRr7pH2ZrAhd5zpIaFgxU=; b=Z5Am8VLo/JyIFGuF7vR7qTIk63nCtjqV+jB8N2VwEeVJ4GtY2IGEfcp4kmXWq1qmE3 zhPdaRN1J9iXds9IIEUaWY287sc5BNIU3aEQyxSqYpPmQpe4y0d55QBMpX8yd5YbeKUq pnuZl/ADHV69/+NmQ0J5JC2pW6qP2JdQQpSFSdCcX2ONzSNzQuXVHVNXCR4fhTuep579 re5oQWPJc4ahsHgbyn2i1WeBKH2gZ2Cg8ZujW9uADhugdI1MxeFXhomoHhKHtaDrQk8t vG3oHsU4NfebzqF9pXAYvP2V55x8tkBdLzGpxfCNzr9PfmuldhG/+dmhhMKfG2sCgSqc YMzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Ptw9LPvdNaTSTSXCH6+HDdgRr7pH2ZrAhd5zpIaFgxU=; b=nLHYQYTVhyaSXIp4ZPcKcyLl71e0cKdpdCTsywVn1O/q51Je+Z7Rk0Nbf2jGmPxeXt T0uNHyT1AMp+FizC+xPOKUUU3V/wMo6MbpgNpqsfl57G7ZizFJ3w0kggzCGuLtqnf0fe lyNqrRXVHJYQLCa12GPRq2wBE30A3dz4nOWJ8uflsbjU4LEdAIL9VsEUztiK1XUOz9rN LA9oy3Qa7GXZ8PlXhAbNbGGFEZheAXNaq+2fh96FsiFmJEKrJldbiFY7UWCrZCzDG2ms LPUcuQBW2wVLHu7bh0nqFhnCVAiOgNOsY5pnI8ipwS2+rNb1PM4yF+yE1E2HsVxHNiVw eqgA== X-Gm-Message-State: APjAAAWZ/nrcx8Ml0S6N8m1p6B1U5UDW7FSxqY7tBFdyKmk0GVGTXU5G c+woMoxoRJGo1jLMlIw9SvqXjzqc X-Google-Smtp-Source: APXvYqyfF84dhtSnBsGZ914QvitE8o6GKNKBIU9YAY22FzJwdW0yeePKo7aLqPal8XBBt9HnGowi8A== X-Received: by 2002:a37:ef13:: with SMTP id j19mr37077418qkk.4.1554947661812; Wed, 10 Apr 2019 18:54:21 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d41sm26908486qtd.90.2019.04.10.18.54.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Apr 2019 18:54:20 -0700 (PDT) From: Noam Postavsky References: Date: Wed, 10 Apr 2019 21:54:19 -0400 In-Reply-To: (Allen Li's message of "Wed, 27 Mar 2019 14:08:42 -0700") Message-ID: <87o95d9uic.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) retitle 35022 custom-add-load, custom-load-symbol don't support filenames with directory components severity 35022 wishlist quit Allen Li writes: > But not for this: > > ;; Called from site-start > (custom-autoload 'foo-some-variable "some/path/to/foo" nil) > ;; Called from init.el/package-initialize > (custom-autoload 'foo-some-variable "foo" nil) > > I'm not sure yet what the proper approach for my problem is. Would it be too impertinent to suggest the proper aproach is this: ;; Called from site-start (add-to-list 'load-path (expand-file-name "some/path/to")) (custom-autoload 'foo-some-variable "foo" nil) ;; Called from init.el/package-initialize (custom-autoload 'foo-some-variable "foo" nil) Otherwise, I guess extending custom-add-load and custom-load-symbol to handle entries of the form (LIBRARY . RELATIVE-NAME) could make sense. From unknown Sun Jun 15 10:56:53 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Allen Li Subject: bug#35022: closed (Re: bug#35022: 26.1; Load order of custom-autoload, custom-load-symbol, custom-loads is backward?) Message-ID: References: X-Gnu-PR-Message: they-closed 35022 X-Gnu-PR-Package: emacs Reply-To: 35022@debbugs.gnu.org Date: Sat, 13 Apr 2019 21:58:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1555192681-13426-1" This is a multi-part message in MIME format... ------------=_1555192681-13426-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #35022: custom-add-load, custom-load-symbol don't support filenames with di= rectory components which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 35022@debbugs.gnu.org. --=20 35022: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35022 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1555192681-13426-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 35022-done) by debbugs.gnu.org; 13 Apr 2019 21:57:22 +0000 Received: from localhost ([127.0.0.1]:59325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFQeI-0003Tg-0N for submit@debbugs.gnu.org; Sat, 13 Apr 2019 17:57:22 -0400 Received: from mail-io1-f42.google.com ([209.85.166.42]:41375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFQeF-0003TS-8L for 35022-done@debbugs.gnu.org; Sat, 13 Apr 2019 17:57:20 -0400 Received: by mail-io1-f42.google.com with SMTP id v10so11562308iom.8 for <35022-done@debbugs.gnu.org>; Sat, 13 Apr 2019 14:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NL5L/yrk1lbohtVJQbLNNKpXm9RduOfYT5xtMMWIVzE=; b=Nhp7HHCTnwkBnEG1dw9PTWhdn/jDzqxpHN6KXf7fd+iTwngEmA0Xt7QjYblwgWzqdj 5HcK1jIiciudX848riMThoPc+7GP+9gsBJcKg3CZe4U4C8Mykw3NQeUAgoJ5WYKdS+yD L51Pg+xs24TREjspbGCFbGNB1ErL8x/KfDRo75EsYHcezWLkqyznjmdQyzyCCEPYahhL o4ouKLUpQNqncaitS/gXVN7krVKMPz6wGcvpNA2ExslkxuJihDIWl6hMt+P5di4G51Vg mo9R19JKw1M8l1KjoQWyP3U7/8D11puh2ed+QQ66iQ0rhgsVe5Sayc6L8W25x/Ymhnr7 7Gmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NL5L/yrk1lbohtVJQbLNNKpXm9RduOfYT5xtMMWIVzE=; b=QbcBPZac3bAI3F+7NErYusKpIXNq+eOCDOzTWfHcaCLyloOxWhyQ9Q5bLFtXJ9oNBS iuBaIpueVP4tq/g8UcuY0R6f+emMy0hz4/o/DA1OyuKAaHjmrVNcXiQDbTCQWAQpUbLN QHRu/0q8GCftn3kKtu64oJEka/qkE2sh1E0FdwPgHpzIBzgNiTyVXeAWKV62ZrrF7dP2 oOQ4+givnppjPDmAbmkbIbBu9A4flqU5kIoz3nE3U4MRCBRymbNRUrUnica4sqSG6qcI 4AZT4sZI03Rbz/G4fKWnrTzR631vauDFY2qMw5vzNTL5GvkACJ17kNP+FXs43eNx041J urqQ== X-Gm-Message-State: APjAAAVJFoHE4NMhPNrjV3ziMVH3MGq96RX3QpvHsQ1++/mWDnOS5Znq rvjl/ineVwUwYOAL9O+H06hAsQnxJGJQjIACYLwvAQ== X-Google-Smtp-Source: APXvYqyhYXiwByz03WjtFhsojmwqO5JuxVVbvzOK172UQChTsRmhYU6QNss/DueZyMqIshYEHQZNKAHAVizx3HeAZ9s= X-Received: by 2002:a5e:df06:: with SMTP id f6mr2285378ioq.199.1555192633481; Sat, 13 Apr 2019 14:57:13 -0700 (PDT) MIME-Version: 1.0 References: <87o95d9uic.fsf@gmail.com> In-Reply-To: <87o95d9uic.fsf@gmail.com> From: Allen Li Date: Sat, 13 Apr 2019 21:57:02 +0000 Message-ID: Subject: Re: bug#35022: 26.1; Load order of custom-autoload, custom-load-symbol, custom-loads is backward? To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35022-done Cc: 35022-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Apr 11, 2019 at 1:54 AM Noam Postavsky wrote: > > Allen Li writes: > > > But not for this: > > > > ;; Called from site-start > > (custom-autoload 'foo-some-variable "some/path/to/foo" nil) > > ;; Called from init.el/package-initialize > > (custom-autoload 'foo-some-variable "foo" nil) > > > > I'm not sure yet what the proper approach for my problem is. > > Would it be too impertinent to suggest the proper aproach is this: > > ;; Called from site-start > (add-to-list 'load-path (expand-file-name "some/path/to")) > (custom-autoload 'foo-some-variable "foo" nil) > ;; Called from init.el/package-initialize > (custom-autoload 'foo-some-variable "foo" nil) The site-start is shipped by the distro which I don't have control over. > > Otherwise, I guess extending custom-add-load and custom-load-symbol to > handle entries of the form (LIBRARY . RELATIVE-NAME) could make sense. After some deliberation, I think custom-add-load's current behavior is correct, so I'll take my issue downstream. Thanks ------------=_1555192681-13426-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Mar 2019 19:46:05 +0000 Received: from localhost ([127.0.0.1]:33561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9EUv-000440-BM for submit@debbugs.gnu.org; Wed, 27 Mar 2019 15:46:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9EUt-00043G-S8 for submit@debbugs.gnu.org; Wed, 27 Mar 2019 15:46:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:33272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9EUo-0005DU-IM for submit@debbugs.gnu.org; Wed, 27 Mar 2019 15:45:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9EUn-0005HM-6n for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 15:45:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9EUl-0005Ah-Uh for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 15:45:57 -0400 Received: from mail-it1-x12c.google.com ([2607:f8b0:4864:20::12c]:50503) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h9EUl-00059L-FB for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 15:45:55 -0400 Received: by mail-it1-x12c.google.com with SMTP id m137so2137081ita.0 for ; Wed, 27 Mar 2019 12:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=xwGLgS0g7C7Z+Yvxxg0cIhIvY8+qV8Gd18n3nSP3kkM=; b=CG6wdyqqnxEco50rIMAH9/42nJyiBMoYMW7Xlh03tgPyGOMGfnnC+zR5falXCsV27L fdL/KnBuU6KnLdvnu400wViTodMBruCtZs6VZx/ZIO6v6+IB403WXdr1aE1T8kZAgqHA gZMF3CxMK4TzPtKHKlRjgvrVVwKLYiPr3RFjrcF9y5nd1Ny0OreJraoqVB8PY0dnMHxM 5I61+iZjoZeR2BKDtobEJEF7kkYooh5/M8vFFa8sGEqyeSa1Fo2UPvnVZQhcdcFM1gCl bdLuhUO5BGhJgLEeGKCjGnwmPVKGa00dYtQmBBHJsvVH4tL9p6GGcWJrnFBe431lyHUm GSlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=xwGLgS0g7C7Z+Yvxxg0cIhIvY8+qV8Gd18n3nSP3kkM=; b=ABQv30dXnKCljbFn4Lss9SCypMd2j8muVpzLklmVAXtVuskDYCMHumbHDD0GnZ1W6N bz5rnIGk6ivVHcLUnrqI6fK8k2A/9a8m/ygatbkrFgowvk50xZd+t0dAytgYUb2X+Q49 6Q33+YgV128CfIB5O5KE2buPBi0N52K8K+1loTbLJ1OMrzproaoucqJZLnWGPhYd4zij 26bwY7Dt/N0TxqCPVKLX3jt+nRS2qIWJE+DUyM+f2rEfl+DXCeVIJZEQY8llA96w82wO R9lFl+j9E4rxVpEuC7Z6C6QD+w7srhiWqSMgrFaWGg6rkxri2aOAKenjbriqOAfkssJV JFzQ== X-Gm-Message-State: APjAAAU0caKn+GB/qLOOAQhIpXM/QmPPO3uTWxhAI6GJSasmemBL2pzV PBHfORBKuzp4ppCqYbG6evWKfeIGKV+9sijF5tp3YsW4QEU= X-Google-Smtp-Source: APXvYqyFR7bF6qyZPQKdtpLtO73Ji0ygmKo0i6EVmtHL5l/ubMnh40p90I8NxGIMQJDo5eSXbqzMpayviuktROLFLXM= X-Received: by 2002:a24:6b84:: with SMTP id v126mr5009447itc.136.1553715953435; Wed, 27 Mar 2019 12:45:53 -0700 (PDT) MIME-Version: 1.0 From: Allen Li Date: Wed, 27 Mar 2019 12:45:42 -0700 Message-ID: Subject: 26.1; Load order of custom-autoload, custom-load-symbol, custom-loads is backward? To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000007cd87c058518af38" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::12c X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --0000000000007cd87c058518af38 Content-Type: text/plain; charset="UTF-8" I just spent some time tracking down an unexpected behavior in custom autoloads. The custom-autoload function is used in autoloads/loaddef files to set up custom variables. custom-autoload adds a load path to the custom-loads property of a variable. This property is then used in custom-load-symbol to load each of the load paths. The problem is that custom-autoload adds load paths to the front of custom-loads, and custom-load-symbol loads the paths in forward order. This is unexpected because if the site distributes a package foo and the user installs their own version of foo, the site custom-autoload will be called first: ;; Called from site-start (custom-autoload 'foo-some-variable "path/to/site/foo" nil) ;; Called from init.el/package-initialize (custom-autoload 'foo-some-variable "path/to/user/foo" nil) In this case the custom-loads property will be ("path/to/user/foo" "path/to/site/foo") The user version will be loaded first, and the site version will be loaded later, overriding the user version. This behavior is unexpected; the user would expect that their version of foo overrides the site version of foo. Furthermore, this behavior is somewhat non-deterministic; site overrides foo *only if* foo is loaded via setting foo-some-variable with customize. If foo is loaded normally (e.g. with require), then the user version of foo will be loaded in preference to the site verison of foo. I have attached a patch fixing this. Note that this is technically a breaking change; however I really doubt any one is intentionally relying on this behavior. I consider this a bugfix and I think there are probably users who don't realize that they are suffering from this bug because it's so subtle. In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.24), modified by Debian Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Debian GNU/Linux rodete (upgraded from: Ubuntu 14.04 LTS) --0000000000007cd87c058518af38 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Load-custom-variable-dependencies-in-FIFO-order.patch" Content-Disposition: attachment; filename="0001-Load-custom-variable-dependencies-in-FIFO-order.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jtrmcp880 RnJvbSA3MTk1NzNjNDNlY2I2ZTM3ZTJmN2M4MTNkZmNhYjA5Yzg3MDdkNTlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8YXlhdGFuZUBnb29nbGUuY29tPgpEYXRlOiBX ZWQsIDI3IE1hciAyMDE5IDEyOjM5OjI4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gTG9hZCBjdXN0 b20gdmFyaWFibGUgZGVwZW5kZW5jaWVzIGluIEZJRk8gb3JkZXIKClRoZSBjdXN0b20tYXV0b2xv YWQgZnVuY3Rpb24gaXMgdXNlZCBpbiBhdXRvbG9hZHMvbG9hZGRlZiBmaWxlcyB0byBzZXQKdXAg Y3VzdG9tIHZhcmlhYmxlcy4gIGN1c3RvbS1hdXRvbG9hZCBhZGRzIGEgbG9hZCBwYXRoIHRvIHRo ZQpjdXN0b20tbG9hZHMgcHJvcGVydHkgb2YgYSB2YXJpYWJsZS4gIFRoaXMgcHJvcGVydHkgaXMg dGhlbiB1c2VkIGluCmN1c3RvbS1sb2FkLXN5bWJvbCB0byBsb2FkIGVhY2ggb2YgdGhlIGxvYWQg cGF0aHMuCgpUaGUgcHJvYmxlbSBpcyB0aGF0IGN1c3RvbS1hdXRvbG9hZCBhZGRzIGxvYWQgcGF0 aHMgdG8gdGhlIGZyb250IG9mCmN1c3RvbS1sb2FkcywgYW5kIGN1c3RvbS1sb2FkLXN5bWJvbCBs b2FkcyB0aGUgcGF0aHMgaW4gZm9yd2FyZCBvcmRlci4KClRoaXMgaXMgdW5leHBlY3RlZCBiZWNh dXNlIGlmIHRoZSBzaXRlIGRpc3RyaWJ1dGVzIGEgcGFja2FnZSBmb28gYW5kIHRoZQp1c2VyIGlu c3RhbGxzIHRoZWlyIG93biB2ZXJzaW9uIG9mIGZvbywgdGhlIHNpdGUgY3VzdG9tLWF1dG9sb2Fk IHdpbGwgYmUKY2FsbGVkIGZpcnN0OgoKOzsgQ2FsbGVkIGZyb20gc2l0ZS1zdGFydAooY3VzdG9t LWF1dG9sb2FkICdmb28tc29tZS12YXJpYWJsZSAicGF0aC90by9zaXRlL2ZvbyIgbmlsKQo7OyBD YWxsZWQgZnJvbSBpbml0LmVsL3BhY2thZ2UtaW5pdGlhbGl6ZQooY3VzdG9tLWF1dG9sb2FkICdm b28tc29tZS12YXJpYWJsZSAicGF0aC90by91c2VyL2ZvbyIgbmlsKQoKSW4gdGhpcyBjYXNlIHRo ZSBjdXN0b20tbG9hZHMgcHJvcGVydHkgd2lsbCBiZQoKKCJwYXRoL3RvL3VzZXIvZm9vIiAicGF0 aC90by9zaXRlL2ZvbyIpCgpUaGUgdXNlciB2ZXJzaW9uIHdpbGwgYmUgbG9hZGVkIGZpcnN0LCBh bmQgdGhlIHNpdGUgdmVyc2lvbiB3aWxsIGJlCmxvYWRlZCBsYXRlciwgb3ZlcnJpZGluZyB0aGUg dXNlciB2ZXJzaW9uLgoKVGhpcyBiZWhhdmlvciBpcyB1bmV4cGVjdGVkOyB0aGUgdXNlciB3b3Vs ZCBleHBlY3QgdGhhdCB0aGVpciB2ZXJzaW9uIG9mCmZvbyBvdmVycmlkZXMgdGhlIHNpdGUgdmVy c2lvbiBvZiBmb28uICBGdXJ0aGVybW9yZSwgdGhpcyBiZWhhdmlvciBpcwpzb21ld2hhdCBub24t ZGV0ZXJtaW5pc3RpYzsgc2l0ZSBvdmVycmlkZXMgZm9vICpvbmx5IGlmKiBmb28gaXMgbG9hZGVk CnZpYSBzZXR0aW5nIGZvby1zb21lLXZhcmlhYmxlIHdpdGggY3VzdG9taXplLiAgSWYgZm9vIGlz IGxvYWRlZCBub3JtYWxseQooZS5nLiB3aXRoIHJlcXVpcmUpLCB0aGVuIHRoZSB1c2VyIHZlcnNp b24gb2YgZm9vIHdpbGwgYmUgbG9hZGVkIGluCnByZWZlcmVuY2UgdG8gdGhlIHNpdGUgdmVyaXNv biBvZiBmb28uCgoqIGxpc3AvY3VzdG9tLmVsIChjdXN0b20tbG9hZC1zeW1ib2wpOiBMb2FkIHZh cmlhYmxlIGRlcHMgaW4gcmV2ZXJzZSBvcmRlci4KLS0tCiBsaXNwL2N1c3RvbS5lbCB8IDIgKy0K IDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdp dCBhL2xpc3AvY3VzdG9tLmVsIGIvbGlzcC9jdXN0b20uZWwKaW5kZXggZjAxMjU3NDJkMS4uZGE0 MDdiZWU4MyAxMDA2NDQKLS0tIGEvbGlzcC9jdXN0b20uZWwKKysrIGIvbGlzcC9jdXN0b20uZWwK QEAgLTYzOSw3ICs2MzksNyBAQCBjdXN0b20tbG9hZC1zeW1ib2wKICAgICAgIChjb25kaXRpb24t Y2FzZSBuaWwKIAkgIChyZXF1aXJlICdjdXMtc3RhcnQpCiAJKGVycm9yIG5pbCkpCi0gICAgICAo ZG9saXN0IChsb2FkIChnZXQgc3ltYm9sICdjdXN0b20tbG9hZHMpKQorICAgICAgKGRvbGlzdCAo bG9hZCAocmV2ZXJzZSAoZ2V0IHN5bWJvbCAnY3VzdG9tLWxvYWRzKSkpCiAJKGNvbmQgKChzeW1i b2xwIGxvYWQpIChjb25kaXRpb24tY2FzZSBuaWwgKHJlcXVpcmUgbG9hZCkgKGVycm9yIG5pbCkp KQogCSAgICAgIDs7IFRoaXMgaXMgc3Vic3VtZWQgYnkgdGhlIHRlc3QgYmVsb3csIGJ1dCBpdCdz IG11Y2ggZmFzdGVyLgogCSAgICAgICgoYXNzb2MgbG9hZCBsb2FkLWhpc3RvcnkpKQotLSAKMi4y MS4wLjM5Mi5nZjhmNjc4NzE1OWUtZ29vZwoK --0000000000007cd87c058518af38-- ------------=_1555192681-13426-1--