GNU bug report logs - #35021
M-^ (delete-indentation) doesn't work without a mark present

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#35036: closed (27.0.50; delete-indentation removes all blank
 lines)
Date: Sun, 31 Mar 2019 16:43:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 31 Mar 2019 17:42:43 +0100
with message-id <87mulb8070.fsf <at> tcd.ie>
and subject line Re: bug#35021: M-^ (delete-indentation) doesn't work without a mark present
has caused the debbugs.gnu.org bug report #35021,
regarding 27.0.50; delete-indentation removes all blank lines
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
35021: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35021
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; delete-indentation removes all blank lines
Date: Thu, 28 Mar 2019 16:19:18 -0500

After 8fa94a1ecc18a41ca2738f438b3fbc817c9fdc82, delete-indentation
removes all blank lines so that a buffer:

one


two|


with | as point, M-x delete-indentation results in:

one two

whereas before it would result in:

one

two

This seems contrary to the documentation, which states, "Join this line
to previous and fix up whitespace at join." and also the NEWS entry,
"When there's no active region, the command works on the current and the
previous or the next line, as before."

I'm happy to submit a patch fixing this, but should it change the
documentation to match the new behavior, or fix the code so that the
behavior is unchanged?

Also, is the patch in Bug#35021 going to get applied soonish? If so I'll
hold off in order not to create conflicts...

Thanks,
Alex

[Message part 3 (message/rfc822, inline)]

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: stephen_leake <at> stephe-leake.org, alex.branham <at> gmail.com, stlman <at> poczta.fm,
 35021-done <at> debbugs.gnu.org, j <at> lollyshouse.ca
Subject: Re: bug#35021: M-^ (delete-indentation) doesn't work without a mark
 present
Date: Sun, 31 Mar 2019 17:42:43 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
>> Cc: Alex Branham <alex.branham <at> gmail.com>,  <j <at> lollyshouse.ca>,  <35021 <at> debbugs.gnu.org>,  <stephen_leake <at> stephe-leake.org>,  <stlman <at> poczta.fm>
>> Date: Sun, 31 Mar 2019 03:41:47 +0100
>> 
>> > Looks OK to me, please push.
>> 
>> Thanks, but my last patch only fixed the bug with the interactive spec,
>> and I have since discovered and fixed a few more edge-cases (including
>> that reported by Alex in bug#35036).
>> 
>> I attach the updated patch.  Can I push this one instead?
>
> Yes, this LGTM as well.

Thanks, I pushed to master and am thus closing this report.

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.