From unknown Fri Sep 05 08:41:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35018 <35018@debbugs.gnu.org> To: bug#35018 <35018@debbugs.gnu.org> Subject: Status: 26.1; Use diff as en ert-explainer for string= Reply-To: bug#35018 <35018@debbugs.gnu.org> Date: Fri, 05 Sep 2025 15:41:23 +0000 retitle 35018 26.1; Use diff as en ert-explainer for string=3D reassign 35018 emacs submitter 35018 Pierre Neidhardt severity 35018 wishlist tag 35018 wontfix thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 06:19:21 2019 Received: (at submit) by debbugs.gnu.org; 27 Mar 2019 10:19:21 +0000 Received: from localhost ([127.0.0.1]:60876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h95eS-00054m-To for submit@debbugs.gnu.org; Wed, 27 Mar 2019 06:19:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h95eR-00054Y-CI for submit@debbugs.gnu.org; Wed, 27 Mar 2019 06:19:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:40828) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h95eM-00052p-8F for submit@debbugs.gnu.org; Wed, 27 Mar 2019 06:19:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h95eL-0004jW-4l for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 06:19:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h95eK-00052C-0E for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 06:19:13 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:57729) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h95eJ-00050H-K4 for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 06:19:11 -0400 X-Originating-IP: 92.169.116.19 Received: from bababa (lfbn-1-4117-19.w92-169.abo.wanadoo.fr [92.169.116.19]) (Authenticated sender: pierre@atlas.engineer) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id D3CD62000D for ; Wed, 27 Mar 2019 10:19:07 +0000 (UTC) From: Pierre Neidhardt To: bug-gnu-emacs@gnu.org Subject: 26.1; Use diff as en ert-explainer for string= Date: Wed, 27 Mar 2019 11:19:07 +0100 Message-ID: <87a7hgpqlg.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.70.183.200 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain I've just committed webfeeder.el to ELPA. In his review, Stefan Monnier suggested we merged the following code snippet upstream: --8<---------------cut here---------------start------------->8--- (defun webfeeder--string=-explainer (string-a string-b) "Return the diff output of STRING-A and STRING-B" (unless (string= string-a string-b) (let (file-a file-b) (unwind-protect (let (result) (setq file-a (make-temp-file "webfeeder") file-b (make-temp-file "webfeeder")) (with-temp-file file-a (insert string-a)) (with-temp-file file-b (insert string-b)) (setq result (with-temp-buffer ;; The following generates a *Diff* buffer which is ;; convenient for coloration. (diff file-a file-b nil 'no-async) (diff-no-select file-a file-b nil 'no-async (current-buffer)) (buffer-string))) result) (delete-file file-a) (delete-file file-b))))) ;; FIXME: Add this to ERT! (put 'string= 'ert-explainer #'webfeeder--string=-explainer) --8<---------------cut here---------------end--------------->8--- I've used this feature extensively in my ERT tests: it displays a "diff" of string A and string B, which is a pretty nice default when the strings are longer than a single line. Food for thoughts :) --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlybThsACgkQm9z0l6S7 zH/r9Qf+K2yYToMAJppMy0GAEXcabQKsHTn7rzGSgJO4dadDP2gxQhdxaRDGFY08 djKuUR+NUzannI/3DUNx3QW7sK555VOn1f8b94jAmhogRVPabOqnx9cTMh+W24Rp tnXdeIlntRf536KBZ9U7a1rqPdKs80l8FR0k4A2y4xCHcQ5F5XM2b1uNA+kjhXgL BFMQqduqMTwswzAOjUpboQqK4I1p5B+Vs8ax4xHL3BLWW3esLLeTyJ5fXJiexZeB DlTLLaNwRFxQGjO0RmjNwVPBKevcSXalnv98nodbLIR6i0Cb8oF/SxZcJpn3kio1 +5kKgCRiOk8SjxHsgO73Q7VgtxSIBA== =gXXe -----END PGP SIGNATURE----- --==-=-=-- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 01 21:05:12 2019 Received: (at 35018) by debbugs.gnu.org; 2 Apr 2019 01:05:12 +0000 Received: from localhost ([127.0.0.1]:40153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB7rU-0007nS-Ic for submit@debbugs.gnu.org; Mon, 01 Apr 2019 21:05:12 -0400 Received: from mail-qk1-f178.google.com ([209.85.222.178]:44968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB7rS-0007n5-0D; Mon, 01 Apr 2019 21:05:10 -0400 Received: by mail-qk1-f178.google.com with SMTP id y5so6888083qkc.11; Mon, 01 Apr 2019 18:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9yTaVMbTfdkxPYTynoecC4Rz8cN+ZLX3itujc/XKHX4=; b=FQzFFl9BCuUmL7CxV+fSOLASKEX3RkTgECtHAtspQTiFwr1bwlipDFiG3NifjTPfGZ sXjSqR/5naFlApOB3LAk5yn8eSg1tcIDyWq5PAxV77cWyRBIN+SO7ukGRTxwpbU1x2Uq N28jEI1q8PffQUJmTmNX650LXyc518F+HkLlODUiiIGApdNhVFZURdfXo7H++ODsgTjw Nkd62JI6Fu+InHxgOkYdwrbv7DQH1INv+hIeuKc/fCSlLdgL3Q9Z8q+QCILVBXtGTWwL WwTZaiTeApZIA/fNBBdZvyZCllLEAbaP4/PqRpAAV5FMctCkREPdlnPoMz3PyYzbpCXt btwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9yTaVMbTfdkxPYTynoecC4Rz8cN+ZLX3itujc/XKHX4=; b=JyIbT2bkfDlhoNRZgDGPF2URR3pmdRVUC4a1tExqW14vum4JDLP2UougscGZ+hpRqJ YiPS28rFQQNdeQ/LOPzMQuwy4wEc/IGkN5nuARqSjGEUOrzkcTXSg1BLwagdGeD8m7IU C7G7GxeySF/RHW+785eZWZWp7FIg2HaevlKqn5Rj+i8GcQjmTqLQ0ZbMoWaVsP3cTyWF 1Yiha/BFT5ivvBpKvgCg/JRxcyJEEQnz/tX6KCCCZ41hRmvNktThryuUxm6PDJt4e1vB Rp+j3vo7UgXwYA+DZ0qTcm4NKX6zReh7tJpDomf2HLWhm1L8tH0dtBd9xAERt2lNPRah r2LQ== X-Gm-Message-State: APjAAAWN/hqSZjVVfcFQtfwz8xWFZIdoTP5E5WhFsdyKVJGbhU3bQ/ll fg8SxXcZaLwACWzrhorr4/wttBEJ X-Google-Smtp-Source: APXvYqzJKiiJmUukdGpshQ+/9HOA2JO86HuVOXvgPS8CQW1Xwh/6GAcog638ZWFZa5Nbw4L6oWINfg== X-Received: by 2002:ae9:e21a:: with SMTP id c26mr54370089qkc.293.1554167104204; Mon, 01 Apr 2019 18:05:04 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 46sm7804747qtz.87.2019.04.01.18.05.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Apr 2019 18:05:03 -0700 (PDT) From: Noam Postavsky To: Pierre Neidhardt Subject: Re: bug#35018: 26.1; Use diff as en ert-explainer for string= References: <87a7hgpqlg.fsf@ambrevar.xyz> Date: Mon, 01 Apr 2019 21:05:01 -0400 In-Reply-To: <87a7hgpqlg.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Wed, 27 Mar 2019 11:19:07 +0100") Message-ID: <87imvxgqte.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35018 Cc: 35018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 35018 wishlist quit Pierre Neidhardt writes: > I've just committed webfeeder.el to ELPA. In his review, Stefan Monnier > suggested we merged the following code snippet upstream: > > (defun webfeeder--string=-explainer (string-a string-b) > "Return the diff output of STRING-A and STRING-B" > (unless (string= string-a string-b) I guess a diff won't help so much for single line strings, so maybe the condition should check for that? e.g. (or (string= string-a string-b) (not (string-match-p "\n" string-a)) (not (string-match-p "\n" string-b)) > (let (file-a file-b) > (unwind-protect > (let (result) > (setq file-a (make-temp-file "webfeeder") > file-b (make-temp-file "webfeeder")) > (with-temp-file file-a > (insert string-a)) > (with-temp-file file-b > (insert string-b)) > (setq result > (with-temp-buffer > ;; The following generates a *Diff* buffer which is > ;; convenient for coloration. > (diff file-a file-b nil 'no-async) > (diff-no-select file-a file-b nil 'no-async (current-buffer)) Isn't the diff-no-select redudant, since diff already calls it? > (buffer-string))) > result) You don't need the 'result' variable here, just make the (with-temp-buffer...) the last expression in the let (which could then be converted to progn). > (delete-file file-a) > (delete-file file-b))))) You should check that each of file-a and file-b are non-nil before trying to delete (in case either make-temp-file signals an error). From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 04:00:08 2019 Received: (at 35018) by debbugs.gnu.org; 2 Apr 2019 08:00:08 +0000 Received: from localhost ([127.0.0.1]:40290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBEL2-0007I3-8d for submit@debbugs.gnu.org; Tue, 02 Apr 2019 04:00:08 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:35247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBEKz-0007Gy-DL for 35018@debbugs.gnu.org; Tue, 02 Apr 2019 04:00:06 -0400 X-Originating-IP: 92.169.116.19 Received: from bababa (lfbn-1-4117-19.w92-169.abo.wanadoo.fr [92.169.116.19]) (Authenticated sender: pierre@atlas.engineer) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 3667A20008; Tue, 2 Apr 2019 08:00:01 +0000 (UTC) From: Pierre Neidhardt To: Noam Postavsky Subject: Re: bug#35018: 26.1; Use diff as en ert-explainer for string= In-Reply-To: <87imvxgqte.fsf@gmail.com> References: <87a7hgpqlg.fsf@ambrevar.xyz> <87imvxgqte.fsf@gmail.com> Date: Tue, 02 Apr 2019 09:59:59 +0200 Message-ID: <874l7gon0g.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35018 Cc: 35018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thanks for the review! Noam Postavsky writes: >> (defun webfeeder--string=3D-explainer (string-a string-b) >> "Return the diff output of STRING-A and STRING-B" >> (unless (string=3D string-a string-b) > > I guess a diff won't help so much for single line strings, so maybe the > condition should check for that? e.g. > > (or (string=3D string-a string-b) > (not (string-match-p "\n" string-a)) > (not (string-match-p "\n" string-b)) Yes, this is very nice! >> (let (file-a file-b) >> (unwind-protect >> (let (result) >> (setq file-a (make-temp-file "webfeeder") >> file-b (make-temp-file "webfeeder")) >> (with-temp-file file-a >> (insert string-a)) >> (with-temp-file file-b >> (insert string-b)) >> (setq result >> (with-temp-buffer >> ;; The following generates a *Diff* buffer which is >> ;; convenient for coloration. >> (diff file-a file-b nil 'no-async) >> (diff-no-select file-a file-b nil 'no-async (current= -buffer)) > > Isn't the diff-no-select redudant, since diff already calls it? The first diff is a typo. It should be diff-no-select only. Cheers! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlyjFn8ACgkQm9z0l6S7 zH/JLQf/TDfUaevD/ZntASBUWEXv5Ce3mMy+e1echzW9cVIrAcHugWLagIHeIQ1v JaehU7B+d3y059Snv2m0ZTEVFB/5F6zPYu9vAnj9evEEEW4EOHZ5G7Yal+bpSIkk 2OYxEf6JURQyBBS9cbRrHepdMlTrhcRN1K/4VSsMBBHDtIPZHnwASM/LicyeKn0F 8ealm+DP2Z4ltRqJGkK6mGyN0bzr1VXs0cdskRNMizvI51q9FRMtZ8qfdT7VZqF6 NXXGZ6M+pHgvChB/0TdkkZkRQYwY7reb0XnkBZgcebj4EDcsbgbkAddFLSt3c+Q8 B1klCvE2bHDEi9h/9dPDA4bupF+OmA== =CphO -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 23 09:42:25 2021 Received: (at 35018) by debbugs.gnu.org; 23 Jun 2021 13:42:25 +0000 Received: from localhost ([127.0.0.1]:40637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lw396-000254-Ol for submit@debbugs.gnu.org; Wed, 23 Jun 2021 09:42:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lw394-00024m-Hz for 35018@debbugs.gnu.org; Wed, 23 Jun 2021 09:42:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Se7dLmip6XDwfSStS7jhMPLuvzFKVHjS18bzDXDldqg=; b=ha8p+iHPqaF093cGPWFQPtCNgY JgujFX/LS469PTozfDWtUFM1dP7Vp1XxII9+mhRrbbEqaMRk5nS+Yq2q7HjrWSkyjyZiYz93qLmtY Gy5feslKcG6wK+BQ9jsrvwlSsP4ZbAHFZHINYZ/uTo0XqHH21j7RvQx3zh9i51TBLkWY=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lw38v-0005EE-0E; Wed, 23 Jun 2021 15:42:15 +0200 From: Lars Ingebrigtsen To: Pierre Neidhardt Subject: Re: bug#35018: 26.1; Use diff as en ert-explainer for string= References: <87a7hgpqlg.fsf@ambrevar.xyz> X-Now-Playing: The Clash's _Sandinista!_: "Corner Soul" Date: Wed, 23 Jun 2021 15:42:11 +0200 In-Reply-To: <87a7hgpqlg.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Wed, 27 Mar 2019 11:19:07 +0100") Message-ID: <87wnqklmto.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Pierre Neidhardt writes: > I've just committed webfeeder.el to ELPA. In his review, Stefan Monnier > suggested we merged the following code snippet upstream: I've adapted this to ert to see how it would look, and... I'm not sure it's all that helpful as is. The following test: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 35018 Cc: 35018@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Pierre Neidhardt writes: > I've just committed webfeeder.el to ELPA. In his review, Stefan Monnier > suggested we merged the following code snippet upstream: I've adapted this to ert to see how it would look, and... I'm not sure it's all that helpful as is. The following test: (ert-deftest test-test-test () (should (string= "foo\nbar" "zot\nbar"))) then gives this output: (ert-test-failed ((should (string= "foo\12bar" "zot\12bar")) :form (string= "foo\12bar" "zot\12bar") :value nil :explanation "diff -u /tmp/webfeeder1kS4io /tmp/webfeederwYoKdx\12--- /tmp/webfeeder1kS4io\0112021-06-23 15:37:54.407053381 +0200\12+++ /tmp/webfeederwYoKdx\0112021-06-23 15:37:54.407053381 +0200\12@@ -1,2 +1,2 @@\12-foo\12+zot\12 bar\12\\ No newline at end of file\12\12Diff finished. Wed Jun 23 15:37:54 2021\12")) Which isn't all that nice. But I guess we could massage the output. Removing the header and trailer, we get: (ert-test-failed ((should (string= "foo\12bar" "zot\12bar")) :form (string= "foo\12bar" "zot\12bar") :value nil :explanation "@@ -1,2 +1,2 @@\12-foo\12+zot\12 bar\12\\ ")) But... that's still not exactly readable. So I don't know. Anybody got an opinion here, or an easy fix that'll make this readable in this context? diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el index 6793b374ee..004bc81b4a 100644 --- a/lisp/emacs-lisp/ert.el +++ b/lisp/emacs-lisp/ert.el @@ -63,6 +63,7 @@ (require 'ewoc) (require 'find-func) (require 'pp) +(require 'diff) ;;; UI customization options. @@ -535,6 +536,34 @@ ert--explain-equal (ert--explain-equal-rec a b))) (put 'equal 'ert-explainer 'ert--explain-equal) +(defun ert--explain-string (string-a string-b) + "Return the diff output of STRING-A and STRING-B" + (unless (or (string= string-a string-b) + ;; Only do diffs if there are newlines. + (not (string-match-p "\n" string-a)) + (not (string-match-p "\n" string-b))) + (let (file-a file-b) + (unwind-protect + (let (result) + (setq file-a (make-temp-file "ert") + file-b (make-temp-file "ert")) + (with-temp-file file-a + (insert string-a)) + (with-temp-file file-b + (insert string-b)) + (setq result + (with-temp-buffer + ;; The following generates a *Diff* buffer which is + ;; convenient for coloration. + (diff-no-select file-a file-b nil 'no-async) + (diff-no-select file-a file-b nil 'no-async + (current-buffer)) + (buffer-string))) + result) + (delete-file file-a) + (delete-file file-b))))) +(put 'string= 'ert-explainer #'ert--explain-string) + (defun ert--significant-plist-keys (plist) "Return the keys of PLIST that have non-null values, in order." (cl-assert (zerop (mod (length plist) 2)) t) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 23 09:42:40 2021 Received: (at control) by debbugs.gnu.org; 23 Jun 2021 13:42:40 +0000 Received: from localhost ([127.0.0.1]:40640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lw39M-00025a-5c for submit@debbugs.gnu.org; Wed, 23 Jun 2021 09:42:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lw39L-00025M-Eh for control@debbugs.gnu.org; Wed, 23 Jun 2021 09:42:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bM3KPXGqflOBeQadiqkNAhy4g0dGWHmqC2AW66kVuH4=; b=vHYrkKEv3npTIZa0jhKJIEtbYh GS0o3nM3d6ZGoRcsa0BP2YIxkdi/Am+5ROPZpjax9698LLrgabRhKQ2DHEyurzUmw7Ro0enuwSIpC yZwmIpuLODA+/Hx2BLHDc1MkkWc4bOCKRbMVAE9XH0rGrwOGNt9q9uBzUW5RFeBPsv+M=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lw39E-0005Ee-0d for control@debbugs.gnu.org; Wed, 23 Jun 2021 15:42:33 +0200 Date: Wed, 23 Jun 2021 15:42:31 +0200 Message-Id: <87v964lmt4.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #35018 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 35018 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 35018 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 24 03:06:51 2021 Received: (at 35018) by debbugs.gnu.org; 24 Jun 2021 07:06:51 +0000 Received: from localhost ([127.0.0.1]:42273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwJRr-0006Nh-Dz for submit@debbugs.gnu.org; Thu, 24 Jun 2021 03:06:51 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:40041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwJRp-0006NQ-B8 for 35018@debbugs.gnu.org; Thu, 24 Jun 2021 03:06:50 -0400 Received: (Authenticated sender: mail@ambrevar.xyz) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 46ADAFF804; Thu, 24 Jun 2021 07:06:41 +0000 (UTC) From: Pierre Neidhardt To: Lars Ingebrigtsen Subject: Re: bug#35018: 26.1; Use diff as en ert-explainer for string= In-Reply-To: <87wnqklmto.fsf@gnus.org> References: <87a7hgpqlg.fsf@ambrevar.xyz> <87wnqklmto.fsf@gnus.org> Date: Thu, 24 Jun 2021 09:06:24 +0200 Message-ID: <87a6nfwxlb.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Lars, thanks for giving this a shot! To clarify, the original intent was to display the output in a diff-mode buffer, which would make it readable I believe. Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.199 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.199 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ambrevar.xyz (xyz)] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 35018 Cc: 35018@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Lars, thanks for giving this a shot! To clarify, the original intent was to display the output in a diff-mode buffer, which would make it readable I believe. Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.199 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.199 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ambrevar.xyz (xyz)] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Lars, thanks for giving this a shot! To clarify, the original intent was to display the output in a diff-mode buffer, which would make it readable I believe. Then no need to parse the output of the diff command :) Cheers! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFGBAEBCAAwFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAmDULvASHG1haWxAYW1i cmV2YXIueHl6AAoJEJvc9Jeku8x/6DMH/R7mcJmtFFeXJCQVVoLhJuJ5uubaw2+b EBHRbMZSTubONF3zZDh1cVr8qfnSRQ0MAJzqcD2r1u7XmANv1tWOreb2JC9QkEN0 EC9PGm0cVaiYJ+Riq7heWaAPvE6kpOvRNqetQZxM3TPenlQU5Kjqg54wdpLvJxG2 tfZ4E7BMQthlac87bgIztpOcBv8xg0mtVuXa7zW6EL4YOkMUpnpUvnHlAs0DYdAq R7OaGDmqriJ7gr/hZIQd1XSUszNBMlPGppWlVp1ai5EqKs3snxSKwBBf5LMMKlzr LhxOxpqilbX0E69jwcZAp7zRPfCjp4AA05V7p4c7YXUdJk3j7TKAVJQ= =EXKy -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 24 10:52:48 2021 Received: (at 35018) by debbugs.gnu.org; 24 Jun 2021 14:52:48 +0000 Received: from localhost ([127.0.0.1]:43772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwQim-0003x9-Gx for submit@debbugs.gnu.org; Thu, 24 Jun 2021 10:52:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwQij-0003wq-T1 for 35018@debbugs.gnu.org; Thu, 24 Jun 2021 10:52:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bup7LIFmcFU5+0Om0zw3GckNSQcJn8/70Zk+ww78cYw=; b=FR67gccDhWztWNGkAfNCiqyRkQ Z4DoiKytWCXkK0HI8Ugv86AQNbiUhGrGFLmbkc18Savjv6pRGJCJoB7aKShCyEAEjKQb/kp+TNbG9 xH6wS5wY2DRyj5wvqu0AJl+jbNsAGjU+QagoRYZW03ehIWRDIcsRul2H9qNpTzlDdSsw=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwQia-0001L6-8n; Thu, 24 Jun 2021 16:52:38 +0200 From: Lars Ingebrigtsen To: Pierre Neidhardt Subject: Re: bug#35018: 26.1; Use diff as en ert-explainer for string= References: <87a7hgpqlg.fsf@ambrevar.xyz> <87wnqklmto.fsf@gnus.org> <87a6nfwxlb.fsf@ambrevar.xyz> X-Now-Playing: Paul Haig's _The Fruit of the Original Sin_: "Mad Horses" Date: Thu, 24 Jun 2021 16:52:35 +0200 In-Reply-To: <87a6nfwxlb.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Thu, 24 Jun 2021 09:06:24 +0200") Message-ID: <87k0mjjowc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Pierre Neidhardt writes: > To clarify, the original intent was to display the output in a diff-mode > buffer, which would make it readable I believe. Oh, I see... So it shouldn't be displayed in batch runs at all? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 35018 Cc: 35018@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Pierre Neidhardt writes: > To clarify, the original intent was to display the output in a diff-mode > buffer, which would make it readable I believe. Oh, I see... So it shouldn't be displayed in batch runs at all? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 24 11:59:46 2021 Received: (at 35018) by debbugs.gnu.org; 24 Jun 2021 15:59:46 +0000 Received: from localhost ([127.0.0.1]:43878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwRlZ-0007v8-Pu for submit@debbugs.gnu.org; Thu, 24 Jun 2021 11:59:45 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:59801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwRlV-0007uq-4r for 35018@debbugs.gnu.org; Thu, 24 Jun 2021 11:59:44 -0400 Received: (Authenticated sender: mail@ambrevar.xyz) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 046F720000B; Thu, 24 Jun 2021 15:59:33 +0000 (UTC) From: Pierre Neidhardt To: Lars Ingebrigtsen Subject: Re: bug#35018: 26.1; Use diff as en ert-explainer for string= In-Reply-To: <87k0mjjowc.fsf@gnus.org> References: <87a7hgpqlg.fsf@ambrevar.xyz> <87wnqklmto.fsf@gnus.org> <87a6nfwxlb.fsf@ambrevar.xyz> <87k0mjjowc.fsf@gnus.org> Date: Thu, 24 Jun 2021 17:59:32 +0200 Message-ID: <87pmwbtfrv.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Lars Ingebrigtsen writes: > Oh, I see... So it shouldn't be displayed in batch runs at all? The original implementation was not meant with batch mode in mind, but we could make it more readable as you suggested. Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [217.70.178.232 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.178.232 listed in list.dnswl.org] 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ambrevar.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 35018 Cc: 35018@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Lars Ingebrigtsen writes: > Oh, I see... So it shouldn't be displayed in batch runs at all? The original implementation was not meant with batch mode in mind, but we could make it more readable as you suggested. Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.178.232 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [217.70.178.232 listed in wl.mailspike.net] 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ambrevar.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Oh, I see... So it shouldn't be displayed in batch runs at all?=20=20 The original implementation was not meant with batch mode in mind, but we could make it more readable as you suggested. =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFGBAEBCAAwFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAmDUq+QSHG1haWxAYW1i cmV2YXIueHl6AAoJEJvc9Jeku8x/FysIAKbVbP7rNdmjjaaqMPJ1Q5MZtOkuiH0i 1e1nvohlO4khRCceg/4fuRKAWMbnRI/SP8eaCMF4zDmlKR9U1z65G++I+006Febe YprU53UCq1ji0Nn9bhejI+8dIdhfvC5JHjZX+z4AmCMRU25TnV6JhQ7dx91kynZH moZ+RBhtKiwN9XgviaAODV9cWP0zg9gh8eb1pqGWlX8q5OZC4peHW5tt9Z9grKF6 XRxEYFHQHxaWCTMYsXRB+fmSush+0UmElLrhailZCgeZUck7WQj7OS6ic5Ti8o0o wE2HCsSMuQ45MFOS2GDvlkAMbZQRQwLgsK6kr0jecTuv8oEIPd3cHSU= =umH1 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 22 19:17:02 2021 Received: (at control) by debbugs.gnu.org; 22 Jul 2021 23:17:02 +0000 Received: from localhost ([127.0.0.1]:41814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6hw6-00075I-Ed for submit@debbugs.gnu.org; Thu, 22 Jul 2021 19:17:02 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6hw2-00074k-1H for control@debbugs.gnu.org; Thu, 22 Jul 2021 19:17:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SpjEIRtDaXMCRbNzX/dzpY9JYDg4jIvHS3brIoltTps=; b=o3GcRnnmhPnbkisnWlTkQt6ot5 yCPVBLepBA9GUoWkrnSBwhIrkyjC6NE7GRpcGYZV+emCjemN1+ysKDDL4e8t909ISkR5d2YHd/NZS C943o/EzHQYQQZ7/MoBrmvz3pTX6Yr5ecTxudQtiXqmogQ4I9nvK8VcuwbAE0hVrLfMY=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6hvt-0008Pv-Nb for control@debbugs.gnu.org; Fri, 23 Jul 2021 01:16:51 +0200 Date: Fri, 23 Jul 2021 01:16:49 +0200 Message-Id: <87pmvaey72.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #35018 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 35018 - moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 35018 - moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 11:33:46 2021 Received: (at 35018) by debbugs.gnu.org; 12 Oct 2021 15:33:46 +0000 Received: from localhost ([127.0.0.1]:49222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maJmj-0001Ck-SQ for submit@debbugs.gnu.org; Tue, 12 Oct 2021 11:33:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maJmh-0001CS-PC for 35018@debbugs.gnu.org; Tue, 12 Oct 2021 11:33:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wAXcOAeo33HaRnJO6scOmxK0s9dWIC958am5wTiADt8=; b=X8QsAbOao2iAVm53dNrbSZ0CdE zZkJSGlGZiGKrtrYARsZpYNX/2gl6YcHwyJvhDqGRoYGFQHWDYg5mAdc3rl9cXGGh0zIszTpnXcXv rzZzZtSIPnJrJ2c3AI9vWPCmjqTaz+8scU5fdA6cn6NZNZZ3gSDIvvYyDeq+Oe90Fl+0=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maJmX-0006Kj-H5; Tue, 12 Oct 2021 17:33:36 +0200 From: Lars Ingebrigtsen To: Pierre Neidhardt Subject: Re: bug#35018: 26.1; Use diff as en ert-explainer for string= References: <87a7hgpqlg.fsf@ambrevar.xyz> <87wnqklmto.fsf@gnus.org> <87a6nfwxlb.fsf@ambrevar.xyz> <87k0mjjowc.fsf@gnus.org> <87pmwbtfrv.fsf@ambrevar.xyz> X-Now-Playing: Arthur Russell's _24 to 24 Music (Live at the Kitchen)_: "24 to 24 Music Live at the Kitchen" Date: Tue, 12 Oct 2021 17:33:32 +0200 In-Reply-To: <87pmwbtfrv.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Thu, 24 Jun 2021 17:59:32 +0200") Message-ID: <87bl3ub6lv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Pierre Neidhardt writes: > The original implementation was not meant with batch mode in mind, but > we could make it more readable as you suggested. It's still not clear to me how this is supposed to be used. Do you have a more complete implementation, or a description of how this is to be used in a workflow? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 35018 Cc: 35018@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Pierre Neidhardt writes: > The original implementation was not meant with batch mode in mind, but > we could make it more readable as you suggested. It's still not clear to me how this is supposed to be used. Do you have a more complete implementation, or a description of how this is to be used in a workflow? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 13:23:53 2021 Received: (at 35018) by debbugs.gnu.org; 12 Oct 2021 17:23:53 +0000 Received: from localhost ([127.0.0.1]:52173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maLVJ-0000DP-Iw for submit@debbugs.gnu.org; Tue, 12 Oct 2021 13:23:53 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:56443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maLVG-0000Ct-K9 for 35018@debbugs.gnu.org; Tue, 12 Oct 2021 13:23:51 -0400 Received: (Authenticated sender: mail@ambrevar.xyz) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 6C8D1240004; Tue, 12 Oct 2021 17:23:43 +0000 (UTC) From: Pierre Neidhardt To: Lars Ingebrigtsen Subject: Re: bug#35018: 26.1; Use diff as en ert-explainer for string= In-Reply-To: <87bl3ub6lv.fsf@gnus.org> References: <87a7hgpqlg.fsf@ambrevar.xyz> <87wnqklmto.fsf@gnus.org> <87a6nfwxlb.fsf@ambrevar.xyz> <87k0mjjowc.fsf@gnus.org> <87pmwbtfrv.fsf@ambrevar.xyz> <87bl3ub6lv.fsf@gnus.org> Date: Tue, 12 Oct 2021 19:23:42 +0200 Message-ID: <87y26yyx5t.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 35018 Cc: 35018@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --=-=-= Content-Type: text/plain Sorry, I don't have any other implementation and I haven't used it in years, so I'm afraid I can't be of much help here. Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFGBAEBCAAwFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAmFlxJ4SHG1haWxAYW1i cmV2YXIueHl6AAoJEJvc9Jeku8x/c4EIAIqvOe64eH2XgBxKBhb3XGmtdnbkkyhn EAsRFUE5VbpmPs2+hnHiXprJBguzchordhCiocIlCFhb7qMRS8ip3Rnq2OaIJH0A r0te+7UbR491FJJn9KF6MARUuejWGJ8DGBufpP3+fdl0AHStYLFXLlUs0ILYUV1X DATUOUE6HQbmk3j5sSErWg1OL160SBWjdoHlP2o1TYH48gzB9/kPc0c2ZMSPLH3N A1ztOz3Z0UuqRFioyhkEQ2KkvnR87vo7yWMnXyVE50XHDTbTDb0nOLPK86h98hJw wLodCbIhyU2McgzIJxlyAhWnpUjEp2jCpMkFmRDRHhf1oTRitgCpqkE= =7laq -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 07:21:58 2021 Received: (at 35018) by debbugs.gnu.org; 13 Oct 2021 11:21:58 +0000 Received: from localhost ([127.0.0.1]:58581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1macKc-0001hJ-3K for submit@debbugs.gnu.org; Wed, 13 Oct 2021 07:21:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1macKa-0001h1-CC for 35018@debbugs.gnu.org; Wed, 13 Oct 2021 07:21:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MCWTOZtuLBRJ2QgqpvIzs/sh3Oo+HjP8AZStmkoe8q8=; b=b2wK8nnu6UVCazuHU6Fp3Iyebs V6t+xvcnCOrrY4tWZ15H8GCRFX4MvnqlZQqaG16SJw5lVScLCcwnWP2MeqmjFRa9CNQrVxM3gKgrA Lr+lLlgpaQO2ySMkHtDx71sAWg2Baz+7v6tkMrZeBMKW7+E7YuRqpHRTVx/fmssK13hg=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1macKQ-0007bc-4y; Wed, 13 Oct 2021 13:21:48 +0200 From: Lars Ingebrigtsen To: Pierre Neidhardt Subject: Re: bug#35018: 26.1; Use diff as en ert-explainer for string= References: <87a7hgpqlg.fsf@ambrevar.xyz> <87wnqklmto.fsf@gnus.org> <87a6nfwxlb.fsf@ambrevar.xyz> <87k0mjjowc.fsf@gnus.org> <87pmwbtfrv.fsf@ambrevar.xyz> <87bl3ub6lv.fsf@gnus.org> <87y26yyx5t.fsf@ambrevar.xyz> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUJCAkqKiofHx8e HiBISEdAPz7///+cw1o9AAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UKDQsCB5KA+C0AAAGQSURBVDjL 5VNBchwhDBRSHjDA+g5DHiBoPyAb+wOpyv/fkgbW5XXKe3BVbpma2Rm6JTUttCL/z3U8Isr6xSM6 PabGF+TDj0/AzMf8n1mEtA/rXbnH+FvqtW65N7Mae6zTOp6j3zmsV3S2yhqxGN/x+Ep05H7Cq0v4 +U4sCfAmAbm84dfpLTZC1tKLtfC0t/OddTClucwNXE29uSE+PZV6AlRezNIPBys8abE20BQjdfGV Qrb0FN0KnVUchmxG0EoIlHDC2kTTITXBLy7P5cxgLGSYFjkPRwS+sb7NqNkwhXRHFrtk2z5sNqk3 ldFHzJGE79A5OOOkzuCIxAPhxdgzM8GpSBJSGVH6xavksRtssFFo99Qs4VV6hsP3QRnHIBzdprJr R18ixgDKaFGPg5/BkdZhoTKncW8YOTvT3TN0ZdxGs2gePrhGVL0bh2KagxMZ9VRanC7txsHmOwA3 67LfmQfi41fC/ifMIF/xaaqdMZW/Js50RnpYiN8RzKVPn2XbjZC7zZVJoPmHYuvLppGMP6M+Mp5c oDFnAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTEwLTEzVDExOjAyOjA3KzAwOjAwUXaQhQAAACV0 RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMC0xM1QxMTowMjowNyswMDowMCArKDkAAAAASUVORK5CYII= X-Now-Playing: Alasdair Roberts og =?utf-8?Q?V=C3=B6lvur's?= _The Old Fabled River_: "Song Composed in August" Date: Wed, 13 Oct 2021 13:21:45 +0200 In-Reply-To: <87y26yyx5t.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Tue, 12 Oct 2021 19:23:42 +0200") Message-ID: <87ee8p8912.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Pierre Neidhardt writes: > Sorry, I don't have any other implementation and I haven't used it in > years, so I'm afraid I can't be of much help here. OK -- it sounds like it's unlikely to be any further progress here in this bug report, then, and I'm closing this bug report. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 35018 Cc: 35018@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Pierre Neidhardt writes: > Sorry, I don't have any other implementation and I haven't used it in > years, so I'm afraid I can't be of much help here. OK -- it sounds like it's unlikely to be any further progress here in this bug report, then, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 07:22:05 2021 Received: (at control) by debbugs.gnu.org; 13 Oct 2021 11:22:05 +0000 Received: from localhost ([127.0.0.1]:58585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1macKj-0001iA-Fr for submit@debbugs.gnu.org; Wed, 13 Oct 2021 07:22:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1macKh-0001hK-9j for control@debbugs.gnu.org; Wed, 13 Oct 2021 07:22:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=X1PjkBYb2AFf8ijbNJLNCPAwggn8/WGMm8LS7yPmVqU=; b=jf6jq0zMxThrRaYHU1mgoPvfcP KDDbsD0EO99BnKbSgBFfBZYpfwWw+Jpd1Ay43nYT5yJVYh6RzII4XhhNJ0/9ycuWz4UY7E9VHn/FG jXZ5yJHGFT8bbk46uTW7G3WWBAao/t+/SBU8FjHnIX0CDGZaOZoiAjsLvXfkVGPCaraQ=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1macKZ-0007bl-IR for control@debbugs.gnu.org; Wed, 13 Oct 2021 13:21:57 +0200 Date: Wed, 13 Oct 2021 13:21:55 +0200 Message-Id: <87czo9890s.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #35018 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 35018 wontfix close 35018 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 35018 wontfix close 35018 quit From unknown Fri Sep 05 08:41:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 10 Nov 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator