From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 26 08:52:09 2019 Received: (at submit) by debbugs.gnu.org; 26 Mar 2019 12:52:09 +0000 Received: from localhost ([127.0.0.1]:59191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8lYn-0000H1-9k for submit@debbugs.gnu.org; Tue, 26 Mar 2019 08:52:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8lYj-0000GR-GN for submit@debbugs.gnu.org; Tue, 26 Mar 2019 08:52:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:43129) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8lYe-0000ib-5T for submit@debbugs.gnu.org; Tue, 26 Mar 2019 08:52:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8lYc-0002jR-P0 for bug-gzip@gnu.org; Tue, 26 Mar 2019 08:51:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8lVq-0008Qv-TL for bug-gzip@gnu.org; Tue, 26 Mar 2019 08:49:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28260) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8lVq-0008Ny-Ht for bug-gzip@gnu.org; Tue, 26 Mar 2019 08:49:06 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BA1693003D3E for ; Tue, 26 Mar 2019 12:41:08 +0000 (UTC) Received: from jamartisT480s (unknown [10.40.205.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1529583888 for ; Tue, 26 Mar 2019 12:41:07 +0000 (UTC) Date: Tue, 26 Mar 2019 13:41:06 +0100 From: Jakub Martisko To: bug-gzip@gnu.org Subject: [Patch][BUG] Wrong skip value in gzexe Message-ID: <20190326124106.wg6vwywttmurced2@jamartisT480s> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="577rlwhw53vwkjvj" Content-Disposition: inline User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 26 Mar 2019 12:41:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --577rlwhw53vwkjvj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, the skip value in gzexe seems to be wrong since the [1] commit. See the attached patch/test. The problem and its solution has been originaly reported here [2] (Mentioning just for the credit sake). Thanks, Jakub [1]: http://git.savannah.gnu.org/cgit/gzip.git/commit/?id=63aa2268a5abfed0116d04bbe3952e4a753af91d [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1690825 --577rlwhw53vwkjvj Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="gzexe.patch" >From 21cd963565a43dabd59516bd4cca5c76a614f255 Mon Sep 17 00:00:00 2001 From: Jakub Martisko Date: Tue, 26 Mar 2019 12:29:30 +0100 Subject: [PATCH] Fix: the value of the skip variable in the gzexe --- gzexe.in | 4 ++-- tests/Makefile.am | 1 + tests/gzexe | 20 ++++++++++++++++++++ 3 files changed, 23 insertions(+), 2 deletions(-) create mode 100755 tests/gzexe diff --git a/gzexe.in b/gzexe.in index 6c61183..cffa84e 100644 --- a/gzexe.in +++ b/gzexe.in @@ -145,7 +145,7 @@ for i do if test $decomp -eq 0; then (cat <<'EOF' && #!/bin/sh -skip=44 +skip=49 tab=' ' nl=' @@ -201,7 +201,7 @@ EOF else # decompression - skip=44 + skip=49 skip_line=`sed -e 1d -e 2q "$file"` case $skip_line in skip=[0-9] | skip=[0-9][0-9] | skip=[0-9][0-9][0-9]) diff --git a/tests/Makefile.am b/tests/Makefile.am index ebdce5b..4dfbccf 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -15,6 +15,7 @@ # along with this program. If not, see . TESTS = \ + gzexe \ gzip-env \ helin-segv \ help-version \ diff --git a/tests/gzexe b/tests/gzexe new file mode 100755 index 0000000..45f71c7 --- /dev/null +++ b/tests/gzexe @@ -0,0 +1,20 @@ +#!/bin/sh +#Try running simple shell script compressed by gzexe + +. "${srcdir=.}/init.sh"; path_prepend_ .. + +cat < foo || framework_failure_ +#!/bin/sh +echo "Hello World!" +EOF + +echo "Hello World!" > exp || framework_failure_ + +fail=0 +gzexe foo || fail=1 +/bin/sh foo > out 2> err || fail=1 + +compare exp out || fail=1 +test -s err && fail=1 + +Exit $fail -- 2.21.0 --577rlwhw53vwkjvj-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 26 22:47:04 2019 Received: (at 35002-done) by debbugs.gnu.org; 27 Mar 2019 02:47:04 +0000 Received: from localhost ([127.0.0.1]:60749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8yam-0000NX-A4 for submit@debbugs.gnu.org; Tue, 26 Mar 2019 22:47:04 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8yai-0000Mz-1e for 35002-done@debbugs.gnu.org; Tue, 26 Mar 2019 22:47:02 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D2FDD160A59; Tue, 26 Mar 2019 19:46:53 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0aaVKqpaoHbK; Tue, 26 Mar 2019 19:46:52 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B8007160D10; Tue, 26 Mar 2019 19:46:52 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gOGXQNVlEDHP; Tue, 26 Mar 2019 19:46:52 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 75591160A59; Tue, 26 Mar 2019 19:46:52 -0700 (PDT) Subject: Re: bug#35002: [Patch][BUG] Wrong skip value in gzexe To: Jakub Martisko , 35002-done@debbugs.gnu.org References: <20190326124106.wg6vwywttmurced2@jamartisT480s> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <9693821b-c31b-2193-a0f4-311bbb5e8d79@cs.ucla.edu> Date: Tue, 26 Mar 2019 19:46:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190326124106.wg6vwywttmurced2@jamartisT480s> Content-Type: multipart/mixed; boundary="------------AAB44EB0D648E5B19CBF695C" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35002-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------AAB44EB0D648E5B19CBF695C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 3/26/19 5:41 AM, Jakub Martisko wrote: > the skip value in gzexe seems to be wrong since the [1] commit. > > [1]: http://git.savannah.gnu.org/cgit/gzip.git/commit/?id=63aa2268a5abfed0116d04bbe3952e4a753af91d > Thanks, I installed the attached to fix it. Pretty fragile script, if you ask me, but now's not the time to redo the plumbing.... --------------AAB44EB0D648E5B19CBF695C Content-Type: text/x-patch; name="0001-gzexe-fix-count-of-lines-to-skip.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-gzexe-fix-count-of-lines-to-skip.patch" >From 21033c04ffda821e462fe773e86c16547cae0a31 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 26 Mar 2019 19:44:43 -0700 Subject: [PATCH] gzexe: fix count of lines to skip Problem reported by Jakub Martisko (Bug#35002). * gzexe.in (skip): Bump from 44 to 49. --- gzexe.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gzexe.in b/gzexe.in index 8fca8c8..832cd07 100644 --- a/gzexe.in +++ b/gzexe.in @@ -145,7 +145,7 @@ for i do if test $decomp -eq 0; then (cat <<'EOF' && #!/bin/sh -skip=44 +skip=49 tab=' ' nl=' -- 2.20.1 --------------AAB44EB0D648E5B19CBF695C-- From unknown Sat Jun 14 19:28:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 24 Apr 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator