From unknown Thu Jun 12 08:38:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34999 <34999@debbugs.gnu.org> To: bug#34999 <34999@debbugs.gnu.org> Subject: Status: Record special field abstraction leakage Reply-To: bug#34999 <34999@debbugs.gnu.org> Date: Thu, 12 Jun 2025 15:38:56 +0000 retitle 34999 Record special field abstraction leakage reassign 34999 guix submitter 34999 Ludovic Court=C3=A8s severity 34999 important thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 26 05:38:22 2019 Received: (at submit) by debbugs.gnu.org; 26 Mar 2019 09:38:22 +0000 Received: from localhost ([127.0.0.1]:59040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8iXG-00086v-Ej for submit@debbugs.gnu.org; Tue, 26 Mar 2019 05:38:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8iXF-00086h-Ch for submit@debbugs.gnu.org; Tue, 26 Mar 2019 05:38:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:54039) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8iXA-0006AC-7K for submit@debbugs.gnu.org; Tue, 26 Mar 2019 05:38:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8iX9-0008H9-08 for bug-Guix@gnu.org; Tue, 26 Mar 2019 05:38:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8iX8-00069c-TW for bug-Guix@gnu.org; Tue, 26 Mar 2019 05:38:14 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=45764 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h8iX8-0007Ll-BM for bug-Guix@gnu.org; Tue, 26 Mar 2019 05:38:14 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: bug-Guix@gnu.org Subject: Record special field abstraction leakage X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 Germinal an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 26 Mar 2019 10:38:11 +0100 Message-ID: <87zhpiht6k.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The changes I made in version-control.scm and gnucash.scm in commit e6301fb76d0a8d931ece2e18d197e3c2cc53fc6c revealed an abstraction leakage I wasn=E2=80=99t aware of: there=E2=80=99s a pattern where users =E2=80=9Cs= ee=E2=80=9D that thunked fields are thunked: (package ;; =E2=80=A6 (inputs =E2=80=A6) (arguments `(foo bar ,(inputs) =E2=80=A6))) ;<- here =E2=80=98inputs= =E2=80=99 is seen as a thunk Fortunately I could only find two occurrences of this and this use case is more elegantly replaced by: (package-inputs this-record) =E2=80=A6 which also has better semantics. It=E2=80=99s remains a bug, tho= ugh. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 07:26:11 2019 Received: (at control) by debbugs.gnu.org; 4 Apr 2019 11:26:11 +0000 Received: from localhost ([127.0.0.1]:43726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC0VX-00037r-9I for submit@debbugs.gnu.org; Thu, 04 Apr 2019 07:26:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC0VT-000370-GC for control@debbugs.gnu.org; Thu, 04 Apr 2019 07:26:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC0VO-0004d3-9I for control@debbugs.gnu.org; Thu, 04 Apr 2019 07:26:02 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=57504 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hC0VN-00005Y-Qm for control@debbugs.gnu.org; Thu, 04 Apr 2019 07:26:02 -0400 Date: Thu, 04 Apr 2019 13:26:00 +0200 Message-Id: <87v9zurozb.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #34999 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 34999 important From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 24 11:47:40 2021 Received: (at 34999) by debbugs.gnu.org; 24 Aug 2021 15:47:40 +0000 Received: from localhost ([127.0.0.1]:45043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIYeK-0006sp-8x for submit@debbugs.gnu.org; Tue, 24 Aug 2021 11:47:40 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:41734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIYeI-0006sf-7r for 34999@debbugs.gnu.org; Tue, 24 Aug 2021 11:47:39 -0400 Received: from nijino.local (62-47-226-13.adsl.highway.telekom.at [62.47.226.13]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GvD5H5K6Vz3wXG; Tue, 24 Aug 2021 17:47:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1629820051; bh=PCeCbsMt8jXHvxMLAcICxckc6dbqmUGBSIaUNhB6tTo=; h=Subject:From:To:Date:In-Reply-To:References; b=TMvXpCixw5pyuSDhfoYSFSjFrF/05rMI4MfRgS4Ngb0wEOXIJEBzep1lr8pI5Itig UWjcHbSFE5ZWbl1yP2nQX4u1bbGjDjY52pOL92dn1o14+45rgAN8EYOjlWYlxfgfh+ pQJnCuCPfvWP0lbIm+Hi5aanG+QcYn7ZSsdFCRZ0= Message-ID: Subject: Re: Record special field abstraction leakage From: Leo Prikler To: Ludovic =?ISO-8859-1?Q?Court=E8s?= , 34999@debbugs.gnu.org Date: Tue, 24 Aug 2021 17:47:30 +0200 In-Reply-To: <87zhpiht6k.fsf@gnu.org> References: <87zhpiht6k.fsf@gnu.org> Content-Type: multipart/mixed; boundary="=-5+XuvfSwQSjxnipieDpA" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34999 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-5+XuvfSwQSjxnipieDpA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi Ludo, I think I have found out why users see the thunked fields as below. Am Dienstag, den 26.03.2019, 10:38 +0100 schrieb Ludovic Courtès: > The changes I made in version-control.scm and gnucash.scm in commit > e6301fb76d0a8d931ece2e18d197e3c2cc53fc6c revealed an abstraction > leakage > I wasn’t aware of: there’s a pattern where users “see” that thunked > fields are thunked: > > (package > ;; … > (inputs …) > (arguments `(foo bar ,(inputs) …))) ;<- here ‘inputs’ is seen as > a thunk The issue is that for constructing the records, we let*-bind the field names to their values before calling the constructor. In these let*- bindings the fields are already wrapped, e.g. inputs will be bound to the value that the record field inputs will have, not to the raw value. I've attached a patch to fix this issue as well as a MWE to try it out. I'm not sure about the broader semantics of this patch, though. I fear that exposing raw values through let-binding probably eliminates the delayed/thunked nature of said fields in some ways. WDYT? --=-5+XuvfSwQSjxnipieDpA Content-Disposition: attachment; filename*0=0001-guix-records-let-bind-raw-values-wrap-them-in-constr.pat; filename*1=ch Content-Type: text/x-patch; name="0001-guix-records-let-bind-raw-values-wrap-them-in-constr.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAxZjM4ZmY0YzhiOTNjZGU1MzNjZjNkM2Y2NzM1OGFhZmU5Y2YzZGZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gUHJpa2xlciA8bGVvLnByaWtsZXJAc3R1ZGVudC50dWdy YXouYXQ+CkRhdGU6IFR1ZSwgMjQgQXVnIDIwMjEgMTc6MzI6MzMgKzAyMDAKU3ViamVjdDogW1BB VENIXSBndWl4OiByZWNvcmRzOiBsZXQqLWJpbmQgcmF3IHZhbHVlcywgd3JhcCB0aGVtIGluCiBj b25zdHJ1Y3Rvci4KClRoaXMgZml4ZXMgdGhlIGFic3RyYWN0aW9uIGxlYWthZ2UgbWVudGlvbmVk IGluIDxodHRwczovL2J1Z3MuZ251Lm9yZy8zNDk5OT4uCgoqIGd1aXgvcmVjb3Jkcy5zY20gKG1h a2Utc3ludGFjdGljLWNvbnN0cnVjdG9yKVtmaWVsZC1iaW5kaW5nc106IEJpbmQgdG8gcmF3CnZh bHVlLgpbZmllbGQtdmFsdWVdOiBBbHdheXMgd3JhcCB0aGUgdmFsdWUuCltyZWNvcmQtaW5oZXJp dGFuY2VdOiBXcmFwICJpbmhlcml0ZWQiIHZhbHVlcy4KLS0tCiBndWl4L3JlY29yZHMuc2NtIHwg MTcgKysrKysrKysrKy0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA3 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2d1aXgvcmVjb3Jkcy5zY20gYi9ndWl4L3JlY29y ZHMuc2NtCmluZGV4IGVkOTRjODNkYWMuLjA3NGYxNjUwYzggMTAwNjQ0Ci0tLSBhL2d1aXgvcmVj b3Jkcy5zY20KKysrIGIvZ3VpeC9yZWNvcmRzLnNjbQpAQCAtMTUzLDcgKzE1MywxMCBAQCBvZiBU WVBFIG1hdGNoZXMgdGhlIGV4cGFuc2lvbi10aW1lIEFCSS4iCiAKICAgICAgICAgICAgI2AobWFr ZS1zdHJ1Y3Qvbm8tdGFpbCB0eXBlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICMsQChtYXAg KGxhbWJkYSAoZmllbGQgaW5kZXgpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAob3IgKGZpZWxkLWluaGVyaXRlZC12YWx1ZSBmaWVsZCkKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChvciAoYW5kPT4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGZpZWxkLWluaGVyaXRlZC12YWx1ZSBmaWVsZCkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSAodmFsdWUpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdyYXAtZmllbGQtdmFsdWUgZmllbGQgdmFs dWUpKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaWYgKGlubmF0 ZS1maWVsZD8gZmllbGQpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICh3cmFwLWZpZWxkLXZhbHVlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBmaWVsZCAoZmllbGQtZGVmYXVsdC12YWx1ZSBmaWVsZCkpCkBAIC0yMTEsOCAr MjE0LDcgQEAgb2YgVFlQRSBtYXRjaGVzIHRoZSBleHBhbnNpb24tdGltZSBBQkkuIgogICAgICAg ICAgICAobWFwIChsYW1iZGEgKGZpZWxkK3ZhbHVlKQogICAgICAgICAgICAgICAgICAgKHN5bnRh eC1jYXNlIGZpZWxkK3ZhbHVlICgpCiAgICAgICAgICAgICAgICAgICAgICgoZmllbGQgdmFsdWUp Ci0gICAgICAgICAgICAgICAgICAgICAjYChmaWVsZAotICAgICAgICAgICAgICAgICAgICAgICAg Iywod3JhcC1maWVsZC12YWx1ZSAjJ2ZpZWxkICMndmFsdWUpKSkpKQorICAgICAgICAgICAgICAg ICAgICAgI2AoZmllbGQgdmFsdWUpKSkpCiAgICAgICAgICAgICAgICAgZmllbGQrdmFsdWUpKQog CiAgICAgICAgICAoc3ludGF4LWNhc2UgcyAoaW5oZXJpdCBleHBlY3RlZCAuLi4pCkBAIC0yMjQs MTAgKzIyNiwxMSBAQCBvZiBUWVBFIG1hdGNoZXMgdGhlIGV4cGFuc2lvbi10aW1lIEFCSS4iCiAg ICAgICAgICAgICgoXyAoZmllbGQgdmFsdWUpICguLi4gLi4uKSkKICAgICAgICAgICAgIChsZXQg KChmaWVsZHMgKG1hcCBzeW50YXgtPmRhdHVtICMnKGZpZWxkICguLi4gLi4uKSkpKSkKICAgICAg ICAgICAgICAgKGRlZmluZSAoZmllbGQtdmFsdWUgZikKLSAgICAgICAgICAgICAgICAob3IgKGZp bmQgKGxhbWJkYSAoeCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZXE/IGYgKHN5bnRh eC0+ZGF0dW0geCkpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAjJyhmaWVsZCAoLi4uIC4u LikpKQotICAgICAgICAgICAgICAgICAgICAod3JhcC1maWVsZC12YWx1ZSBmIChmaWVsZC1kZWZh dWx0LXZhbHVlIGYpKSkpCisgICAgICAgICAgICAgICAgKHdyYXAtZmllbGQtdmFsdWUgZgorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChvciAoZmluZCAobGFtYmRhICh4KQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlcT8gZiAoc3ludGF4 LT5kYXR1bSB4KSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICMnKGZpZWxkICguLi4gLi4uKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChmaWVsZC1kZWZhdWx0LXZhbHVlIGYpKSkpCiAKICAgICAgICAgICAgICAgOzsgUGFzcyBT IHRvIG1ha2Ugc3VyZSBzb3VyY2UgbG9jYXRpb24gaW5mbyBpcyBwcmVzZXJ2ZWQuCiAgICAgICAg ICAgICAgIChyZXBvcnQtZHVwbGljYXRlLWZpZWxkLXNwZWNpZmllciAnbmFtZSBzKQotLSAKMi4z My4wCgo= --=-5+XuvfSwQSjxnipieDpA Content-Disposition: attachment; filename="34999-mwe.scm" Content-Type: text/x-scheme; name="34999-mwe.scm"; charset="UTF-8" Content-Transfer-Encoding: base64 KHVzZS1tb2R1bGVzIChndWl4IHJlY29yZHMpKQoKKGRlZmluZS1yZWNvcmQtdHlwZSogPHRoaW5n PiB0aGluZyBtYWtlLXRoaW5nCiAgdGhpbmc/CiAgdGhpcy10aGluZwogIChuYW1lIHRoaW5nLW5h bWUgKHRodW5rZWQpKQogIChuYW1lMiB0aGluZy1uYW1lMikpCgoobGV0KiAoKCV0aGluZwogICAg ICAgKHRoaW5nCiAgICAgICAgKG5hbWUgImZvbyIpCiAgICAgICAgKG5hbWUyIG5hbWUpKSkKICAg ICAgICgldGhpbmcyCiAgICAgICAgKHRoaW5nCiAgICAgICAgIChpbmhlcml0ICV0aGluZykKICAg ICAgICAgKG5hbWUgImJhciIpKSkpCiAgKGZvcm1hdCAjdCAidGhpbmcxOn4lICBuYW1lOiB+YX4l ICBuYW1lMjogfmF+JX4lIgogICAgICAgICAgKHRoaW5nLW5hbWUgJXRoaW5nKQogICAgICAgICAg KHRoaW5nLW5hbWUyICV0aGluZykpCgogIChmb3JtYXQgI3QgInRoaW5nMjp+JSAgbmFtZTogfmF+ JSAgbmFtZTI6IH5hfiUiCiAgICAgICAgICAodGhpbmctbmFtZSAldGhpbmcyKQogICAgICAgICAg KHRoaW5nLW5hbWUyICV0aGluZzIpKSkK --=-5+XuvfSwQSjxnipieDpA--