GNU bug report logs - #34993
27.0.50; Repeated call to custom-add-option in esh-mode.el

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Mon, 25 Mar 2019 14:12:01 UTC

Severity: minor

Tags: fixed, patch

Found in version 27.0.50

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #12 received at control <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 34993 <at> debbugs.gnu.org
Subject: Re: bug#34993: 27.0.50;
 Repeated call to custom-add-option in esh-mode.el
Date: Wed, 03 Apr 2019 22:56:29 -0400

tags 34993 fixed
close 34993 27.1
quit

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> esh-mode.el has a repeated call to 'custom-add-option':
> (custom-add-option 'eshell-pre-command-hook 'eshell-push-command-mark)
>
> From context, I assume the latter was intended for a different second
> argument.  The patch is attached.

Yep, looks like a copy-pasto, I pushed your patch to master.

[1: 64925714ef]: 2019-04-03 22:41:39 -0400
  Fix repeated 'custom-add-option' in esh-mode.el (Bug#34993)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=64925714ef6b4d7485e5aee7a8ac063c20c07bc5
This bug report was last modified 6 years and 102 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.