From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 10:11:35 2019 Received: (at submit) by debbugs.gnu.org; 25 Mar 2019 14:11:35 +0000 Received: from localhost ([127.0.0.1]:58491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8QK7-0008JT-Ic for submit@debbugs.gnu.org; Mon, 25 Mar 2019 10:11:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8QK5-0008JF-7M for submit@debbugs.gnu.org; Mon, 25 Mar 2019 10:11:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:50738) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8QJz-0001Qs-V4 for submit@debbugs.gnu.org; Mon, 25 Mar 2019 10:11:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8QJy-0007mn-T4 for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2019 10:11:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8QJy-0001Mm-1U for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2019 10:11:26 -0400 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:41568) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8QJx-0001JH-IS for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2019 10:11:25 -0400 Received: by mail-lj1-x234.google.com with SMTP id k8so7950615lja.8 for ; Mon, 25 Mar 2019 07:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=UzLDuDdNGP3GoNXkBXBioEhuMyC4BQpxz4oUv1+Ccl8=; b=s4jBvdEwj5oZxCpa/wyG2vI0yBjJ88x1ahlG4UHZc0Dkanl6fSDhb48puOU3Lmmxbu o9zwwmVqNPt9n10o3BiW5CtqQnouk1vdwuVZneH5mH43IxXVIy4q7lSqYJf3FRzIG2/N tLaAqFbX6VALEBu6B2oUMQSQYihGsZ42oJq6A7hVgucuC++wphyWSeRb9msprjfiXilA wSvkttwIgDWmPLFzdWfE6K2b2aZWGYDnpID54PBmcCp0B630MQGgsH27cV1XPD7Dv86Q ciyXeL2bcKHTmyHkRjqexHQssNbn0uUjdvPa+H3R6000boOb4uklpzfpUgSNhMeANE1u vsWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=UzLDuDdNGP3GoNXkBXBioEhuMyC4BQpxz4oUv1+Ccl8=; b=Qbk9gmJY+ypsWQ+j0TmybZUSMlCoPyjeoK3yKztV23QA0j30UWEHJPwnrR3C4GxLPq ga9fJKV4HEWDKlsgOwocnxCzl+GF3lRhCBB0Jl+1z+MaGBXsh9BnfZy+k0nu8796umvr +VgUrikRDNHgCNMsvEqmYODMmFFh2LvBeDwlFifsg96ChM5e0Qgxo2n9h7JqrXiMJYAZ /gbBs+Iw7GKcIt6IXAotdCpXlia+xlzncgop3fYXOxUL6p6LAJN6YP+qxXOFDw6S/yss cH3mXARB+VfVv4VBFSMBTCpAt5hVvplKni7E7Ktq8Z01q8gG2k+zunv+NYOEKkNyORKq lO6A== X-Gm-Message-State: APjAAAUwIuCYvzGBoZkGHMoxF1Jsk+iSKFgmo7nPTXc57kWdRvi646Gs LzVTQZP/UupHm9ZKmUrWGf18IP9ihV3+j0UuRyofzndg X-Google-Smtp-Source: APXvYqzHiXGoHcVLy2umZOqOzDwR4XUpXmwyI1BZR77NSw7jcBwOwH+lfgVo+Rh8yderqx6QxIkaSnhD2w6PJVay7AE= X-Received: by 2002:a2e:3506:: with SMTP id z6mr13247990ljz.72.1553523083364; Mon, 25 Mar 2019 07:11:23 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Mon, 25 Mar 2019 11:11:11 -0300 Message-ID: Subject: 27.0.50; Repeated call to custom-add-option in esh-mode.el To: bug-gnu-emacs Content-Type: multipart/mixed; boundary="000000000000895c570584ebc7ad" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::234 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000895c570584ebc7ad Content-Type: multipart/alternative; boundary="000000000000895c540584ebc7ab" --000000000000895c540584ebc7ab Content-Type: text/plain; charset="UTF-8" Tags: patch esh-mode.el has a repeated call to 'custom-add-option': (custom-add-option 'eshell-pre-command-hook 'eshell-push-command-mark) >From context, I assume the latter was intended for a different second argument. The patch is attached. Best regards, Mauro. --000000000000895c540584ebc7ab Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Tags: patch

esh-mode.el has a repe= ated call to 'custom-add-option':
(custom-add-option 'eshell= -pre-command-hook 'eshell-push-command-mark)

From context, I ass= ume the latter was intended for a different second
argument.=C2=A0 The p= atch is attached.

Best regards,
<= div>Mauro.
--000000000000895c540584ebc7ab-- --000000000000895c570584ebc7ad Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-repeated-call-to-custom-add-option-in-esh-mode.e.patch" Content-Disposition: attachment; filename="0001-Fix-repeated-call-to-custom-add-option-in-esh-mode.e.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jtoezyi30 RnJvbSBkNTM4NDFhYTExZGEzYTk4YTZhYjU2ZTEyMTRkYzNhYjY3Zjc0MjE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IE1vbiwgMjUgTWFyIDIwMTkgMTA6Mzg6MzkgLTAzMDAKU3ViamVjdDogW1BBVENIXSBG aXggcmVwZWF0ZWQgY2FsbCB0byAnY3VzdG9tLWFkZC1vcHRpb24nIGluIGVzaC1tb2RlLmVsCgoq IGxpc3AvZXNoZWxsL2VzaC1tb2RlLmVsOiBDYWxsICdjdXN0b20tYWRkLW9wdGlvbicgd2l0aCB0 aGUgcmlnaHQKYXJndW1lbnQuCi0tLQogbGlzcC9lc2hlbGwvZXNoLW1vZGUuZWwgfCAyICstCiAx IGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQg YS9saXNwL2VzaGVsbC9lc2gtbW9kZS5lbCBiL2xpc3AvZXNoZWxsL2VzaC1tb2RlLmVsCmluZGV4 IDMwMjk4NzYuLjBhMTYwYjkgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaC1tb2RlLmVsCisr KyBiL2xpc3AvZXNoZWxsL2VzaC1tb2RlLmVsCkBAIC01NTEsNyArNTUxLDcgQEAgZXNoZWxsLWdv dG8taW5wdXQtc3RhcnQKIDl0ZXJtIGJlaGF2aW9yLiIKICAgKGdvdG8tY2hhciBlc2hlbGwtbGFz dC1pbnB1dC1zdGFydCkpCiAKLShjdXN0b20tYWRkLW9wdGlvbiAnZXNoZWxsLXByZS1jb21tYW5k LWhvb2sgJ2VzaGVsbC1wdXNoLWNvbW1hbmQtbWFyaykKKyhjdXN0b20tYWRkLW9wdGlvbiAnZXNo ZWxsLXByZS1jb21tYW5kLWhvb2sgJ2VzaGVsbC1nb3RvLWlucHV0LXN0YXJ0KQogCiAoZGVmc3Vi c3QgZXNoZWxsLWludGVyYWN0aXZlLXByaW50IChzdHJpbmcpCiAgICJQcmludCBTVFJJTkcgdG8g dGhlIGVzaGVsbCBkaXNwbGF5IGJ1ZmZlci4iCi0tIAoyLjcuNAoK --000000000000895c570584ebc7ad-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 22:56:38 2019 Received: (at 34993) by debbugs.gnu.org; 4 Apr 2019 02:56:38 +0000 Received: from localhost ([127.0.0.1]:43552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBsYP-0001CZ-QH for submit@debbugs.gnu.org; Wed, 03 Apr 2019 22:56:38 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]:37733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBsYO-0001CG-2M; Wed, 03 Apr 2019 22:56:36 -0400 Received: by mail-qt1-f178.google.com with SMTP id z16so1589086qtn.4; Wed, 03 Apr 2019 19:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wzV78zB9gHBMxHcMivdNRl85cacq+IQC+g0jeA+KUy4=; b=j0f2jCb+8NoeASSbDkQxvlHVTER0oSPVUUfZNUK/WXoMg5QLvR6SNCIj1nbhfbq0Ud yexrY8S+gglHyeWC1mebni3Cjmtlr2x6fbLV7TXfC8aViA+mp3zGzKiFoanSpvDyGn0h dUHpLG2HtCicS08io5o79/cFPX9hgFsmMW7H3pQ1+kv/o/FQH1iCXJWgm165x8UgsF0l DbOwpQHKxoVSS0XdPjLjdt3xb4AJlxxpbv8Xf118o4AxtHy8d5tuCwDks5PVqaUkw4Ub 4A4ZixFFHm6944oMBIQQZLc3wWncPSHevBF6jQ7CCA2aJVHDsHu7WFszs1vTTO+gwc+O oEhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wzV78zB9gHBMxHcMivdNRl85cacq+IQC+g0jeA+KUy4=; b=MTwy5+mpmM9MlWX1I+Ic7qTa4kjqErk/KfLLNtwtU3CjZU/qQaOD8vaKiZmWHXp9QA 6uMtWyhHvCEuKU+A1RLTxjdURLhd5qcyAhnseNxSwNPLVVYlcR0+8ZkbehfiOL3IxFTs rXIf3R0vycrcXJNiZSlmn+egJk8KV4OFePllqt8CjLqBD8R7yQDJ2YVsuPME3e9hTg54 ch9Kxt8GifT3vT1yMiAQd48daFGpcopFbZ1lAecOw4GtphnD/UkUakZpYYAhm4wI/tRJ qeQIk23dou1EcCORLHnucpLo/SdgEjbtbJA6m1KWZ9Q9yUJRbj7wvMMY2g8A6DRu38bc fHeA== X-Gm-Message-State: APjAAAU4mVjZCXqfvA0IuGwOQIfyYhD+sGRs9Phs2uXeZVM20sDW4dsz 1nLfrHUr5oKud8jWo5iY23C57Hlp X-Google-Smtp-Source: APXvYqwgNMK0+z7bhn9nrwNiQxBbXbYoSc9q8wKR1zus2Rp9skOJMjic5ymIm/pebnYS/eUggGIEkg== X-Received: by 2002:aed:3769:: with SMTP id i96mr3282522qtb.296.1554346590548; Wed, 03 Apr 2019 19:56:30 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m73sm9125385qke.95.2019.04.03.19.56.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 19:56:29 -0700 (PDT) From: Noam Postavsky To: Mauro Aranda Subject: Re: bug#34993: 27.0.50; Repeated call to custom-add-option in esh-mode.el References: Date: Wed, 03 Apr 2019 22:56:29 -0400 In-Reply-To: (Mauro Aranda's message of "Mon, 25 Mar 2019 11:11:11 -0300") Message-ID: <87zhp6eaw2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34993 Cc: 34993@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 34993 fixed close 34993 27.1 quit Mauro Aranda writes: > esh-mode.el has a repeated call to 'custom-add-option': > (custom-add-option 'eshell-pre-command-hook 'eshell-push-command-mark) > > From context, I assume the latter was intended for a different second > argument. The patch is attached. Yep, looks like a copy-pasto, I pushed your patch to master. [1: 64925714ef]: 2019-04-03 22:41:39 -0400 Fix repeated 'custom-add-option' in esh-mode.el (Bug#34993) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=64925714ef6b4d7485e5aee7a8ac063c20c07bc5 From unknown Mon Aug 11 21:37:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 02 May 2019 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator