From unknown Fri Jun 20 07:14:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34987 <34987@debbugs.gnu.org> To: bug#34987 <34987@debbugs.gnu.org> Subject: Status: 27.0.50; Error after toggling duplicate suppression Reply-To: bug#34987 <34987@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:14:56 +0000 retitle 34987 27.0.50; Error after toggling duplicate suppression reassign 34987 emacs,gnus submitter 34987 "Basil L. Contovounesios" severity 34987 normal tag 34987 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 24 23:45:41 2019 Received: (at submit) by debbugs.gnu.org; 25 Mar 2019 03:45:41 +0000 Received: from localhost ([127.0.0.1]:57362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8GYP-00050s-IY for submit@debbugs.gnu.org; Sun, 24 Mar 2019 23:45:41 -0400 Received: from mail-ed1-f47.google.com ([209.85.208.47]:40967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8GYM-00050c-L9 for submit@debbugs.gnu.org; Sun, 24 Mar 2019 23:45:39 -0400 Received: by mail-ed1-f47.google.com with SMTP id a25so6230102edc.8 for ; Sun, 24 Mar 2019 20:45:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version; bh=mFq9l+zM7i9qZB5mPY0nPg16vFlJLGCT2l+HAtHATn4=; b=yHzRcA3Jet6LQCcFrY7YDhJAI46wEJ2HQ9fKbOQBP6swNLBxkMA/FpaRMlGsTsa/W6 cS6JEytCkPglumKHSv2+9pQHWfAQpmYxcRa+dyqOKqh7Olv4/Hoo3zy/Jv0ajRV/puFp VhAblpzNC1A+Y2egZSxcE1AX+WAGr8weKgTLxOFpFYSk+jKX0KFP86OkWssuQ0JenO1H r68GwgAfKcFXuyUmDCUAbKZaNgKLSireO0iolXmsk4Hxtx5pnx2lQ8YiVR2D5Oa6n7PP P/+mea3Kzz///wOZZFc2kwUfgWvcOuOf0Vs1j3q5Hyy4GA0QxsEjkAr4SsRWA7AymWqI kNEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=mFq9l+zM7i9qZB5mPY0nPg16vFlJLGCT2l+HAtHATn4=; b=PAoTUrZN+RQmEq+PV/SeMDkBLw9+eARLOlNPckFyH5uQKQDj6weOEeqiJjVMuuSpSs BpyYIMjTGXQIwwLwYN3zaqgnP8AFEmHNsQ30cQ7+LhBmqmA19TkOapdPoMokFcHIwt8+ 7RYDpMQ1tQapItHhDgZET9nHf/cwFORoEaYxXfoGTV5C5YjGSsAA3vGBBZd8SxMGkYL6 ow4xL3coO52WDNUrO2ENpGVayVmumGevY8zUdtAsXpdVZpd3Ahhy3gynYtiWpashyFke sBYvVmcsQZlW9njmRWdwokjQjOnPFyseKIQXUOBgVsT1z6/Wd77TmRN2XVHA4ZsanqBR Fulg== X-Gm-Message-State: APjAAAUcNeSuHZS0y7Km63D1ZJ1cdZqrGhUUAUscW5uwayzjz0Lw6/iY tlDM70wL3qCzUD2xfGICaMVv8XSz0qY= X-Google-Smtp-Source: APXvYqy1APb0p+9cdToIUWpAW2jrjD9DW7PhpMs2IwviYhm8O7CVeRQr+a402Ms/byPnIfAA/zqhHg== X-Received: by 2002:a50:89fa:: with SMTP id h55mr14710656edh.296.1553485531514; Sun, 24 Mar 2019 20:45:31 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id w11sm4842784eds.39.2019.03.24.20.45.30 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 24 Mar 2019 20:45:30 -0700 (PDT) From: "Basil L. Contovounesios" To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) Subject: 27.0.50; Error after toggling duplicate suppression X-Debbugs-Version: 5.13 X-Debbugs-Package: emacs,gnus X-Debbugs-Cc: Eric Abrahamsen Date: Mon, 25 Mar 2019 03:45:29 +0000 Message-ID: <87pnqfiply.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Further to the discussion in bug#34973 and bug#34974, it indeed looks to me like gnus-suppress-duplicates cannot be enabled only after entering the summary buffer. In other words, I see the following: 0. Start Gnus with gnus-suppress-duplicates left at default value of nil 1. Enter summary buffer 2. M-x set-variable RET gnus-suppress-duplicates RET t RET 3. M-u Debugger entered--Lisp error: (wrong-type-argument hash-table-p nil) remhash("" nil) gnus-dup-unsuppress-article(36322) gnus-mark-article-as-unread(36322 32) gnus-summary-mark-article(nil 32 nil) gnus-summary-mark-forward(1 32) gnus-summary-clear-mark-forward(1) funcall-interactively(gnus-summary-clear-mark-forward 1) call-interactively(gnus-summary-clear-mark-forward nil nil) command-execute(gnus-summary-clear-mark-forward) Patch to follow. Thanks, -- Basil Gnus v5.13 In GNU Emacs 27.0.50 (build 6, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2019-03-25 built on thunk Repository revision: 5fdf4fc07df7dd897931efb5dbf5f26dfaff9274 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: Debian GNU/Linux buster/sid From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 24 23:54:11 2019 Received: (at 34987) by debbugs.gnu.org; 25 Mar 2019 03:54:11 +0000 Received: from localhost ([127.0.0.1]:57370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Ggd-0005DN-Hc for submit@debbugs.gnu.org; Sun, 24 Mar 2019 23:54:11 -0400 Received: from mail-ed1-f49.google.com ([209.85.208.49]:38617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Ggc-0005D5-C0 for 34987@debbugs.gnu.org; Sun, 24 Mar 2019 23:54:10 -0400 Received: by mail-ed1-f49.google.com with SMTP id q14so6248270edr.5 for <34987@debbugs.gnu.org>; Sun, 24 Mar 2019 20:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ysw1o4/24OPZ/sxElj294sgYb6QxPIvinbr39qyxMqM=; b=nXNC+pcLP7kMR2Ci7GxKnhchfX4+b+ZnUmQLj8+4XsCw0n2Hl/Fqi1DDvTvxUyHcoG TFRCSaaIiMdr1gOEpTXRRgh33hqiZpp2mRfLd2Oh8bVikbCg7pTgbVaKki7KKegYP5Rj bAgj6Dy2S9AHeclqeW4jyeqvJURLsaAme6ZHAE/1jBsjySXEbNrr1K3fyX8VPBRlNdc7 UoUxZ5N4bjk1NqlYx7XrEpZrxqyS4+NpL7zGOB+NIh2wmO0ELulIwaray0v6UiisGvd9 Z1J1EGJWaIdSOalAXJ1sQ7eZ3PJvyL5eQAn5Ivr0LNhI8C1RGn/7pfJ9R00dRY5Ul1F7 18Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ysw1o4/24OPZ/sxElj294sgYb6QxPIvinbr39qyxMqM=; b=iOhJHBgCbJmsbn/CBA8Tn6nJOBPDYkMGIC1c2G8MEhCUIvr8Kxip3O51c9kLoZzfsv x0mR6d//X0j/7BtS9h/17ecjik1i7ZvYGpWENUOIsaCyKVbrK0Hw55SZqRjGj/sa0gTt UCbXmmPKYo1RNQ2FoCzL5L4pYY/Hwaxq+EHTt2YlUqA4bvWHoRT2mI38PNWw7d2fdyBm 7+v6iJ6H6ATks2D925QN1Zehjj7uTMqBaxWMjl7yPH9UNaFNW+VvOMulBwey0sVByIUR VA1qwzPLoQ2DXNT8vTBiGTfDAlmq8tqeqmzPLuoZsu6rY4wojTV8i09QXQSFVnlmJwR1 QChg== X-Gm-Message-State: APjAAAXZ5Q9XE1I7TzT9qoLc6t5qZt1r4WUWYRCKbGBfXl08mHF6s1bQ 1dDgL1VFSkwZiJ9O37Eh41E2gtz/wVQpMQ== X-Google-Smtp-Source: APXvYqyb1HSg++HBQXEIf6VyOTgD5XWHWPQTpWi4KynwXChuPm2FIACbVtTFQPXIjx99Fh00iC5Lqw== X-Received: by 2002:a17:906:708d:: with SMTP id b13mr11971622ejk.120.1553486043334; Sun, 24 Mar 2019 20:54:03 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id m3sm3196701ejn.76.2019.03.24.20.54.02 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 24 Mar 2019 20:54:02 -0700 (PDT) From: "Basil L. Contovounesios" To: 34987@debbugs.gnu.org Subject: Re: bug#34987: 27.0.50; Error after toggling duplicate suppression References: <87pnqfiply.fsf@tcd.ie> Date: Mon, 25 Mar 2019 03:54:01 +0000 In-Reply-To: <87pnqfiply.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 25 Mar 2019 03:45:29 +0000") Message-ID: <874l7rip7q.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34987 Cc: Eric Abrahamsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 34987 patch quit "Basil L. Contovounesios" writes: > Patch to follow. Here it is: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-Gnus-duplicate-suppression-guards-bug-34987.patch >From 162c8d12a4614776e0104b6701d27f5b30bf607b Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Mon, 25 Mar 2019 02:15:10 +0000 Subject: [PATCH] Fix Gnus duplicate suppression guards (bug#34987) * lisp/gnus/gnus-dup.el (gnus-dup-enter-articles) (gnus-dup-suppress-articles): Use gnus-dup-hashtb as an indicator of initialization instead of gnus-dup-list, which may happen to be nil. (gnus-dup-unsuppress-article): Do nothing if gnus-dup-hashtb is uninitialized. --- lisp/gnus/gnus-dup.el | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lisp/gnus/gnus-dup.el b/lisp/gnus/gnus-dup.el index 8b876489e1..86dbf1a574 100644 --- a/lisp/gnus/gnus-dup.el +++ b/lisp/gnus/gnus-dup.el @@ -105,7 +105,7 @@ gnus-dup-save (defun gnus-dup-enter-articles () "Enter articles from the current group for future duplicate suppression." - (unless gnus-dup-list + (unless gnus-dup-hashtb (gnus-dup-open)) (setq gnus-dup-list-dirty t) ; mark list for saving (let (msgid) @@ -129,7 +129,7 @@ gnus-dup-enter-articles (defun gnus-dup-suppress-articles () "Mark duplicate articles as read." - (unless gnus-dup-list + (unless gnus-dup-hashtb (gnus-dup-open)) (gnus-message 8 "Suppressing duplicates...") (let ((auto (and gnus-newsgroup-auto-expire @@ -149,9 +149,10 @@ gnus-dup-suppress-articles (defun gnus-dup-unsuppress-article (article) "Stop suppression of ARTICLE." - (let* ((header (gnus-data-header (gnus-data-find article))) - (id (when header (mail-header-id header)))) - (when id + (let (header id) + (when (and gnus-dup-hashtb + (setq header (gnus-data-header (gnus-data-find article))) + (setq id (mail-header-id header))) (setq gnus-dup-list-dirty t) (setq gnus-dup-list (delete id gnus-dup-list)) (remhash id gnus-dup-hashtb)))) -- 2.20.1 --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 13:43:13 2019 Received: (at 34987) by debbugs.gnu.org; 5 Apr 2019 17:43:13 +0000 Received: from localhost ([127.0.0.1]:46265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCSrx-0001KW-F0 for submit@debbugs.gnu.org; Fri, 05 Apr 2019 13:43:13 -0400 Received: from mail-ed1-f47.google.com ([209.85.208.47]:43803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCSrv-0001KF-67 for 34987@debbugs.gnu.org; Fri, 05 Apr 2019 13:43:12 -0400 Received: by mail-ed1-f47.google.com with SMTP id t22so1229928edw.10 for <34987@debbugs.gnu.org>; Fri, 05 Apr 2019 10:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RjRn1l+cBCNTg6RGRMv+D7VeC+lBANqakVY2+G2BR/Q=; b=dIqA58hq2+Yft/49+fzPYyofFrqkUBQBz0PFtRfYxTicx/BAOjeMgX/ni69C0a/A+t eT7rwV8w24BEWWL4AJIESn7mYm0H3yJQNpURj/k/T0jF5skv3PfV0rIIfisWBvdJo0Ih BeOvX3F4A1SrFZrRhNR4kpdcsqPv+q0P8HLzblExH5lgU2OE01EQ4146EOlHX/MbS0zl n47A3osynIS8KGBH+LvC2ZWEX1B3rFAeULv/A42DZPiU58b12LexLepttgyV6bamTFxX tGi5hpFE5toEx8whKNX00qUyWoAODo4Drhh7L5/nhiPjw2LwRHY22P8DHAerWb5DxpEe 5KYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RjRn1l+cBCNTg6RGRMv+D7VeC+lBANqakVY2+G2BR/Q=; b=fGVzjWWYNDUjyR2pkR1Eeut09N6YYBE6o6R2YqfkCnh2v01OD7OYokcAtmzrZxbcGy gJ/DrSz6amr2Hz3d3FiAsmNCyhCsuCdQ1HtD0H0rQ20+I11mv+gXFEovPJFUVK/Bu1OK 2RHFGjZ0nvEd7wA8N3e/kTI/99fNsfMhQ4wCuagpJvTMYo5EWDpDRTLl4Zn+FgLhD/l2 QUXWsqzkc1r2AP557vkl1GpcKSj3OiUPBihJVQoGZxlgTN7R70HKfwmFGo50bYCvAc91 SxlIwqNhOtbn+wvTeyzQVzeNU5m1IQPY7r/LFuiRVTM1ulcpridZk9zua2nz08Lwoc/N nDpg== X-Gm-Message-State: APjAAAUW9MA5/tVEo3AkcXFD0nzjRofFBIyJU28VIn1Cptd1qTISOu/S EmK8syMkPA91LWwyUDKBbsyV8EOsR1XSYyhC X-Google-Smtp-Source: APXvYqz4WHZ1shRNwCTIUuYuRIF32im8kpBrbvnFmmdBwNG12YjOc1cyevFyU9a+kjcZqwg18/bJRg== X-Received: by 2002:a17:906:b291:: with SMTP id q17mr8149309ejz.56.1554486185008; Fri, 05 Apr 2019 10:43:05 -0700 (PDT) Received: from localhost (86-41-18-45-dynamic.agg3.crz.crz-crz.eircom.net. [86.41.18.45]) by smtp.gmail.com with ESMTPSA id a38sm6691658eda.71.2019.04.05.10.43.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Apr 2019 10:43:04 -0700 (PDT) From: "Basil L. Contovounesios" To: 34987@debbugs.gnu.org Subject: Re: bug#34987: 27.0.50; Error after toggling duplicate suppression References: <87pnqfiply.fsf@tcd.ie> <874l7rip7q.fsf@tcd.ie> Date: Fri, 05 Apr 2019 18:43:03 +0100 In-Reply-To: <874l7rip7q.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 25 Mar 2019 03:54:01 +0000") Message-ID: <87a7h48i1k.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34987 Cc: Eric Abrahamsen , Katsumi Yamaoka X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [CCing Yamaoka-san due to recent work in this area.] "Basil L. Contovounesios" writes: > "Basil L. Contovounesios" writes: > >> Patch to follow. > > Here it is: > > From 162c8d12a4614776e0104b6701d27f5b30bf607b Mon Sep 17 00:00:00 2001 > From: "Basil L. Contovounesios" > Date: Mon, 25 Mar 2019 02:15:10 +0000 > Subject: [PATCH] Fix Gnus duplicate suppression guards (bug#34987) > > * lisp/gnus/gnus-dup.el (gnus-dup-enter-articles) > (gnus-dup-suppress-articles): Use gnus-dup-hashtb as an indicator of > initialization instead of gnus-dup-list, which may happen to be nil. > (gnus-dup-unsuppress-article): Do nothing if gnus-dup-hashtb is > uninitialized. > --- > lisp/gnus/gnus-dup.el | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/lisp/gnus/gnus-dup.el b/lisp/gnus/gnus-dup.el > index 8b876489e1..86dbf1a574 100644 > --- a/lisp/gnus/gnus-dup.el > +++ b/lisp/gnus/gnus-dup.el > @@ -105,7 +105,7 @@ gnus-dup-save > > (defun gnus-dup-enter-articles () > "Enter articles from the current group for future duplicate suppression." > - (unless gnus-dup-list > + (unless gnus-dup-hashtb > (gnus-dup-open)) > (setq gnus-dup-list-dirty t) ; mark list for saving > (let (msgid) > @@ -129,7 +129,7 @@ gnus-dup-enter-articles > > (defun gnus-dup-suppress-articles () > "Mark duplicate articles as read." > - (unless gnus-dup-list > + (unless gnus-dup-hashtb > (gnus-dup-open)) > (gnus-message 8 "Suppressing duplicates...") > (let ((auto (and gnus-newsgroup-auto-expire > @@ -149,9 +149,10 @@ gnus-dup-suppress-articles > > (defun gnus-dup-unsuppress-article (article) > "Stop suppression of ARTICLE." > - (let* ((header (gnus-data-header (gnus-data-find article))) > - (id (when header (mail-header-id header)))) > - (when id > + (let (header id) > + (when (and gnus-dup-hashtb > + (setq header (gnus-data-header (gnus-data-find article))) > + (setq id (mail-header-id header))) > (setq gnus-dup-list-dirty t) > (setq gnus-dup-list (delete id gnus-dup-list)) > (remhash id gnus-dup-hashtb)))) > -- > 2.20.1 Sorry to nag, but I think this is a straightforward enough fix that I would like to push soon. WDYT? Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 15:23:06 2019 Received: (at 34987) by debbugs.gnu.org; 9 Apr 2019 19:23:06 +0000 Received: from localhost ([127.0.0.1]:51989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDwKo-0002L5-4j for submit@debbugs.gnu.org; Tue, 09 Apr 2019 15:23:06 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:47584 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDwKj-0002KK-Nd for 34987@debbugs.gnu.org; Tue, 09 Apr 2019 15:23:03 -0400 Received: from localhost (97-113-35-98.tukw.qwest.net [97.113.35.98]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id CDC8FFA05B; Tue, 9 Apr 2019 19:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554837776; bh=98zVDzKzYHdvrA5LiV2AjyghMighrsvucuUlxU+rwV0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=UVnoVd+VzMwLJTllxIQveC0BUJtrWSt5Xs20gVJG34trPBeNB9alj5gC/0Ytn2Pi4 orSNxlxnZElyWRCWgvp1fqCHQFCJp8qmTtdQCcnOdEzjHW2C+kTr6CRTjSoUGzIZ21 ZJzZxKkQNrkxQnSUnVXyETbFfCXG9EKNuGMLWBlY= From: Eric Abrahamsen To: "Basil L. Contovounesios" Subject: Re: bug#34987: 27.0.50; Error after toggling duplicate suppression References: <87pnqfiply.fsf@tcd.ie> <874l7rip7q.fsf@tcd.ie> <87a7h48i1k.fsf@tcd.ie> Date: Tue, 09 Apr 2019 12:22:54 -0700 In-Reply-To: <87a7h48i1k.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 05 Apr 2019 18:43:03 +0100") Message-ID: <877ec3dlv5.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34987 Cc: Katsumi Yamaoka , 34987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > [CCing Yamaoka-san due to recent work in this area.] > > "Basil L. Contovounesios" writes: > >> "Basil L. Contovounesios" writes: >> >>> Patch to follow. >> >> Here it is: >> >> From 162c8d12a4614776e0104b6701d27f5b30bf607b Mon Sep 17 00:00:00 2001 >> From: "Basil L. Contovounesios" >> Date: Mon, 25 Mar 2019 02:15:10 +0000 >> Subject: [PATCH] Fix Gnus duplicate suppression guards (bug#34987) >> >> * lisp/gnus/gnus-dup.el (gnus-dup-enter-articles) >> (gnus-dup-suppress-articles): Use gnus-dup-hashtb as an indicator of >> initialization instead of gnus-dup-list, which may happen to be nil. >> (gnus-dup-unsuppress-article): Do nothing if gnus-dup-hashtb is >> uninitialized. >> --- >> lisp/gnus/gnus-dup.el | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/lisp/gnus/gnus-dup.el b/lisp/gnus/gnus-dup.el >> index 8b876489e1..86dbf1a574 100644 >> --- a/lisp/gnus/gnus-dup.el >> +++ b/lisp/gnus/gnus-dup.el >> @@ -105,7 +105,7 @@ gnus-dup-save >> >> (defun gnus-dup-enter-articles () >> "Enter articles from the current group for future duplicate suppression." >> - (unless gnus-dup-list >> + (unless gnus-dup-hashtb >> (gnus-dup-open)) >> (setq gnus-dup-list-dirty t) ; mark list for saving >> (let (msgid) >> @@ -129,7 +129,7 @@ gnus-dup-enter-articles >> >> (defun gnus-dup-suppress-articles () >> "Mark duplicate articles as read." >> - (unless gnus-dup-list >> + (unless gnus-dup-hashtb >> (gnus-dup-open)) >> (gnus-message 8 "Suppressing duplicates...") >> (let ((auto (and gnus-newsgroup-auto-expire >> @@ -149,9 +149,10 @@ gnus-dup-suppress-articles >> >> (defun gnus-dup-unsuppress-article (article) >> "Stop suppression of ARTICLE." >> - (let* ((header (gnus-data-header (gnus-data-find article))) >> - (id (when header (mail-header-id header)))) >> - (when id >> + (let (header id) >> + (when (and gnus-dup-hashtb >> + (setq header (gnus-data-header (gnus-data-find article))) >> + (setq id (mail-header-id header))) >> (setq gnus-dup-list-dirty t) >> (setq gnus-dup-list (delete id gnus-dup-list)) >> (remhash id gnus-dup-hashtb)))) >> -- >> 2.20.1 > > Sorry to nag, but I think this is a straightforward enough fix that I > would like to push soon. WDYT? Looks fine to me... From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 16:30:47 2019 Received: (at control) by debbugs.gnu.org; 9 Apr 2019 20:30:47 +0000 Received: from localhost ([127.0.0.1]:52045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDxOJ-0004Cn-6z for submit@debbugs.gnu.org; Tue, 09 Apr 2019 16:30:47 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:33604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDxOH-0004CV-QD for control@debbugs.gnu.org; Tue, 09 Apr 2019 16:30:46 -0400 Received: by mail-ed1-f53.google.com with SMTP id b8so36031edq.0 for ; Tue, 09 Apr 2019 13:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=osOeWrCZ7MZBJziLHWkyAIOIrwRwyhX8ffnXXtYay/w=; b=z6nD1twm0kGaK9BwdSONNKXgRiU91Uaw0KWHfaMZCDYB3Zq2lZ8oPxl8GkFFbR3aRV 8tIfjV0mZgyV3SyLgSsT+2ayIYaD9PhTfMQB41b/xMJbSIwKIxO1x85tbCwBKEUN9P6Z MYtkyiVvpG0qLrLF+mBKDfs7jIP+LwkjpTlVsSK6EsWNky25td1i1SHY4bvbDRdSiegQ hBpsa1hvSWE/L0lt7ij5MVuu4a0YvVMqi6PpC7FxsbJCaguN9JUzGNXZ8NcUnzO6EH5M ETWCUgtNaYjETg/nXXSxCDhUuAHoWSOYz/SpY9nj9PTSAcb2raATaxufr5pJsk/PA9TJ gp6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=osOeWrCZ7MZBJziLHWkyAIOIrwRwyhX8ffnXXtYay/w=; b=uSzpS0n4ggzVFPrfb2ZGfIbK1dhCP5IsvzflKsnFGGndOZWRram8X7wMqK+p2klMD/ 3rfgkkUJW6aRznMZerfgHY7Kfw+4+dTLKRG6Vak/F2wtJGDelHEPQ/Fc8O98kPNe1e+f KJb7+nYe9GVLSkGWUFUwAnSZXxTLlySzzMzCdDbMEPjssoytHn40RePYfP/iQI4pcDEw rjX1YHK+iBAw93FEeqOpa8hG/02qlJDgNrVYfT9kWfCwJbrgVvKRnt9Er7EXhToob8tL PRvChnfZegztiwhLLxCRMArFWFi1hMYsnCEpWicBmHvU2cXZe1pYnjth8y/24TVaueqR 6u1g== X-Gm-Message-State: APjAAAWu9wb0umD2mCbyFDMRC5j2s6XWnhdcP1rrWo9f/icLH5Jp5Utq jFGqml97RkJOTzgSnqgWgiUf5Q== X-Google-Smtp-Source: APXvYqztbKbpRfr4obUl/iNIkla7Oe/P1LEkWhXtfHJ6Ds7iYwCoso+Sx2g8gQuJre0oSNcSp8Tr6Q== X-Received: by 2002:a50:a49c:: with SMTP id w28mr24538727edb.151.1554841840005; Tue, 09 Apr 2019 13:30:40 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id b54sm9722571ede.58.2019.04.09.13.30.38 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 09 Apr 2019 13:30:39 -0700 (PDT) From: "Basil L. Contovounesios" To: Eric Abrahamsen Subject: Re: bug#34987: 27.0.50; Error after toggling duplicate suppression References: <87pnqfiply.fsf@tcd.ie> <874l7rip7q.fsf@tcd.ie> <87a7h48i1k.fsf@tcd.ie> <877ec3dlv5.fsf@ericabrahamsen.net> Date: Tue, 09 Apr 2019 21:30:37 +0100 In-Reply-To: <877ec3dlv5.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 09 Apr 2019 12:22:54 -0700") Message-ID: <87muky9b0y.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: Katsumi Yamaoka , 34987-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 34987 fixed close 34987 quit Eric Abrahamsen writes: > "Basil L. Contovounesios" writes: > >> Sorry to nag, but I think this is a straightforward enough fix that I >> would like to push soon. WDYT? > > Looks fine to me... That's all I need. ;) Pushed to master[1] and am thus closing this bug. [1: 6cb49922e6]: Fix Gnus duplicate suppression guards (bug#34987) 2019-04-09 21:29:38 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6cb49922e63c2523ccdd6e0a6bd72bcfa72c50c6 Thanks, -- Basil From unknown Fri Jun 20 07:14:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 May 2019 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator