GNU bug report logs - #34986
write-region not governed by require-final-newline

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34986 in the body.
You can then email your comments to 34986 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: write-region not governed by require-final-newline
Date: Mon, 25 Mar 2019 11:28:56 +0800

User, despite setting
 require-final-newline t
in .emacs, still finds he is often creating files without final
newlines.

It turns out write-region, which he often uses, is not governed by
require-final-newline.

I though the whole logic of require-final-newline was to help people add
those newlines.

Message #8 received at 34986 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 34986 <at> debbugs.gnu.org
Subject: Re: bug#34986: write-region not governed by require-final-newline
Date: Mon, 25 Mar 2019 04:08:38 +0000

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> User, despite setting
>  require-final-newline t
> in .emacs, still finds he is often creating files without final
> newlines.
>
> It turns out write-region, which he often uses, is not governed by
> require-final-newline.
>
> I though the whole logic of require-final-newline was to help people add
> those newlines.

The user option require-final-newline is relevant only when visiting
files, not when writing to arbitrary ones, so you probably want to use
save-buffer instead of write-region or similar.

See (info "(emacs) Visiting"), (info "(emacs) Customize Save"), and
(info "(elisp) Saving Buffers").

-- 
Basil

Message #11 received at 34986 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 34986 <at> debbugs.gnu.org
Subject: Re: bug#34986: write-region not governed by require-final-newline
Date: Mon, 25 Mar 2019 12:14:06 +0800

>>>>> "BLC" == Basil L Contovounesios <contovob <at> tcd.ie> writes:

BLC> The user option require-final-newline is relevant only when visiting
BLC> files, not when writing to arbitrary ones,

OK, but perhaps add a note about that somewhere on the docstring:

require-final-newline...
Documentation:
Whether to add a newline automatically at the end of the file.

A value of t means do this only when the file is about to be saved.
A value of ‘visit’ means do this right after the file is visited.
A value of ‘visit-save’ means do it at both of those times.
Any other non-nil value means ask user whether to add a newline, when saving.
A value of nil means don’t add newlines.

Message #14 received at 34986 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 34986 <at> debbugs.gnu.org
Subject: Re: bug#34986: write-region not governed by require-final-newline
Date: Mon, 14 Oct 2019 22:49:52 +0200

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

>>>>>> "BLC" == Basil L Contovounesios <contovob <at> tcd.ie> writes:
>
> BLC> The user option require-final-newline is relevant only when visiting
> BLC> files, not when writing to arbitrary ones,
>
> OK, but perhaps add a note about that somewhere on the docstring:
>
> require-final-newline...
> Documentation:
> Whether to add a newline automatically at the end of the file.

I've now added text to the doc string to mention this.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.