Subject: bug#34983: 27.0.50; Gnus cannot start

From: Eric Abrahamsen <[email-masked]>
Date: Mon, 25 Mar 2019 07:47:21 -0700

On 03/25/19 12:24 PM, Colin Baxter wrote:
>>>>>> Bastien  <[email-masked]> writes:
>
>     > Hello, Colin Baxter <[email-masked]> writes:
>
>     >> Warning: Warning - invalid active: "nnrss:AnnPhys" 2059 1 y;
>     >> Warning - invalid active: "nnrss:JMO" 284 1 y; Warning - invalid
>     >> active: "nnrss:PRA" 307 1 y; Warning - invalid active:
>     >> "nnrss:PRL" 852 1 y; Warning - invalid active: "nnrss:ProcRSocA"
>     >> 141 1 y; Warning - invalid active: "nnrss:JPhysA" 133 1 y
>
>     > FWIW, I also had the same kind of warnings with 27.0.50.

This part of the bug, thankfully, is fairly simple, and I think the
attached patch will fix it. Will one or more of you apply this and give
it a shot?

diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index f1202e176e..8c2411f4d9 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -4029,7 +4029,7 @@ gnus-group-list-active
 		 (insert "       *: "
 			 (gnus-group-decoded-name group)
 			 "\n"))
-       (list 'gnus-group (gethash group gnus-active-hashtb)
+       (list 'gnus-group group
 	     'gnus-unread t
 	     'gnus-level (inline (gnus-group-level group)))))
     (goto-char (point-min))))
diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el
index 82141e0221..5a78df9fe4 100644
--- a/lisp/gnus/gnus-start.el
+++ b/lisp/gnus/gnus-start.el
@@ -2145,9 +2145,12 @@ gnus-active-to-gnus-format
 	(condition-case ()
 	    (if (and (stringp (progn
 				(setq group (read cur)
-				      group (if (numberp group)
-						(number-to-string group)
-					      (symbol-name group)))))
+				      group (cond ((numberp group)
+						   (number-to-string group))
+						  ((symbolp group)
+						   (symbol-name group))
+						  ((stringp group)
+						   group)))))
 		     (numberp (setq max (read cur)))
 		     (numberp (setq min (read cur)))
 		     (null (progn