From unknown Fri Jun 13 11:48:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34956: Fix for define-compilation-mode Resent-From: Troy Hinckley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Mar 2019 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 34956@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155335643227299 (code B ref -1); Sat, 23 Mar 2019 15:54:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Mar 2019 15:53:52 +0000 Received: from localhost ([127.0.0.1]:55701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7ixz-00076E-Vp for submit@debbugs.gnu.org; Sat, 23 Mar 2019 11:53:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7guB-0003mg-2v for submit@debbugs.gnu.org; Sat, 23 Mar 2019 09:41:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:56452) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7gu5-0007y4-IE for submit@debbugs.gnu.org; Sat, 23 Mar 2019 09:41:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7gu4-0003M8-Kr for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 09:41:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7gff-0005W0-PZ for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 09:26:48 -0400 Received: from mail-vs1-xe36.google.com ([2607:f8b0:4864:20::e36]:36293) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h7gff-0005TQ-Fe for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 09:26:47 -0400 Received: by mail-vs1-xe36.google.com with SMTP id n4so2957017vsm.3 for ; Sat, 23 Mar 2019 06:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=K9npiXLTR7TXX/YvFSQOYT3hLMmSiCeQQVvitOQQB/I=; b=jrvvkUw/nKJhP/lTgcxSpEitWQDJJuHLMW7HV+VMmHJZlbuji/VLtGv+vOOc0vkJEf Mf2whiJx3ZS9IyxoMv11JB2VtRig1UQVD3Gr92WXuH7IXb64u8F+Lr6h9dJSeuJ/eAFj 6hhaYmgJOakrN2ghTGRjbCU3S9KQxX/FB0OT9oXuQVszVV9OM61Qk4Ojr0o/entsbj6i E4i/HTklUwBScmtdd77ZybDmlBTbqtr+y0OBwOBA0JffL60k7vXT/KTImaWu8pKpB8F2 ryTYDXI/UPqUdaj90o2mm9jYVphjSmJNOIzpUQooE4MrRlaFPiQ1DfV9+cACemDDI4OQ 9+Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=K9npiXLTR7TXX/YvFSQOYT3hLMmSiCeQQVvitOQQB/I=; b=ZHpQCt+AUFHBqRftsfOa7NaB2qwCr2rb5VppL57c3vUI2fG77ILEtY3yJwcydIm79+ KnjfB4PjtXBRwcbWBjVG9uF7fQH9RBSj/GNEf+Xn0wGRvUCL8oB8b8dP93UKBMDeq0Iz izVlhwKp/nmTKXQw8O/JczrJt06JEA4HWMn+Ukgd1wEwQfWjhIrTN8LwrHv575BYPiX5 gGms8ER2I4kuKmkWFG3ofIArekLjc5MnflpnjYgCyqNdakR+p3+Ph8WP1+1D+ncdn0wT elirkejEK7Lf6Twg81/hGByMHeHx5htJ4NQ/mzjXpJ+WFfpmgAZ4tdE7aoECVdhSEymF SUpw== X-Gm-Message-State: APjAAAUQt9zl0Jlb9m6DoGvuTWdGv+vfGG2osEalEMb1DN8VaUYoEI1H OoDnUXxrhm3P9ST+BKufa1ljhDYH0nNYkyl3JLZrzg== X-Google-Smtp-Source: APXvYqyVdDTYaCEk9P9w+yYvhdsSgzxSHHelmCJjTMkHR8i9t/viT3R3MYh6obgRPwnSqsfK7kH9byNkdNuPoPYpRH0= X-Received: by 2002:a05:6102:44a:: with SMTP id e10mr9024258vsq.81.1553347606234; Sat, 23 Mar 2019 06:26:46 -0700 (PDT) MIME-Version: 1.0 From: Troy Hinckley Date: Sat, 23 Mar 2019 07:26:34 -0600 Message-ID: Content-Type: multipart/mixed; boundary="000000000000486c210584c2ec3a" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::e36 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Mailman-Approved-At: Sat, 23 Mar 2019 11:53:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000486c210584c2ec3a Content-Type: multipart/alternative; boundary="000000000000486c1d0584c2ec38" --000000000000486c1d0584c2ec38 Content-Type: text/plain; charset="UTF-8" Hello, This a is small patch that removes compilation-buffer-name-function-from define-compilation-mode. compilation-buffer-name-function is used before the major-mode is loaded, therefore overriding it in define-compilation-mode is ineffectual. Removing it from the list of overridden variables will ensure that it is not mistaken for a variable that can be major mode specific. Also the function compilation-start takes an optional argument name-function, so there is already a mechanism to override it. --000000000000486c1d0584c2ec38 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,
This a is small patch that removes compilation-= buffer-name-function-from define-compilation-mode. compilation-buffer-name-= function is used before the major-mode is loaded, therefore overriding it i= n define-compilation-mode is ineffectual. Removing it from the list of over= ridden variables will ensure that it is not mistaken for a variable that ca= n be major mode specific. Also the function compilation-start takes an opti= onal argument name-function, so there is already a mechanism to override it= .=C2=A0
--000000000000486c1d0584c2ec38-- --000000000000486c210584c2ec3a Content-Type: application/octet-stream; name="0001-Remove-compilation-buffer-name-function-from-derived.patch" Content-Disposition: attachment; filename="0001-Remove-compilation-buffer-name-function-from-derived.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jtlj08f90 RnJvbSBmNzA1ZmU2YTIxYmQyN2YxN2I1ZTEzMjM5OTA5YTA4M2I5YTg4N2IxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUcm95IEhpbmNrbGV5IDx0Lm1hY21hbkBnbWFpbC5jb20+CkRh dGU6IFdlZCwgMTYgSmFuIDIwMTkgMTQ6NDc6MDcgLTA4MDAKU3ViamVjdDogW1BBVENIXSBSZW1v dmUgY29tcGlsYXRpb24tYnVmZmVyLW5hbWUtZnVuY3Rpb24gZnJvbSBkZXJpdmVkIG1vZGUKCkJl Y2F1c2UgdGhpcyB2YXJpYWJsZSBpcyB1c2VkIHRvIGNyZWF0ZSB0aGUgYnVmZmVyIG5hbWUsIHdo aWNoIGhhcHBlbnMKYmVmb3JlIHRoZSBtYWpvci1tb2RlIGlzIGxvYWRlZCwgb3ZlcnJpZGluZyBp dCB3aXRoIGEgbW9kZSBzcGVjaWZpYwp2ZXJzaW9uIGlzIGluZWZmZWN0dWFsLgotLS0KIGxpc3Av cHJvZ21vZGVzL2NvbXBpbGUuZWwgfCAzICstLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2NvbXBpbGUu ZWwgYi9saXNwL3Byb2dtb2Rlcy9jb21waWxlLmVsCmluZGV4IDM2NTBiMDU2MDcuLmUxMzVjZDNh MjggMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2NvbXBpbGUuZWwKKysrIGIvbGlzcC9wcm9n bW9kZXMvY29tcGlsZS5lbApAQCAtMjA2Niw4ICsyMDY2LDcgQEAgYnkgcmVwbGFjaW5nIHRoZSBm aXJzdCB3b3JkLCBlLmcuLCBgY29tcGlsYXRpb24tc2Nyb2xsLW91dHB1dCcgZnJvbQogCQkJICAg IChpZiAoYm91bmRwICdieXRlLWNvbXBpbGUtYm91bmQtdmFyaWFibGVzKQogCQkJCShtZW1xIChj ZHIgdikgYnl0ZS1jb21waWxlLWJvdW5kLXZhcmlhYmxlcykpKQogCQkJYChzZXQgKG1ha2UtbG9j YWwtdmFyaWFibGUgJywoY2FyIHYpKSAsKGNkciB2KSkpKQotCQkgJyhjb21waWxhdGlvbi1idWZm ZXItbmFtZS1mdW5jdGlvbgotCQkgICBjb21waWxhdGlvbi1kaXJlY3RvcnktbWF0Y2hlcgorCQkg Jyhjb21waWxhdGlvbi1kaXJlY3RvcnktbWF0Y2hlcgogCQkgICBjb21waWxhdGlvbi1lcnJvcgog CQkgICBjb21waWxhdGlvbi1lcnJvci1yZWdleHAtYWxpc3QKIAkJICAgY29tcGlsYXRpb24tZXJy b3ItcmVnZXhwLWFsaXN0LWFsaXN0Ci0tIAoyLjEyLjAKCg== --000000000000486c210584c2ec3a-- From unknown Fri Jun 13 11:48:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34956: Fix for define-compilation-mode Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Apr 2019 23:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Troy Hinckley Cc: 34956@debbugs.gnu.org Received: via spool by 34956-submit@debbugs.gnu.org id=B34956.15544213342618 (code B ref 34956); Thu, 04 Apr 2019 23:43:01 +0000 Received: (at 34956) by debbugs.gnu.org; 4 Apr 2019 23:42:14 +0000 Received: from localhost ([127.0.0.1]:44810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCBzp-0000g5-Lc for submit@debbugs.gnu.org; Thu, 04 Apr 2019 19:42:13 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:42163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCBzm-0000fn-W0; Thu, 04 Apr 2019 19:42:11 -0400 Received: by mail-qt1-f175.google.com with SMTP id p20so5394912qtc.9; Thu, 04 Apr 2019 16:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZnKt5XTE1a/2Bv8RU14yqRGY9krckzRG45Sifry56vY=; b=Ivbb869MfKRzDIP0s8Qskj8yZ49MiKKthKIFQcxW3qKHFIEtZ2ADiTJ7so6rvkt+Bh IWWLKBTQ8+O19Cj/fQFFqX9gM0G8cJL2soxoiK5pRVu0O1cqH3628UWcBE7hzBUvFUs8 RUdL5SPjgjxXX4E6RAhvEbsXS2cPzi0gJ5JrANiym0gNoBxdh7hEq8A9T/N5Z7/8yT11 f7ev69dSDcSrEg7ZYIr0I415a4crOBSwU6k5L7S8I9px/xKifGt+x1EDkYGXk31Y7Ohq Kb4TuNTraZ6yvATMNia+zI4PqZR/eU2SI6/zmt3IJCUKUxp7qxoBUBLMjDiNPl+p/XV2 AhBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ZnKt5XTE1a/2Bv8RU14yqRGY9krckzRG45Sifry56vY=; b=M8MQch5Ygi8LfjmKrM4vPY0qNnw7HYJMZ022qsKx+SC7MSOJXVZzOXlmhJHOCc28Zv KpIX5t3sSA6illSXM6foIS4zDQ3CAinEoXjmnDhR/gI4V0KjGkxgTh7/xITD4OXQAF8q EdNhZ0QDFA4TElsmBvZCYVkE7ZiE+WnTL+dFLaeBCTD0n8kLTYW6ZpTEESJ22TZPU1JL yLq7MMX2cPgW7vpVC4LfZVGLAwCRBE76Ldg6f0gFqyF5mhvjWRm/DnwWMFYfEqc5Xxcr yrCThsxpd/pw5DxsCs7QdthYBFmbgjqPqMCJE9pv22E1KE24v20cF2Qbz+DaG8BDeZiu WF9A== X-Gm-Message-State: APjAAAUF+8HBj0iiPfygME9rQJmqLVQBLkmu6CFRnFNGZ2YCMSFfYrw4 iEoxXE4tmTuAYO2bWUR5OpeRbnhM X-Google-Smtp-Source: APXvYqx8i+QXWH8U5JD/3ZIO9BzZmC2gEEDOYujAobtWEfBJ3i2pKnbPTEDqaTEXXbBtuyBE+Va8ww== X-Received: by 2002:a0c:9dc1:: with SMTP id p1mr7196552qvf.60.1554421325441; Thu, 04 Apr 2019 16:42:05 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i11sm10242632qkg.33.2019.04.04.16.42.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Apr 2019 16:42:04 -0700 (PDT) From: Noam Postavsky References: Date: Thu, 04 Apr 2019 19:42:03 -0400 In-Reply-To: (Troy Hinckley's message of "Sat, 23 Mar 2019 07:26:34 -0600") Message-ID: <87h8bde3sk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 34956 minor tags 34956 fixed close 34956 27.1 quit Troy Hinckley writes: > This a is small patch that removes compilation-buffer-name-function-from > define-compilation-mode. compilation-buffer-name-function is used before > the major-mode is loaded, therefore overriding it in > define-compilation-mode is ineffectual. Removing it from the list of > overridden variables will ensure that it is not mistaken for a variable > that can be major mode specific. Also the function compilation-start takes > an optional argument name-function, so there is already a mechanism to > override it. Pushed to master. [1: 905f619519]: 2019-04-04 19:39:42 -0400 Don't check comp-buffer-name-function in derived mode (Bug#34956) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=905f6195191a518b7bb2dbdf6eacae41d31fc54e