From unknown Fri Jun 13 09:57:31 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34954 <34954@debbugs.gnu.org> To: bug#34954 <34954@debbugs.gnu.org> Subject: Status: 26.1.92; eshell gets loaded twice Reply-To: bug#34954 <34954@debbugs.gnu.org> Date: Fri, 13 Jun 2025 16:57:31 +0000 retitle 34954 26.1.92; eshell gets loaded twice reassign 34954 emacs submitter 34954 Mauro Aranda severity 34954 minor tag 34954 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 23 11:06:24 2019 Received: (at submit) by debbugs.gnu.org; 23 Mar 2019 15:06:24 +0000 Received: from localhost ([127.0.0.1]:55661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7iE4-0005zH-AM for submit@debbugs.gnu.org; Sat, 23 Mar 2019 11:06:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7iE0-0005z2-MP for submit@debbugs.gnu.org; Sat, 23 Mar 2019 11:06:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:37610) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7iDs-0000ZJ-LZ for submit@debbugs.gnu.org; Sat, 23 Mar 2019 11:06:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7iDq-0006AK-M5 for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 11:06:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7iDn-0000R7-6C for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 11:06:09 -0400 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:39216) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h7iDm-0000Ci-H2 for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 11:06:07 -0400 Received: by mail-lj1-x233.google.com with SMTP id l7so4348035ljg.6 for ; Sat, 23 Mar 2019 08:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=/CsXMHh4OQsLdXpVwdc5UwXpJsPFr1crDSTht5bNGGM=; b=gbCWsi6ACDguIOO+6yte2p6UaKLNWD9PhY750apdXbyawl7tBLehVCY0fqbcQdNdyh iiNricBBvCaUxGCml4ugfNTWMGHkaUuvVFb5QFM8842L5dRsWEBCejEUPb6CqKOSETQk ZJQUArDVsGgNr/P+L31RlnK1xVzNT+oPtnUkaNOfHEE9ivCBg5tgqHx401QVUhzXu3+A +JKVFCV/BbI7QZiFgg1WM8FGRiGCV5ILA9gT9l6Eb1HRb6Qw6KbHwx8Mn+MO2cYNDTBP ILxYH6+6UP4ca5jMhtMdP552HN8wgji+g7ye0goxk1PGsVAZ4e+G+cMcU/av2pRQN2IQ RSPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=/CsXMHh4OQsLdXpVwdc5UwXpJsPFr1crDSTht5bNGGM=; b=Uy1nnV7HI+p9+2MrMXBmSl6cXZcVu9yF9F/obwC/9jKg09OGlAQWcwIfOKHdYFf2oY 2q02UQaCGEavGtOzTiv7yqzZhyNBUN2A6POZBQTqRyeGkFojPAkUwvUIwmwFV/YYak9+ UXR19OwcXiLlCoAJOnkkPOxv5hSfr9nF55Nlr68G6uvKEuIRv+kg5MpN9qlklNqm71/5 yR29bmXo90THPciH3elno97twIrQUIBJq4MPArdKmBXHz6GoQH/8OE/vNhpByM03PZnY qvk5nZfPqB9DiaLQK51YZtkomgWqt3tY5y1OFhfVEvhOiqsmB5myd1HPnzRjHtdxZ5+6 GCww== X-Gm-Message-State: APjAAAUgxRrTTduekBzkMW3Ij6Kdo5SHdVFEFmRWl8oo0wckAbOoJYEB GPtpPxTt6V74qv20S5pbPgZiKHcekO7n9bXBArEQpQ== X-Google-Smtp-Source: APXvYqxPCEgZqPNRxnMxYr+HtzmG1Pabn/Vk8h1ZIlL4yokIHcVVrIVxoTh+EAD6mOHLwzVKxCMtZej8KsWNcNeozRM= X-Received: by 2002:a2e:3506:: with SMTP id z6mr8169789ljz.72.1553353557278; Sat, 23 Mar 2019 08:05:57 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:2b53:0:0:0:0:0 with HTTP; Sat, 23 Mar 2019 08:05:56 -0700 (PDT) From: Mauro Aranda Date: Sat, 23 Mar 2019 12:05:56 -0300 Message-ID: Subject: 26.1.92; eshell gets loaded twice To: bug-gnu-emacs Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::233 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello Emacs. I was messing around with eshell hooks when I encountered this bug. This behavior is present in a fairly recent build of emacs 26 and in master as well. Here's a recipe: 1) Start emacs: emacs -Q. 2) On *scratch* buffer, write the following expressions: The function can be whatever indicates a duplicate (I keep it simple for myself): (defun eshell-loaded-msg () (insert "Eshell was loaded.\n")) (add-hook 'eshell-load-hook 'eshell-loaded-msg) 3) M-x eval-buffer 4) M-x eshell 5) After Eshell gets loaded, type C-x b RET to go back to *scratch* buffer. 6) Notice that "Eshell was loaded" appears twice. My conclusion is that eshell gets loaded twice, becuase eshell.el requires esh-mode, which requires esh-module, which in turn requires eshell. Since this require expression comes before the provide expresion (provide 'eshell) in eshell.el, eshell gets loaded twice. In GNU Emacs 26.1.92 (build 1, i686-pc-linux-gnu, GTK+ Version 3.18.9) of 2019-03-22 built on the-blackbeard Repository revision: 24fc1337c169aeb1095dcc58bf8d4bbe48abefc0 Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 16.04.6 LTS Recent messages: Loading em-basic...done Loading em-cmpl...done Loading em-dirs...done Loading em-glob...done Loading em-hist...done Loading em-ls...done Loading em-prompt...done Loading em-script...done Loading em-term...done Loading em-unix...done Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LCMS2 Important settings: value of $LANG: en_US.utf8 value of $XMODIFIERS: locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils em-unix em-term term disp-table easymenu ehelp em-script em-prompt em-ls cl-loaddefs cl-lib em-hist em-pred em-glob em-dirs em-cmpl em-basic em-banner em-alias pcomplete comint ansi-color ring esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg esh-groups eshell esh-module esh-mode esh-util elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 111308 10030) (symbols 24 22085 1) (miscs 20 57 161) (strings 16 33578 1765) (string-bytes 1 938325) (vectors 12 17691) (vector-slots 4 564929 12642) (floats 8 56 61) (intervals 28 231 1) (buffers 536 12) (heap 1024 32162 939)) From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 23 11:14:23 2019 Received: (at 34954) by debbugs.gnu.org; 23 Mar 2019 15:14:23 +0000 Received: from localhost ([127.0.0.1]:55667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7iLn-0006Aa-9d for submit@debbugs.gnu.org; Sat, 23 Mar 2019 11:14:23 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:37840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7iLl-0006AO-VX for 34954@debbugs.gnu.org; Sat, 23 Mar 2019 11:14:22 -0400 Received: by mail-lj1-f171.google.com with SMTP id v13so4365480ljk.4 for <34954@debbugs.gnu.org>; Sat, 23 Mar 2019 08:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=I82Gyok/cRkoMu/UU209B9j081rLFC2VSGAzJum6xJU=; b=eQcUosaRrqXaIiYyMKIyUZzth4kjCF4FJnAj1Fa2q1YjdI1bnHp350LATOy1/IjHpq gVnb41Bw4UpdlrR1Xb3shAZ/KAIwsLO/rXEXPoFcWi+ZGbPcU8W53F+pQtgvvt1SMgua dVHp8i0bYV47xoKBkGmnB0eMKGC8MZKOi1o+4/PmCecVsyumuCgiN1Jh79iIZ3xt3GMv 8ikpgzPNLIPM7VlMzh1mGbr7rHRy4YNfWMvXsMnB9N+7fa/TdSUV9Fg5lNQSGtV+QjFk YQINK5gFELrMmES5G3X2L0dL9ysEaa+Cr9Q+vSd1ZTP4c4p+xgcZyaab2raqGEnF9mmJ yxZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=I82Gyok/cRkoMu/UU209B9j081rLFC2VSGAzJum6xJU=; b=ERxXXeY6EBjsITxL6F21+9lQmWuDdeE42izRl0QQwXlZmwV9vRGvD12wniOsGszXNI LW29IB0PFP+1ybQOiNtBKrEtn1MJhz/HAVP2kHaxEmw5IHebroS6qo/MC0LLxhsRmTyU d3nVBFOf2nufKwp0I2yeLQTbBy1Km60x+MvqQbtMgdh7GfZFlK7XxL/O32zuNKEVuMn7 8JLVQ9UYc9Zpi4gwNdtbZz42qz1rbLuXAbsX4sGbO/BHubHjkybtpAShaaEGd0HHs4lf Ex4axq5pA0SArDWodtSS19mKkjZe6SyAwjVuKrpngJsJOOIDprKkhGSRVsOb2HajjzK7 l29g== X-Gm-Message-State: APjAAAWNtbs29eL4zbjnchPZ7CGljgC0Nn4U6knfiWTegSxfoUFmqFA0 kw4nCxLCw8JNatyYXUBQ2hNEynrYnhfVQ/BKot0Ctw== X-Google-Smtp-Source: APXvYqxvwguy0f2G9WiZ2hT+UDUXP6NVv0kxijW5kAVcSYg25oUXqMZPD4TV4+SXQ/enWNw4ddJ61u0YkN19A188mf8= X-Received: by 2002:a2e:5cc3:: with SMTP id q186mr8395522ljb.23.1553354055830; Sat, 23 Mar 2019 08:14:15 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:2b53:0:0:0:0:0 with HTTP; Sat, 23 Mar 2019 08:14:14 -0700 (PDT) In-Reply-To: References: From: Mauro Aranda Date: Sat, 23 Mar 2019 12:14:14 -0300 Message-ID: Subject: Re: bug#34954: 26.1.92; eshell gets loaded twice To: 34954@debbugs.gnu.org Content-Type: multipart/mixed; boundary="000000000000b56d3c0584c46c7b" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34954 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b56d3c0584c46c7b Content-Type: text/plain; charset="UTF-8" The attached patch fixes it for me, but maybe someone with more insight can provide a better solution. --000000000000b56d3c0584c46c7b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Avoid-recursive-load-of-eshell.patch" Content-Disposition: attachment; filename="0001-Avoid-recursive-load-of-eshell.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 RnJvbSA1NDc0ZTc4OTE2NzhkMDk1N2E4NTUyYmMyNzYxNjA4ZWY3MWIxNTMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFNhdCwgMjMgTWFyIDIwMTkgMTE6Mzg6MTQgLTAzMDAKU3ViamVjdDogW1BBVENIXSBB dm9pZCByZWN1cnNpdmUgbG9hZCBvZiBlc2hlbGwKCiogbGlzcC9lc2hlbGwvZXNoZWxsLmVsOiBQ cm92aWRlIGVzaGVsbCBiZWZvcmUgcmVxdWlyaW5nIGVzaC1tb2RlIHRvCmF2b2lkIGEgcmVjdXJz aXZlIGxvYWQgd2hlbiBlc2gtbW9kZSByZXF1aXJlcyBlc2gtbW9kdWxlICh3aGljaCBpbgp0dXJu IHJlcXVpcmVzIGVzaGVsbCkuICAoQnVnICMzNDk1NCkKVGhpcyBidWcgc2hvd3MgdXAgYmVjYXVz ZSAnZXNoZWxsLWxvYWQtaG9vaycgaXMgcnVuIHR3aWNlLgotLS0KIGxpc3AvZXNoZWxsL2VzaGVs bC5lbCB8IDUgKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZXNoZWxsLmVsIGIvbGlzcC9lc2hlbGwv ZXNoZWxsLmVsCmluZGV4IDQ1MTY4MDAuLmM3ZWQ3MTAgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxs L2VzaGVsbC5lbAorKysgYi9saXNwL2VzaGVsbC9lc2hlbGwuZWwKQEAgLTE3NSw2ICsxNzUsOSBA QAogKGV2YWwtd2hlbi1jb21waWxlCiAgIChyZXF1aXJlICdjbC1saWIpKQogKHJlcXVpcmUgJ2Vz aC11dGlsKQorOzsgUHJvdmlkZSBlc2hlbGwgYmVmb3JlIHJlcXVpcmluZyBlc2gtbW9kZSwgdG8g YXZvaWQgYSByZWN1cnNpdmUgbG9hZC4KKzs7IChCdWcgIzM0OTU0KQorKHByb3ZpZGUgJ2VzaGVs bCkKIChyZXF1aXJlICdlc2gtbW9kZSkKIAogKGRlZmdyb3VwIGVzaGVsbCBuaWwKQEAgLTQwMyw2 ICs0MDYsNCBAQCBlc2hlbGwtdW5sb2FkLWFsbC1tb2R1bGVzCiAKIChydW4taG9va3MgJ2VzaGVs bC1sb2FkLWhvb2spCiAKLShwcm92aWRlICdlc2hlbGwpCi0KIDs7OyBlc2hlbGwuZWwgZW5kcyBo ZXJlCi0tIAoyLjcuNAoK --000000000000b56d3c0584c46c7b-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 08:31:40 2019 Received: (at 34954) by debbugs.gnu.org; 27 Mar 2019 12:31:40 +0000 Received: from localhost ([127.0.0.1]:60952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h97iW-00023Q-G4 for submit@debbugs.gnu.org; Wed, 27 Mar 2019 08:31:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h97iU-00023D-R9 for 34954@debbugs.gnu.org; Wed, 27 Mar 2019 08:31:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44748) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h97iP-0005cS-DK; Wed, 27 Mar 2019 08:31:33 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1h97iN-0000nD-SM; Wed, 27 Mar 2019 08:31:32 -0400 From: Glenn Morris To: Mauro Aranda Subject: Re: bug#34954: 26.1.92; eshell gets loaded twice References: X-Spook: halcon Tremor Mud slide SBI DES Contamination Indigo X-Ran: ]K@JP/j3VN'%>@_GJx/R:LSh51~f%td0JhIHU[lH#XKn,}HRl6"h1C~:&Cdcr40uK[<]H$ X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 27 Mar 2019 08:31:31 -0400 In-Reply-To: (Mauro Aranda's message of "Sat, 23 Mar 2019 12:05:56 -0300") Message-ID: <2himw4qz18.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34954 Cc: 34954@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) For the specific issue of the load-hook, see https://debbugs.gnu.org/24491#8 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 09:51:36 2019 Received: (at 34954) by debbugs.gnu.org; 27 Mar 2019 13:51:36 +0000 Received: from localhost ([127.0.0.1]:60989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h98xq-0003yv-DH for submit@debbugs.gnu.org; Wed, 27 Mar 2019 09:51:34 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:35407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h98xo-0003yi-C0 for 34954@debbugs.gnu.org; Wed, 27 Mar 2019 09:51:32 -0400 Received: by mail-lf1-f46.google.com with SMTP id u21so11439364lfu.2 for <34954@debbugs.gnu.org>; Wed, 27 Mar 2019 06:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=cKEIss2Q/O588ZFGu0GreiQA9HSgZeKzcUYsL2x8+d8=; b=LU5XNdDjgz6+rTpJuocGsee5guR/oC64DA/pjochuSyo/09QTeRZ6MKeQq4PWFTE8A b2glesRcmQviAZWIMWIyvL+rwJ+nbBcBXfoT82ZzafBdVnQDj3rSBA6immpW6PAH44NO eoM/HCOp+7Rg07YB0cR+5rndKcrzhGdlfmE3Enq90ftN5b/d73LwtqJFoPp/c+PCL2jS UDoZAARmWLhOOpAMkYKlSMumvS4cnAs7ObQbHaMW3p3GtFkwx4OhCZbLIqFhqYNn7b9j f2CVgd2yeh7MFMHPqzWitMvp6H+/axhL/mDELf9sIVo4K5alHnXsq8eEm3RV7Wl7cZII L2SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=cKEIss2Q/O588ZFGu0GreiQA9HSgZeKzcUYsL2x8+d8=; b=sCawhIW4yF1TcIxST2rODIRv0mHm25bjVC6n36DPNKzYWJcVvV8Wy5ayX0zrrFtSz0 bHgCe3c1p/9SvKL3+lejxZ01ySSjxtOUosML/pudhJVv1EDsA7yFKvxGxCaMcf9X3/xY psuvD2zjiJr7NPyIQV9k/O1LyOxbttsq/YFS+4LHVEcc9Xqv5HRAsq3yXfa7XM468Q7H t3xRcLybRGG/3H9306Lxv2BP1fkP8EZib1FsTSVW4EZMlCTdSy8W9L2DoGVDoS3/LL78 16Gz7pmqlOyoS9dDM5CvpKHZ/OWwJkx2sUb5iUqBhAJx0BmYw99iw2ES52dUGsg8xMPN hTxQ== X-Gm-Message-State: APjAAAV/92nyld8RHJO//s8e4hIBl6xbVPD5KTQGW5/0NdvNnamc3BV3 rdhRuaCOcUPoFBZCBQ4U7VR4M1Hpw7b0BHDSqKailC+n X-Google-Smtp-Source: APXvYqyFBeiOSo5o+cdjrhGJzpNn0KCaJPpGqO6+6VZdOYSf1PDqukV9N9JP/0wkBaqSx9kxetsmesL0FhpHrwdmy5Y= X-Received: by 2002:a19:6d01:: with SMTP id i1mr18567375lfc.118.1553694685847; Wed, 27 Mar 2019 06:51:25 -0700 (PDT) MIME-Version: 1.0 References: <2himw4qz18.fsf@fencepost.gnu.org> In-Reply-To: <2himw4qz18.fsf@fencepost.gnu.org> From: Mauro Aranda Date: Wed, 27 Mar 2019 10:51:13 -0300 Message-ID: Subject: Re: bug#34954: 26.1.92; eshell gets loaded twice To: 34954@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000d6e49b058513bb34" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34954 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000d6e49b058513bb34 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry for the noise, I forgot to keep 34954@debbugs.gnu.org Hello Glenn. > For the specific issue of the load-hook, see https://debbugs.gnu.org/24491#8 Sorry I missed that bug report. Could both reports be merged? > You ought to be able to avoid such problems by using > (with-)eval-after-load instead of foo-load-hook, since the former runs > after provide (effectively). Your recommendation works, but only if the order is: (require 'eshell) (with-eval-after-load "eshell" (insert "Eshell was loaded.\n") When the order is: (with-eval-after-load "eshell" (insert "Eshell was loaded.\n") (require 'eshell) The string is inserted twice, because eshell is loaded twice. Is the former order recommended over the latter? Mandatory? I can't find that information on the manual. Of course, if I eval (starting from emacs -Q): (with-eval-after-load 'eshell (insert "Eshell was loaded.\n") And then type `M-x eshell' I get the repeated string inserted, because again, eshell is loaded twice. > Frankly all foo-load-hooks are probably historical baggage that should > be obsoleted. There's no need for them to exist given that a general > solution does. Anyway, my recipe was meant to provide evidence that eshell gets loaded twice. That still happens, either eshell-load-hook or with-eval-after-load is used in real code. It would be good to solve that double loading. That way, either eshell-load-hook (until it is obsoleted, if it eventually happens) or with-eval-after-load (any order of execution) can be used. Best Regards, Mauro. El mi=C3=A9., 27 mar. 2019 a las 9:31, Glenn Morris () escribi= =C3=B3: > > For the specific issue of the load-hook, see > https://debbugs.gnu.org/24491#8 > --000000000000d6e49b058513bb34 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry for the noise, I forgot to keep 34954@debbugs.gnu.org

Hello Glenn.=

> For the specific issue of the load-hook, see https://debbugs.gnu.org/24491#= 8

Sorry I missed that bug report.=C2=A0 Could both report= s be merged?

> You ought to be able to avoid such problems by usi= ng
> (with-)eval-after-load instead of foo-load-hook, since the forme= r runs
> after provide (effectively).

Your recommendation work= s, but only if the order is:
(require 'eshell)
(with-eval-after-l= oad "eshell" (insert "Eshell was loaded.\n")

Whe= n the order is:
(with-eval-after-load "eshell" (insert "E= shell was loaded.\n")
(require 'eshell)

The string is in= serted twice, because eshell is loaded twice.

Is the former order re= commended over the latter? Mandatory?=C2=A0 I can't
find that inform= ation on the manual.

Of course, if I eval (starting from emacs -Q):<= br>(with-eval-after-load 'eshell (insert "Eshell was loaded.\n&quo= t;)
And then type `M-x eshell' I get the repeated string inserted, b= ecause
again, eshell is loaded twice.

> Frankly all foo-load-hooks are pro= bably historical baggage that should
> be obsoleted. There's no n= eed for them to exist given that a general
> solution does.

An= yway, my recipe was meant to provide evidence that eshell gets loaded
tw= ice.=C2=A0 That still happens, either eshell-load-hook or
with-eval-afte= r-load is used in real code.=C2=A0 It would be good to solve
that double= loading.=C2=A0 That way, either eshell-load-hook (until it is
obsoleted= , if it eventually happens) or with-eval-after-load (any order
of execut= ion) can be used.


Best Regards,
Mauro.

El mi=C3=A9., 27 = mar. 2019 a las 9:31, Glenn Morris (<rgm@= gnu.org>) escribi=C3=B3:

For the specific issue of the load-hook, see https://debbugs.gnu.org/= 24491#8
--000000000000d6e49b058513bb34-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 22:55:21 2019 Received: (at 34954) by debbugs.gnu.org; 4 Apr 2019 02:55:21 +0000 Received: from localhost ([127.0.0.1]:43542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBsXB-00019p-1M for submit@debbugs.gnu.org; Wed, 03 Apr 2019 22:55:21 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]:46640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBsX9-00019X-54; Wed, 03 Apr 2019 22:55:19 -0400 Received: by mail-qt1-f178.google.com with SMTP id z17so1503957qts.13; Wed, 03 Apr 2019 19:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6S5AUHizo4+yqy4jsmiQRNOUxMPMH29AXkdXAmm0jVE=; b=U/JYfbxFhtA/d1irIsPfCMpMBiWDqsnS8g/NgtC+RMowOzUJA3E3b8oXePtsF9NfbK 1so6+rIVwSpVjwWP6jUpXq3JVv3G3B7P8V+anqM45VgqbgxqJArsUkUbimFg2rKO6vRN tKTgvfmvKMp3nM39nr97meF2Iwz2t89SKtWZtvC830O4AUsEMXPuo/eB+wmif/ppBDK/ uge7jd06Qhhf1oJDrcEwNvkte7w9jW1+y54XulOIF3bKU3iGpwCIBfd1ijdgvJ/m9pxK geIki0GI8Al79axk/8ggqIdYkjhSVdq8a0LeOvs2H0KeKGpHvUOxg6S28naim24VwJYf KTdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6S5AUHizo4+yqy4jsmiQRNOUxMPMH29AXkdXAmm0jVE=; b=UoFuPCn9Xv+l4AuNwlLnbH7jpg+vyRT21Ac3OdBQC6R8qo6vaPXoG2KQIvV4QEBI58 wR73Jn8VOxtuYlOqGsgzeFejcVu8SSn49b6Zud2VFbFNw6B+i8wHerlJCmZ0o0TYio6W ioOILNMO9usmfkLzxjnFs9nXck79O11HqR6UroP1OYUt2LNdQD7BC9+2WwV2POUxXrjI /FBoUW/swau+Ug30I6TRdDTyPUMMvlb4SCprd6QAcbPnrv/KBunkbns7lmd/Ld1zh6Ji k89ETeAuo5fP6ZKWpy5gx6fia9+fv6cJ2wQ3UUn9snaFprH6m4vxMm1fx96wUdKpxsNX RE8w== X-Gm-Message-State: APjAAAXR/VhUrKHcdVZTTkqxiMdDJn8sIuidvNwHwQesZZsPI8njG4Qn h9WpmPa6gRgsQCYpe2qjCF0ATaph X-Google-Smtp-Source: APXvYqwICnRFHvNMrlyYSm/bBNGF29XL6kT+5Rtvk934MuczD9yDFe56sIxo//7tHlXvoBZfBmgR2w== X-Received: by 2002:ac8:2f96:: with SMTP id l22mr3295417qta.258.1554346511834; Wed, 03 Apr 2019 19:55:11 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id y34sm8098760qta.96.2019.04.03.19.55.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 19:55:10 -0700 (PDT) From: Noam Postavsky To: Mauro Aranda Subject: Re: bug#34954: 26.1.92; eshell gets loaded twice References: <2himw4qz18.fsf@fencepost.gnu.org> Date: Wed, 03 Apr 2019 22:55:09 -0400 In-Reply-To: (Mauro Aranda's message of "Wed, 27 Mar 2019 10:51:13 -0300") Message-ID: <8736myfpiq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34954 Cc: 34954@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 34954 24491 tags 34954 fixed close 34954 27.1 quit Mauro Aranda writes: > > Anyway, my recipe was meant to provide evidence that eshell gets loaded > twice. That still happens, either eshell-load-hook or > with-eval-after-load is used in real code. It would be good to solve > that double loading. That way, either eshell-load-hook (until it is > obsoleted, if it eventually happens) or with-eval-after-load (any order > of execution) can be used. Yep, makes sense, I've pushed your patch [1: 5e55b1b829]. To your question about a better solution, I think it would require a major reorganizing of eshell's code to avoid circular requires, and we already have some prior art where some eshell have the provide at the top, so we may as well go with what you posted. [1: 5e55b1b829]: 2019-04-03 22:47:10 -0400 Avoid recursive load of eshell https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5e55b1b82952a03b704c464e8086d3c41e993a46 From unknown Fri Jun 13 09:57:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 02 May 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator