GNU bug report logs - #34953
Add xfce4-whiskermenu-plugin

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#34953: closed (Add xfce4-whiskermenu-plugin)
Date: Sun, 24 Mar 2019 22:06:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 24 Mar 2019 23:04:54 +0100
with message-id <8736ncszcp.fsf <at> gnu.org>
and subject line Re: [bug#34953] Add xfce4-whiskermenu-plugin
has caused the debbugs.gnu.org bug report #34953,
regarding Add xfce4-whiskermenu-plugin
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
34953: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34953
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: <pkill9 <at> runbox.com>
To: "guix-patches" <guix-patches <at> gnu.org>
Subject: Add xfce4-whiskermenu-plugin
Date: Sat, 23 Mar 2019 11:56:20 +0000 (GMT)

[Message part 3 (text/plain, inline)]

Attached is a patch that adds the Whiskermenu panel plugin for Xfce: https://goodies.xfce.org/projects/panel-plugins/xfce4-whiskermenu-plugin

I originally had GTK+ added as an input, and the configure phase searches for it, but since it builds fine without GTK+ I've removed it. If Garcon is removed then it errors on not finding GTK+, but I don't know, if it works then *shrug*.

[0001-gnu-Add-xfce4-whiskermenu-plugin.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: <pkill9 <at> runbox.com>
Cc: 34953-done <at> debbugs.gnu.org
Subject: Re: [bug#34953] Add xfce4-whiskermenu-plugin
Date: Sun, 24 Mar 2019 23:04:54 +0100

[Message part 6 (text/plain, inline)]

Hello,

<pkill9 <at> runbox.com> skribis:

> Attached is a patch that adds the Whiskermenu panel plugin for Xfce: https://goodies.xfce.org/projects/panel-plugins/xfce4-whiskermenu-plugin
>
> I originally had GTK+ added as an input, and the configure phase searches for it, but since it builds fine without GTK+ I've removed it. If Garcon is removed then it errors on not finding GTK+, but I don't know, if it works then *shrug*.

What happens is that GTK+ gets propagated via Garcon, which is why it
works even if you don’t add it as an input.  However, since this package
clearly has a direct dependency on GTK+, we should add it to ‘inputs’.

> From e7a99c0c1fea1549b08cd2e4a1c540a3a0091675 Mon Sep 17 00:00:00 2001
> From: Pkill -9 <pkill9 <at> runbox.com>
> Date: Sat, 23 Mar 2019 11:49:52 +0000
> Subject: [PATCH] gnu: Add xfce4-whiskermenu-plugin.
>
> * gnu/packages/xfce.scm (xfce4-whiskermenu-plugin): New variable.

Applied with the changes below.

Thank you!

Ludo’.

[Message part 7 (text/x-patch, inline)]

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index f716bd01eb..8543dcffed 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -427,17 +427,18 @@ keys for controlling the audio volume.")
     (inputs
      `(("xfce4-panel" ,xfce4-panel)
        ("garcon" ,garcon)
-       ("exo" ,exo)))
+       ("exo" ,exo)
+       ("gtk+" ,gtk+-2)))
     (arguments
       `(#:tests? #f)) ; no tests
     (home-page "https://goodies.xfce.org/projects/panel-plugins/xfce4-whiskermenu-plugin")
     (synopsis "Application menu panel plugin for Xfce")
     (description
-     "An alternative to the default application menu panel plugin for Xfce4.
-It uses separate sections to display categories and applications, and
-includes a search bar to search for applications.")
-    ;;The main plugin code is covered by gpl2, but files in panel-plugin directory
-    ;;are covered by gpl2+. The SVG icon is covered by gpl2.
+     "This package provides an alternative to the default application menu
+panel plugin for Xfce4.  It uses separate sections to display categories and
+applications, and includes a search bar to search for applications.")
+    ;; The main plugin code is covered by gpl2, but files in panel-plugin directory
+    ;; are covered by gpl2+.  The SVG icon is covered by gpl2.
     (license (list gpl2 gpl2+))))
 
 (define-public xfce4-xkb-plugin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.