Subject: bug#34953: closed (Re: [bug#34953] Add xfce4-whiskermenu-plugin)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 24 Mar 2019 22:06:02 +0000

Your bug report

#34953: Add xfce4-whiskermenu-plugin

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
34953: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34953
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#34953] Add xfce4-whiskermenu-plugin
From: Ludovic Courtès <[email-masked]>
To: <[email-masked]>
Cc: [email-masked]
Date: Sun, 24 Mar 2019 23:04:54 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

<[email-masked]> skribis:

> Attached is a patch that adds the Whiskermenu panel plugin for Xfce: https://goodies.xfce.org/projects/panel-plugins/xfce4-whiskermenu-plugin
>
> I originally had GTK+ added as an input, and the configure phase searches for it, but since it builds fine without GTK+ I've removed it. If Garcon is removed then it errors on not finding GTK+, but I don't know, if it works then *shrug*.

What happens is that GTK+ gets propagated via Garcon, which is why it
works even if you don’t add it as an input.  However, since this package
clearly has a direct dependency on GTK+, we should add it to ‘inputs’.

> From e7a99c0c1fea1549b08cd2e4a1c540a3a0091675 Mon Sep 17 00:00:00 2001
> From: Pkill -9 <[email-masked]>
> Date: Sat, 23 Mar 2019 11:49:52 +0000
> Subject: [PATCH] gnu: Add xfce4-whiskermenu-plugin.
>
> * gnu/packages/xfce.scm (xfce4-whiskermenu-plugin): New variable.

Applied with the changes below.

Thank you!

Ludo’.

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index f716bd01eb..8543dcffed 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -427,17 +427,18 @@ keys for controlling the audio volume.")
     (inputs
      `(("xfce4-panel" ,xfce4-panel)
        ("garcon" ,garcon)
-       ("exo" ,exo)))
+       ("exo" ,exo)
+       ("gtk+" ,gtk+-2)))
     (arguments
       `(#:tests? #f)) ; no tests
     (home-page "https://goodies.xfce.org/projects/panel-plugins/xfce4-whiskermenu-plugin")
     (synopsis "Application menu panel plugin for Xfce")
     (description
-     "An alternative to the default application menu panel plugin for Xfce4.
-It uses separate sections to display categories and applications, and
-includes a search bar to search for applications.")
-    ;;The main plugin code is covered by gpl2, but files in panel-plugin directory
-    ;;are covered by gpl2+. The SVG icon is covered by gpl2.
+     "This package provides an alternative to the default application menu
+panel plugin for Xfce4.  It uses separate sections to display categories and
+applications, and includes a search bar to search for applications.")
+    ;; The main plugin code is covered by gpl2, but files in panel-plugin directory
+    ;; are covered by gpl2+.  The SVG icon is covered by gpl2.
     (license (list gpl2 gpl2+))))
 
 (define-public xfce4-xkb-plugin

Subject: Add xfce4-whiskermenu-plugin
From: <[email-masked]>
To: "guix-patches" <[email-masked]>
Date: Sat, 23 Mar 2019 11:56:20 +0000 (GMT)
List-Id: <debbugs-submit.debbugs.gnu.org>

Attached is a patch that adds the Whiskermenu panel plugin for Xfce: https://goodies.xfce.org/projects/panel-plugins/xfce4-whiskermenu-plugin

I originally had GTK+ added as an input, and the configure phase searches for it, but since it builds fine without GTK+ I've removed it. If Garcon is removed then it errors on not finding GTK+, but I don't know, if it works then *shrug*.

From e7a99c0c1fea1549b08cd2e4a1c540a3a0091675 Mon Sep 17 00:00:00 2001
From: Pkill -9 <[email-masked]>
Date: Sat, 23 Mar 2019 11:49:52 +0000
Subject: [PATCH] gnu: Add xfce4-whiskermenu-plugin.

* gnu/packages/xfce.scm (xfce4-whiskermenu-plugin): New variable.
---
 gnu/packages/xfce.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 6c253849f6..f716bd01eb 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2017 Petter <[email-masked]>
 ;;; Copyright © 2017 ng0 <[email-masked]>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <[email-masked]>
+;;; Copyright © 2019 Pkill -9 <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29,6 +30,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix utils)
+  #:use-module (guix build-system cmake)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system trivial)
@@ -406,6 +408,38 @@ to an auto mixer tool like pavucontrol.  It can optionally handle multimedia
 keys for controlling the audio volume.")
     (license gpl2+)))
 
+(define-public xfce4-whiskermenu-plugin
+  (package
+    (name "xfce4-whiskermenu-plugin")
+    (version "2.3.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://archive.xfce.org/src/panel-plugins/"
+                                  name "/" (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1cnas2x7xi53v6ylq44040narhzd828dc0ysz8yk3qn2mmvp5yr2"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("intltool" ,intltool)))
+    (inputs
+     `(("xfce4-panel" ,xfce4-panel)
+       ("garcon" ,garcon)
+       ("exo" ,exo)))
+    (arguments
+      `(#:tests? #f)) ; no tests
+    (home-page "https://goodies.xfce.org/projects/panel-plugins/xfce4-whiskermenu-plugin")
+    (synopsis "Application menu panel plugin for Xfce")
+    (description
+     "An alternative to the default application menu panel plugin for Xfce4.
+It uses separate sections to display categories and applications, and
+includes a search bar to search for applications.")
+    ;;The main plugin code is covered by gpl2, but files in panel-plugin directory
+    ;;are covered by gpl2+. The SVG icon is covered by gpl2.
+    (license (list gpl2 gpl2+))))
+
 (define-public xfce4-xkb-plugin
   (package
     (name "xfce4-xkb-plugin")
-- 
2.21.0