GNU bug report logs - #34949
27.0.50; Docstring of `vc-deduce-fileset' incomplete

Previous Next

Package: emacs;

Reported by: Philipp Stephani <p.stephani2 <at> gmail.com>

Date: Fri, 22 Mar 2019 18:04:02 UTC

Severity: minor

Tags: confirmed, fixed

Found in version 27.0.50

Fixed in version 28.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log

Message #130 received at 34949 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 34949 <at> debbugs.gnu.org
Subject: Re: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete
Date: Wed, 25 Mar 2020 23:59:46 +0200

On 25.03.2020 00:36, Juri Linkov wrote:
> Finally settled with the following patch.

LGTM, thank you.

> Often this is a minor problem, but given the above, a keybinding
> like `* u' should be of a little help.

The follow-up patch from the next email look good as well.

> -    (bindings--define-key map [vc-dir]
> -      '(menu-item "VC Dir"  vc-dir
> -		  :help "Show the VC status of files in a directory"))
> +    (bindings--define-key map [vc-dir-root]
> +      '(menu-item "VC Dir"  vc-dir-root
> +		  :help "Show the VC status of the repository"))

This part, though... Is it intentional?

I'm all for it personally, but:

- It will need a NEWS entry.
- Are we comfortable with changing the menu entry to the new command, 
but keeping the old key binding pointing to the old command? Looks a bit 
inconsistent.
This bug report was last modified 5 years and 38 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.