GNU bug report logs - #34949
27.0.50; Docstring of `vc-deduce-fileset' incomplete

Previous Next

Package: emacs;

Reported by: Philipp Stephani <p.stephani2 <at> gmail.com>

Date: Fri, 22 Mar 2019 18:04:02 UTC

Severity: minor

Tags: confirmed, fixed

Found in version 27.0.50

Fixed in version 28.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log

Message #124 received at 34949 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 34949 <at> debbugs.gnu.org
Subject: Re: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete
Date: Wed, 25 Mar 2020 23:32:56 +0200

On 25.03.2020 22:47, Juri Linkov wrote:
> Ok, here's the patch that fixes these problems.
> 
> It moves that ugly piece of code to dired-vc-next-action
> (see the comment "Fix deficiency of Dired by adding slash to dirs")

That's what I was going to suggest.

Overall, the patch LGTM, please feel free to install, thank you.

> +     (when (member (expand-file-name (vc-dir-fileinfo->name filearg))
> +                   mark-files)

So MARK-FILES should all be absolute names? That should probably be 
documented.

Alternatively, you could use cl-member with :test #'file-equal-p.
This bug report was last modified 5 years and 38 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.