Subject: Re: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete

From: Juri Linkov <[email-masked]>
Date: Wed, 25 Mar 2020 23:50:58 +0200

>> > VC-Dir needs the same key prefix as is provided by Dired:
>> >
>> > * %             dired-mark-files-regexp
>> > * *             dired-mark-executables
>> > * /             dired-mark-directories
>> > * ?             dired-unmark-all-files
>> > * @             dired-mark-symlinks
>> > * s             dired-mark-subdir-files
>> >
>> > Then VC-Dir could provide, for example:
>> >
>> > * r             vc-dir-mark-registered
>> > * u             vc-dir-mark-unregistered
>> > ...
>
> Apologies for not following this thread (at all).
> Just happened to notice this message.
>
> `* u' is already bound to `dired-unmark', in Dired mode.

VC-Dir already significantly diverted from Dired.
so maybe such mismatch is not so crucial.

> It would be good if you found some other key for this,
> if the mode in question derives from `dired-mode'.

It is not derived from dired-mode in terms of implementation.
But if you can propose another key that is mnemonic then why not.

> To avoid other possible future problems, please consider
> putting all such vc-dired commands on a VC-marking prefix
> key, such as `* v'.

`* v' is not mnemonic for marking.  The character `*'
has such mnemonic because `*' *is* a marking char.

> E.g., use `* v u' for `vc-dir-mark-unregistered'.  `* v'
> is currently undefined for Dired, and that way Dired
> sacrifices only `* v', for possible Dired marking commands.