GNU bug report logs - #34948
[PATCH 0/3] Turn 'essential-services' into an <operating-system> field

Previous Next

Full log

View this message in rfc822 format

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 34948 <at> debbugs.gnu.org
Subject: [bug#34948] [PATCH 3/3] system: Add 'essential-services' field to <operating-system>.
Date: Tue, 26 Mar 2019 02:12:26 +0530

[Message part 1 (text/plain, inline)]

This neatly gets rid of all the #:container? arguments. That's very
nice! :-) I haven't actually built and tested these patches, but these
LGTM. Just one minor observation below.

> +  (cons (service system-service-type
> +                 (let ((locale (operating-system-locale-directory os)))
> +                   (with-monad %store-monad
> +                     (return `(("locale" ,locale))))))
> +        (append base (list %containerized-shepherd-service))))

Why not rewrite this using just a call to append, that is remove the
call to cons? Like so:

(append base
        (list (service system-service-type
                       (let ((locale (operating-system-locale-directory os)))
                         (with-monad %store-monad
                                     (return `(("locale" ,locale))))))
              %containerized-shepherd-service))

Or perhaps, this can be done with cons* also.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.