From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 11:12:16 2019 Received: (at submit) by debbugs.gnu.org; 22 Mar 2019 15:12:16 +0000 Received: from localhost ([127.0.0.1]:54597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7LqB-0006ja-Qv for submit@debbugs.gnu.org; Fri, 22 Mar 2019 11:12:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7Lq9-0006jM-7P for submit@debbugs.gnu.org; Fri, 22 Mar 2019 11:12:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:49984) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7Lq3-0001E2-UJ for submit@debbugs.gnu.org; Fri, 22 Mar 2019 11:12:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7Lq0-0003ol-Hd for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 11:12:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7Lpw-000149-Kv for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 11:12:04 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:32801) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h7Lpt-0000zu-Tg for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 11:12:00 -0400 Received: by mail-wm1-x32a.google.com with SMTP id z6so4536958wmi.0 for ; Fri, 22 Mar 2019 08:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=KogpmEMyKcJhjmghvOFX4rsJsWsndJg7GsDTsgB8vfE=; b=OjQ0WHQmv7uOb7U6FXeluc/MpkEV5T1zVhNaKRZD1zpH50LeoBmVdCxidLe8FtuVOP hoHCdaUJQqxzx+kxYPcJb1H5lVXGryyYbpsPKuD9Hru9yG5TV3SUN5s9FUy5IdXE7xOY DxUDTKsBqxvZB0ncBZqbnse8cfTSBcuJ2yTm7f5b1tAnugtgdjorvA7V1vkmVy5s3JyN wqs12YqkfcanxPDh6epZvCsp0lMtQ2gNB2E+YSd2wm6iaDvm/l9HCVzIp3F1Eyfl7kk0 FMHUbPh9EsIlgF33S4czx0qf/aIUioTV3WqD2ifXkjHPQnt4X+uxbWZaDkZfXCtoI6Z8 WLpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=KogpmEMyKcJhjmghvOFX4rsJsWsndJg7GsDTsgB8vfE=; b=iy9X73R6LwvcNSmXChhm9PN5lTU5Qy67GnPYH04bC4j5KsacYvmY0jjJoo7iObsDQi u8CIeODZIKvP0AAk0/iPjA9zo7VaSk22m9UMwpQLRWCg8/5sIFGtACO0JAhVD+B4tO8A GMUUcleqgppRTEq7i4Yy5/HbPM6QvGpb+xFhqWHKmUhIcWH98UPpBBFlSjk71AZ02zO9 Hwo+On9opgwsCNiNJnXtwEODxB/Lx4Z3AlysJm3CFKeNg5zbHaHt7CFb6bTM+sgDYI79 +XQeLcwofwURZzAltWkueQZ3OWWL3B2K4j/ivaEJnSFNi4efSKWZA8/FgbtTfikiksLV iD7Q== X-Gm-Message-State: APjAAAXV8tlbMfqJipUTgz/TplxrZtQDQEd9a60g4dvUpm9iuPBoSJha RdLUliOC1eR9qZi33alsjKgXAnJ9 X-Google-Smtp-Source: APXvYqwB10V0rqzg6Xp5qO6yEbxt/nLMuOzpdp0+MAPWkkNjXm+ArbbpIXRy9DUc+Iz6O6KLOjmlgQ== X-Received: by 2002:a7b:c743:: with SMTP id w3mr3003339wmk.75.1553267515446; Fri, 22 Mar 2019 08:11:55 -0700 (PDT) Received: from gabor.localnet (254C559E.nat.pool.telekom.hu. [37.76.85.158]) by smtp.gmail.com with ESMTPSA id r1sm6854611wrt.37.2019.03.22.08.11.53 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 08:11:54 -0700 (PDT) From: Braun =?ISO-8859-1?Q?G=E1bor?= To: bug-gnu-emacs@gnu.org Subject: 26.1; cua-mode: wrong type argument when activating rectangle Date: Fri, 22 Mar 2019 16:11:44 +0100 Message-ID: <11259231.O9o76ZdvQC@gabor> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32a X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, Ways to reproduce the bug: 1. Create the following .emacs file (it has been created by customizing some variables): Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: x.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (braungb88[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (braungb88[at]gmail.com) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Hi, Ways to reproduce the bug: 1. Create the following .emacs file (it has been created by customizing some variables): =2D------------------ .emacs ---------------------- (custom-set-variables ;; custom-set-variables was added by Custom. ;; If you edit it by hand, you could mess it up, so be careful. ;; Your init file should contain only one such instance. ;; If there is more than one, they won't work right. '(cua-mode t nil (cua-base)) '(cua-rectangle-mark-key [f7]) '(custom-enabled-themes nil)) (custom-set-faces ;; custom-set-faces was added by Custom. ;; If you edit it by hand, you could mess it up, so be careful. ;; Your init file should contain only one such instance. ;; If there is more than one, they won't work right. ) =2D------------------------------------------------ Start Emacs by the command: emacs -Q -l .emacs Select some text, then press F7, to be explicit, press the following three keystrokes (copied from the help buffer shown by `C-h l'): [previous-line] [previous-line] [cua-toggle-rectangle-mark] The following error message appears at the bottom: Wrong type argument: commandp, cua-toggle-rectangle-mark 2.a) A second way to reproduce the bug: Start Emacs via emacs -Q -f cua-mode --eval "(custom-set-variables '(cua-rectangle-mark- key [(f7)]))" and press the same three keys as above: S-up S-up f7. The same error messae appears. 2.b) The problem does not happen when in the command starting Emacs, the last two arguments are swapped, then the rectangle is activated as=20 expected. emacs -Q --eval "(custom-set-variables '(cua-rectangle-mark-key=20 [(f7)]))" -f cua-mode Suggested patch: Autoload the command mentioned in the error message. Library cua-base.el binds cua-toggle-rectangle-mark to a key in the :set function in (defcustom cua-rectangle-mark-key ...), so it should ensure that the command is defined. =2D-- lisp/emulation/cua-base.el 2018-12-15 09:08:18 +0100 +++ lisp/emulation/cua-base.el 2019-03-09 09:08:18 +0100 @@ -592,6 +592,7 @@ (autoload 'cua-set-rectangle-mark "cua-rect" "Start rectangle at mouse click position." t nil) +(autoload 'cua-toggle-rectangle-mark "cua-rect" nil t) ;; Stub definitions until it is loaded (defvar cua--rectangle) The rest is not part of the patch. System information: In GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.4) of 2019-02-03, modified by Debian built on zam904 Windowing system distributor 'The X.Org Foundation', version=20 11.0.12003000 System Description: Debian GNU/Linux buster/sid Recent messages: =46or information about GNU Emacs and the GNU system, type C-h C-a. Cua mode enabled Mark set command-execute: Wrong type argument: commandp, cua-toggle-rectangle- mark Type M-x delete-other-windows to delete the help window. Making completion list... Configured using: 'configure --build x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/lib --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/share/man --enable-libsystemd --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/26.1/site- lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/26.1/site-lisp:/ usr/share/emacs/site-lisp --with-sound=3Dalsa --without-gconf --with-mailutils --build x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/lib --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/share/man --enable-libsystemd --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/26.1/site- lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/26.1/site-lisp:/ usr/share/emacs/site-lisp --with-sound=3Dalsa --without-gconf --with-mailutils --with-x=3Dyes --with-x-toolkit=3Dgtk3 --with-toolkit-scroll-bars 'CFLAGS=3D-g -O2 -fdebug-prefix-map=3D/build/emacs-26.1+1=3D. -fstack-protector-strong -Wformat -Werror=3Dformat-security -Wall' 'CPPFLAGS=3D-Wdate-time -D_FORTIFY_SOURCE=3D2' LDFLAGS=3D-Wl,-z,relro' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 THREADS LIBSYSTEMD LCMS2 Important settings: value of $LANG: hu_HU.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: delete-selection-mode: t cua-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. =46eatures: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-mode easymenu cl-loaddefs cl-lib cus-start cus-load delsel cua-base elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 107807 14804) (symbols 48 21486 1) (miscs 40 66 204) (strings 32 30425 1350) (string-bytes 1 782154) (vectors 16 14931) (vector-slots 8 500152 12640) (floats 8 61 221) (intervals 56 284 0) (buffers 992 13)) Best wishes, G=C3=A1bor From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 15 21:11:09 2019 Received: (at 34947) by debbugs.gnu.org; 16 Apr 2019 01:11:09 +0000 Received: from localhost ([127.0.0.1]:35950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGCcv-0006bH-72 for submit@debbugs.gnu.org; Mon, 15 Apr 2019 21:11:09 -0400 Received: from mail-qt1-f180.google.com ([209.85.160.180]:42894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGCcs-0006ah-B1; Mon, 15 Apr 2019 21:11:06 -0400 Received: by mail-qt1-f180.google.com with SMTP id p20so21485628qtc.9; Mon, 15 Apr 2019 18:11:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=mIT8GRcBJtgPPzQ6SmbJ4Mq781Fj0IE9v/Yo6kwZ9lw=; b=ekzJhdDlUgKUtC50GUK5DpJJtQW9On5Qxhn5wLXcMRjvbNswLEBzK7Y/DpcEaAldbU vroDmkR1OD6WMrn56PBUvSHBE51PepCWMl2ymPpVYmmkXtvS7ZKbCVSaNOxNkvndEFbH RePD45P7YwV+T+6CsMD3ixGIaqg1JV6epVM+qlxw3MrnD8BmoiZwEmdyxFjYdwbY1Ohi 26dwsGHAs5CtMMzep8BNzX9esWqimnYRISMkV4+C69ubx1DzN6NL2YaHF5eJfikP8vZF 71GQxhd5W1/gfS70u/ht41xtvXnx5eOZlqZsPWnlqZqcxNjbZkvDMBsAQGnHqHZJYCkU KwvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=mIT8GRcBJtgPPzQ6SmbJ4Mq781Fj0IE9v/Yo6kwZ9lw=; b=MEYJ9itJUNZiSiDvSkVuOtvvfKPKHX0RbiahuXMrhPKoGOnPUNqIthwyh0FU++EXjr KxBH01IU0ZJ9VCdBW+iYLyKJar/dy9bAp4Det5LjEm74fcX5cqUfhTRsFSGDuqyn4IXn Bqi3pSXXBv3p28/5TCorqs9v/BIERQ2tQ+rOstjPzooukvBYjyGmE2uX7My1+pa6Jb68 ixrrPyBHe2FfDxVp97u6hJfj2El+zqK+AfuTPx1bi5Gk3gkPnZZ24Qh8hi14ly8WXZHG xjebxogknUejx70kg89YmBvPGjQfufFUnI7RjL4BmQSmd0PXMukfnTMA6dUQ3slkfwu3 5eXw== X-Gm-Message-State: APjAAAVaPUzvvQJEH8cySsFPSQxQ/FPCT3fPYu5PxFlVJWtp39xaq47F xUVBWP0fgkAgBFZvK6wGR/h594D0 X-Google-Smtp-Source: APXvYqxMdPxd+X9LWAv08nDLhG/wZ4ROkR9ckkR+j90mf6NyH/cgo6DfVe29Gt8qvV/YJ8NXBP5AIg== X-Received: by 2002:ac8:294c:: with SMTP id z12mr64933010qtz.79.1555377060776; Mon, 15 Apr 2019 18:11:00 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id h13sm16951340qkj.96.2019.04.15.18.10.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Apr 2019 18:10:59 -0700 (PDT) From: Noam Postavsky To: Braun =?utf-8?Q?G=C3=A1bor?= Subject: Re: bug#34947: 26.1; cua-mode: wrong type argument when activating rectangle References: <11259231.O9o76ZdvQC@gabor> Date: Mon, 15 Apr 2019 21:10:58 -0400 In-Reply-To: <11259231.O9o76ZdvQC@gabor> ("Braun \=\?utf-8\?Q\?G\=C3\=A1bor\=22's\?\= message of "Fri, 22 Mar 2019 16:11:44 +0100") Message-ID: <87bm16zrdp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34947 Cc: 34947@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 34947 minor tags 34947 + patch quit Braun G=C3=A1bor writes: > Suggested patch: > > Autoload the command mentioned in the error message. > Library cua-base.el binds cua-toggle-rectangle-mark to a key > in the :set function in (defcustom cua-rectangle-mark-key ...), > so it should ensure that the command is defined. > > --- lisp/emulation/cua-base.el 2018-12-15 09:08:18 +0100 > +++ lisp/emulation/cua-base.el 2019-03-09 09:08:18 +0100 > @@ -592,6 +592,7 @@ > > (autoload 'cua-set-rectangle-mark "cua-rect" > "Start rectangle at mouse click position." t nil) > +(autoload 'cua-toggle-rectangle-mark "cua-rect" nil t) > > ;; Stub definitions until it is loaded > (defvar cua--rectangle) Looks safe and sensible, I'll push to emacs-26 in a couple of days if there are no objections. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 19 15:27:40 2019 Received: (at 34947) by debbugs.gnu.org; 19 Apr 2019 19:27:40 +0000 Received: from localhost ([127.0.0.1]:44655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHZAi-0004Xn-5b for submit@debbugs.gnu.org; Fri, 19 Apr 2019 15:27:40 -0400 Received: from mail-qk1-f177.google.com ([209.85.222.177]:37789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHZAg-0004XV-1H; Fri, 19 Apr 2019 15:27:38 -0400 Received: by mail-qk1-f177.google.com with SMTP id c1so3419392qkk.4; Fri, 19 Apr 2019 12:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=HfQcDiuhx+eo5r/5E5+NL0RrL1bEe7WPpX2MUkMZ/1s=; b=M6D/83XpTxmtv+us96VSogI5vINnSuIYHgcuhTYytyeYSBN+fPk7uci3d/YiX+njrL 5dM8077dGI7W2YsZaR0XrHzgM3M9FaFgXXhXvQ82aBTqYRwhye6WpcY88tXIbOyTfEkg iIwmUVBjY36eLGfZC6A88pe0/J6uxa3Y8vOHwMcgBInFJY80V1hxiyUKJvDdd7W6Y10O vplFY2VQjtps26VKeORARX2dgCtg9k3qrp/yG2WSY+1yCRPp2V27gRwDPhj450lmjCbh oemvjBzsoRfa6qaUad/zdZj6OPxGJj1f/4KoortaJImVCeObiMq84sWS59aeEbEzNOZs 63JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=HfQcDiuhx+eo5r/5E5+NL0RrL1bEe7WPpX2MUkMZ/1s=; b=YYEY9IJX56/7uvCkx5Tv1WLx9LVPt5LecjivbzvhOrk0gHWNYCJyOIYC6xkNpHhVrl J7Ru/qwrNAikQTDonb1bZGJyCbEJDx1unJSJzww3SR+NTEeeYu0r9DyIfhxseJHVv9zd RlFpuFSCGFKO1nY22i9N1mHqZfoQikG/FawUdcXK5ucyKJQcBW99RCvuD3m9E0YIcuzX R+yhZQ4fgsIgUU5S3NfI9wGz6zW05Y8roBgPFl7AiQOGC0gjVYl1r1tkarrvlyqr058q GJPuDdFRu4XCMH4zA84AMlwep/1AnwnlG+TtMotEJ3Xog/if417C7oNkwVpilx9lEZtP xjTg== X-Gm-Message-State: APjAAAURuOuwKl2vKobZuoBHlT7GV0M8nt8rxMCfIKXooq+DQZUTfMg1 0ldeHo+oS+rqGw/HyNjB1KaKlfUy X-Google-Smtp-Source: APXvYqzqxIWuH77bsLVvsXPzmvLPYOOdN59rapjrf6Qai5m6g28TbZnkG2KRitW/6s2ofgbx40MnyQ== X-Received: by 2002:a05:620a:1410:: with SMTP id d16mr4389215qkj.22.1555702052266; Fri, 19 Apr 2019 12:27:32 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q51sm3812249qte.29.2019.04.19.12.27.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 12:27:31 -0700 (PDT) From: Noam Postavsky To: Braun =?utf-8?Q?G=C3=A1bor?= Subject: Re: bug#34947: 26.1; cua-mode: wrong type argument when activating rectangle References: <11259231.O9o76ZdvQC@gabor> <87bm16zrdp.fsf@gmail.com> Date: Fri, 19 Apr 2019 15:27:30 -0400 In-Reply-To: <87bm16zrdp.fsf@gmail.com> (Noam Postavsky's message of "Mon, 15 Apr 2019 21:10:58 -0400") Message-ID: <87bm11vlr1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34947 Cc: 34947@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 34947 fixed close 34947 26.3 quit >> +++ lisp/emulation/cua-base.el 2019-03-09 09:08:18 +0100 >> @@ -592,6 +592,7 @@ >> >> (autoload 'cua-set-rectangle-mark "cua-rect" >> "Start rectangle at mouse click position." t nil) >> +(autoload 'cua-toggle-rectangle-mark "cua-rect" nil t) >> >> ;; Stub definitions until it is loaded >> (defvar cua--rectangle) > > Looks safe and sensible, I'll push to emacs-26 in a couple of days if > there are no objections. Pushed. 598b45adbd 2019-04-19T15:19:45-04:00 "Autoload cua-toggle-rectangle-mark (Bug#34947)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=598b45adbd8cfc39cf797465ce57a5a50fe730d5 From unknown Sat Aug 09 09:36:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 18 May 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator