From unknown Sun Aug 10 09:45:47 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34944 <34944@debbugs.gnu.org> To: bug#34944 <34944@debbugs.gnu.org> Subject: Status: 27.0.50; FR: support amend in vc-hg Reply-To: bug#34944 <34944@debbugs.gnu.org> Date: Sun, 10 Aug 2025 16:45:47 +0000 retitle 34944 27.0.50; FR: support amend in vc-hg reassign 34944 emacs submitter 34944 Philipp Stephani severity 34944 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 06:56:18 2019 Received: (at submit) by debbugs.gnu.org; 22 Mar 2019 10:56:18 +0000 Received: from localhost ([127.0.0.1]:54020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7HqT-0004hi-Nt for submit@debbugs.gnu.org; Fri, 22 Mar 2019 06:56:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7HqR-0004hQ-Uz for submit@debbugs.gnu.org; Fri, 22 Mar 2019 06:56:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:49871) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7HqM-0000os-In for submit@debbugs.gnu.org; Fri, 22 Mar 2019 06:56:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7HqK-00028R-Hg for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 06:56:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7Hek-00041D-KO for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 06:44:12 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:54527) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h7Heh-0003o8-43 for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 06:44:10 -0400 Received: by mail-wm1-x32c.google.com with SMTP id f3so1650358wmj.4 for ; Fri, 22 Mar 2019 03:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=E8PEbAqYhGNPXdI4IbMf/QT8Av2TcFcDz3NpwX1eNgw=; b=DYmmf8J64gxXM36fwV0OAlPqIyo/1YUCXWdBR6Rmcu2nKLe1tgrNo85EmqcWtBJeM/ 9rqCPwqZxHKmAP+lZyNqs913fO/Z807mER8zU5eS8GAkv+4RGt9zTN714l3QkqmpJMeu 4AF31e8aCTy0Ij5O0zZ/wwMsT3FcovxyR3WuOTsNw+44nYNoitlmlQx8CToxj6tSx4gc wq/c5z3BMp+PaiJzkEklWcRWkVueGayz+4Qf2DKWhQYg9YQ9c7FZNXNoyVyjlzp4/bYG LJbCrB+rf4k4/DUgxYDXJMnZOeFLrxP6udex13aRDWW/nfExXR/pjh3gyVHWhVd9rwGf 76Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=E8PEbAqYhGNPXdI4IbMf/QT8Av2TcFcDz3NpwX1eNgw=; b=naLjEkBYFKdda3ZQYKWpaJC5d5kvudygLqoQSdWPvkn6Ebisw3w1+7yXkoFkzaPo6M xoBf8DtY9O28vdLZPD0S5C7ltijswGEl5LxRBid6U8lettO0ssKSyp4SDBMtswvuHbyW bKm9rYJ8KC8oBQqaUxqxw5prdcDBi0ETWKwjdyazVFlmTjjqTOpaAYyDHh00u7GbROKv JJFeJC5tIV9HGGwJ6Xeg/lXrO28OL+0zvb9be/to5HZ11W0tL0Dr/ySpvVNLZDp+C+4s STCEnTTcBzjnRwzpiDx1bZai4bkDCRK1kDOEIrFIATSBWSycSTfgw9FxH2lOQshhti1q RS1Q== X-Gm-Message-State: APjAAAXuY9x6rgo0SuizkNNvSfbMFetyuM/O0IF6oSOLjoYEsdk2VL7y CwEuu0J1M8bkF/ps6gklidYzii9P X-Google-Smtp-Source: APXvYqzKxOU6qmvxeTAXqEz3iKMnaAXi2NLrRqOtbdWBCTHmNdc4YmMxpR5Qxb/Yoo4LXj9PgVOMqQ== X-Received: by 2002:a1c:9ad6:: with SMTP id c205mr2493189wme.46.1553251445019; Fri, 22 Mar 2019 03:44:05 -0700 (PDT) Received: from phst-desktop.muc.corp.google.com ([2a00:79e0:15:10:da73:c08c:d5e2:512d]) by smtp.gmail.com with ESMTPSA id l26sm6300378wmj.41.2019.03.22.03.44.03 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 03:44:03 -0700 (PDT) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 27.0.50; FR: support amend in vc-hg Date: Fri, 22 Mar 2019 11:44:02 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32c X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The Git integration for vc.el supports amending commits via a magic changelog header. Mercurial has the same functionality, see https://www.mercurial-scm.org/wiki/EditingHistory#Amending_the_latest_ch [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: mercurial-scm.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (p.stephani2[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (p.stephani2[at]gmail.com) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) The Git integration for vc.el supports amending commits via a magic changelog header. Mercurial has the same functionality, see https://www.mercurial-scm.org/wiki/EditingHistory#Amending_the_latest_chang= eset_with_commit_--amend. If would be great to support this in Emacs as well. Maybe the Git approach could even move into main VC, and made available to all backends that support amending? In GNU Emacs 27.0.50 (build 56, x86_64-pc-linux-gnu, GTK+ Version 3.24.2) of 2019-03-22 Repository revision: 4174409c53d85a0def138f92d3e71901380c907a Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Debian GNU/Linux buster/sid Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars subr-x rx gnutls puny seq byte-opt gv bytecomp byte-compile cconv dbus xml cl-loaddefs cl-lib elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 59162 6704) (symbols 48 7776 1) (strings 32 20000 2289) (string-bytes 1 657624) (vectors 16 11264) (vector-slots 8 146496 8886) (floats 8 23 16) (intervals 56 211 0) (buffers 992 12)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado If you received this communication by mistake, please don=E2=80=99t forward= it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 09:18:28 2019 Received: (at 34944) by debbugs.gnu.org; 22 Mar 2019 13:18:28 +0000 Received: from localhost ([127.0.0.1]:54059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7K44-0001st-Jb for submit@debbugs.gnu.org; Fri, 22 Mar 2019 09:18:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7K42-0001sf-BX for 34944@debbugs.gnu.org; Fri, 22 Mar 2019 09:18:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7K3x-0006cv-59; Fri, 22 Mar 2019 09:18:21 -0400 Received: from [176.228.60.248] (port=1591 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h7K3v-0002rA-NH; Fri, 22 Mar 2019 09:18:21 -0400 Date: Fri, 22 Mar 2019 15:18:16 +0200 Message-Id: <83a7hnrqsn.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Fri, 22 Mar 2019 11:44:02 +0100) Subject: Re: bug#34944: 27.0.50; FR: support amend in vc-hg References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34944 Cc: 34944@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Philipp Stephani > Date: Fri, 22 Mar 2019 11:44:02 +0100 > > The Git integration for vc.el supports amending commits via a magic > changelog header. Mercurial has the same functionality, see > https://www.mercurial-scm.org/wiki/EditingHistory#Amending_the_latest_changeset_with_commit_--amend. > If would be great to support this in Emacs as well. Maybe the Git > approach could even move into main VC, and made available to all > backends that support amending? Can you propose a patch for that? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 22:34:17 2019 Received: (at 34944) by debbugs.gnu.org; 23 Mar 2019 02:34:17 +0000 Received: from localhost ([127.0.0.1]:54877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7WUD-0000LM-EA for submit@debbugs.gnu.org; Fri, 22 Mar 2019 22:34:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7WUC-0000Kh-ER for 34944@debbugs.gnu.org; Fri, 22 Mar 2019 22:34:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7WU7-0000Zv-0H; Fri, 22 Mar 2019 22:34:11 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1h7WU0-0000Cl-6D; Fri, 22 Mar 2019 22:34:04 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Eli Zaretskii In-Reply-To: <83a7hnrqsn.fsf@gnu.org> (message from Eli Zaretskii on Fri, 22 Mar 2019 15:18:16 +0200) Subject: Re: bug#34944: 27.0.50; FR: support amend in vc-hg References: <83a7hnrqsn.fsf@gnu.org> Message-Id: Date: Fri, 22 Mar 2019 22:34:04 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34944 Cc: 34944@debbugs.gnu.org, p.stephani2@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > The Git integration for vc.el supports amending commits via a magic > > changelog header. What does this mean, concretely? -- Dr Richard Stallman President, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 23 03:28:38 2019 Received: (at 34944) by debbugs.gnu.org; 23 Mar 2019 07:28:38 +0000 Received: from localhost ([127.0.0.1]:54943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7b53-0007bV-VU for submit@debbugs.gnu.org; Sat, 23 Mar 2019 03:28:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7b53-0007bG-4u for 34944@debbugs.gnu.org; Sat, 23 Mar 2019 03:28:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7b4x-0005YL-Ot; Sat, 23 Mar 2019 03:28:31 -0400 Received: from [176.228.60.248] (port=1705 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h7b4n-0008AL-NR; Sat, 23 Mar 2019 03:28:23 -0400 Date: Sat, 23 Mar 2019 09:28:19 +0200 Message-Id: <83va0aoxrg.fsf@gnu.org> From: Eli Zaretskii To: rms@gnu.org In-reply-to: (message from Richard Stallman on Fri, 22 Mar 2019 22:34:04 -0400) Subject: Re: bug#34944: 27.0.50; FR: support amend in vc-hg References: <83a7hnrqsn.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34944 Cc: 34944@debbugs.gnu.org, p.stephani2@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Richard Stallman > Cc: p.stephani2@gmail.com, 34944@debbugs.gnu.org > Date: Fri, 22 Mar 2019 22:34:04 -0400 > > > > The Git integration for vc.el supports amending commits via a magic > > > changelog header. > > What does this mean, concretely? That a specially formatted header in the VC log buffer signals VC to make the next checkin operation replace the last commit instead of adding a new commit. See vc-git-log-edit-toggle-amend and vc-git-checkin for the details. It boils down to whether or not the nezt "git commit" is invoked with the --amend switch. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 23 21:44:11 2019 Received: (at 34944) by debbugs.gnu.org; 24 Mar 2019 01:44:11 +0000 Received: from localhost ([127.0.0.1]:55933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7sBH-0004xi-BG for submit@debbugs.gnu.org; Sat, 23 Mar 2019 21:44:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7sBE-0004xR-PG for 34944@debbugs.gnu.org; Sat, 23 Mar 2019 21:44:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7sB7-0000FT-FY; Sat, 23 Mar 2019 21:44:01 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1h7sB6-00016P-DU; Sat, 23 Mar 2019 21:44:00 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Eli Zaretskii In-Reply-To: <83va0aoxrg.fsf@gnu.org> (message from Eli Zaretskii on Sat, 23 Mar 2019 09:28:19 +0200) Subject: Re: bug#34944: 27.0.50; FR: support amend in vc-hg References: <83a7hnrqsn.fsf@gnu.org> <83va0aoxrg.fsf@gnu.org> Message-Id: Date: Sat, 23 Mar 2019 21:44:00 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34944 Cc: 34944@debbugs.gnu.org, p.stephani2@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > That a specially formatted header in the VC log buffer signals VC to > make the next checkin operation replace the last commit instead of > adding a new commit. See vc-git-log-edit-toggle-amend and > vc-git-checkin for the details. It boils down to whether or not the > nezt "git commit" is invoked with the --amend switch. Thanks. -- Dr Richard Stallman President, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 20:33:23 2019 Received: (at 34944) by debbugs.gnu.org; 3 Apr 2019 00:33:23 +0000 Received: from localhost ([127.0.0.1]:41912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBTqF-0004VL-6H for submit@debbugs.gnu.org; Tue, 02 Apr 2019 20:33:23 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:47038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBTqD-0004V9-OS for 34944@debbugs.gnu.org; Tue, 02 Apr 2019 20:33:22 -0400 Received: by mail-lj1-f195.google.com with SMTP id h21so13196058ljk.13 for <34944@debbugs.gnu.org>; Tue, 02 Apr 2019 17:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=uvLdV+mJuXuyqtmGpFfy7QNbsQ/VfzTg1l7KhRp2Jcs=; b=cOjLzjFZDVi9t7ak5i1asA7bE874HS5iHwL7UoQAAkU5RVQpqxMsAiWZfPsKEQam1e XRVbkhV01Aw1dCPsuCZMYugIQH+CrFdd8uFZcWje3TvpUFnNoiYe4ro5TQXcmnNl0PZM IhXllKrttwrivMOuYfb/oAE7izOf/iv0gGfYR6Wg6+b4eNqBGMWswxfhY61wh9V8B4bq aL4xT1aBTCVrdxTFNdpigvJe+XM17iWAWatAMFx7CSlhpWn4VXyZrwuCMpzhF8rc80FZ CH4xaHknBssK/1yxZOu/d6opblFeeDM++yQR2YgFXWnCB5wlJs0OEuelBpFH0xB6b9wn 55OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=uvLdV+mJuXuyqtmGpFfy7QNbsQ/VfzTg1l7KhRp2Jcs=; b=DO69+fVYETfnovxudy+Wp8M042RH42aBrmATYENVpWYmXzoCqmnSG/G8LXCVDmQUJv wcYuhHNQS7rmizdvCG00OWxOdEz0K+N0jJOQCiy83wqWq5AG7TSV/bNXvx/RSgCWoojm EKCSpfHecaZU9APE4UtrpvgOtJFr+Kq3G6WEQzgc5rjCTSMBJ13lL6R/LuTMmdtt5281 SBj/V4TN907frw7LWHDQlCJdmFtWt4E7Tdm4qsjEr4asbq+OePKuVa4NLHZuG2xYW79K X9WtGnoEubQvmhVGv/u5Wu3DupgZzsSSyGT6qBe7scxq5H543uhldYSwqAHcHei3KsAe Z++A== X-Gm-Message-State: APjAAAXsFaXu4lYUreXxB9YKNV978GxMk+C/qECkoIrKag5YmWBnOWgB 6Ry+surOxkcRUyFNsmSkPBJqyXcb X-Google-Smtp-Source: APXvYqwvLgucIg9rKj6y7/bNpMEtDaTizB/1PVIiaDj2/+RAlHhfLaTE6ZzdRWoWth66HJUJufmDsw== X-Received: by 2002:a2e:9619:: with SMTP id v25mr31890330ljh.145.1554251595404; Tue, 02 Apr 2019 17:33:15 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id q23sm3003494ljj.44.2019.04.02.17.33.13 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 02 Apr 2019 17:33:13 -0700 (PDT) Subject: Re: bug#34944: 27.0.50; FR: support amend in vc-hg To: Philipp Stephani , 34944@debbugs.gnu.org References: From: Dmitry Gutov Message-ID: <9b5b5852-6b37-59d9-146f-371a213e7045@yandex.ru> Date: Wed, 3 Apr 2019 03:33:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Thunderbird/67.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------24CD473AA45FD7AB1D29DAB2" Content-Language: en-US X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34944 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------24CD473AA45FD7AB1D29DAB2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 22.03.2019 12:44, Philipp Stephani wrote: > > The Git integration for vc.el supports amending commits via a magic > changelog header. Mercurial has the same functionality, see > https://www.mercurial-scm.org/wiki/EditingHistory#Amending_the_latest_changeset_with_commit_--amend. > If would be great to support this in Emacs as well. Maybe the Git > approach could even move into main VC, and made available to all > backends that support amending? Here's a patch you can try (attached). No backend API change necessary, so far. Are there many backends that could support amending? --------------24CD473AA45FD7AB1D29DAB2 Content-Type: text/x-patch; name="vc-hg-amend.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="vc-hg-amend.diff" diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index a921ff1bb8..6ce3ccde1e 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -767,23 +767,12 @@ vc-git-log-edit-toggle-amend "Toggle whether this will amend the previous commit. If toggling on, also insert its message into the buffer." (interactive) - (when (log-edit-toggle-header "Amend" "yes") - (goto-char (point-max)) - (unless (bolp) (insert "\n")) - (insert (with-output-to-string - (vc-git-command - standard-output 1 nil - "log" "--max-count=1" "--pretty=format:%B" "HEAD"))) - (save-excursion - (rfc822-goto-eoh) - (forward-line 1) - (let ((pt (point))) - (and (zerop (forward-line 1)) - (looking-at "\n\\|\\'") - (let ((summary (buffer-substring-no-properties pt (1- (point))))) - (skip-chars-forward " \n") - (delete-region pt (point)) - (log-edit-set-header "Summary" summary))))))) + (vc--log-edit-toggle-amend + (lambda () + (with-output-to-string + (vc-git-command + standard-output 1 nil + "log" "--max-count=1" "--pretty=format:%B" "HEAD"))))) (defvar vc-git-log-edit-mode-map (let ((map (make-sparse-keymap "Git-Log-Edit"))) diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el index 6b17e861dd..9dedfa5744 100644 --- a/lisp/vc/vc-hg.el +++ b/lisp/vc/vc-hg.el @@ -1105,14 +1105,39 @@ vc-hg-unregister (declare-function log-edit-extract-headers "log-edit" (headers string)) +(defun vc-hg-log-edit-toggle-amend () + "Toggle whether this will amend the previous commit. +If toggling on, also insert its message into the buffer." + (interactive) + (vc--log-edit-toggle-amend + (lambda () + (with-output-to-string + (vc-hg-command + standard-output 1 nil + "log" "--limit=1" "--template" "{desc}"))))) + +(defvar vc-hg-log-edit-mode-map + (let ((map (make-sparse-keymap "Hg-Log-Edit"))) + (define-key map "\C-c\C-e" 'vc-hg-log-edit-toggle-amend) + map)) + +(define-derived-mode vc-hg-log-edit-mode log-edit-mode "Log-Edit/hg" + "Major mode for editing Hg log messages. +It is based on `log-edit-mode', and has Hg-specific extensions.") + (defun vc-hg-checkin (files comment &optional _rev) "Hg-specific version of `vc-backend-checkin'. REV is ignored." - (apply 'vc-hg-command nil 0 files - (nconc (list "commit" "-m") - (log-edit-extract-headers '(("Author" . "--user") - ("Date" . "--date")) - comment)))) + (let ((amend-extract-fn + (lambda (value) + (when (equal value "yes") + (list "--amend"))))) + (apply 'vc-hg-command nil 0 files + (nconc (list "commit" "-m") + (log-edit-extract-headers `(("Author" . "--user") + ("Date" . "--date") + ("Amend" . ,amend-extract-fn)) + comment))))) (defun vc-hg-find-revision (file rev buffer) (let ((coding-system-for-read 'binary) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index e6f30c9f80..3ae0ad663e 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -3045,6 +3045,22 @@ vc-check-headers (interactive) (vc-call-backend (vc-backend buffer-file-name) 'check-headers)) +(defun vc--log-edit-toggle-amend (last-msg-fn) + (when (log-edit-toggle-header "Amend" "yes") + (goto-char (point-max)) + (unless (bolp) (insert "\n")) + (insert (funcall last-msg-fn)) + (save-excursion + (rfc822-goto-eoh) + (forward-line 1) + (let ((pt (point))) + (and (zerop (forward-line 1)) + (looking-at "\n\\|\\'") + (let ((summary (buffer-substring-no-properties pt (1- (point))))) + (skip-chars-forward " \n") + (delete-region pt (point)) + (log-edit-set-header "Summary" summary))))))) + ;; These things should probably be generally available --------------24CD473AA45FD7AB1D29DAB2-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 09:54:33 2019 Received: (at 34944) by debbugs.gnu.org; 6 Apr 2019 13:54:33 +0000 Received: from localhost ([127.0.0.1]:46656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hClmD-0002bk-0x for submit@debbugs.gnu.org; Sat, 06 Apr 2019 09:54:33 -0400 Received: from mail-oi1-f173.google.com ([209.85.167.173]:40601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hClmB-0002bX-3S for 34944@debbugs.gnu.org; Sat, 06 Apr 2019 09:54:31 -0400 Received: by mail-oi1-f173.google.com with SMTP id 3so7133418oir.7 for <34944@debbugs.gnu.org>; Sat, 06 Apr 2019 06:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kgQaa6NVZb4FUt0rUuvexoRjYuCsun/BQkNVfs8P5HA=; b=ugw+4SslcYD8AnMaumVHARLyxkvBZQC3de6qIvEc9RtnVfVp5wuUXOSmImnHc760G6 q5sILY3dPmiHxAOUJLQrW+9Y1th9mwzcsbW1Zpd1zpkCnIRWNBUDv0pzvtqd+USxt7Up mxWiWRhEzPAs5M2ASx5e4RhTHww5XigviYVerll0pdh54jpvUvjpew8If8K3xPcd8qDD fkT7VKdRI0bS8dkbHnH9uXt+vPp7xeU/i+lY1t8e291bodvcbf8m1coq0hf9InIVpDaz 2XDsScDLjDB6VP+q2/xGxjTfQeKofAkHM37aguRIFxvCHHAQhTr9zcHb9x9HQ4e8Hhws okyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kgQaa6NVZb4FUt0rUuvexoRjYuCsun/BQkNVfs8P5HA=; b=n1TcKxT+Be7InpfmwYyRii+x/W+Lioh6zckQG+kcs7yQar9W5OinyKcGdzLjaNzRFl oe92K5zNGlIjdC8kTcXljRyNe+E2KP0e0F4BhcKBITZlaUZK7QcjGlbGduhbUglMNHEA 1rWzU1ttWIaWfwAaIP4ljcm7jmHNoNNMklvQ596Ub48vOSKgTbLx7gLdPzfzBL/uCOC2 KWcxEw0vB5tuTdRYFeelV2SXNJ0WjsMjWnBEPvGyoTFLUkhzQ+Rj1rWmQD2mts46ROIx SA2Tghy1tyuXldGIDMZbCmZxtwqNokNnxPyK5rbc8yKtKpnmqspV0Fixhua7iMUZAFX2 fx0Q== X-Gm-Message-State: APjAAAVTwJMayxGFaK7+Io4rp0CHlz6627/63rVYyKKOy5GqpRlAEDK/ JQK50ScZS+JDVPsAi8conO7BS67ODyhqijPSfzo= X-Google-Smtp-Source: APXvYqyk1cx1FR5VPDDPA7SKfeQTa+wereqKxpaPU/8Pp6y9MDbiNE9m9wPXS+HfEteblcWTByuJn7BzxexoXa8mzLI= X-Received: by 2002:aca:d90a:: with SMTP id q10mr10623757oig.65.1554558864474; Sat, 06 Apr 2019 06:54:24 -0700 (PDT) MIME-Version: 1.0 References: <9b5b5852-6b37-59d9-146f-371a213e7045@yandex.ru> In-Reply-To: <9b5b5852-6b37-59d9-146f-371a213e7045@yandex.ru> From: Philipp Stephani Date: Sat, 6 Apr 2019 15:54:08 +0200 Message-ID: Subject: Re: bug#34944: 27.0.50; FR: support amend in vc-hg To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34944 Cc: 34944@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Mi., 3. Apr. 2019 um 02:33 Uhr schrieb Dmitry Gutov : > > On 22.03.2019 12:44, Philipp Stephani wrote: > > > > The Git integration for vc.el supports amending commits via a magic > > changelog header. Mercurial has the same functionality, see > > https://www.mercurial-scm.org/wiki/EditingHistory#Amending_the_latest_changeset_with_commit_--amend. > > If would be great to support this in Emacs as well. Maybe the Git > > approach could even move into main VC, and made available to all > > backends that support amending? > > Here's a patch you can try (attached). > > No backend API change necessary, so far. > > Are there many backends that could support amending? I'm not aware of others. I think for now it's fine to support Mercurial without an API change. Once there are more backends showing up that should have similar support, we can generalize the approach. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 20:48:28 2019 Received: (at 34944) by debbugs.gnu.org; 7 Apr 2019 00:48:28 +0000 Received: from localhost ([127.0.0.1]:47595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCvz2-0003aK-D2 for submit@debbugs.gnu.org; Sat, 06 Apr 2019 20:48:28 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:46189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCvz0-0003a3-Hx for 34944@debbugs.gnu.org; Sat, 06 Apr 2019 20:48:26 -0400 Received: by mail-lf1-f46.google.com with SMTP id r25so6891082lfn.13 for <34944@debbugs.gnu.org>; Sat, 06 Apr 2019 17:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=if5hsQRy6Gy8lYPYnP8DSsFugIb7eYujoSax5lD8hgg=; b=eobqNhPvAEyaWLeQY2wH2zsT/hmDm7MkwnnX3W/KH4mWdeWMqWArQKTan9TPySBtnN p1Ka6GaiUjTgvZleRR/OXMEC3WB0GkQIZkCvEk92iBpQVyrXMS8mdIdWihCY/kieC1B3 fRcdMRCxbXkd/uJ6ZKgKhT8BzJhXFb6Nvq1SD7sp2cSR9JSi4OzZ8uUA97FwfNglR73m kJGyvS/SBFgW71YMXy0LlmgYpc3SoCRX/YGisi3/j2ekTPZanJ7OUvB+podoKknpOh/M jxaC5yKQJWhUhpVvVqJFCKEkSGSKFP2CXLmmcixQ3unmoaL0SvWiqn77njfWrjIoN42w dveQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=if5hsQRy6Gy8lYPYnP8DSsFugIb7eYujoSax5lD8hgg=; b=XYlhIOLCVfQsyuXguZIrfgSFfnv1Ft99JDdJM35U1OW4g9ojmShmNnQ17LiBUv/LsN 89rO6+LiwdqKX/7p6T0QBr8wujKnVXIrEu6IWDMkj4lDI4/WVFC4tKzDlpl9stmPJ7no 2SRZ7hNLprieFhcGyLVP6qFtpZj8CDNTqNwWiCkXCYOXlhz2hwHh1LJah9pU26hRJRcA SHGUcsdUI1qcDjbYDTRl+GhhefncVXdSixf9B2UxHoKAKJ98ni+OxBTPvYGAUEYTfQme 5BxK1PqI7nZ1V6HwZklk8TjX84fhNaPSk5d887KayqEBT4LovJTXexoC8sBQ+sLzJI0A 6d9g== X-Gm-Message-State: APjAAAU73UPs5EQDl3mac3R8mkXifq+FoxGDUiOyWBGKC4g9v43k8Cg4 jqeHqq77A68S37buMQ4difuaBhv1 X-Google-Smtp-Source: APXvYqzHbxlzWwAJGbC58rfLoDU62u8lIX2alamUUepRBgtkeraOfMjzJFxWTg5Mhs5ymLGy/qi6kA== X-Received: by 2002:a19:5506:: with SMTP id n6mr10651903lfe.119.1554598100322; Sat, 06 Apr 2019 17:48:20 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id t28sm6390780lje.9.2019.04.06.17.48.18 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sat, 06 Apr 2019 17:48:19 -0700 (PDT) Subject: Re: bug#34944: 27.0.50; FR: support amend in vc-hg To: Philipp Stephani References: <9b5b5852-6b37-59d9-146f-371a213e7045@yandex.ru> From: Dmitry Gutov Message-ID: <22d84233-a3b5-a037-7696-cbd8e934f4f3@yandex.ru> Date: Sun, 7 Apr 2019 03:48:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0a1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34944 Cc: 34944@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06.04.2019 16:54, Philipp Stephani wrote: > I'm not aware of others. I think for now it's fine to support > Mercurial without an API change. Once there are more backends showing > up that should have similar support, we can generalize the approach. > Thanks! Does the patch work well for you? If yes, I'll install it. (I'm not actually a user of Mercurial at all). From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 17 14:40:23 2019 Received: (at 34944) by debbugs.gnu.org; 17 Apr 2019 18:40:23 +0000 Received: from localhost ([127.0.0.1]:40751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGpTq-0006wl-NW for submit@debbugs.gnu.org; Wed, 17 Apr 2019 14:40:22 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:36833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGpTm-0006wP-EE for 34944@debbugs.gnu.org; Wed, 17 Apr 2019 14:40:20 -0400 Received: by mail-oi1-f174.google.com with SMTP id l203so20885240oia.3 for <34944@debbugs.gnu.org>; Wed, 17 Apr 2019 11:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8byRXh2Pe+4yOleL+O1bgzj6H+QUV+SDAVg0LZwjTc0=; b=pupSfmF7Xw9bK2cc7vlOkXzbcCQs6mYRZxbOXF+LrRXypf3EgPI7ngS4bsIjJ4+A0B E6mNdW7e1dWeQo+eObnsMRhztSx++hmtPkpWrooDOirEKCjMikh6C84GIp1v4H9Yk85X VxmWKEJNtZKqfOMDBiG88wvRNB8gnHnzhP0hQFwnQotxwwsZzdshmQ2e/M2ej8DABOBH TtQepMbOOa8sQY3tddjKMk5/xmzLvRcOIdsQRAfqHZORr3a5t05kRkORgNMMVFr4i1rM +7Mw27eOCdGmPHFdwN6xFMhEGBc3082aK19gnrJYd0kuiu6OOeek8mWBHgUHMHdUdhyX hejw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8byRXh2Pe+4yOleL+O1bgzj6H+QUV+SDAVg0LZwjTc0=; b=IAEt5P6VhStMGjmrfaqZ5DwGMzpafIxuprtB3RhFo2LFtYcFsBd04e+rYa3tF2yJJB q6nEJM9NwjKcVrRp9BU7Af76/1TxZkK+VnQziZa9qO4ueGoSd04YXRa3G9wiz1W22k8I 4uEIuuwCs0YuOB5nhJkMRLGbbQsv02YRKvaZHr0Lp2q69FM336oxXMHEO5NBEyHkMI7n GB41SXvD0us0h5PwSSsOuiJ+YqALpD0w9w8CWCKl2TfceKqjv8DcTigU0N38OFdeYTV3 ggyJmJJwqO5AAY4LxLaavQzHyWXlzv81+SnpeDsMxtxjOE0Ty1KVNPh07yDJCv2tc8jn ldCQ== X-Gm-Message-State: APjAAAUZ3tdj4KDT1dDi9O+FB1aw3IXvqhhRFVt9fe0lV3/3qDpgh4NX i/J8bEdO5JSTEEqA4evQsN+kSEsdcTzxKa8bfCk= X-Google-Smtp-Source: APXvYqy8BfWveAxCpIl3vAsuZ3nNCgHX40WRdtyl7N8/x+9POIB7UPbAo/E8wjtgitjNvbi/kMUAfxXgKOxJk/icC9c= X-Received: by 2002:aca:b3c2:: with SMTP id c185mr41073oif.98.1555526412329; Wed, 17 Apr 2019 11:40:12 -0700 (PDT) MIME-Version: 1.0 References: <9b5b5852-6b37-59d9-146f-371a213e7045@yandex.ru> <22d84233-a3b5-a037-7696-cbd8e934f4f3@yandex.ru> In-Reply-To: <22d84233-a3b5-a037-7696-cbd8e934f4f3@yandex.ru> From: Philipp Stephani Date: Wed, 17 Apr 2019 20:40:01 +0200 Message-ID: Subject: Re: bug#34944: 27.0.50; FR: support amend in vc-hg To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34944 Cc: 34944@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am So., 7. Apr. 2019 um 02:48 Uhr schrieb Dmitry Gutov : > > On 06.04.2019 16:54, Philipp Stephani wrote: > > I'm not aware of others. I think for now it's fine to support > > Mercurial without an API change. Once there are more backends showing > > up that should have similar support, we can generalize the approach. > > Thanks! > > Does the patch work well for you? If yes, I'll install it. I haven't really tried it to be honest and I don't have a Hg repository to work with at the moment :) But it looks correct, so feel free to install it and I'll report back in a couple of weeks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 17:40:59 2019 Received: (at 34944-done) by debbugs.gnu.org; 20 Apr 2019 21:40:59 +0000 Received: from localhost ([127.0.0.1]:46934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHxjH-0003SK-3d for submit@debbugs.gnu.org; Sat, 20 Apr 2019 17:40:59 -0400 Received: from mail-lj1-f169.google.com ([209.85.208.169]:41251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHxjF-0003S4-GJ for 34944-done@debbugs.gnu.org; Sat, 20 Apr 2019 17:40:57 -0400 Received: by mail-lj1-f169.google.com with SMTP id k8so7301033lja.8 for <34944-done@debbugs.gnu.org>; Sat, 20 Apr 2019 14:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=U7Gt1K/5sI4znC6g21BouTI6M8Thk5oauTsS3gy8sus=; b=NXf2tGmHi+UcadTx/KaLGOAcSb4DI2BQYmWCe79LaG6NQ75VTx+csA/Cghyt70LBEn 8Z+OlAUvEqAgT0uKYWWx+59Vb0iUP1c9KK/yEyHrXTf7aDwHIouk1UoJIkznqyyf8B5J Czx7zR4THflHBGbRwqWrY3kq4qIL3cQm7WeTQqbR8P3K5er3yIOv99OYFs/ZClJ9trjd bAJ44/lMelnhGMpKLee0K+24VQlnMv5UwYCUho4WwQnLRJzxSOVeYHsBe9Fm4j3Qmnsz 0ezXM602037E1mLmTZiuLdbozxG/NYK9pQBVEUOAU6ax7feRu6gSuGl3k19cEtrYeX20 2TFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U7Gt1K/5sI4znC6g21BouTI6M8Thk5oauTsS3gy8sus=; b=R4wJyK7OWxSg8iAakNweu3iEQIPgkShlss8MOC8PFJBz91XEqd1UKvII0lvBKnPtkA SXPcWktqM78u1f+HP26t3TUKXa+vs0+kDtyUcA/dxmzh4unH3Nh8B8ZuMC0q3QSOycDy 1CW03uXzNUY3P7QNnFrjleEXB2b8uC6vTh7oyXZkVCNUOFkjjmo1WnUKFveKcOdyYYyk rXk00OjRF9p5ZVeWcHuWrSAC015G/KVAFexclY3q7/f7KUjTd6zk1jm8RwjSVsiFwK/k mranYQC26OPocGtE0rXwoisa987sK53F0tJxdWPgMSHabN2Ak8wiMqJRpzdj0wc+wdWB AlfA== X-Gm-Message-State: APjAAAUEjV9gLNqw/yje2BnrKHngaOGNdScgbBxxHnQBB4LkQra8wgdp +SHBgXhG3QY1HHiOn+AyV+UluBKZ X-Google-Smtp-Source: APXvYqyEwzFqNnPvb86xVNysuSZFiowA/VE92HabbABRkEr3g7/D393n9cOySwFGt78zK5RNarSGtQ== X-Received: by 2002:a2e:7806:: with SMTP id t6mr6046670ljc.143.1555796451371; Sat, 20 Apr 2019 14:40:51 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id o7sm1941317ljj.23.2019.04.20.14.40.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Apr 2019 14:40:50 -0700 (PDT) Subject: Re: bug#34944: 27.0.50; FR: support amend in vc-hg To: Philipp Stephani References: <9b5b5852-6b37-59d9-146f-371a213e7045@yandex.ru> <22d84233-a3b5-a037-7696-cbd8e934f4f3@yandex.ru> From: Dmitry Gutov Message-ID: <485a2d08-573d-2099-cf1b-eca2a0e53859@yandex.ru> Date: Sun, 21 Apr 2019 00:40:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 34944-done Cc: 34944-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Version: 27.1 On 17.04.2019 21:40, Philipp Stephani wrote: > I haven't really tried it to be honest and I don't have a Hg > repository to work with at the moment :) But it looks correct, so feel > free to install it and I'll report back in a couple of weeks. OK, if you insist. Pushed a slightly different patch. Please try it out when you have the chance. From unknown Sun Aug 10 09:45:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 May 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator