GNU bug report logs - #34928
[PATCH] gnu: emacs-rust-mode: Update to 0.4.0.

Previous Next

Full log

Message #8 received at 34928 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Brett Gilio <brettg <at> posteo.net>
Cc: 34928 <at> debbugs.gnu.org
Subject: Re: [bug#34928] [PATCH] gnu: emacs-rust-mode: Update to 0.4.0.
Date: Thu, 21 Mar 2019 09:39:42 +0100

Hi Brett,

> From 51d44ab89ebf4e04f0c70574bf20d9b62532b59e Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg <at> posteo.net>
> Date: Wed, 20 Mar 2019 17:02:04 -0500
> Subject: [PATCH] gnu: emacs-rust-mode: Update to 0.4.0.
>
> * gnu/packages/emacs-xyz.scm (emacs-rust-mode): Update to 0.4.0.
> ---
>  gnu/packages/emacs-xyz.scm | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 9969c7968..916381841 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -12202,13 +12202,11 @@ files.  It focuses on highlighting the document to improve readability.")
>  
>  (define-public emacs-rust-mode
>    (let ((commit
> -         ;; Last release is old (2016), use more recent commit to get bug
> -         ;; fixes.
> -         "64b4a2450e4d4c47f6307851c9b2598cd2254d68")
> +         "106aeab800fb3404baf231845d3e3549ec235afa")
>          (revision "0"))
>      (package
>        (name "emacs-rust-mode")
> -      (version (git-version "0.3.0" revision commit))
> +      (version (git-version "0.4.0" revision commit))
>        (source (origin
>                  (method git-fetch)
>                  (uri
> @@ -12218,7 +12216,7 @@ files.  It focuses on highlighting the document to improve readability.")
>                  (file-name (git-file-name name version))
>                  (sha256
>                   (base32
> -                  "0pbz36lljgb7bdgx3h3g0pq1nss1kvn8mhk1l3mknsmynd6w4nd8"))))
> +                  "0bcrklyicxh032rrp585rl5mxd26nb61dp6r5bl935rlcmxzsczh"))))
>        (build-system emacs-build-system)
>        (arguments
>         `(#:phases

I would prefer to remove the let binding of “commit” and “revision”,
to replace the value of the “version” field with just “0.4.0”, and to
replace the git-fetch commit with “version”.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.