GNU bug report logs - #34904
[PATCH] Update elixir to 1.8.1.

Previous Next

Package: guix-patches;

Reported by: Robert Smith <robertsmith <at> posteo.net>

Date: Mon, 18 Mar 2019 16:03:01 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Robert Smith <robertsmith <at> posteo.net>
Subject: bug#34904: closed (Re: [bug#34904] [PATCH] Update elixir to 1.8.1.)
Date: Thu, 21 Mar 2019 19:56:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#34904: [PATCH] Update elixir to 1.8.1.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 34904 <at> debbugs.gnu.org.

-- 
34904: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34904
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Marius Bakke <mbakke <at> fastmail.com>
To: Robert Smith <robertsmith <at> posteo.net>, 34904-done <at> debbugs.gnu.org
Subject: Re: [bug#34904] [PATCH] Update elixir to 1.8.1.
Date: Thu, 21 Mar 2019 20:54:51 +0100
[Message part 3 (text/plain, inline)]
Hi Robert,

Robert Smith <robertsmith <at> posteo.net> writes:

> Hello,
>
> Excited to be submitting my first patch to guix!

It's a thrill, right? :-)

> The following patch updates elixir from 1.6.6 to 1.8.1.
> This was almost a trivial patch, however the full path of the git 
> executable
> was causing a line to go over 80 chars, which caused a syntax check in 
> the
> elixir Makefile to fail. I added a quick workaround to use elixir's own 
> syntax
> checker to fix the affected file (by putting each argument to the fn on 
> its own line)
> before the test is run.

Heh.  Nice workaround!  I added a commit message that follows our
convention, added the patch to "gnu/local.mk", and pushed the patch
in commit 2f87048dbe14097b9fe19ec470e2628cfca7fdbf.

Thank you, and welcome!
[signature.asc (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
From: Robert Smith <robertsmith <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update elixir to 1.8.1.
Date: Mon, 18 Mar 2019 15:54:52 +0100
[Message part 6 (text/plain, inline)]
Hello,

Excited to be submitting my first patch to guix!
The following patch updates elixir from 1.6.6 to 1.8.1.
This was almost a trivial patch, however the full path of the git 
executable
was causing a line to go over 80 chars, which caused a syntax check in 
the
elixir Makefile to fail. I added a quick workaround to use elixir's own 
syntax
checker to fix the affected file (by putting each argument to the fn on 
its own line)
before the test is run.

Best,

Robert
[0001-Update-elixir-to-1.8.1.patch (text/x-diff, attachment)]

This bug report was last modified 6 years and 124 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.