GNU bug report logs - #34865
[PATCH] Add emacs-zones.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34865 in the body.
You can then email your comments to 34865 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add emacs-zones.
Date: Fri, 15 Mar 2019 01:24:08 +0100

[Message part 1 (text/plain, inline)]

See attached.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-zones.patch (text/x-patch, attachment)]

Message #8 received at 34865 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: 34865 <at> debbugs.gnu.org
Subject: Re: [bug#34865] [PATCH] Add emacs-zones.
Date: Sat, 16 Mar 2019 13:56:17 +0300

[Message part 1 (text/plain, inline)]

Hello Brian,

Could we use emacs-zones from Elpa? See
https://elpa.gnu.org/packages/zones.html . ‘guix import elpa
emacs-zones’ will produce a decent ‘origin’ record to pull a source.

Please, don't forget to add a changelog entry to commit message:

* gnu/packages/emacs-xyz.scm (emacs-zones): New variable.

If you use Magit you could type ‘add’ to paste a yasnippet from
‘etc/snippets/’ Guix Git repository.  Add this directory to
‘yas-snippet-dirs’, see
https://www.gnu.org/software/guix/manual/en/html_node/The-Perfect-Setup.html

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 34865 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Brian Leung <bkleung89 <at> gmail.com>, 34865 <at> debbugs.gnu.org
Subject: Re: [bug#34865] [PATCH] Add emacs-zones.
Date: Fri, 22 Mar 2019 22:37:25 +0100

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> Could we use emacs-zones from Elpa? See
> https://elpa.gnu.org/packages/zones.html . ‘guix import elpa
> emacs-zones’ will produce a decent ‘origin’ record to pull a source.

My understanding is that ELPA and MELPA tarballs are not necessarily
persistent and immutable, and that we generally prefer referring
directly to the upstream repo.

Or am I confusing things?

Ludo’.

Message #14 received at 34865 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Brian Leung <bkleung89 <at> gmail.com>, 34865 <at> debbugs.gnu.org
Subject: Re: [bug#34865] [PATCH] Add emacs-zones.
Date: Sun, 24 Mar 2019 23:01:34 +0300

[Message part 1 (text/plain, inline)]

Hi Ludovic,

Ludovic Courtès <ludo <at> gnu.org> writes:

[…]

>> Could we use emacs-zones from Elpa? See
>> https://elpa.gnu.org/packages/zones.html . ‘guix import elpa
>> emacs-zones’ will produce a decent ‘origin’ record to pull a source.
>
> My understanding is that ELPA and MELPA tarballs are not necessarily
> persistent and immutable, and that we generally prefer referring
> directly to the upstream repo.

Ouch, I thought ELPA is persistent.  That's a significant argument to
not use ELPA for our purposes :-( .

> Or am I confusing things?

We preferred ELPA over GitHub's Git repositories in emacs-xys.scm
(emacs.scm in past), didn't we?

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 34865 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, Brian Leung <bkleung89 <at> gmail.com>,
 34865 <at> debbugs.gnu.org
Subject: Re: [bug#34865] [PATCH] Add emacs-zones.
Date: Tue, 26 Mar 2019 10:39:28 +0100

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
> […]
>
>>> Could we use emacs-zones from Elpa? See
>>> https://elpa.gnu.org/packages/zones.html . ‘guix import elpa
>>> emacs-zones’ will produce a decent ‘origin’ record to pull a source.
>>
>> My understanding is that ELPA and MELPA tarballs are not necessarily
>> persistent and immutable, and that we generally prefer referring
>> directly to the upstream repo.
>
> Ouch, I thought ELPA is persistent.  That's a significant argument to
> not use ELPA for our purposes :-( .
>
>> Or am I confusing things?
>
> We preferred ELPA over GitHub's Git repositories in emacs-xys.scm
> (emacs.scm in past), didn't we?

Hmmm, not sure, Ricardo, what’s the story?  :-)

Ludo’.

Message #20 received at 34865 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 34865 <at> debbugs.gnu.org,
 Brian Leung <bkleung89 <at> gmail.com>
Subject: Re: [bug#34865] [PATCH] Add emacs-zones.
Date: Tue, 26 Mar 2019 11:55:33 +0100

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Oleg,
>
> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> Ludovic Courtès <ludo <at> gnu.org> writes:
>>
>> […]
>>
>>>> Could we use emacs-zones from Elpa? See
>>>> https://elpa.gnu.org/packages/zones.html . ‘guix import elpa
>>>> emacs-zones’ will produce a decent ‘origin’ record to pull a source.
>>>
>>> My understanding is that ELPA and MELPA tarballs are not necessarily
>>> persistent and immutable, and that we generally prefer referring
>>> directly to the upstream repo.
>>
>> Ouch, I thought ELPA is persistent.  That's a significant argument to
>> not use ELPA for our purposes :-( .

I only know that MELPA isn’t immutable.  I assumed that ELPA is fine.

>> We preferred ELPA over GitHub's Git repositories in emacs-xys.scm
>> (emacs.scm in past), didn't we?
>
> Hmmm, not sure, Ricardo, what’s the story?  :-)

I don’t think we did.  I can’t think of even one case where we switched
from git-fetch from GitHub to url-fetch from ELPA.

git-fetch is the preferred way when there are no stable tarballs.

--
Ricardo

Message #23 received at 34865 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 34865 <at> debbugs.gnu.org,
 Brian Leung <bkleung89 <at> gmail.com>
Subject: Re: [bug#34865] [PATCH] Add emacs-zones.
Date: Wed, 27 Mar 2019 11:57:22 +0100

Hello,

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:

[...]

>>>>> Could we use emacs-zones from Elpa? See
>>>>> https://elpa.gnu.org/packages/zones.html . ‘guix import elpa
>>>>> emacs-zones’ will produce a decent ‘origin’ record to pull a source.
>>>>
>>>> My understanding is that ELPA and MELPA tarballs are not necessarily
>>>> persistent and immutable, and that we generally prefer referring
>>>> directly to the upstream repo.
>>>
>>> Ouch, I thought ELPA is persistent.  That's a significant argument to
>>> not use ELPA for our purposes :-( .
>
> I only know that MELPA isn’t immutable.  I assumed that ELPA is fine.

[...]

> git-fetch is the preferred way when there are no stable tarballs.

So, Oleg, I think you can go either way, but fetching over Git is
probably safer.

Can you apply the patch?

Thanks,
Ludo’.

Message #28 received at 34865-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 34865-done <at> debbugs.gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>, Brian Leung <bkleung89 <at> gmail.com>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#34865] [PATCH] Add emacs-zones.
Date: Wed, 27 Mar 2019 22:27:39 +0300

[Message part 1 (text/plain, inline)]

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

[…]

>>>>>> Could we use emacs-zones from Elpa? See
>>>>>> https://elpa.gnu.org/packages/zones.html . ‘guix import elpa
>>>>>> emacs-zones’ will produce a decent ‘origin’ record to pull a source.
>>>>>
>>>>> My understanding is that ELPA and MELPA tarballs are not necessarily
>>>>> persistent and immutable, and that we generally prefer referring
>>>>> directly to the upstream repo.
>>>>
>>>> Ouch, I thought ELPA is persistent.  That's a significant argument to
>>>> not use ELPA for our purposes :-( .
>>
>> I only know that MELPA isn’t immutable.  I assumed that ELPA is fine.
>
> [...]
>
>> git-fetch is the preferred way when there are no stable tarballs.
>
> So, Oleg, I think you can go either way, but fetching over Git is
> probably safer.
>
> Can you apply the patch?

OK, pushed as c881ed8698517a2c2007c2fdc3a7aeec52ff109c with a source
fetching over Git.

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.