From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 15:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 34858@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15525777316760 (code B ref -1); Thu, 14 Mar 2019 15:36:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Mar 2019 15:35:31 +0000 Received: from localhost ([127.0.0.1]:43890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4SOJ-0001ky-21 for submit@debbugs.gnu.org; Thu, 14 Mar 2019 11:35:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4SOI-0001kc-4X for submit@debbugs.gnu.org; Thu, 14 Mar 2019 11:35:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:37992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h4SOC-0000Qg-9j for submit@debbugs.gnu.org; Thu, 14 Mar 2019 11:35:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4SOA-00016l-Ts for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 11:35:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4SO8-0000PX-P2 for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 11:35:22 -0400 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:38852) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4SO6-0000O7-MK for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 11:35:18 -0400 Received: by mail-ot1-x335.google.com with SMTP id e80so350993ote.5 for ; Thu, 14 Mar 2019 08:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=VTnJVT24/Fjgd3ZfKAF9/4E1gNE2xBWhqcH6jP1rkjA=; b=KMchPTn5xR6YDg1mPi0WowGOHhrlgOkqKjWot7TNKSkcRyYhAbqij9bIq6WeRSWGxB visyFWn7+0CpqfyIbiNAwhSeEtGx6RYXnKrOu/3TXuZiCsGXzTxN3EHKbRlEQOapxPBK tcU9Fn/STwjRwldyta7FZnodIQO2DvghwtGEYW7IFKUlhw6Lwcptiw7uPo2AORxYsGXs MZtEGYAY1xptRVcfKwNd2Elh3gqhlfeOC8btVmzJoD7uBmbZk3TA2K+pKQOsnSzN2lsr V53cgH6XdaCNFt83PK6w9E2irPGETmPATC/47FwGKJFDKQ+XlTMwQpb+Mp1rQSxxrb4/ ZMwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=VTnJVT24/Fjgd3ZfKAF9/4E1gNE2xBWhqcH6jP1rkjA=; b=TcgWE3diUeswX8yqKOnQIfNp7N8r0ZRXdroo2w4pCnDf7e+gypqaaN+3fcZ28QMiv3 rHzdNKapuZPaFWHo6met/jBiTTBTikXerKnZFAjPhrEFmdKVtfXu3s6dhNTZJmMpGaIS R9MdkZf87bTPBHbJRAp5DjOqEePSovWn7miy9XuRjj6CCgbRIauZLaPXTTivm/jzFzN8 EdgAMkwfMUA4JqEETD3c2rlDAsqrC68VGSCkCjAxmyEwt9VoaY3+hkg7YwB6NeKDwNTM QEMNF6xCTV3lJv6bId/fbkAdko+kDKYewkxJNAHkSynE22r/HFhNvidJM1S8LpSDek6l GQ8Q== X-Gm-Message-State: APjAAAX2NHp56JiC5tQKVUDaP77YxK+Q/x429t7pKYQsZHdccGzG1Jfb BAic0UeUWVN8ivCJD8wnlGcAkbjP X-Google-Smtp-Source: APXvYqxgnTEq7XmuPIxFitBDDtyEDsAdXCKFFHigOH5XIee0N3YNl8O11mpwEZCJAGBbCBJxy/XmeA== X-Received: by 2002:a9d:4610:: with SMTP id y16mr11275475ote.41.1552577714844; Thu, 14 Mar 2019 08:35:14 -0700 (PDT) Received: from mars (nat-128-62-56-8.public.utexas.edu. [128.62.56.8]) by smtp.gmail.com with ESMTPSA id u5sm5799130otb.62.2019.03.14.08.35.14 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 08:35:14 -0700 (PDT) User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham Date: Thu, 14 Mar 2019 10:35:13 -0500 Message-ID: <871s39mpu6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::335 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) The docstring of indent-relative says: If the previous nonblank line has no indent points beyond the column point starts at, then `tab-to-tab-stop' is done, if both FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done in this case. Yet in a buffer like this: foo with point at the beginning of line, C-u M-x indent-relative results in: test I'm happy to submit a patch fixing this, but should it update the documentation to match what happens or should it update the code to match the documentation? Thanks, Alex From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alex Branham Cc: 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.15525792719483 (code B ref 34858); Thu, 14 Mar 2019 16:02:02 +0000 Received: (at 34858) by debbugs.gnu.org; 14 Mar 2019 16:01:11 +0000 Received: from localhost ([127.0.0.1]:43909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4Sn9-0002St-1Q for submit@debbugs.gnu.org; Thu, 14 Mar 2019 12:01:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4Sn7-0002Sh-7b for 34858@debbugs.gnu.org; Thu, 14 Mar 2019 12:01:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4Smt-0001PU-3Q; Thu, 14 Mar 2019 12:00:55 -0400 Received: from [176.228.60.248] (port=1805 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h4Smr-0002Hi-SD; Thu, 14 Mar 2019 12:00:54 -0400 Date: Thu, 14 Mar 2019 18:00:32 +0200 Message-Id: <83wol11m5b.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <871s39mpu6.fsf@gmail.com> (message from Alex Branham on Thu, 14 Mar 2019 10:35:13 -0500) References: <871s39mpu6.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex Branham > Date: Thu, 14 Mar 2019 10:35:13 -0500 > > If the previous nonblank line has no indent points beyond the > column point starts at, then `tab-to-tab-stop' is done, if both > FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done > in this case. > > Yet in a buffer like this: > > foo > > with point at the beginning of line, C-u M-x indent-relative results in: > > test > > I'm happy to submit a patch fixing this, but should it update the > documentation to match what happens or should it update the code to > match the documentation? I think this is a documentation bug, as it doesn't describe the special case of "no previous nonblank line". From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.155258024811138 (code B ref 34858); Thu, 14 Mar 2019 16:18:02 +0000 Received: (at 34858) by debbugs.gnu.org; 14 Mar 2019 16:17:28 +0000 Received: from localhost ([127.0.0.1]:43922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4T2t-0002tY-Kk for submit@debbugs.gnu.org; Thu, 14 Mar 2019 12:17:28 -0400 Received: from mail-oi1-f171.google.com ([209.85.167.171]:38059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4T2r-0002tL-6m for 34858@debbugs.gnu.org; Thu, 14 Mar 2019 12:17:25 -0400 Received: by mail-oi1-f171.google.com with SMTP id a15so4884394oid.5 for <34858@debbugs.gnu.org>; Thu, 14 Mar 2019 09:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=/tdpiMo93xuGTNZXNkSVs9xdRMtppn0F2LhKS0F6Dpk=; b=RvQu2Atf0X+DeVv1VOBcQV8xKL/LMxAeldMLmjIvxesNL/zuvVzQWyFrmPtlwvw2hP KDtGPwvalV+sLEuOaWeEUuUBm4esDJn+YvjVKD0586VQUEijakzLdrDIUUViUkxrF3Zx Eh2Y/4yGt6xAcVvTYDee7sDc+LOrqF5LqXcxqJ9E/qxxhylSsDz3zsgwbB/7h3fQMEET 8jFCDUf8N6SvgL/wXFdOH+eojzImqMTULerv85SvngpA1IvaBH4pI3B1qjMS2+CbaNBU FngmCJVy94zY9RqdC1RkL8Nr2/qdZHog9NixanFoRbTMAmhsjpT0cj0McnOHtv8VyQbO /vPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=/tdpiMo93xuGTNZXNkSVs9xdRMtppn0F2LhKS0F6Dpk=; b=gsOTwSGFeqMFHgeQTB32tlDng7qhiQB4jgurfe5HA3Uep93F3UQKcXwcRRXWaJZ+c+ ZKtIsV12VRg+jQShCMzL4sQ7Ydcu8hhf68X4tcilPopTjYhYvdZ4ABOAQszOPwIB8sOd ADr5CmpMfXGfB9HuIqjuDDdOgh8rlTAHotzZhNqf8rIGq/PId4U+20aGppZa7zSKmyYJ 5wke9NM4vwzuxkE9JwKQP3D4JgBjC6ECHlaY+/lw3yint0ntemzOHoZnlmpEDWOfS/pl ZCVW5LqiYxokkGpixDSSxO9o9ROi0ygKfCLioow5US8TefUZSzP2B/grMiH6Xvkecdge PXUg== X-Gm-Message-State: APjAAAWZU0QG9+nWLyLe7/KfFvcfQbOQg1rnGndU48iqRR/tYYWqSatd LWoHwSJXgByzaHm4bYTVNgn2aSAfjZk= X-Google-Smtp-Source: APXvYqxz/JbokpVnf0goI1LLHXfR/XGk61b2NJ0/yQTIaG70E33eUaasI1IOyv2z7yJB9UGA+xKJ0Q== X-Received: by 2002:aca:857:: with SMTP id 84mr2335922oii.125.1552580238229; Thu, 14 Mar 2019 09:17:18 -0700 (PDT) Received: from mars (nat-128-62-56-8.public.utexas.edu. [128.62.56.8]) by smtp.gmail.com with ESMTPSA id o67sm3483287oia.9.2019.03.14.09.17.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 09:17:17 -0700 (PDT) References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham In-reply-to: <83wol11m5b.fsf@gnu.org> Date: Thu, 14 Mar 2019 11:17:16 -0500 Message-ID: <87wol1l9bn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On Thu 14 Mar 2019 at 11:00, Eli Zaretskii wrote: > I think this is a documentation bug, as it doesn't describe the > special case of "no previous nonblank line". OK, patch attached. While looking over this I noticed the lisp reference manual also needed to be updated a bit so I did that as well. Thanks, Alex >From cefe6581558e45558907996ea39ac44e512f7944 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Thu, 14 Mar 2019 11:14:18 -0500 Subject: [PATCH] Update documentation for indent-relative functions * lisp/indent.el (indent-relative): Document what happens when there is no previous nonblank line. * doc/lispref/text.texi (Relative Indent): Document indent-relative-first-indent-point instead of obsolete indent-relative-maybe. Fix documentation of which argument from 'indent-relative' is used. Bug#34858 --- doc/lispref/text.texi | 4 ++-- lisp/indent.el | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/lispref/text.texi b/doc/lispref/text.texi index 21c5a73f88..abcea17010 100644 --- a/doc/lispref/text.texi +++ b/doc/lispref/text.texi @@ -2571,11 +2571,11 @@ The quick brown fox jum @point{}ped. @end example @end deffn -@deffn Command indent-relative-maybe +@deffn Command indent-relative-first-indent-point @comment !!SourceFile indent.el This command indents the current line like the previous nonblank line, by calling @code{indent-relative} with @code{t} as the -@var{unindented-ok} argument. The return value is unpredictable. +@var{first-only} argument. The return value is unpredictable. If the previous nonblank line has no indent points beyond the current column, this command does nothing. diff --git a/lisp/indent.el b/lisp/indent.el index 34757a43d7..25615f4113 100644 --- a/lisp/indent.el +++ b/lisp/indent.el @@ -598,8 +598,8 @@ considered. If the previous nonblank line has no indent points beyond the column point starts at, then `tab-to-tab-stop' is done, if both -FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done -in this case. +FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done. +If there isn't a previous nonblank line, call `tab-to-tab-stop'. See also `indent-relative-first-indent-point'." (interactive "P") -- 2.19.2 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Update-documentation-for-indent-relative-functions.patch >From cefe6581558e45558907996ea39ac44e512f7944 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Thu, 14 Mar 2019 11:14:18 -0500 Subject: [PATCH] Update documentation for indent-relative functions * lisp/indent.el (indent-relative): Document what happens when there is no previous nonblank line. * doc/lispref/text.texi (Relative Indent): Document indent-relative-first-indent-point instead of obsolete indent-relative-maybe. Fix documentation of which argument from 'indent-relative' is used. Bug#34858 --- doc/lispref/text.texi | 4 ++-- lisp/indent.el | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/lispref/text.texi b/doc/lispref/text.texi index 21c5a73f88..abcea17010 100644 --- a/doc/lispref/text.texi +++ b/doc/lispref/text.texi @@ -2571,11 +2571,11 @@ The quick brown fox jum @point{}ped. @end example @end deffn -@deffn Command indent-relative-maybe +@deffn Command indent-relative-first-indent-point @comment !!SourceFile indent.el This command indents the current line like the previous nonblank line, by calling @code{indent-relative} with @code{t} as the -@var{unindented-ok} argument. The return value is unpredictable. +@var{first-only} argument. The return value is unpredictable. If the previous nonblank line has no indent points beyond the current column, this command does nothing. diff --git a/lisp/indent.el b/lisp/indent.el index 34757a43d7..25615f4113 100644 --- a/lisp/indent.el +++ b/lisp/indent.el @@ -598,8 +598,8 @@ considered. If the previous nonblank line has no indent points beyond the column point starts at, then `tab-to-tab-stop' is done, if both -FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done -in this case. +FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done. +If there isn't a previous nonblank line, call `tab-to-tab-stop'. See also `indent-relative-first-indent-point'." (interactive "P") -- 2.19.2 --=-=-=-- From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 16:46:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Alex Branham , 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.155258194613855 (code B ref 34858); Thu, 14 Mar 2019 16:46:03 +0000 Received: (at 34858) by debbugs.gnu.org; 14 Mar 2019 16:45:46 +0000 Received: from localhost ([127.0.0.1]:43947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4TUH-0003bO-MQ for submit@debbugs.gnu.org; Thu, 14 Mar 2019 12:45:46 -0400 Received: from mail-it1-f175.google.com ([209.85.166.175]:50674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4TUC-0003az-IY for 34858@debbugs.gnu.org; Thu, 14 Mar 2019 12:45:40 -0400 Received: by mail-it1-f175.google.com with SMTP id m137so5784989ita.0 for <34858@debbugs.gnu.org>; Thu, 14 Mar 2019 09:45:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yKYgoeTlCwRFYJtIi1BfNC9CeGnODj/wTfr4+aAREMM=; b=ZzPcUkb+DQ+5Vv6GxEC8v5wnXxjYoWd7cGhgPCeFA5Xywx3m3bObmkFW064sIYmLMp cq4QTVNi6/ZK6cDpgkLQExRFgWGhENLRs0EIdQgqVIieP0rU53hX6BI8fAcvy3GXePOL yGf8aDVYJRwBw1BU6RoSpeLdTJRNZWKvulWv+2xBoKKFem6A6YjWFfd+Gi6qfkZ4PaXW GdyAd3qFlAuV1O22wHsCUeDoh9VGBNym0qp3ghyDIl4sQRVkMdCVbFxaFnpbfBIG2C8u pvGN6qHAvTf1wlJYbxyGwVCclMu/cR04XtDI8iRZMva0BQ7jaAkgAO2wVQqtFMCosJ+s liQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=yKYgoeTlCwRFYJtIi1BfNC9CeGnODj/wTfr4+aAREMM=; b=f6DTzIq/R5fpuIC7+OkCW2+NbFbgALnQDndMg1SyhP19K9Vlx194NYOWcbiBxM4kMA byff/+MADgoVkzJ6aC6NIwMSkFjI8PsGxSLuL1i+Zk2MMdS9k8cYUceXGnU7h9X++6x5 za0oGjP2XSJCTBDfBpPYcpnvkPePDNzy/V74YCv6/TdkfT+51qv7O+3nxie20E0kJAxN ac8W/lzSZEhtIng1HrVGfJTR7MOGChHgN2ZwYprHGHwpyWibBxU9hm1qFpnUliijZRpw XGdJj98ZgAmkRrictfW4F5Qwv+o74ATSN3bml8oRjpnT7xplN8AXGLQ+3vQD3OPXSCc3 zVRA== X-Gm-Message-State: APjAAAWTlIoizzsIm/1ni54dWKm/uokXqSveAtBxJbFP2Vbx2pDDeQ8a UlVuZBTKwaQsnyrmuulbC4GqaYLG X-Google-Smtp-Source: APXvYqxgDSCoBbUv6feMmkkYv3VWY/rePojCDMT2GrM0DzSRjZyZvTIzDqltZRCL+lGfbQgUV3/jEA== X-Received: by 2002:a02:1e13:: with SMTP id m19mr26298987jad.94.1552581934177; Thu, 14 Mar 2019 09:45:34 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id a6sm1376152itl.13.2019.03.14.09.45.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 09:45:33 -0700 (PDT) From: Alex References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> Date: Thu, 14 Mar 2019 10:45:32 -0600 In-Reply-To: <83wol11m5b.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Mar 2019 18:00:32 +0200") Message-ID: <87o96d5rrn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Alex Branham >> Date: Thu, 14 Mar 2019 10:35:13 -0500 >> >> If the previous nonblank line has no indent points beyond the >> column point starts at, then `tab-to-tab-stop' is done, if both >> FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done >> in this case. >> >> Yet in a buffer like this: >> >> foo >> >> with point at the beginning of line, C-u M-x indent-relative results in: >> >> test >> >> I'm happy to submit a patch fixing this, but should it update the >> documentation to match what happens or should it update the code to >> match the documentation? > > I think this is a documentation bug, as it doesn't describe the > special case of "no previous nonblank line". I believe that the case of "no previous nonblank line" could be considered as there being a single indent point at column 0, so if FIRST-ONLY is non-nil, then `tab-to-tab-stop' shouldn't be called. How about the following patch instead? diff --git a/lisp/indent.el b/lisp/indent.el index 34757a43d7..4ee4617de9 100644 --- a/lisp/indent.el +++ b/lisp/indent.el @@ -597,7 +597,7 @@ indent-relative considered. If the previous nonblank line has no indent points beyond the -column point starts at, then `tab-to-tab-stop' is done, if both +column point starts at, then `tab-to-tab-stop' is done if both FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done in this case. @@ -627,7 +627,7 @@ indent-relative (if (> opoint (point)) (goto-char opoint)) (move-marker opoint nil))) - (unindented-ok nil) + ((or unindented-ok first-only) nil) (t (tab-to-tab-stop))))) (defcustom tab-stop-list nil From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 18:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alex Cc: alex.branham@gmail.com, 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.155258659321189 (code B ref 34858); Thu, 14 Mar 2019 18:04:01 +0000 Received: (at 34858) by debbugs.gnu.org; 14 Mar 2019 18:03:13 +0000 Received: from localhost ([127.0.0.1]:44024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4UhE-0005Vh-J1 for submit@debbugs.gnu.org; Thu, 14 Mar 2019 14:03:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4UhC-0005VV-K6 for 34858@debbugs.gnu.org; Thu, 14 Mar 2019 14:03:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4Uh6-0007S2-3z; Thu, 14 Mar 2019 14:03:05 -0400 Received: from [176.228.60.248] (port=1350 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h4Uh2-0006kZ-7C; Thu, 14 Mar 2019 14:03:03 -0400 Date: Thu, 14 Mar 2019 20:02:32 +0200 Message-Id: <83tvg51ghz.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87o96d5rrn.fsf@gmail.com> (message from Alex on Thu, 14 Mar 2019 10:45:32 -0600) References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87o96d5rrn.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex > Cc: Alex Branham , 34858@debbugs.gnu.org > Date: Thu, 14 Mar 2019 10:45:32 -0600 > > Eli Zaretskii writes: > > >> From: Alex Branham > >> Date: Thu, 14 Mar 2019 10:35:13 -0500 > >> > >> If the previous nonblank line has no indent points beyond the > >> column point starts at, then `tab-to-tab-stop' is done, if both > >> FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done > >> in this case. > >> > >> Yet in a buffer like this: > >> > >> foo > >> > >> with point at the beginning of line, C-u M-x indent-relative results in: > >> > >> test > >> > >> I'm happy to submit a patch fixing this, but should it update the > >> documentation to match what happens or should it update the code to > >> match the documentation? > > > > I think this is a documentation bug, as it doesn't describe the > > special case of "no previous nonblank line". > > I believe that the case of "no previous nonblank line" could be > considered as there being a single indent point at column 0, so if > FIRST-ONLY is non-nil, then `tab-to-tab-stop' shouldn't be called. How > about the following patch instead? I don't understand what you are saying here. The doc string says "no indent point _beyond_" the column where point starts, so assuming a single indent point at column zero doesn't change anything. From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 18:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: alex.branham@gmail.com, 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.155258984426405 (code B ref 34858); Thu, 14 Mar 2019 18:58:01 +0000 Received: (at 34858) by debbugs.gnu.org; 14 Mar 2019 18:57:24 +0000 Received: from localhost ([127.0.0.1]:44043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4VXf-0006rp-Q3 for submit@debbugs.gnu.org; Thu, 14 Mar 2019 14:57:24 -0400 Received: from mail-it1-f178.google.com ([209.85.166.178]:33403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4VXd-0006rO-SX for 34858@debbugs.gnu.org; Thu, 14 Mar 2019 14:57:22 -0400 Received: by mail-it1-f178.google.com with SMTP id f186so8521396ita.0 for <34858@debbugs.gnu.org>; Thu, 14 Mar 2019 11:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=atDgT6TBnVWfgP35qKzgpshm/PCoeVdeO0iVkvGqfKc=; b=fsCS1j6ri9NKXdaabj3rv51gmIon1zIl1GzCZotEAAs7SyFYoT/dRMIkDKr7iYMi2V OHHivy10rdF9lQOUVa37ALB+2apEgElTRInzO0nDN+4ax+yZfNtLbnXt9M0uXpVsGC9E /Ijy9mxyhqxotANdKrJ/t7DObSuU6UY16KrrnbDcu81KIFnhf6aW+RtZViI2Y4syIgmg g94KsuywU9qCYAdRYUmHpf4rPhP5Hka3VusFLMijvhGyXRwWc6kWO+NSrZmak67eiuHy 3iWOxYPxjs35BAoOTh4S1EXwz8kAUF0NVWGO8Ng+E0QRHjZ2hduulIPpcue7iFV/+BwK pbDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=atDgT6TBnVWfgP35qKzgpshm/PCoeVdeO0iVkvGqfKc=; b=nnSzrIrAokUhCICvB72BDvM1EUekcLA//AmgMME1Sp7lzdDN3N5nGEB9zU0QOejcGU sWDrEpQ0XkCn2ryVNzbJ0ODpjsmZdymuYb2P/dbsCxIOLkwLNxs7tyLDBEInCY+KHkLO BBa3LG2pzlysxLLas7QPlylhXiicANmBCtQL5zn3IgtodECaZ5zNodMTYtPDUkgj17jS reCZG6j7vLbCjR+RZ7Uj6tFIVri5OwbpTh1/bUnsGgrvVtw21y7f49lN5RrmzL+1zPi8 iDWUZTaYoOsy/mTSxc9K+K62qZaQO8MuF8NUsEgcaWcCDTQdzq5AhT4l44NjMRFQtPw1 7hVw== X-Gm-Message-State: APjAAAULDK0jzHDpaPikDnlrIaMAR9MpaRNl7F3ZdNVHYDdrfqzgXaKu 6fLQUlCtStYsdMu+uy/P0oSF92NK X-Google-Smtp-Source: APXvYqwva4MzyNACP7Sq6+4vl8kelZ4FbAt9YP4crxw0zwg0Wp9InWLI6jUyowXyWH7avY+e0/if7g== X-Received: by 2002:a02:3e8b:: with SMTP id s133mr13159018jas.16.1552589835721; Thu, 14 Mar 2019 11:57:15 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id y19sm1737741itb.2.2019.03.14.11.57.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 11:57:14 -0700 (PDT) From: Alex References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87o96d5rrn.fsf@gmail.com> <83tvg51ghz.fsf@gnu.org> Date: Thu, 14 Mar 2019 12:57:08 -0600 In-Reply-To: <83tvg51ghz.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Mar 2019 20:02:32 +0200") Message-ID: <87k1h15lob.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Alex >> Cc: Alex Branham , 34858@debbugs.gnu.org >> Date: Thu, 14 Mar 2019 10:45:32 -0600 >> > >> > I think this is a documentation bug, as it doesn't describe the >> > special case of "no previous nonblank line". >> >> I believe that the case of "no previous nonblank line" could be >> considered as there being a single indent point at column 0, so if >> FIRST-ONLY is non-nil, then `tab-to-tab-stop' shouldn't be called. How >> about the following patch instead? > > I don't understand what you are saying here. The doc string says "no > indent point _beyond_" the column where point starts, so assuming a > single indent point at column zero doesn't change anything. Sorry, I wasn't clear. I meant that the special case here could be considered (trivially) equivalent to the case where the previous non-blank line has a single indent point at column zero, and therefore should be treated equivalently when FIRST-ONLY is non-nil (`tab-to-tab-stop` should not be called if on or past the first indent point, i.e., column 0). The usage of `beyond' does not change the behaviour when the starting column is on the first indent point, which outside of this special case is doing nothing. Specifically, the `indent' branch of the cond is normally executed when FIRST-ONLY is non-nil because `indent' is set within the `re-search-backward' conditional to be equal to the starting column; however, in this special case, `re-search-backward' returns nil and so `indent' remains nil. My patch covers this case by also checking for FIRST-ONLY in the cond. From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 20:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alex Cc: alex.branham@gmail.com, 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.15525947882310 (code B ref 34858); Thu, 14 Mar 2019 20:20:01 +0000 Received: (at 34858) by debbugs.gnu.org; 14 Mar 2019 20:19:48 +0000 Received: from localhost ([127.0.0.1]:44104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4WpQ-0000bA-Jz for submit@debbugs.gnu.org; Thu, 14 Mar 2019 16:19:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4WpO-0000aw-0x for 34858@debbugs.gnu.org; Thu, 14 Mar 2019 16:19:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4WpI-00043i-Jr; Thu, 14 Mar 2019 16:19:40 -0400 Received: from [176.228.60.248] (port=2219 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h4WpB-0000q5-HU; Thu, 14 Mar 2019 16:19:37 -0400 Date: Thu, 14 Mar 2019 22:18:56 +0200 Message-Id: <83lg1h1a6n.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87k1h15lob.fsf@gmail.com> (message from Alex on Thu, 14 Mar 2019 12:57:08 -0600) References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87o96d5rrn.fsf@gmail.com> <83tvg51ghz.fsf@gnu.org> <87k1h15lob.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex > Cc: alex.branham@gmail.com, 34858@debbugs.gnu.org > Date: Thu, 14 Mar 2019 12:57:08 -0600 > > Sorry, I wasn't clear. I meant that the special case here could be > considered (trivially) equivalent to the case where the previous > non-blank line has a single indent point at column zero, and therefore > should be treated equivalently when FIRST-ONLY is non-nil > (`tab-to-tab-stop` should not be called if on or past the first indent > point, i.e., column 0). But then we'd do nothing in that situation. How does it make sense? > The usage of `beyond' does not change the behaviour when the starting > column is on the first indent point, which outside of this special case > is doing nothing. When there are previous lines to align with, yes. But here there's nothing before, so what is the justification for doing nothing? From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 21:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: alex.branham@gmail.com, 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.15525988878775 (code B ref 34858); Thu, 14 Mar 2019 21:29:01 +0000 Received: (at 34858) by debbugs.gnu.org; 14 Mar 2019 21:28:07 +0000 Received: from localhost ([127.0.0.1]:44118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4XtX-0002HT-9Z for submit@debbugs.gnu.org; Thu, 14 Mar 2019 17:28:07 -0400 Received: from mail-it1-f176.google.com ([209.85.166.176]:35314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4XtW-0002Gx-8B for 34858@debbugs.gnu.org; Thu, 14 Mar 2019 17:28:06 -0400 Received: by mail-it1-f176.google.com with SMTP id 188so7586218itb.0 for <34858@debbugs.gnu.org>; Thu, 14 Mar 2019 14:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=MhFLiRVfyzzB0hr1bB1MZ9FBctEQqwUM42i/nER6p0M=; b=auPAmvHgQrQzns9DAKO4QxSyKr09yfykUanzWDIcuA8w7Jd+zCenzunDbTDKu3FAh0 qnRwDsnINiJALiCGiIFTbRMpfD7bi3dsuM+Pz8WeJ+6oAZcGH+reHFYOw7t0ahtU9S5n D87bIk26CvbKUSJjk64YhlhNV99ZumOothoGJsc0yjhuxkI0UJwT7TUsLM9xkYcrPv1r uYgdJuGZGVTs61ydTZE6pg3f6r63R0AFeBsPJDjHei0BMHeJn0NN4Qygg7Zbp9FeUfXO lukB3JdPuDtY1Z3Q8CezLzLYVCFwoPSM56TWPUcurPFRGGPj/Qna2CrhZpf7NmWRnJiY BOOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MhFLiRVfyzzB0hr1bB1MZ9FBctEQqwUM42i/nER6p0M=; b=j0DHqJl5dCW5GRriN4frHChrURl068PYehj372mGRxLvF9byf+b5JBLWkCTCdCSqe+ Y/UI8Nap+0OIQgYb6idB8naDK8HvC0IjTsXHyTQA/9nTTEve4TkeHom+ZAMbG5E1tNYc VCkGhNiJ1DlGnbkRldSpspqoc1VA4X5zed0F5cmxt8LFSmbxiy2E8iX7cr4iy1E2drVO qHpeEoSrJcV07KWtLl1Sf8EnN94sEunoaDD7ZuHLxMHAK+GUrWV/IudxmlhUxcT/BpGB oBPtLN0uJ8ELwVx2rl9TLGEKL/55ZsubSo2LJNe2puBRNiQ30cH4q6yf2Vxl4/tmCyOU B9ag== X-Gm-Message-State: APjAAAVRdj4OvOxd+WAwmtg9gzbvGgmp+9uZ+ljN+qwi8mmOuWh5WCPf dfMPXH16Ebg2N8zEukbPU9znnegM X-Google-Smtp-Source: APXvYqwc+2iLB7FQrrgL/ij+8ItLX5zxOwZSmP7d1/QDeYENbTnuViw4qsMRt0HUh/x08l7JqcN/2w== X-Received: by 2002:a24:906:: with SMTP id 6mr371969itm.76.1552598880147; Thu, 14 Mar 2019 14:28:00 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id s1sm86364iob.32.2019.03.14.14.27.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 14:27:59 -0700 (PDT) From: Alex References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87o96d5rrn.fsf@gmail.com> <83tvg51ghz.fsf@gnu.org> <87k1h15lob.fsf@gmail.com> <83lg1h1a6n.fsf@gnu.org> Date: Thu, 14 Mar 2019 15:27:54 -0600 In-Reply-To: <83lg1h1a6n.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Mar 2019 22:18:56 +0200") Message-ID: <87ftrp5ep1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Alex >> Cc: alex.branham@gmail.com, 34858@debbugs.gnu.org >> Date: Thu, 14 Mar 2019 12:57:08 -0600 >> >> Sorry, I wasn't clear. I meant that the special case here could be >> considered (trivially) equivalent to the case where the previous >> non-blank line has a single indent point at column zero, and therefore >> should be treated equivalently when FIRST-ONLY is non-nil >> (`tab-to-tab-stop` should not be called if on or past the first indent >> point, i.e., column 0). > > But then we'd do nothing in that situation. How does it make sense? > >> The usage of `beyond' does not change the behaviour when the starting >> column is on the first indent point, which outside of this special case >> is doing nothing. > > When there are previous lines to align with, yes. But here there's > nothing before, so what is the justification for doing nothing? I don't see the justification for calling `tab-to-tab-stop' since that behaviour would be surprising given that `tab-to-tab-stop' is otherwise called only if FIRST-ONLY is nil. I view FIRST-ONLY as meaning "this procedure will not indent past the first indent point"; in the case of no such point, I believe that doing nothing is the more reasonable action. Also,` indent-relative-first-indent-point' expects this behaviour. If one wants `indent-relative' to call `tab-to-tab-stop' in the case of no previous non-blank line, then one could call it without the FIRST-ONLY/prefix argument. From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Mar 2019 04:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alex Cc: alex.branham@gmail.com, 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.155262554618796 (code B ref 34858); Fri, 15 Mar 2019 04:53:02 +0000 Received: (at 34858) by debbugs.gnu.org; 15 Mar 2019 04:52:26 +0000 Received: from localhost ([127.0.0.1]:44303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4epV-0004t6-Ni for submit@debbugs.gnu.org; Fri, 15 Mar 2019 00:52:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4epU-0004st-HM for 34858@debbugs.gnu.org; Fri, 15 Mar 2019 00:52:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4epP-0002Z4-6e; Fri, 15 Mar 2019 00:52:19 -0400 Received: from [176.228.60.248] (port=1887 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h4epO-0001jg-No; Fri, 15 Mar 2019 00:52:19 -0400 Date: Fri, 15 Mar 2019 06:52:00 +0200 Message-Id: <83k1h020zz.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87ftrp5ep1.fsf@gmail.com> (message from Alex on Thu, 14 Mar 2019 15:27:54 -0600) References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87o96d5rrn.fsf@gmail.com> <83tvg51ghz.fsf@gnu.org> <87k1h15lob.fsf@gmail.com> <83lg1h1a6n.fsf@gnu.org> <87ftrp5ep1.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex > Cc: alex.branham@gmail.com, 34858@debbugs.gnu.org > Date: Thu, 14 Mar 2019 15:27:54 -0600 > > >> The usage of `beyond' does not change the behaviour when the starting > >> column is on the first indent point, which outside of this special case > >> is doing nothing. > > > > When there are previous lines to align with, yes. But here there's > > nothing before, so what is the justification for doing nothing? > > I don't see the justification for calling `tab-to-tab-stop' since that > behaviour would be surprising given that `tab-to-tab-stop' is otherwise > called only if FIRST-ONLY is nil. I view FIRST-ONLY as meaning "this > procedure will not indent past the first indent point"; in the case of > no such point, I believe that doing nothing is the more reasonable > action. Also,` indent-relative-first-indent-point' expects this > behaviour. > > If one wants `indent-relative' to call `tab-to-tab-stop' in the case of > no previous non-blank line, then one could call it without the > FIRST-ONLY/prefix argument. I guess we will have to disagree, then. Alex, feel free to start a discussion on emacs-devel regarding what to do in this special case, it seems like there's a certain controversy. Thanks. From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Filipp Gunbin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Mar 2019 20:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alex Branham Cc: Eli Zaretskii , 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.15531134127766 (code B ref 34858); Wed, 20 Mar 2019 20:24:02 +0000 Received: (at 34858) by debbugs.gnu.org; 20 Mar 2019 20:23:32 +0000 Received: from localhost ([127.0.0.1]:52204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6hkK-00021B-Gd for submit@debbugs.gnu.org; Wed, 20 Mar 2019 16:23:32 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:50541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6hkI-00020y-KR for 34858@debbugs.gnu.org; Wed, 20 Mar 2019 16:23:30 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7641D23A4C; Wed, 20 Mar 2019 16:23:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 20 Mar 2019 16:23:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=n2D2ZtDkEezW025EwIanN0hqXe PlPH8hbAQ/tDoj2J0=; b=qxHb09gV4hlYqrFY9csl1cyuZp1/H6AcjuYfN7nFTY NPMXwS2a5IJpef0pwDVa6mD2vj/ML/wtPi8TT9DEB6EsymLeNTWhvNb8sL96xndC 25vsxjp0/Rmn2pZTAMIayg3N1bMW0pK7yBW9KQkiOOgKx69agoaeVr0z4t0oE11p vOJmz/ahDmv2e/yXOaZqKGHtjVfAxrJLUVDta5KsXXPdZh5Lwo2ItEyAYfwCCL6C KYwJj+aUe4Q4TfqIboVrf0PPb5O8mNykjTqDmLodBBl0/lR6cYt+bg1ZHnXnWSOI EEs0/1Ula3R9qIz120WIs8uFktsLITzwbQ1/XQ/D1oqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=n2D2Zt DkEezW025EwIanN0hqXePlPH8hbAQ/tDoj2J0=; b=CKpfrKtnLbd6OnYC4NgSKP gzXYHTGVUK5cEKigfQ2Rl+43Z2mxnZllLjLw5NSSvEmXtXJplYbSE6tCIGNSPkeR muBR+JW0lbed5322/kTZi0DvO4v04DlXHtjbWZf3mKASMf/hxK7aNmrBeZoMHnwm 2bzfigBYZOHxaE1OuSQpP4QLq0p0qcDKQtJjdsjHrzNdrsF3/hc5DB6X+U+UFg5x smnVMCWbIZhapscIEsF1ilcYwatIBcoJWnSOgIz/EFb06CvZFk5kfhpTWNU9KQaO NAA51jMwEZCbOYxFTrASgbkvQTfNYhrddza1Cz5VcP8pV7gfetJascSHTsCBpQyg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrieeigddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefhihhlihhp phcuifhunhgsihhnuceofhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmheqnecukfhppe elfedrudehfedrudejuddruddvieenucfrrghrrghmpehmrghilhhfrhhomhepfhhguhhn sghinhesfhgrshhtmhgrihhlrdhfmhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from fgunbin.local (unknown [93.153.171.126]) by mail.messagingengine.com (Postfix) with ESMTPA id 5772710310; Wed, 20 Mar 2019 16:23:24 -0400 (EDT) From: Filipp Gunbin In-Reply-To: <87wol1l9bn.fsf@gmail.com> (Alex Branham's message of "Thu, 14 Mar 2019 11:17:16 -0500") References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87wol1l9bn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Wed, 20 Mar 2019 23:23:22 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Alex, a minor comment: On 14/03/2019 11:17 -0500, Alex Branham wrote: > diff --git a/lisp/indent.el b/lisp/indent.el > index 34757a43d7..25615f4113 100644 > --- a/lisp/indent.el > +++ b/lisp/indent.el > @@ -598,8 +598,8 @@ considered. > > If the previous nonblank line has no indent points beyond the > column point starts at, then `tab-to-tab-stop' is done, if both > -FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done > -in this case. > +FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done. > +If there isn't a previous nonblank line, call `tab-to-tab-stop'. ^ and UNINDENTED-OK is nil Filipp From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Mar 2019 23:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Filipp Gunbin Cc: Eli Zaretskii , 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.155355520919345 (code B ref 34858); Mon, 25 Mar 2019 23:07:01 +0000 Received: (at 34858) by debbugs.gnu.org; 25 Mar 2019 23:06:49 +0000 Received: from localhost ([127.0.0.1]:58798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Yg5-00051w-8J for submit@debbugs.gnu.org; Mon, 25 Mar 2019 19:06:49 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:42391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Yg3-00051i-Bi for 34858@debbugs.gnu.org; Mon, 25 Mar 2019 19:06:47 -0400 Received: by mail-oi1-f178.google.com with SMTP id w139so8414457oie.9 for <34858@debbugs.gnu.org>; Mon, 25 Mar 2019 16:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=C57ALEYeNMxX2pvMmNHsn/ekUMuHlFxwmfXVRvzo+WE=; b=pwGDpBjnyx0DMIDZg2XOkEiFETR9J60yraRS0naitAtZkOa62+Y52QM+Q0ZcApMnDM Q48l3y8DmIgXf2zy/Ay3nlMuYXgGFVOJsrFCHF+f3jGJG0jZk3onokYNjFTzJ3buAOp0 7Z+ieYT/L9L/d8bmPeTY/PEjF3sFsmfLExvzkQunhSr9g0aW3QiuDCgL/KwDEYCmaFEM Zkvdi+bVEfIlK+zBVutG+zORqn5tTFV1qq6hMu+NxxMG+gPcgrzXg2xluNHgkcKYdT3U wOVbeo24rKA4UQ3GSe3Ze5pRrIFg2CEWHbU5xReKdc5Z2r0WDS6cOP6ZEv4fQcpLYhPF jt6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=C57ALEYeNMxX2pvMmNHsn/ekUMuHlFxwmfXVRvzo+WE=; b=V/m6yfGiU8b2G9e5Dpu0sVQk+kwQEdILDRhY5TGyHiRt+K+eHI1+FLYX5Flyg1O+i9 VKFfRwngu1qx83Ff5/amh+5SQe7s7Umt7vDV/kBrZ/CBoJrUqCWdUPS5fRyPz8DWXVi3 dh6kCvTaqT901iaNS6WGPVgzIdFO53BR+DGrQ9U5GoduzH0YfcwlPrJW6iLev94ZkvFM IUR7c9HaYsO1mlU3srGUbRrT6/eo0uS0hMVgNvAVSzcUiI49LicDPTr4XQt+CJXyvGqf E8H+iWV09mNGZFzBPlMwiuNKC4Nu6ChH89dVH7I2PFiH54pMGCvKgVA1hd2mBhIrqkjW 4fkw== X-Gm-Message-State: APjAAAXfH+bqagYt2kCmI9tFC6/dPdu7cNi/fy3+/AhUmCHg3TW6jvRn aUq5543CFL9+xNRGbeZ16/D2k8x5 X-Google-Smtp-Source: APXvYqxKKRrdHf4sp0QV2QXMxX+fo8U1XtepYRW/FGQO+UZPtbiEzksOUSRqX76K1Wc6bD8CTTSNhA== X-Received: by 2002:aca:adc8:: with SMTP id w191mr13663913oie.110.1553555201385; Mon, 25 Mar 2019 16:06:41 -0700 (PDT) Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id i9sm6587020oth.13.2019.03.25.16.06.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Mar 2019 16:06:39 -0700 (PDT) References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87wol1l9bn.fsf@gmail.com> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham In-reply-to: Date: Mon, 25 Mar 2019 18:06:37 -0500 Message-ID: <87y352tuyq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed 20 Mar 2019 at 15:23, Filipp Gunbin wrote: > Alex, a minor comment: > >> -FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done >> -in this case. >> +FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done. >> +If there isn't a previous nonblank line, call `tab-to-tab-stop'. > ^ > and UNINDENTED-OK is nil Thanks. I'll include that and push this patch later this week, unless I hear back otherwise. Alex From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Mar 2019 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alex Branham Cc: fgunbin@fastmail.fm, 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.155361478225729 (code B ref 34858); Tue, 26 Mar 2019 15:40:02 +0000 Received: (at 34858) by debbugs.gnu.org; 26 Mar 2019 15:39:42 +0000 Received: from localhost ([127.0.0.1]:60411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8oAw-0006gv-Im for submit@debbugs.gnu.org; Tue, 26 Mar 2019 11:39:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8oAu-0006gh-26 for 34858@debbugs.gnu.org; Tue, 26 Mar 2019 11:39:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8oAo-0007dA-Dp; Tue, 26 Mar 2019 11:39:34 -0400 Received: from [176.228.60.248] (port=4931 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h8oAn-0003Ey-Ka; Tue, 26 Mar 2019 11:39:33 -0400 Date: Tue, 26 Mar 2019 17:39:38 +0200 Message-Id: <838sx1mypx.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87y352tuyq.fsf@gmail.com> (message from Alex Branham on Mon, 25 Mar 2019 18:06:37 -0500) References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87wol1l9bn.fsf@gmail.com> <87y352tuyq.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex Branham > Cc: Eli Zaretskii , 34858@debbugs.gnu.org > Date: Mon, 25 Mar 2019 18:06:37 -0500 > > Thanks. I'll include that and push this patch later this week, unless I > hear back otherwise. I asked to raise the issue about which we disagreed on emacs-devel, to see what others think. I don't think I saw any such discussion, did I miss it? Thanks. From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Mar 2019 15:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: fgunbin@fastmail.fm, 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.155361493325991 (code B ref 34858); Tue, 26 Mar 2019 15:43:01 +0000 Received: (at 34858) by debbugs.gnu.org; 26 Mar 2019 15:42:13 +0000 Received: from localhost ([127.0.0.1]:60419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8oDN-0006l8-Au for submit@debbugs.gnu.org; Tue, 26 Mar 2019 11:42:13 -0400 Received: from mail-oi1-f173.google.com ([209.85.167.173]:44500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8oDL-0006kv-Sg for 34858@debbugs.gnu.org; Tue, 26 Mar 2019 11:42:12 -0400 Received: by mail-oi1-f173.google.com with SMTP id i21so10254856oib.11 for <34858@debbugs.gnu.org>; Tue, 26 Mar 2019 08:42:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=gtYhcDXzL7LF2932Ka5HEnLT5MF5rJ341VrKD53mxj4=; b=hlgvymnha/HWwf87K55+Y2ww8mnKAh93wjSbAMdI4hRrJUiCoJgnuzFgypBzsXjovC aXpcKHkUv81te4/+VYutbxCVy3OA6vo+EcCgVNkFw9mu65xK1OeKGN0h7bbFpbcUVuww 9+nLVeEwzqAGnMUTXxrE6das7BdoPfZUI4KiHW7v6A6fo7qTyjSPb0NGoIBEv5dRc1Ca 9je3YyS4nWxFSWMgfhMpNRU46OXoc+r5tI266GT8vKBzPL+ZUC+nJPDQFlXm66IifNEf tbH5B4c3efuq+CpAsaXv1yIcnz5w3z7CEXXtpcr+iV/EjcxBIV7PAK66LuVhO9KjB+GY 6HCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=gtYhcDXzL7LF2932Ka5HEnLT5MF5rJ341VrKD53mxj4=; b=iQp7EedOuTC6KtU/O3+tNOU4ZGz2gAueEFdz+u4zSsUV+9HzJk7wS1Pl698d8cDOcN +0MUFacdtKOabxWk3cByHg/xGr7+uZFJdG0Op3adTDsKFQAhi12pPFPIckFuYcuvcOiR hz39B0XG8lR8MeOnHAekhDet6Uj/nm99PhEnXqku1hYVzTQBbr+HG2Hpefyh/CgHq+Qx yRY9LhuhL3dqek/FSTBYWLRn1J0y+66E6WMjzYaJPY69EeHND23IqKWDweNOg0xxIvlt gRRWNgASAKPWNDlm5m+LFuscUWL0s1n/J8odG3sLIBWzpA1JqFyI7zYE1DDJcPA3cNdD Jx7w== X-Gm-Message-State: APjAAAWIZlIWuWoK0+uoXp1HYTqCOkF2KbTj6cGEk+lCfftLgsP3DLUQ hPGp0Ae/H4xOBXEsLLatLeE2A+v0Xw4= X-Google-Smtp-Source: APXvYqwy3wyppbykMrNyRbFkmW6Gd1CRmhuhMG9lG389A8bdf3ElxrkE9zk5Nym/PBW2l1vZIDOGrA== X-Received: by 2002:aca:dc8b:: with SMTP id t133mr16447685oig.25.1553614925704; Tue, 26 Mar 2019 08:42:05 -0700 (PDT) Received: from mars (nat-128-62-52-241.public.utexas.edu. [128.62.52.241]) by smtp.gmail.com with ESMTPSA id i203sm7396897oih.13.2019.03.26.08.42.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 08:42:05 -0700 (PDT) References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87wol1l9bn.fsf@gmail.com> <87y352tuyq.fsf@gmail.com> <838sx1mypx.fsf@gnu.org> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham In-reply-to: <838sx1mypx.fsf@gnu.org> Date: Tue, 26 Mar 2019 10:42:04 -0500 Message-ID: <87tvfpfxrn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue 26 Mar 2019 at 10:39, Eli Zaretskii wrote: >> Thanks. I'll include that and push this patch later this week, unless I >> hear back otherwise. > > I asked to raise the issue about which we disagreed on emacs-devel, to > see what others think. I don't think I saw any such discussion, did I > miss it? Confusingly, it wasn't me you disagreed with, that was a different Alex :-) I didn't see it either, FWIW. Either way that gets decided, I think this is OK to push in the meantime to emacs-26 since the behavior there will be unchanged, right? The changed behavior would only be 27-forward. Alex From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Mar 2019 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alex Branham Cc: fgunbin@fastmail.fm, 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.155361887932173 (code B ref 34858); Tue, 26 Mar 2019 16:48:02 +0000 Received: (at 34858) by debbugs.gnu.org; 26 Mar 2019 16:47:59 +0000 Received: from localhost ([127.0.0.1]:60497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8pF1-0008Mq-43 for submit@debbugs.gnu.org; Tue, 26 Mar 2019 12:47:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8pEz-0008Me-MV for 34858@debbugs.gnu.org; Tue, 26 Mar 2019 12:47:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8pEu-0000nD-C5; Tue, 26 Mar 2019 12:47:52 -0400 Received: from [176.228.60.248] (port=1498 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h8pEt-0000ea-Pc; Tue, 26 Mar 2019 12:47:52 -0400 Date: Tue, 26 Mar 2019 18:47:59 +0200 Message-Id: <83wokllgzk.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87tvfpfxrn.fsf@gmail.com> (message from Alex Branham on Tue, 26 Mar 2019 10:42:04 -0500) References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87wol1l9bn.fsf@gmail.com> <87y352tuyq.fsf@gmail.com> <838sx1mypx.fsf@gnu.org> <87tvfpfxrn.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex Branham > Cc: fgunbin@fastmail.fm, 34858@debbugs.gnu.org > Date: Tue, 26 Mar 2019 10:42:04 -0500 > > Either way that gets decided, I think this is OK to push in the meantime > to emacs-26 since the behavior there will be unchanged, right? The > changed behavior would only be 27-forward. Please don't push anything to emacs-26 yet, until we either release Emacs 26.2 or decide we need another RC. Thanks. From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Apr 2019 00:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alex Branham Cc: Eli Zaretskii , 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.155416393216984 (code B ref 34858); Tue, 02 Apr 2019 00:13:01 +0000 Received: (at 34858) by debbugs.gnu.org; 2 Apr 2019 00:12:12 +0000 Received: from localhost ([127.0.0.1]:40097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB72C-0004Ps-5t for submit@debbugs.gnu.org; Mon, 01 Apr 2019 20:12:12 -0400 Received: from mail-ed1-f51.google.com ([209.85.208.51]:46611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB729-0004Pc-Q4 for 34858@debbugs.gnu.org; Mon, 01 Apr 2019 20:12:10 -0400 Received: by mail-ed1-f51.google.com with SMTP id d1so9965073edd.13 for <34858@debbugs.gnu.org>; Mon, 01 Apr 2019 17:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uZCeJedEpLJNVPXHPvNfggXSPlpuAaavJo8aj32653c=; b=uvDfIX2XcVN4elvjpQbDMpZ+IMiGR7Z+k4BYjx3O6PswKN/YoAMiv2KFWQz4lFji1Y WTZCCGGebzLwtIHxn6oJMy6octnumoVSEQkRNXLy4uGGZRgqtUe/DdY+NQnV6oQvMQUl zoPaiE+SsnttZVjhSW+cJeFfT15WEKLMZq3mTd7ePQZ7NPpZjsTAd5VmVedXoqsuRG7S GjEA057slFOqTCeO29kjKzcwLljr1B8EAshwxl+hzBMscgx61XTmkcMxYaktjsDjoDI2 z9H3gRiqKDk7W66DxuZUTo2bWGLrGwaSRXVQFNQdf8USrlnCFJ7oElcsWoVwaZTWiqpa +atQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uZCeJedEpLJNVPXHPvNfggXSPlpuAaavJo8aj32653c=; b=XxljDoRVkLT1CFykj2AXynqH3wXQhnOshDQsls+rcP3drFhax+YKQVtj9Mq5KbcOFP LGvwo7vdFBPjRdCiw9+xeP8hpvV9tZIANczVBifRDa8FsiisVHadXwosZZ3qq4y8XTlg jEA5vyNpLBcoLZlMNzkbCmc+vTIvqdUEBnGhPSlgCg7pEO+BHuC0xr0cAIC0aRnGdKAF ddXOlqOEB2GzXQHNI1cfDMYS3YD+88TUqX4liw30M1SPNo/XsCYK8xiSFrr+a3I20Dqi 5yRE61B0g/LMfqeLqDKZDY/Dma3SonrmRVsLXAg1qgWkb/8gTJ6IR9nF0nD5Ofjt7hY1 5i1w== X-Gm-Message-State: APjAAAV04PKXXU2WUYVat2/rw0AJtfn+II0t/Wq5fhkmUQA2oTpr3iDY q5+f15N3ur4lcVc+XgSZHo0tag== X-Google-Smtp-Source: APXvYqzi8Azh9kFQpuY5BypJMqhDH/degrnjfGLPDydlsKgpW0C2RqanEv3S8FjLB3Dl+tYUnvkoWA== X-Received: by 2002:aa7:c383:: with SMTP id k3mr7267357edq.137.1554163924172; Mon, 01 Apr 2019 17:12:04 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:20c2:134e:4f3a:683a]) by smtp.gmail.com with ESMTPSA id i49sm1937433ede.95.2019.04.01.17.12.02 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 01 Apr 2019 17:12:03 -0700 (PDT) From: "Basil L. Contovounesios" References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87wol1l9bn.fsf@gmail.com> Date: Tue, 02 Apr 2019 01:11:57 +0100 In-Reply-To: <87wol1l9bn.fsf@gmail.com> (Alex Branham's message of "Thu, 14 Mar 2019 11:17:16 -0500") Message-ID: <87v9zx6zaq.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Alex Branham writes: > On Thu 14 Mar 2019 at 11:00, Eli Zaretskii wrote: > >> I think this is a documentation bug, as it doesn't describe the >> special case of "no previous nonblank line". > > OK, patch attached. While looking over this I noticed the lisp reference > manual also needed to be updated a bit so I did that as well. I think some code needs updating in addition to the Elisp manual: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Avoid-using-obsolete-indent-relative-maybe.patch >From d8c74ae527c52cffcb23d9704a899dd304188276 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Tue, 2 Apr 2019 00:56:04 +0100 Subject: [PATCH] Avoid using obsolete indent-relative-maybe * lisp/electric.el (electric-indent-functions-without-reindent): * lisp/indent.el (indent-according-to-mode): Check for indent-relative-first-indent-point in addition to its obsolete alias indent-relative-maybe. * lisp/obsolete/vi.el (vi-com-map): Use indent-relative-first-indent-point in place of its obsolete alias indent-relative-maybe. --- lisp/electric.el | 6 +++--- lisp/indent.el | 10 ++++++---- lisp/obsolete/vi.el | 2 +- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/lisp/electric.el b/lisp/electric.el index 657913a396..07da2f1d9e 100644 --- a/lisp/electric.el +++ b/lisp/electric.el @@ -223,9 +223,9 @@ electric-indent-inhibit (defvar electric-indent-functions-without-reindent '(indent-relative indent-to-left-margin indent-relative-maybe - py-indent-line coffee-indent-line org-indent-line yaml-indent-line - haskell-indentation-indent-line haskell-indent-cycle haskell-simple-indent - yaml-indent-line) + indent-relative-first-indent-point py-indent-line coffee-indent-line + org-indent-line yaml-indent-line haskell-indentation-indent-line + haskell-indent-cycle haskell-simple-indent yaml-indent-line) "List of indent functions that can't reindent. If `indent-line-function' is one of those, then `electric-indent-mode' will not try to reindent lines. It is normally better to make the major diff --git a/lisp/indent.el b/lisp/indent.el index 34757a43d7..f3d3158faa 100644 --- a/lisp/indent.el +++ b/lisp/indent.el @@ -65,15 +65,17 @@ indent-according-to-mode "Indent line in proper way for current major mode. Normally, this is done by calling the function specified by the variable `indent-line-function'. However, if the value of that -variable is `indent-relative' or `indent-relative-maybe', handle -it specially (since those functions are used for tabbing); in -that case, indent by aligning to the previous non-blank line." +variable is `indent-relative' or `indent-relative-first-indent-point', +handle it specially (since those functions are used for tabbing); +in that case, indent by aligning to the previous non-blank line." (interactive) (save-restriction (widen) (syntax-propertize (line-end-position)) (if (memq indent-line-function - '(indent-relative indent-relative-maybe)) + '(indent-relative + indent-relative-maybe + indent-relative-first-indent-point)) ;; These functions are used for tabbing, but can't be used for ;; indenting. Replace with something ad-hoc. (let ((column (save-excursion diff --git a/lisp/obsolete/vi.el b/lisp/obsolete/vi.el index 7d44f561d4..df5ddfdbcf 100644 --- a/lisp/obsolete/vi.el +++ b/lisp/obsolete/vi.el @@ -132,7 +132,7 @@ vi-com-map (define-key vi-com-map "\C-e" 'vi-expose-line-below) (define-key vi-com-map "\C-f" 'vi-forward-windowful) (define-key vi-com-map "\C-g" 'keyboard-quit) - (define-key vi-com-map "\C-i" 'indent-relative-maybe) ; TAB + (define-key vi-com-map "\C-i" 'indent-relative-first-indent-point) ; TAB (define-key vi-com-map "\C-j" 'vi-next-line) ; LFD (define-key vi-com-map "\C-k" 'vi-kill-line) ; extension (define-key vi-com-map "\C-l" 'recenter) -- 2.20.1 --=-=-= Content-Type: text/plain I think the changes pertaining to the move from indent-relative-maybe to indent-relative-first-indent-point should be pushed independently of any changes to the behaviour of indent-relative at BOB or its documentation. Can they be pushed to master, and only backported to emacs-26 as needed/applicable? > From cefe6581558e45558907996ea39ac44e512f7944 Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Thu, 14 Mar 2019 11:14:18 -0500 > Subject: [PATCH] Update documentation for indent-relative functions > > * lisp/indent.el (indent-relative): Document what happens when there > is no previous nonblank line. > * doc/lispref/text.texi (Relative Indent): Document > indent-relative-first-indent-point instead of obsolete > indent-relative-maybe. Fix documentation of which argument from ^^^ Missing double space. > diff --git a/doc/lispref/text.texi b/doc/lispref/text.texi > index 21c5a73f88..abcea17010 100644 > --- a/doc/lispref/text.texi > +++ b/doc/lispref/text.texi > @@ -2571,11 +2571,11 @@ The quick brown fox jum @point{}ped. > @end example > @end deffn > > -@deffn Command indent-relative-maybe > +@deffn Command indent-relative-first-indent-point > @comment !!SourceFile indent.el > This command indents the current line like the previous nonblank line, > by calling @code{indent-relative} with @code{t} as the > -@var{unindented-ok} argument. The return value is unpredictable. > +@var{first-only} argument. The return value is unpredictable. Just curious: is there any preference between "unpredictable" and "undefined" for documenting return values? If so, why? > If the previous nonblank line has no indent points beyond the current > column, this command does nothing. > diff --git a/lisp/indent.el b/lisp/indent.el > index 34757a43d7..25615f4113 100644 > --- a/lisp/indent.el > +++ b/lisp/indent.el > @@ -598,8 +598,8 @@ considered. > > If the previous nonblank line has no indent points beyond the > column point starts at, then `tab-to-tab-stop' is done, if both > -FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done > -in this case. > +FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done. > +If there isn't a previous nonblank line, call `tab-to-tab-stop'. I'm not against spelling this final sentence out, but in my reading it's already covered by the first sentence, as a non-existent line vacuously "has no indent points beyond the column point starts at". ;) Thanks, -- Basil --=-=-=-- From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Apr 2019 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Basil L. Contovounesios" Cc: alex.branham@gmail.com, 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.15542160209256 (code B ref 34858); Tue, 02 Apr 2019 14:41:02 +0000 Received: (at 34858) by debbugs.gnu.org; 2 Apr 2019 14:40:20 +0000 Received: from localhost ([127.0.0.1]:41427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBKaI-0002PA-6b for submit@debbugs.gnu.org; Tue, 02 Apr 2019 10:40:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBKaF-0002Ou-PG for 34858@debbugs.gnu.org; Tue, 02 Apr 2019 10:40:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBKa9-0006I4-NI; Tue, 02 Apr 2019 10:40:09 -0400 Received: from [176.228.60.248] (port=4033 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hBKa7-00014z-6m; Tue, 02 Apr 2019 10:40:08 -0400 Date: Tue, 02 Apr 2019 17:40:20 +0300 Message-Id: <83zhp8fp2j.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87v9zx6zaq.fsf@tcd.ie> (contovob@tcd.ie) References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87wol1l9bn.fsf@gmail.com> <87v9zx6zaq.fsf@tcd.ie> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: "Basil L. Contovounesios" > Cc: Eli Zaretskii , 34858@debbugs.gnu.org > Date: Tue, 02 Apr 2019 01:11:57 +0100 > > > OK, patch attached. While looking over this I noticed the lisp reference > > manual also needed to be updated a bit so I did that as well. > > I think some code needs updating in addition to the Elisp manual: Fine with me, thanks. > I think the changes pertaining to the move from indent-relative-maybe to > indent-relative-first-indent-point should be pushed independently of any > changes to the behaviour of indent-relative at BOB or its documentation. > > Can they be pushed to master, and only backported to emacs-26 as > needed/applicable? Yes. Please note that the emacs-26 branch is currently frozen, as we will probably release Emacs 26.2 soon. > > -@var{unindented-ok} argument. The return value is unpredictable. > > +@var{first-only} argument. The return value is unpredictable. > > Just curious: is there any preference between "unpredictable" and > "undefined" for documenting return values? If so, why? I actually don't understand why this sentence should be there at all. IMO, it isn't useful to say that the return value is undefined, better not to say anything (which has the same meaning, but avoids the possible interpretation that other doc strings, which don't say that, imply otherwise). > > --- a/lisp/indent.el > > +++ b/lisp/indent.el > > @@ -598,8 +598,8 @@ considered. > > > > If the previous nonblank line has no indent points beyond the > > column point starts at, then `tab-to-tab-stop' is done, if both > > -FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done > > -in this case. > > +FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done. > > +If there isn't a previous nonblank line, call `tab-to-tab-stop'. > > I'm not against spelling this final sentence out, but in my reading it's > already covered by the first sentence, as a non-existent line vacuously > "has no indent points beyond the column point starts at". ;) Adding that was the main purpose of the changeset, as at least one person wasn't sure your interpretation is so clearly implied. From unknown Sun Jun 22 11:37:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34858: indent-relative called with prefix calls tab-to-tab-stop Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Apr 2019 17:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: alex.branham@gmail.com, 34858@debbugs.gnu.org Received: via spool by 34858-submit@debbugs.gnu.org id=B34858.155431155021235 (code B ref 34858); Wed, 03 Apr 2019 17:13:01 +0000 Received: (at 34858) by debbugs.gnu.org; 3 Apr 2019 17:12:30 +0000 Received: from localhost ([127.0.0.1]:43165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBjR7-0005WQ-J7 for submit@debbugs.gnu.org; Wed, 03 Apr 2019 13:12:29 -0400 Received: from mail-ed1-f48.google.com ([209.85.208.48]:34561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBjR5-0005WE-T2 for 34858@debbugs.gnu.org; Wed, 03 Apr 2019 13:12:28 -0400 Received: by mail-ed1-f48.google.com with SMTP id x14so15625125eds.1 for <34858@debbugs.gnu.org>; Wed, 03 Apr 2019 10:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=A9rCIeqeJThbZh+ZIvAkEjTErHothahyiZOdyRxD+cg=; b=dFqCusxPAuQ44698yxru5stAazogjuwqVU9OnJ5JYeXbJ7WMDiQOxMhOJogwc+p/Hv /AKHZqPvEQ9uFVz3S2jC/XoZo58M3TtI4Qwp7b1nCR5ejBkWd7lOS9ZS2KYpT/6ErfwR hUoTQr5bqZMnfIjWYeSq5fuNQlX+fG+6nSVHgYTNVUUZbGSs01pxQK9DB73V57e0WpXi A6//+4kU5tDhTbBiNp8bGn8XBOppPtAT9r8ZxW5JrHYRu/EVlAoV4i3nqXyg0BFY6zCp +qi1E1tK+3fHQT7pXTCAzotZI9mwh6iHFeSErqUxxQhkwaq9ebkE5XP3+EZIs3jiG+HL gjwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=A9rCIeqeJThbZh+ZIvAkEjTErHothahyiZOdyRxD+cg=; b=Y5vi6mDNWB1+y+TMybVNl1HlKx4PB+yS/M/JfsBjjIgvURl5BdObBjIP9GAi9OfcSF GHNoMruzf8g8KYsEAHWnFo6llZanfe/kPbUnFJ/P3WdXFnxrQamcD512xOjkqufBlWqg WLDlNODGNCsgd8hTO0XAD5MXmKutDDtAS4JneQxusPeMHIUpwm59luQBVsG9sYyKN19x ZyhZdKRsJB5LiXwYEkCsy/3sKDz1TXEg9cD12i4G6KQr+4NRUccempFLfYKbTLCrZYmb CWBRCJsYoCDKUBDCVigQufiCXsQd2NURCK684AkI9NKR1A2e4dqQAFUkY6BTh8ufpF1f JUcA== X-Gm-Message-State: APjAAAXLMOCqZ96Fp9sp5uj/I0Eu3QwavvG41kit/GByZ/HQeOtbuiwd NVwZqw9OdIfC7SBTlptEkbd3cg== X-Google-Smtp-Source: APXvYqzDALvGvHyHOPOUHro6+PDjXeeV1LL9LWx5R9xctKYAOa8pFKGboylVk893XR5nSVl0Bn7Iig== X-Received: by 2002:a17:906:4e58:: with SMTP id g24mr552390ejw.190.1554311542010; Wed, 03 Apr 2019 10:12:22 -0700 (PDT) Received: from localhost ([134.226.214.248]) by smtp.gmail.com with ESMTPSA id x3sm1580560ejb.53.2019.04.03.10.12.20 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 03 Apr 2019 10:12:21 -0700 (PDT) From: "Basil L. Contovounesios" References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87wol1l9bn.fsf@gmail.com> <87v9zx6zaq.fsf@tcd.ie> <83zhp8fp2j.fsf@gnu.org> Date: Wed, 03 Apr 2019 18:12:15 +0100 In-Reply-To: <83zhp8fp2j.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 2 Apr 2019 17:40:20 +0300") Message-ID: <878swrrp1s.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Cc: Eli Zaretskii , 34858@debbugs.gnu.org >> Date: Tue, 02 Apr 2019 01:11:57 +0100 >> >> > OK, patch attached. While looking over this I noticed the lisp reference >> > manual also needed to be updated a bit so I did that as well. >> >> I think some code needs updating in addition to the Elisp manual: > > Fine with me, thanks. > >> I think the changes pertaining to the move from indent-relative-maybe to >> indent-relative-first-indent-point should be pushed independently of any >> changes to the behaviour of indent-relative at BOB or its documentation. >> >> Can they be pushed to master, and only backported to emacs-26 as >> needed/applicable? > > Yes. Thanks, pushed to master. Alex, can you also please push your docfixes for the Elisp manual? > Please note that the emacs-26 branch is currently frozen, as we will > probably release Emacs 26.2 soon. Right, that's what I was alluding to when I said "as needed/applicable". >> > -@var{unindented-ok} argument. The return value is unpredictable. >> > +@var{first-only} argument. The return value is unpredictable. >> >> Just curious: is there any preference between "unpredictable" and >> "undefined" for documenting return values? If so, why? > > I actually don't understand why this sentence should be there at all. > IMO, it isn't useful to say that the return value is undefined, better > not to say anything (which has the same meaning, but avoids the > possible interpretation that other doc strings, which don't say that, > imply otherwise). Seconded. >> > --- a/lisp/indent.el >> > +++ b/lisp/indent.el >> > @@ -598,8 +598,8 @@ considered. >> > >> > If the previous nonblank line has no indent points beyond the >> > column point starts at, then `tab-to-tab-stop' is done, if both >> > -FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done >> > -in this case. >> > +FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done. >> > +If there isn't a previous nonblank line, call `tab-to-tab-stop'. >> >> I'm not against spelling this final sentence out, but in my reading it's >> already covered by the first sentence, as a non-existent line vacuously >> "has no indent points beyond the column point starts at". ;) > > Adding that was the main purpose of the changeset, as at least one > person wasn't sure your interpretation is so clearly implied. Right. Thanks, -- Basil From unknown Sun Jun 22 11:37:27 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Alex Branham Subject: bug#34858: closed (Re: bug#34858: indent-relative called with prefix calls tab-to-tab-stop) Message-ID: References: <875zrsuf8r.fsf@gmail.com> <871s39mpu6.fsf@gmail.com> X-Gnu-PR-Message: they-closed 34858 X-Gnu-PR-Package: emacs Reply-To: 34858@debbugs.gnu.org Date: Sat, 06 Apr 2019 00:53:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1554511982-2605-1" This is a multi-part message in MIME format... ------------=_1554511982-2605-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #34858: indent-relative called with prefix calls tab-to-tab-stop which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 34858@debbugs.gnu.org. --=20 34858: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34858 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1554511982-2605-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 34858-done) by debbugs.gnu.org; 6 Apr 2019 00:52:47 +0000 Received: from localhost ([127.0.0.1]:46419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCZZe-0000fM-Rd for submit@debbugs.gnu.org; Fri, 05 Apr 2019 20:52:47 -0400 Received: from mail-oi1-f176.google.com ([209.85.167.176]:38620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCZZc-0000f7-Pb for 34858-done@debbugs.gnu.org; Fri, 05 Apr 2019 20:52:45 -0400 Received: by mail-oi1-f176.google.com with SMTP id a6so6351499oie.5 for <34858-done@debbugs.gnu.org>; Fri, 05 Apr 2019 17:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=kSI1Jb2MunLIo+npmWNSM+urFzz5FQpzYLSaLYpMFko=; b=lA1pZ3bx5eTTQt4MyHHV8j+BIkTW/Wxd7//XL/b83h5S83qzJpJ/TupkzuV7jIkXf5 9s3KVL3UeeSXIwsNq2IedFztRYr/QnjCVI39FkqkwjLg2uyqD6utTPIv4VjjSgPugOa9 VuehTmVo+nZVOZoE+Bex4GZypF6iQk+8QYPjsaR/JoARkfd54YsB3cJ1Wm+/H1FsET9a r4nOlXENIcQ7VQC7+WN8pq3ILabbGbEx3Mw2XCP4uDMwcQoURLnw3fqVvaNa6K3eBaWe HZ2D9m2303L3IV4dAQHI3Sz5/RPkOCmrY1bnb6br/xDn5S9CTj9R+hQEQ+kSU8Gs8+WL litw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=kSI1Jb2MunLIo+npmWNSM+urFzz5FQpzYLSaLYpMFko=; b=lyX4qkhOgoqrwMugy82K7YcVFkRERrXxna0nOUt+pPBYdh6Jx0WQbBUce+6e3qgGdr 23z5jT5EybGBD+hHHWWRr+4LjSfosNwUv1j0+dcDD5UIPh0P8bSZc7mqozWItNWKBJ91 CcBVZnDu+gEubnSnwW6w/MQIF55eyM01BkAiVq/M63/IWv+tlTbcWQktyeNKCo1ziiMk 0X/E/0oIU9jB5slfiOBKYMGTEnGbTE28t2y0TXN/3LFOhbngZRJkB16tT4udNEDP72b6 9gcbFMR1vSLpNbeorEcqxDz+/4hmoWtK86OkAvEdRIynCf+f0NZ1All2lvjH+WI+4DGV 8POQ== X-Gm-Message-State: APjAAAUDkKcH00Y3KT8CGJINtcCqVmvH9Zl8IYNqhBCA2UZo1q5WE3aY pc/V2SIOPSkwOMJ5XG49D5Iw+Vsz X-Google-Smtp-Source: APXvYqyaU+SxKsD7GVTUUiqtHAAB3yOAZtGf7dkFu0K5UqMpeBk9VokdwolZXuYKCAHiySFT2mPsCw== X-Received: by 2002:aca:544b:: with SMTP id i72mr8569055oib.51.1554511958647; Fri, 05 Apr 2019 17:52:38 -0700 (PDT) Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id u198sm9623598oie.26.2019.04.05.17.52.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Apr 2019 17:52:37 -0700 (PDT) References: <871s39mpu6.fsf@gmail.com> <83wol11m5b.fsf@gnu.org> <87wol1l9bn.fsf@gmail.com> <87v9zx6zaq.fsf@tcd.ie> <83zhp8fp2j.fsf@gnu.org> <878swrrp1s.fsf@tcd.ie> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: "Basil L. Contovounesios" Subject: Re: bug#34858: indent-relative called with prefix calls tab-to-tab-stop In-reply-to: <878swrrp1s.fsf@tcd.ie> Date: Fri, 05 Apr 2019 19:52:36 -0500 Message-ID: <875zrsuf8r.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34858-done Cc: 34858-done@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed 03 Apr 2019 at 12:12, Basil L. Contovounesios wrote: >>> Can they be pushed to master, and only backported to emacs-26 as >>> needed/applicable? >> >> Yes. > > Thanks, pushed to master. Alex, can you also please push your docfixes > for the Elisp manual? Thanks! I pushed the docfix as as 10cd65878c741d2a22a1f2c36c54fcad4e516f72, to appear in Emacs 27.1. I'm closing this bug report. Sorry for the delay, Alex ------------=_1554511982-2605-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Mar 2019 15:35:31 +0000 Received: from localhost ([127.0.0.1]:43890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4SOJ-0001ky-21 for submit@debbugs.gnu.org; Thu, 14 Mar 2019 11:35:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4SOI-0001kc-4X for submit@debbugs.gnu.org; Thu, 14 Mar 2019 11:35:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:37992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h4SOC-0000Qg-9j for submit@debbugs.gnu.org; Thu, 14 Mar 2019 11:35:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4SOA-00016l-Ts for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 11:35:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4SO8-0000PX-P2 for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 11:35:22 -0400 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:38852) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4SO6-0000O7-MK for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 11:35:18 -0400 Received: by mail-ot1-x335.google.com with SMTP id e80so350993ote.5 for ; Thu, 14 Mar 2019 08:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=VTnJVT24/Fjgd3ZfKAF9/4E1gNE2xBWhqcH6jP1rkjA=; b=KMchPTn5xR6YDg1mPi0WowGOHhrlgOkqKjWot7TNKSkcRyYhAbqij9bIq6WeRSWGxB visyFWn7+0CpqfyIbiNAwhSeEtGx6RYXnKrOu/3TXuZiCsGXzTxN3EHKbRlEQOapxPBK tcU9Fn/STwjRwldyta7FZnodIQO2DvghwtGEYW7IFKUlhw6Lwcptiw7uPo2AORxYsGXs MZtEGYAY1xptRVcfKwNd2Elh3gqhlfeOC8btVmzJoD7uBmbZk3TA2K+pKQOsnSzN2lsr V53cgH6XdaCNFt83PK6w9E2irPGETmPATC/47FwGKJFDKQ+XlTMwQpb+Mp1rQSxxrb4/ ZMwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=VTnJVT24/Fjgd3ZfKAF9/4E1gNE2xBWhqcH6jP1rkjA=; b=TcgWE3diUeswX8yqKOnQIfNp7N8r0ZRXdroo2w4pCnDf7e+gypqaaN+3fcZ28QMiv3 rHzdNKapuZPaFWHo6met/jBiTTBTikXerKnZFAjPhrEFmdKVtfXu3s6dhNTZJmMpGaIS R9MdkZf87bTPBHbJRAp5DjOqEePSovWn7miy9XuRjj6CCgbRIauZLaPXTTivm/jzFzN8 EdgAMkwfMUA4JqEETD3c2rlDAsqrC68VGSCkCjAxmyEwt9VoaY3+hkg7YwB6NeKDwNTM QEMNF6xCTV3lJv6bId/fbkAdko+kDKYewkxJNAHkSynE22r/HFhNvidJM1S8LpSDek6l GQ8Q== X-Gm-Message-State: APjAAAX2NHp56JiC5tQKVUDaP77YxK+Q/x429t7pKYQsZHdccGzG1Jfb BAic0UeUWVN8ivCJD8wnlGcAkbjP X-Google-Smtp-Source: APXvYqxgnTEq7XmuPIxFitBDDtyEDsAdXCKFFHigOH5XIee0N3YNl8O11mpwEZCJAGBbCBJxy/XmeA== X-Received: by 2002:a9d:4610:: with SMTP id y16mr11275475ote.41.1552577714844; Thu, 14 Mar 2019 08:35:14 -0700 (PDT) Received: from mars (nat-128-62-56-8.public.utexas.edu. [128.62.56.8]) by smtp.gmail.com with ESMTPSA id u5sm5799130otb.62.2019.03.14.08.35.14 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 08:35:14 -0700 (PDT) User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: bug-gnu-emacs@gnu.org Subject: indent-relative called with prefix calls tab-to-tab-stop Date: Thu, 14 Mar 2019 10:35:13 -0500 Message-ID: <871s39mpu6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::335 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) The docstring of indent-relative says: If the previous nonblank line has no indent points beyond the column point starts at, then `tab-to-tab-stop' is done, if both FIRST-ONLY and UNINDENTED-OK are nil, otherwise nothing is done in this case. Yet in a buffer like this: foo with point at the beginning of line, C-u M-x indent-relative results in: test I'm happy to submit a patch fixing this, but should it update the documentation to match what happens or should it update the code to match the documentation? Thanks, Alex ------------=_1554511982-2605-1--