GNU bug report logs - #34856
[PATCH] *sum --help: add note about binary/text mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#34856: closed ([PATCH] *sum --help: add note about
 binary/text mode)
Date: Mon, 18 Mar 2019 08:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 18 Mar 2019 09:11:59 +0100
with message-id <91da2b5c-6903-569c-a836-a9b9d83dc243 <at> bernhard-voelker.de>
and subject line Re: bug#34856: [PATCH] *sum --help: add note about binary/text mode
has caused the debbugs.gnu.org bug report #34856,
regarding [PATCH] *sum --help: add note about binary/text mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
34856: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34856
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kamil Dudka <kdudka <at> redhat.com>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] *sum --help: add note about binary/text mode
Date: Thu, 14 Mar 2019 13:48:01 +0100

* src/md5sum.c (usage): Make it clear that there is no difference
between binary mode and text mode on GNU systems.

Bug: https://bugzilla.redhat.com/406981
Bug: https://bugzilla.redhat.com/1688740
---
 src/md5sum.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/md5sum.c b/src/md5sum.c
index 3532f7b7a..f75b6de02 100644
--- a/src/md5sum.c
+++ b/src/md5sum.c
@@ -287,7 +287,10 @@ The following five options are useful only when verifying checksums:\n\
 The sums are computed as described in %s.  When checking, the input\n\
 should be a former output of this program.  The default mode is to print a\n\
 line with checksum, a space, a character indicating input mode ('*' for binary,\
-\n' ' for text or where binary is insignificant), and name for each FILE.\n"),
+\n' ' for text or where binary is insignificant), and name for each FILE.\n\
+\n\
+Note: There is no difference between binary mode and text mode on GNU systems.\
+\n"),
               DIGEST_REFERENCE);
       emit_ancillary_info (PROGRAM_NAME);
     }
-- 
2.17.2

[Message part 3 (message/rfc822, inline)]

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Kamil Dudka <kdudka <at> redhat.com>, 34856-done <at> debbugs.gnu.org
Subject: Re: bug#34856: [PATCH] *sum --help: add note about binary/text mode
Date: Mon, 18 Mar 2019 09:11:59 +0100

On 3/14/19 1:48 PM, Kamil Dudka wrote:
> +Note: There is no difference between binary mode and text mode on GNU systems.\

Thanks for the patch - I see this is a downstream patch in Fedora since
several years.

I changed the Subject line to conform to our 'commit-msg' hook:

  md5sum,b2sum,sha*sum: --help: add note about binary/text mode

and pushed at:

  https://git.sv.gnu.org/cgit/coreutils.git/commit/?id=ae61b10663

Have a nice day,
Berny

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.