Subject: bug#34838: closed (Re: [bug#34838] [PATCH 0/6] Add '--with-git-url' and make sure it composes well)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 17 Mar 2019 21:57:02 +0000

Your bug report

#34838: [PATCH 0/6] Add '--with-git-url' and make sure it composes well

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
34838: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34838
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#34838] [PATCH 0/6] Add '--with-git-url' and make sure it composes well
From: Ludovic Courtès <[email-masked]>
To: [email-masked]
Date: Sun, 17 Mar 2019 22:56:27 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès <[email-masked]> skribis:

> This patch series allows for things like this:
>
>   guix build python-numpy \
>     --with-git-url=python=https://github.com/python/cpython \
>     --with-commit=python=86900a49000c4a96ad1dc34e49d8af4245b08843

Merged!

  d831b19079 guix build: '--with-branch' strips slashes from the version string.
  845c44012c guix build: '--with-commit' makes recursive checkouts.
  14328b81a2 guix build: Transformation options match packages by spec.
  0c0ff42a24 guix build: Factorize 'package-git-url'.
  f258d88628 packages: Add 'package-input-rewriting/spec'.
  880916ac52 guix build: Add '--with-git-url'.

Ludo’.

Subject: [PATCH 0/6] Add '--with-git-url' and make sure it composes well
From: Ludovic Courtès <[email-masked]>
To: [email-masked]
Cc: Ludovic Courtès <[email-masked]>
Date: Wed, 13 Mar 2019 10:57:55 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Guix!

This patch series allows for things like this:

  guix build python-numpy \
    --with-git-url=python=https://github.com/python/cpython \
    --with-commit=python=86900a49000c4a96ad1dc34e49d8af4245b08843

Initially I just wanted to add a ‘--with-git-url’ transformation option,
but then allowing it to be combined with ‘--with-branch’, for example,
turned out to be more involved.

To achieve that, this patch series changes transformation options so
they match packages by spec (“guile”, “guile@2”, etc.) instead of
matching them by identity as was the case before (specifically, we’d
get the identity of the package to be replaced with ‘specification->package’.)

That leads to a slight semantic change: transformations now apply
to any package that matches the given spec, whereas before they would
only apply to the public package that matches the spec.  In practice,
it probably doesn’t make any difference since there are rarely (if ever)
several distinct packages with the same name.

Feedback welcome!

Ludo’.

Ludovic Courtès (6):
  guix build: Add '--with-git-url'.
  packages: Add 'package-input-rewriting/spec'.
  guix build: Factorize 'package-git-url'.
  guix build: Transformation options match packages by spec.
  guix build: '--with-commit' makes recursive checkouts.
  guix build: '--with-branch' strips slashes from the version string.

 doc/guix.texi           |  61 ++++++++++++++---
 guix/packages.scm       |  38 +++++++++++
 guix/scripts/build.scm  | 146 +++++++++++++++++++++++++++-------------
 tests/packages.scm      |  51 ++++++++++++++
 tests/scripts-build.scm | 109 ++++++++++++++++++++++++++++--
 5 files changed, 343 insertions(+), 62 deletions(-)

-- 
2.21.0