GNU bug report logs - #34811
Make package name regexes case-insensitive

Previous Next

Full log

Message #11 received at 34811 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <somebody <at> not-sent-or-endorsed-by.tobias.gr>
Cc: 34811 <at> debbugs.gnu.org
Subject: Re: [bug#34811] Make package name regexes case-insensitive
Date: Tue, 21 May 2019 16:51:48 +0200

Ping!

Ludovic Courtès <ludo <at> gnu.org> skribis:

> Hello!
>
> Tobias Geerinckx-Rice <somebody <at> not-sent-or-endorsed-by.tobias.gr>
> skribis:
>
>> I think they should.
>>
>> All of our package names are lower case, and it doesn't add value that
>>
>>  $ guix package -A ExifTool
>>
>> matches zero, zip, zilch, nada, nothing, while
>>
>>  $ guix package -A exiftool
>>  perl-image-exiftool	11.11	out gnu/packages/photo.scm:208:2
>>
>> does.
>
> Indeed.
>
>>>>From 5876eb1fe6d412d7f2a556e0903cd2d87994ab9e Mon Sep 17 00:00:00 2001
>> From: Tobias Geerinckx-Rice <me <at> tobias.gr>
>> Date: Mon, 11 Mar 2019 11:37:11 +0100
>> Subject: [PATCH] ui: Match package names case-insensitively.
>>
>> * guix/ui.scm (make-package-name-regexp): New variable.
>> * guix/scripts/package.scm (options->upgrade-predicate, process-query):
>> Use it.
>
> [...]
>
>> -                   (make-regexp* (or regexp "")))
>> +                   (make-package-name-regexp (or regexp "")))
>
> I don’t think the abstraction brings much here; I’d prefer
> ‘regexp/icase’ to be inlined.  WDYT?
>
> Otherwise LGTM, thanks!
>
> Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.