From unknown Thu Aug 14 21:44:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34811 <34811@debbugs.gnu.org> To: bug#34811 <34811@debbugs.gnu.org> Subject: Status: Make package name regexes case-insensitive Reply-To: bug#34811 <34811@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:44:02 +0000 retitle 34811 Make package name regexes case-insensitive reassign 34811 guix-patches submitter 34811 Tobias Geerinckx-Rice severity 34811 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 11 06:58:23 2019 Received: (at submit) by debbugs.gnu.org; 11 Mar 2019 10:58:23 +0000 Received: from localhost ([127.0.0.1]:38660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3IdP-0002xN-UD for submit@debbugs.gnu.org; Mon, 11 Mar 2019 06:58:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3IdM-0002x7-Gl for submit@debbugs.gnu.org; Mon, 11 Mar 2019 06:58:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:33443) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3IdH-0004ab-4o for submit@debbugs.gnu.org; Mon, 11 Mar 2019 06:58:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3IdF-0005pD-FB for guix-patches@gnu.org; Mon, 11 Mar 2019 06:58:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3IQD-00036o-Pz for guix-patches@gnu.org; Mon, 11 Mar 2019 06:44:42 -0400 Received: from tobias.gr ([2001:470:7405::1]:51244) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3IQD-00034c-AI for guix-patches@gnu.org; Mon, 11 Mar 2019 06:44:41 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 6e900e7a for ; Mon, 11 Mar 2019 10:44:37 +0000 (UTC) Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 45bf3316 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for ; Mon, 11 Mar 2019 10:44:37 +0000 (UTC) From: Tobias Geerinckx-Rice To: guix-patches@gnu.org Subject: Make package name regexes case-insensitive Date: Mon, 11 Mar 2019 11:44:35 +0100 Message-ID: <87ftrther0.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:470:7405::1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain; format=flowed Guix, I think they should. All of our package names are lower case, and it doesn't add value that $ guix package -A ExifTool matches zero, zip, zilch, nada, nothing, while $ guix package -A exiftool perl-image-exiftool 11.11 out gnu/packages/photo.scm:208:2 does. Kind regards, T G-R --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-ui-Match-package-names-case-insensitively.patch Content-Transfer-Encoding: quoted-printable >From 5876eb1fe6d412d7f2a556e0903cd2d87994ab9e Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Mon, 11 Mar 2019 11:37:11 +0100 Subject: [PATCH] ui: Match package names case-insensitively. * guix/ui.scm (make-package-name-regexp): New variable. * guix/scripts/package.scm (options->upgrade-predicate, process-query): Use it. --- guix/scripts/package.scm | 9 +++++---- guix/ui.scm | 6 ++++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm index efff511299..563615938b 100644 --- a/guix/scripts/package.scm +++ b/guix/scripts/package.scm @@ -6,6 +6,7 @@ ;;; Copyright =C2=A9 2016 Roel Janssen ;;; Copyright =C2=A9 2016 Benz Schenk ;;; Copyright =C2=A9 2016 Chris Marusich +;;; Copyright =C2=A9 2019 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. ;;; @@ -526,14 +527,14 @@ upgrading, #f otherwise." (define upgrade-regexps (filter-map (match-lambda (('upgrade . regexp) - (make-regexp* (or regexp ""))) + (make-package-name-regexp (or regexp ""))) (_ #f)) opts)) =20 (define do-not-upgrade-regexps (filter-map (match-lambda (('do-not-upgrade . regexp) - (make-regexp* regexp)) + (make-package-name-regexp regexp)) (_ #f)) opts)) =20 @@ -686,7 +687,7 @@ processed, #f otherwise." #t) =20 (('list-installed regexp) - (let* ((regexp (and regexp (make-regexp* regexp))) + (let* ((regexp (and regexp (make-package-name-regexp regexp))) (manifest (profile-manifest profile)) (installed (manifest-entries manifest))) (leave-on-EPIPE @@ -702,7 +703,7 @@ processed, #f otherwise." #t)) =20 (('list-available regexp) - (let* ((regexp (and regexp (make-regexp* regexp))) + (let* ((regexp (and regexp (make-package-name-regexp regexp))) (available (fold-available-packages (lambda* (name version result #:key outputs location diff --git a/guix/ui.scm b/guix/ui.scm index 2fc001d2eb..eb4ea28d52 100644 --- a/guix/ui.scm +++ b/guix/ui.scm @@ -13,6 +13,7 @@ ;;; Copyright =C2=A9 2013, 2014 Free Software Foundation, Inc. ;;; Copyright =C2=A9 2018 Sahithi Yarlagadda ;;; Copyright =C2=A9 2018 Ricardo Wurmus +;;; Copyright =C2=A9 2019 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. ;;; @@ -79,6 +80,7 @@ show-version-and-exit show-bug-report-information make-regexp* + make-package-name-regexp string->number* size->number show-derivation-outputs @@ -548,6 +550,10 @@ nicely." (leave (G_ "'~a' is not a valid regular expression: ~a~%") regexp message)))) =20 +(define (make-package-name-regexp regexp) + "Like 'make-regexp*' but specifically for package names (i.e. ignore cas= e)" + (make-regexp* regexp regexp/icase)) + (define (string->number* str) "Like `string->number', but error out with an error message on failure." (or (string->number str) --=20 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 15 18:11:21 2019 Received: (at 34811) by debbugs.gnu.org; 15 Mar 2019 22:11:22 +0000 Received: from localhost ([127.0.0.1]:45573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4v2v-0004eZ-Lg for submit@debbugs.gnu.org; Fri, 15 Mar 2019 18:11:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4v2t-0004eL-39 for 34811@debbugs.gnu.org; Fri, 15 Mar 2019 18:11:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4v2n-000593-Jo; Fri, 15 Mar 2019 18:11:13 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59414 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h4v2m-0005XH-VK; Fri, 15 Mar 2019 18:11:13 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tobias Geerinckx-Rice Subject: Re: [bug#34811] Make package name regexes case-insensitive References: <87ftrther0.fsf@nckx> Date: Fri, 15 Mar 2019 23:11:11 +0100 In-Reply-To: <87ftrther0.fsf@nckx> (Tobias Geerinckx-Rice's message of "Mon, 11 Mar 2019 11:44:35 +0100") Message-ID: <874l833i0w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34811 Cc: 34811@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello! Tobias Geerinckx-Rice skribis: > I think they should. > > All of our package names are lower case, and it doesn't add value that > > $ guix package -A ExifTool > > matches zero, zip, zilch, nada, nothing, while > > $ guix package -A exiftool > perl-image-exiftool 11.11 out gnu/packages/photo.scm:208:2 > > does. Indeed. >>>From 5876eb1fe6d412d7f2a556e0903cd2d87994ab9e Mon Sep 17 00:00:00 2001 > From: Tobias Geerinckx-Rice > Date: Mon, 11 Mar 2019 11:37:11 +0100 > Subject: [PATCH] ui: Match package names case-insensitively. > > * guix/ui.scm (make-package-name-regexp): New variable. > * guix/scripts/package.scm (options->upgrade-predicate, process-query): > Use it. [...] > - (make-regexp* (or regexp ""))) > + (make-package-name-regexp (or regexp ""))) I don=E2=80=99t think the abstraction brings much here; I=E2=80=99d prefer =E2=80=98regexp/icase=E2=80=99 to be inlined. WDYT? Otherwise LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue May 21 10:52:02 2019 Received: (at 34811) by debbugs.gnu.org; 21 May 2019 14:52:02 +0000 Received: from localhost ([127.0.0.1]:40555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT67V-0005zf-Sh for submit@debbugs.gnu.org; Tue, 21 May 2019 10:52:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT67Q-0005zN-Ca for 34811@debbugs.gnu.org; Tue, 21 May 2019 10:52:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT67K-000835-6Q; Tue, 21 May 2019 10:51:50 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=40420 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hT67J-0005m7-Mx; Tue, 21 May 2019 10:51:50 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tobias Geerinckx-Rice Subject: Re: [bug#34811] Make package name regexes case-insensitive References: <87ftrther0.fsf@nckx> <874l833i0w.fsf@gnu.org> Date: Tue, 21 May 2019 16:51:48 +0200 In-Reply-To: <874l833i0w.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 15 Mar 2019 23:11:11 +0100") Message-ID: <87r28rzwqj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34811 Cc: 34811@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Ludovic Court=C3=A8s skribis: > Hello! > > Tobias Geerinckx-Rice > skribis: > >> I think they should. >> >> All of our package names are lower case, and it doesn't add value that >> >> $ guix package -A ExifTool >> >> matches zero, zip, zilch, nada, nothing, while >> >> $ guix package -A exiftool >> perl-image-exiftool 11.11 out gnu/packages/photo.scm:208:2 >> >> does. > > Indeed. > >>>>>From 5876eb1fe6d412d7f2a556e0903cd2d87994ab9e Mon Sep 17 00:00:00 2001 >> From: Tobias Geerinckx-Rice >> Date: Mon, 11 Mar 2019 11:37:11 +0100 >> Subject: [PATCH] ui: Match package names case-insensitively. >> >> * guix/ui.scm (make-package-name-regexp): New variable. >> * guix/scripts/package.scm (options->upgrade-predicate, process-query): >> Use it. > > [...] > >> - (make-regexp* (or regexp ""))) >> + (make-package-name-regexp (or regexp ""))) > > I don=E2=80=99t think the abstraction brings much here; I=E2=80=99d prefer > =E2=80=98regexp/icase=E2=80=99 to be inlined. WDYT? > > Otherwise LGTM, thanks! > > Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 30 17:10:56 2020 Received: (at 34811-done) by debbugs.gnu.org; 30 Nov 2020 22:10:56 +0000 Received: from localhost ([127.0.0.1]:56952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjrNo-0006h7-H3 for submit@debbugs.gnu.org; Mon, 30 Nov 2020 17:10:56 -0500 Received: from tobias.gr ([80.241.217.52]:49088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjrNm-0006gx-Ks for 34811-done@debbugs.gnu.org; Mon, 30 Nov 2020 17:10:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=/azFLq1GiBa8yZiIYhSt5ONZaIsrQuq6J4mpOB4VclI=; h=date:subject:to: from; b=EskXYxy5SnCMsfA5/oL6loBTIww2hiYsby963BRWySAGOasH3laNi2qkt3pjaJ 1UbxZeVGNwCN8PCWV9849hDrwmLO6mhCtrGD462GH+ibizi/QU/iBbOVP2KAQy+QOcJygR mfXJnqNsl9POLy9kU6VpmO1CXdUSQ95bm/1naPOINLO0Nq44TcVCmcCB5A8M/pWEhADGyW Izu2oqwYjy4KE2J0m4tXCEQnMepbqSRvpFouOQ7orj3HfV2EGr4JfYRsiPPdPHZYymkII4 pOKb6Cv/t/49dgtrbpMwIbLwCXzZozFg6Ea6qZ4Fweo2z8hYsCxvfEXa/At7U3PEwWmtoA == Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 9e589c1c (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for <34811-done@debbugs.gnu.org>; Mon, 30 Nov 2020 22:11:05 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: 34811-done@debbugs.gnu.org Subject: Make package name regexes case-insensitive Date: Mon, 30 Nov 2020 23:10:51 +0100 Message-ID: <87im9mwl5g.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34811-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; format=flowed Done & forgotten as commit b56d160944ace6e06fcfe5a36310c98e6a213b87. Closing now, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX8Vt6w0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15xMUA/iEY7I9CienzqsrMAZFOXLqYGE9m7Xcx+7/uJFta ReY5AQCBH6bZPDxjVDfafINo0dnQRYoe0GIf684rpZmmJT1mAQ== =vk/B -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Aug 14 21:44:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 29 Dec 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator