GNU bug report logs - #34807
[PATCH 1/2] Add (guix lzlib).

Previous Next

Full log

Message #23 received at 34807 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 34807 <at> debbugs.gnu.org
Subject: Re: [bug#34807] [PATCH 1/2] Add (guix lzlib).
Date: Sat, 04 May 2019 12:23:23 +0200

[Message part 1 (text/plain, inline)]

Right on time, I just finished it!

- I've been in touch with Antonio, Lzip's maintainer, for more than a
  week and now I'm confident that I have a decent understanding of the
  library.

- Your m4 suggestion didn't work.  I've included a comment.  We need to
  fix it before merging.  I'm not the right person for this job I'm
  afraid :p  Ludo?

- The convenience functions do not support multi-member archives.
  Multi-member archives are mostly useful for parallelization, but we
  don't use that in Guix, so it's OK.  Should it be required some day,
  we would need to implement it, which requires a little bit more work.
  I've documented all that.

- The implementation of lzread! is subpar because I understood a
  subtlety a bit too late.  But that's alright, it does not affect
  performance nor reliability.

- I've included 11 tests covering all your suggestions.

- I haven't strace'd the Guile process.  The code regarding ports is
  identical to zlib.scm, so it's unlikely there would be an issue in
  this area.  I have never done this before, so out of curiosity, how do
  you run a specific Guix tests without going through `make'?

Next steps? :D

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

[0001-Add-guix-lzlib.patch (text/x-patch, attachment)]

[0002-dir-locals.el-Add-call-with-lzip-input-port-and-call.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.