Subject: Re: bug#34796: [PATCH] * lisp/simple.el (delete-indentation): Join lines in a region

From: Eli Zaretskii <[email-masked]>
Date: Fri, 15 Mar 2019 10:13:59 +0200

> From: Łukasz Stelmach <[email-masked]>
> Date: Sat,  9 Mar 2019 18:56:34 +0100
> Cc: Łukasz Stelmach <[email-masked]>
> 
> If a region is active, join all the lines it spans.

Thanks.

Please provide a ChangeLog-style commit log message for your proposed
changes, and also accompany them with suitable changes to NEWS and the
user manual.

> -(defun delete-indentation (&optional arg)
> +(defun delete-indentation (&optional arg beg end)
>    "Join this line to previous and fix up whitespace at join.
> -If there is a fill prefix, delete it from the beginning of this line.
> -With argument, join this line to following line."
> -  (interactive "*P")
> +If there is a fill prefix, delete it from the beginning of this
> +line.  With argument, join this line to following line. With a
> +region active, join lines in the region. If both argument and
> +region are set, the region is ignored."

Please leave 2 spaces between sentences in the doc string.

With those issues taken care of, I think this feature can be
installed.