GNU bug report logs - #34781
27.0.50; integer in pcase sometimes compared by eq

Previous Next

Package: emacs;

Reported by: Mattias Engdegård <mattiase <at> acm.org>

Date: Thu, 7 Mar 2019 15:16:02 UTC

Severity: normal

Tags: patch

Found in version 27.0.50

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: monnier <at> iro.umontreal.ca, 34781 <at> debbugs.gnu.org
Subject: bug#34781: 27.0.50; integer in pcase sometimes compared by eq
Date: Thu, 28 Mar 2019 13:30:18 -0700
On 3/28/19 12:51 PM, Mattias Engdegård wrote:
> Not that I can see; the singular case uses eql for integerp.
> I didn't think of the case you described, thanks. We then need a new
> function:
>
>   portable-fixnum-p
> ...
>
> and names for the bounds:
>
>   portable-most-{positive,negative}-fixnum

If we have the bounds, then portable-fixnum-p is merely a convenience, no?

I'd prefer the names most-negative-portable-fixnum and
most-positive-portable-fixnum. Their documentation should make it clear
what the portability test is for. Presumably the test applies just to
this version of Emacs, since future versions might change the portable
fixnum bounds.





This bug report was last modified 6 years and 53 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.