From unknown Thu Jun 19 14:04:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34781 <34781@debbugs.gnu.org> To: bug#34781 <34781@debbugs.gnu.org> Subject: Status: 27.0.50; integer in pcase sometimes compared by eq Reply-To: bug#34781 <34781@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:04:34 +0000 retitle 34781 27.0.50; integer in pcase sometimes compared by eq reassign 34781 emacs submitter 34781 Mattias Engdeg=C3=A5rd severity 34781 normal tag 34781 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 07 10:15:55 2019 Received: (at submit) by debbugs.gnu.org; 7 Mar 2019 15:15:56 +0000 Received: from localhost ([127.0.0.1]:35564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1ukV-0001Kj-N9 for submit@debbugs.gnu.org; Thu, 07 Mar 2019 10:15:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1ukT-0001KW-1a for submit@debbugs.gnu.org; Thu, 07 Mar 2019 10:15:54 -0500 Received: from lists.gnu.org ([209.51.188.17]:47092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1ukN-0005y6-7a for submit@debbugs.gnu.org; Thu, 07 Mar 2019 10:15:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1ukM-0002oX-9T for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 10:15:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1ukH-0005tj-8E for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 10:15:45 -0500 Received: from mail224c50.megamailservers.eu ([91.136.10.234]:48658 helo=mail33c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1uk7-0005fL-Cl for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 10:15:38 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1551971723; bh=G9jsiSfppCZsepTyjlgSWyB5hC1UoiO/JlhPA7kxVvA=; h=Subject:From:To:Date:From; b=mQU8+4Cdy3AHuhzDBeSik8ysrMZ712KLrOgb4MuiFlncqKEqH1m9awSTuZ/9zH3W6 g6Nz7HTxqkk7+5cQjbBPJhJa8W5B4CFqgeBVpHYRp16IGddFmXsCmIwNXIYONa70pu A0B+lEYHUnc1CKs8ZwwrB1XycX7OB5IWTxOQ/fVo= Feedback-ID: mattiase@acm.or Received: from dhcppc0 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x27FDRUN023113 for ; Thu, 7 Mar 2019 15:15:23 +0000 Message-ID: <0def6336a8d4cc8a769e9320f0a37962ba64d1de.camel@acm.org> Subject: 27.0.50; integer in pcase sometimes compared by eq From: Mattias =?ISO-8859-1?Q?Engdeg=E5rd?= To: bug-gnu-emacs@gnu.org Date: Thu, 07 Mar 2019 16:13:27 +0100 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-CTCH-RefID: str=0001.0A0B020E.5C81358B.001F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=fZaDNXYF c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=IkcTkHD0fZMA:10 a=cQZZq8QP7GP-45M59_gA:9 a=QEXdDO2ut3YA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.234 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) (defun f (x) (pcase x ((or 'a #x10000000000000000) t))) (f #x10000000000000000) => nil Just replacing integerp with fixnump fixes this, but I'm not sure if more of the same lurks somewhere. --- a/lisp/emacs-lisp/pcase.el +++ b/lisp/emacs-lisp/pcase.el @@ -792,7 +792,7 @@ pcase--u1 (let ((upat (cddr alt))) (eq (car-safe upat) 'quote))) (let ((val (cadr (cddr alt)))) - (unless (or (integerp val) (symbolp val)) + (unless (or (fixnump val) (symbolp val)) (setq memq-ok nil)) (push (cadr (cddr alt)) simples)) (push alt others)))) From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 12 08:24:48 2019 Received: (at 34781) by debbugs.gnu.org; 12 Mar 2019 12:24:48 +0000 Received: from localhost ([127.0.0.1]:39823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3gSe-0004Zt-Ez for submit@debbugs.gnu.org; Tue, 12 Mar 2019 08:24:48 -0400 Received: from mail228c50.megamailservers.eu ([91.136.10.238]:42364 helo=mail36c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3gSb-0004Zi-Hp for 34781@debbugs.gnu.org; Tue, 12 Mar 2019 08:24:47 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1552393483; bh=+kKtmPX3O7DZ0Z3XG//0B44aB3pp0laLTtO1EBUblqA=; h=Subject:From:To:Date:In-Reply-To:References:From; b=fAjoJC5mdmzqpLQSWXgSbCVon3kptEYWvJOFpaH/NpdkQTkzpNlIYpSK4jyDNWYEo Ekm82M+SkWO9VJ8BRUppe48yHrPk8UOd9Vt52eIB+5zwjCN3EWNKE09/bL34HAP7aY 3QZdfmyfUOQ1LLwazhL9nvyWIkReqBk71/AHs3oQ= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail36c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2CCOf90028671 for <34781@debbugs.gnu.org>; Tue, 12 Mar 2019 12:24:43 +0000 Message-ID: <305d88ad0e9aecb3c7c5f09471c46b73f94ec0ed.camel@acm.org> Subject: Re: bug#34781: Acknowledgement (27.0.50; integer in pcase sometimes compared by eq) From: Mattias =?ISO-8859-1?Q?Engdeg=E5rd?= To: 34781@debbugs.gnu.org Date: Tue, 12 Mar 2019 13:24:41 +0100 In-Reply-To: References: <0def6336a8d4cc8a769e9320f0a37962ba64d1de.camel@acm.org> Content-Type: multipart/mixed; boundary="=-OzNv7LgiXq3txfz0OD1v" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CTCH-RefID: str=0001.0A0B0207.5C87A50B.0046, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=XOQetzpE c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=y2tYfCZ9LdmtVnpN8oIA:9 a=N54-gffFAAAA:8 a=DcszBkVG1JhBaV3v1PgA:9 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 a=Z5ABNNGmrOfJ6cZ5bIyy:22 a=jd6J4Gguk5HxikPWLKER:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34781 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-OzNv7LgiXq3txfz0OD1v Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Tags: patch Complete patch with test case. --=-OzNv7LgiXq3txfz0OD1v Content-Disposition: attachment; filename="0001-Don-t-match-bignums-with-memq-in-pcase.patch" Content-Type: text/x-patch; name="0001-Don-t-match-bignums-with-memq-in-pcase.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBiMTU2NTYzY2U2ODBmMmY2M2NmNTdlOTc2ZjI0MTZkNTNhOTRhYjRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFR1ZSwgMTIgTWFyIDIwMTkgMTM6MTk6MzUgKzAxMDAK U3ViamVjdDogW1BBVENIXSBEb24ndCBtYXRjaCBiaWdudW1zIHdpdGggYG1lbXEnIGluIGBwY2Fz ZScKCiogbGlzcC9lbWFjcy1saXNwL3BjYXNlLmVsIChwY2FzZS0tdTEpOgpVc2UgZml4bnVtcCBp bnN0ZWFkIG9mIGludGVnZXJwIGFzIGNyaXRlcmlvbiBmb3IgbWVtcSAoQnVnIzM0NzgxKS4KKiB0 ZXN0L2xpc3AvZW1hY3MtbGlzcC9wY2FzZS10ZXN0cy5lbCAocGNhc2UtdGVzdHMtbWVtYmVyKTog VGVzdCB0aGUgYWJvdmUuCi0tLQogbGlzcC9lbWFjcy1saXNwL3BjYXNlLmVsICAgICAgICAgICAg fCAyICstCiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9wY2FzZS10ZXN0cy5lbCB8IDYgKysrKysrCiAy IGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdp dCBhL2xpc3AvZW1hY3MtbGlzcC9wY2FzZS5lbCBiL2xpc3AvZW1hY3MtbGlzcC9wY2FzZS5lbApp bmRleCA5ZGUyNDAxNTQ5Li5jMjZhM2Q3NzA4IDEwMDY0NAotLS0gYS9saXNwL2VtYWNzLWxpc3Av cGNhc2UuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3BjYXNlLmVsCkBAIC03OTIsNyArNzkyLDcg QEAgcGNhc2UtLXUxCiAgICAgICAgICAgICAgICAgICAgKGxldCAoKHVwYXQgKGNkZHIgYWx0KSkp CiAgICAgICAgICAgICAgICAgICAgICAoZXEgKGNhci1zYWZlIHVwYXQpICdxdW90ZSkpKQogICAg ICAgICAgICAgICAobGV0ICgodmFsIChjYWRyIChjZGRyIGFsdCkpKSkKLSAgICAgICAgICAgICAg ICAodW5sZXNzIChvciAoaW50ZWdlcnAgdmFsKSAoc3ltYm9scCB2YWwpKQorICAgICAgICAgICAg ICAgICh1bmxlc3MgKG9yIChmaXhudW1wIHZhbCkgKHN5bWJvbHAgdmFsKSkKICAgICAgICAgICAg ICAgICAgIChzZXRxIG1lbXEtb2sgbmlsKSkKICAgICAgICAgICAgICAgICAocHVzaCAoY2FkciAo Y2RkciBhbHQpKSBzaW1wbGVzKSkKICAgICAgICAgICAgIChwdXNoIGFsdCBvdGhlcnMpKSkpCmRp ZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9wY2FzZS10ZXN0cy5lbCBiL3Rlc3QvbGlz cC9lbWFjcy1saXNwL3BjYXNlLXRlc3RzLmVsCmluZGV4IDFlOWQzN2ZiZmEuLmE3YzY2ZGJmMWUg MTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL3BjYXNlLXRlc3RzLmVsCisrKyBiL3Rl c3QvbGlzcC9lbWFjcy1saXNwL3BjYXNlLXRlc3RzLmVsCkBAIC01Niw2ICs1NiwxMiBAQCBwY2Fz ZS10ZXN0cy1ncmVwCiAgICAgICAgICAgICdtZW1iZXIgKG1hY3JvZXhwYW5kLWFsbCAnKHBjYXNl IHggKChvciAiYSIgMiAzKSBib2R5KSkpKSkKICAgKHNob3VsZC1ub3QgKHBjYXNlLXRlc3RzLWdy ZXAKICAgICAgICAgICAgICAgICdtZW1xIChtYWNyb2V4cGFuZC1hbGwgJyhwY2FzZSB4ICgob3Ig ImEiIDIgMykgYm9keSkpKSkpCisgIChzaG91bGQgKHBjYXNlLXRlc3RzLWdyZXAKKyAgICAgICAg ICAgJ21lbWJlciAobWFjcm9leHBhbmQtYWxsICcocGNhc2UgeCAoKG9yICN4MTAwMDAwMDAwMDAw MDAwMDAgMiAzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBib2R5KSkpKSkKKyAgKHNob3VsZC1ub3QgKHBjYXNlLXRlc3RzLWdyZXAKKyAgICAgICAgICAg ICAgICdtZW1xIChtYWNyb2V4cGFuZC1hbGwgJyhwY2FzZSB4ICgob3IgI3gxMDAwMDAwMDAwMDAw MDAwMCAyIDMpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgYm9keSkpKSkpCiAgIChsZXQgKChleHAgKG1hY3JvZXhwYW5kLWFsbAogICAgICAgICAgICAg ICAgICAgICAgICcocGNhc2UgeAogICAgICAgICAgICAgICAgICAgICAgICAgICgiYSIgYm9keTEp Ci0tIAoyLjIwLjEKCg== --=-OzNv7LgiXq3txfz0OD1v-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 12 09:11:54 2019 Received: (at control) by debbugs.gnu.org; 12 Mar 2019 13:11:54 +0000 Received: from localhost ([127.0.0.1]:39841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3hCE-0005iS-8y for submit@debbugs.gnu.org; Tue, 12 Mar 2019 09:11:54 -0400 Received: from mail176c50.megamailservers.eu ([91.136.10.186]:40386 helo=mail37c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3hCB-0005iH-JF for control@debbugs.gnu.org; Tue, 12 Mar 2019 09:11:53 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1552396310; bh=iVk+MdpOePa77qx6UCerTFGr7s3YwUsRV6X9yVf4zHI=; h=Subject:From:To:Date:From; b=hDTSV8Cz+E3wxqMvho4xBFoJP6nWUuuxP03dR4GiQYQ+BGdgMzcNPiufumNJrlgP0 6kPcMX6+Zr/hbpbDhnhdPOH+kEBMlQRX+BT+sg7bU7WG6JEUgZZjYisDBjA/x/d3wv QG0ZLDapZY1kX+8S4vbclh2BbRPafNesmN//d7Gw= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2CDBmv9015393 for ; Tue, 12 Mar 2019 13:11:49 +0000 Message-ID: <829ba0d746f3f2a0d91ac48f741c3a7ffce0a7f7.camel@acm.org> Subject: tags From: Mattias =?ISO-8859-1?Q?Engdeg=E5rd?= To: control@debbugs.gnu.org Date: Tue, 12 Mar 2019 14:11:47 +0100 Content-Type: text/plain User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CTCH-RefID: str=0001.0A0B020C.5C87B015.00B2, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=J+uEEjvS c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=Wiz2-FTGAWC8hrgevLEA:9 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 34781 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 16 15:09:41 2019 Received: (at 34781) by debbugs.gnu.org; 16 Mar 2019 19:09:41 +0000 Received: from localhost ([127.0.0.1]:46720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h5Ege-0004St-RQ for submit@debbugs.gnu.org; Sat, 16 Mar 2019 15:09:41 -0400 Received: from mail150c50.megamailservers.eu ([91.136.10.160]:51870 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h5Egb-0004Si-Go for 34781@debbugs.gnu.org; Sat, 16 Mar 2019 15:09:38 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1552763376; bh=ExPayG2OmF8wpiSndXMn4+i//82tubj/HZRDKtJYE5o=; h=From:Subject:Date:References:To:In-Reply-To:From; b=EBjjLllhydmfb3aJzNdBCCk0Tdqu9cAamRPNAu/GUg0brO08vrQC9eJc+k3ZUTwcM p/cbHsiBak74wzo/Zv9dIKKJMFoL9gL4w0CtOmvfcWZQPV/W4yY2/ySNr2/Vg+Q7Ft p2Dyb3y+aOwE4bNN6p8i23ItxIJQ191tct57170k= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2GJ9YGv004086 for <34781@debbugs.gnu.org>; Sat, 16 Mar 2019 19:09:35 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: 27.0.50; integer in pcase sometimes compared by eq Date: Sat, 16 Mar 2019 20:09:34 +0100 References: <0def6336a8d4cc8a769e9320f0a37962ba64d1de.camel@acm.org> <305d88ad0e9aecb3c7c5f09471c46b73f94ec0ed.camel@acm.org> To: 34781@debbugs.gnu.org In-Reply-To: <305d88ad0e9aecb3c7c5f09471c46b73f94ec0ed.camel@acm.org> Message-Id: X-Mailer: Apple Mail (2.3445.102.3) X-CTCH-RefID: str=0001.0A0B020F.5C8D49F0.0008, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=a4UeC3aF c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=x2NND2vXo1cYZ_Z0KNgA:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34781 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I can't find any similar problem elsewhere in the pcase code; singular = bignum comparison was taken care of long ago. Is the patch acceptable? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 14:26:05 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 18:26:05 +0000 Received: from localhost ([127.0.0.1]:34705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9Zj3-0007Wu-1I for submit@debbugs.gnu.org; Thu, 28 Mar 2019 14:26:05 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9Zj0-0007WQ-Ka for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 14:26:03 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 70092160A6F; Thu, 28 Mar 2019 11:25:56 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id gWLZY-8fHJTy; Thu, 28 Mar 2019 11:25:55 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B117D160F0B; Thu, 28 Mar 2019 11:25:55 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id I998OaF07hYd; Thu, 28 Mar 2019 11:25:55 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 95BE51608B8; Thu, 28 Mar 2019 11:25:55 -0700 (PDT) To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= From: Paul Eggert Subject: 27.0.50; integer in pcase sometimes compared by eq Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Thu, 28 Mar 2019 11:25:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34781 Cc: 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I can't find any similar problem elsewhere in the pcase code; singular bignum comparison was taken care of long ago. > Is the patch acceptable? Thanks, it looks good to me; please install into the master branch What happens if a source file that uses pcase is compiled on a 64-bit machine that has wide fixnums, and is then loaded and run on a 32-bit machine that has narrow fixnums? Will this pcase code still work? And if not, are there similar bugs elsewhere in the pcase code? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 15:43:31 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 19:43:31 +0000 Received: from localhost ([127.0.0.1]:34761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9avz-0004zl-Eq for submit@debbugs.gnu.org; Thu, 28 Mar 2019 15:43:31 -0400 Received: from mout.web.de ([212.227.15.3]:41359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9avw-0004zX-Ma for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 15:43:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1553802197; bh=t8zlEOCl+TiPlD/GN3wZuBgsuHu2Yo6isV8zlYlo5RY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=NlWKSPUfy+ReVeWh2JjKVSptUWV6/WdVoy2t20WmV/Lr5ldiIvIb2EkkD5nQkwC8i Hx7E1CllbRgfpUZavItmWAi/oUR541XvUyPYpxVF7APfxqMm870C25v03tty9cFkTr //XLFA7h0sTgDr2ARbHGI6yJly4zO2zyFN+ilav8= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([188.99.160.30]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LiaAW-1gXFNJ14AO-00cjeM; Thu, 28 Mar 2019 20:43:17 +0100 From: Michael Heerdegen To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#34781: 27.0.50; integer in pcase sometimes compared by eq References: <0def6336a8d4cc8a769e9320f0a37962ba64d1de.camel@acm.org> Date: Thu, 28 Mar 2019 20:43:15 +0100 In-Reply-To: <0def6336a8d4cc8a769e9320f0a37962ba64d1de.camel@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Thu, 07 Mar 2019 16:13:27 +0100") Message-ID: <8736n66azw.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:i8Hk7QF0llkvxNV5iNmfw3i5P8P+1DWUR68rSKxLjvkIKPhXodF IkNuBpUU9CBEqhteFa4Gr6CcRkiKYpMAUqXjwCK001q8pKhJp9VZbNJbSI0fD36svLJzte7 kt5dJF0t6ECjNoEKCG3QglBdgS1utu4l09y6kiRPvAFGPBwTHV7+s5mUtTCpOsWErOS1Kc4 m/oaiCs3Tf/hU/OZTxvfg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:+Z6soX3m/QY=:rShGuaJkpFIxcnsnTEzogR g+s5luNIPWD1QB4fsvRsCyOiZ0ElRhblx7JOerqZ5A1/+ppRLJL4uS8CzBYadFXkSsA/0h+n8 xrHFiLvakjUe1N+sOsCWLkxfUjkVQo9u4agNNY2C2kis5qpiuzx+y1A0KmML7TJzpYRhZv7mw 1eNkA/iLlQbftcq3vkEzKJYczaUuBFGS7Fausv6LShR0/gPa3EVnemOruEZi98mkSrl78sYk3 ykWc/rx+aA4sSMwtmkpUtDsbP1TlZyo6nxyY3SfARrXjbdtoayyeN7V04as8cEbX2a/KfLXhu QzO2zkbADxJnWSYleRwwQJo/Rq6eGlnGdnz9VGsP5OxQ0MyNNMVJBCDnk216w8tKEWcUL9tCh XdcO1JK2Wg8Ne9eNhGn2SgyKQWSLrzYl70PNpMMSPyGTPLXEu04Qw7skBCFWNesar0PTqNIrh nAC7XcrIjKGDmiuCA/2tojY8UWk1jz3kxd0HfcCEGwSkZ5epMz2TA4K1qmw8LIZWM5pHxA1eY Lk7rdSpKw5NifshSExCiPxkN3BIqMK3mvT4xhcLNeoCkg1CQiHg75lXoRhTmHT6EOnCS03wnY Kg1mX28cr6TFPwCrCuIWBDGVfFVf6yOrk7IhXHHAjMEBqr4LsZfBXCXAoXau1a7YLiTKfSuhJ WeYi11WU1RFL8YlF3dH9bpBh+weHeeiHxZ8oFIzegFuyBdcvrC6xB4oyvcU0SKQfZp4eog+uH 2HSzZmQanwvKGDEUwC6zCKEH6KrfzM2m7FW3tCnQnf8u21IAXZZwGqyDQKCbiyfAfKQVqMFbM NBbwtoTOoL7b/D5uqYMtrE2VCnPR3OC8+mIw18RgSe7MPzJhlT+nRaBVY+an3vtEhLnoK9LcS hM3ec1hLfstRdIhFB2KkU8HyuwKNGbEMUFWY+JCmheO5hpugnFs3zv4TNcrkiBFuPWFkLRLkk CI1RWriEVhA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34781 Cc: 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: > (defun f (x) > (pcase x > ((or 'a #x10000000000000000) t))) > > (f #x10000000000000000) =3D> nil > > Just replacing integerp with fixnump fixes this, but I'm not sure if > more of the same lurks somewhere. I had a quick look and didn't find anything obvious. Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 15:48:06 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 19:48:06 +0000 Received: from localhost ([127.0.0.1]:34765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9b0Q-00056m-5s for submit@debbugs.gnu.org; Thu, 28 Mar 2019 15:48:06 -0400 Received: from mout.web.de ([212.227.17.11]:59403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9b0O-00056I-Uh for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 15:48:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1553802464; bh=kRkGPKi1CPIS3BmojavsDrmzzXQI5jISRcNIQMDuFpg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=V5pMvupTOBAHfJvwuLgO1FzBPoaLZrJLscMb1VrwCS2hX/UJTokdJqO/V9P12625P JK8dAdu+yPSPgkwtCOLXoFLsTumOfQJXtmrmLkSrCqo+38cPE7YRftxU8jzS2487x3 gLbqBjLSQRKqeaIo5KJB95VRCZFXvtncDsPLMxu0= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([188.99.160.30]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MOAjQ-1h46pI1cAO-005ajK; Thu, 28 Mar 2019 20:47:44 +0100 From: Michael Heerdegen To: Paul Eggert Subject: Re: bug#34781: 27.0.50; integer in pcase sometimes compared by eq References: <0def6336a8d4cc8a769e9320f0a37962ba64d1de.camel@acm.org> Date: Thu, 28 Mar 2019 20:47:42 +0100 In-Reply-To: (Paul Eggert's message of "Thu, 28 Mar 2019 11:25:55 -0700") Message-ID: <87y34y4w81.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:LvnN76JaMp0rGa5/0sCeBMQay87DxLIw5M0Bww3zxGlCoShPqnR RIPFepQ+4WC0crDnVIuSZj6YPucuA19PuupU7oOPxTDGbDbRy5/YYSywzL9BdiWwVq/RdCO JVTHHtsTdkovJ4RKc2S2rL4qaCrqG2yJ09/+GN363MSZ7DtrppoKPAfs7FqId4q9LZX5jJH sIgjhceLcs2W8WaKs1CgA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:yqrvYC5OBTs=:cCa28rkO5BwAExMCNl+zOB AQzr6TvBZ6fBJ9zfpPLWbcN/hY6fy9UEa9/bQDp8dOnb5rSh9J84pGlxbxf7sKlKepNq40pLr 8TugXW3Z6cMuvpMpr3V1qT8WS9xzFBtkeMoi3yjDi/K8RdS/QOtRlhg1AYDAFbvRnOb0Y8Xpt 18xAKcZa1qL58+rL20tliRxp/E55XBMOk+6Zv96XYWesm8wLdbNMY8p3M+AYFPVKS53RKE1Ss niflXE5lFBvYkTS6k0aciiw6DTYm3kqnY4mOIxL/0F8aKZqNH/SrLfxzOogBVjJgfFqZKofo/ bNj1PECnQZbgeWni44DaxogkVHwkaOLMqyjw0EU0/Q4fT7FSrLyPuv/guzoXgyHHwSI0nOShH YvghsVLRZ1h/2UiAC7CBBwb8wW66iXOo/9ZjPGHDMV+GidLh1It5QagKOCfVdHWks2Zy3U3Or gTGodxbJnRBX7IhiFsK8Pvv+8eFhjjyEAu8BFG5e1Ub8aa5KaGnoBiO5rSq/2SxK1fqWaZ/NK 2JTnHccmDytCfb1BfPYe6HNaLenyTVv0KtZDJFQFwZkrB+RCY5A/PvaQjOo7SRfgnrdJZOxug r0qS/zaSQL1yGZyEQGrupo+GEg6rodUYB7gEVCrhWXUdTBwqT2jAv06LYGC3hpD/y3sUBKC/g ni1j8bxHsVtib3e8Sd86RhzbzSCMkfWFeuDOEBXQgWSACwztWkDOYBDNmOxbxyU8+cu/WV6jj Uai8luxHw4RS/gXhzcgdeq3fVm6sNP4hBs8Dz+uyNTusIdZn5ciYHj+4Fad1osq0Y/CPMzK6m jJCMFoaP9JG0rggRIxiDe1Fx8L1wFqBbQcfl9r6ySl9LsYVGQtOTqTb0bAwWGO7384Radh37R xpVj+eeZ/DV+SaBbPPFux6UMGMg8FiYIIPWkgFBvRKcBa46VTwOtKhB3HoKp7+3YfEiq4koaB tqoHExV+PDA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34781 Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Paul Eggert writes: > What happens if a source file that uses pcase is compiled on a 64-bit > machine that has wide fixnums, and is then loaded and run on a 32-bit > machine that has narrow fixnums? Will this pcase code still work? And > if not, are there similar bugs elsewhere in the pcase code? AFAIU the patch only corrects an optimization (use `memq' instead of `member') that doesn't work for bignums. This can never be harmful. I had a quick look at pcase.el, and also tried the obvious cases (quote, backquote), and didn't find any other obvious bug. Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 15:51:59 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 19:51:59 +0000 Received: from localhost ([127.0.0.1]:34769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9b4A-0005C9-PM for submit@debbugs.gnu.org; Thu, 28 Mar 2019 15:51:58 -0400 Received: from mail157c50.megamailservers.eu ([91.136.10.167]:52218 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9b48-0005Bz-RR for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 15:51:57 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1553802704; bh=7Kllq/Z+7b0TOJgf/0X9y69zxqX+3rm5w39Vi4CH7GI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=mE7+FGv9ul71LqiTKa06INoMHyB8fPJFt+YOnlyljtg7ZdrqgjwCSCKw457Q90pOa xzefUhY96sxRvcpcX5TbAiIXmKYhJhLysD5mwhBYb+V4WqCMeahlSgnllUHOOO2+ze 9BcdXIvQvMqakjWkN2f8Cb+CVm6d/ZYL/yyEwIYA= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2SJpejc000527; Thu, 28 Mar 2019 19:51:42 +0000 Message-ID: Subject: Re: 27.0.50; integer in pcase sometimes compared by eq From: Mattias =?ISO-8859-1?Q?Engdeg=E5rd?= To: Paul Eggert Date: Thu, 28 Mar 2019 20:51:40 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-CTCH-RefID: str=0001.0A0B0201.5C9D25D0.0064, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=a8seC3aF c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=QQUOvgvckhQt0zx9LMwA:9 a=QEXdDO2ut3YA:10 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34781 Cc: monnier@iro.umontreal.ca, 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tor 2019-03-28 klockan 11:25 -0700 skrev Paul Eggert: > > Thanks, it looks good to me; please install into the master branch > > What happens if a source file that uses pcase is compiled on a 64-bit > machine that has wide fixnums, and is then loaded and run on a 32-bit > machine that has narrow fixnums? Will this pcase code still work? And > if > not, are there similar bugs elsewhere in the pcase code? Not that I can see; the singular case uses eql for integerp. I didn't think of the case you described, thanks. We then need a new function: portable-fixnum-p guaranteed-fixnum-p always-fixnum-p fixnum-everywhere-p here-a-fixnum-there-a-fixnum-everywhere-a-fixnum-p and names for the bounds: portable-most-{positive,negative}-fixnum ... Name suggestions welcome. Meanwhile, I'll make a new patch. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 16:30:29 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 20:30:29 +0000 Received: from localhost ([127.0.0.1]:34780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9bfR-00066A-6X for submit@debbugs.gnu.org; Thu, 28 Mar 2019 16:30:29 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9bfN-00065v-U3 for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 16:30:27 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B4E63160EEC; Thu, 28 Mar 2019 13:30:19 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id S46oJjzUL95o; Thu, 28 Mar 2019 13:30:19 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EBFE7160F1A; Thu, 28 Mar 2019 13:30:18 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sb4D9STo_gat; Thu, 28 Mar 2019 13:30:18 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id CD26D160F15; Thu, 28 Mar 2019 13:30:18 -0700 (PDT) Subject: Re: 27.0.50; integer in pcase sometimes compared by eq To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= References: From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> Date: Thu, 28 Mar 2019 13:30:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34781 Cc: monnier@iro.umontreal.ca, 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 3/28/19 12:51 PM, Mattias Engdeg=C3=A5rd wrote: > Not that I can see; the singular case uses eql for integerp. > I didn't think of the case you described, thanks. We then need a new > function: > > portable-fixnum-p > ... > > and names for the bounds: > > portable-most-{positive,negative}-fixnum If we have the bounds, then portable-fixnum-p is merely a convenience, no= ? I'd prefer the names most-negative-portable-fixnum and most-positive-portable-fixnum. Their documentation should make it clear what the portability test is for. Presumably the test applies just to this version of Emacs, since future versions might change the portable fixnum bounds. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 16:33:53 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 20:33:54 +0000 Received: from localhost ([127.0.0.1]:34785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9bij-0006B1-Mp for submit@debbugs.gnu.org; Thu, 28 Mar 2019 16:33:53 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9bih-0006Ao-KR for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 16:33:52 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 50EBD160F0B; Thu, 28 Mar 2019 13:33:46 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id sO_-fCuXGrqH; Thu, 28 Mar 2019 13:33:45 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8C460160F65; Thu, 28 Mar 2019 13:33:45 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qnc7fjIoDGlw; Thu, 28 Mar 2019 13:33:45 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 7125A160F55; Thu, 28 Mar 2019 13:33:45 -0700 (PDT) Subject: Re: bug#34781: 27.0.50; integer in pcase sometimes compared by eq To: Michael Heerdegen References: <0def6336a8d4cc8a769e9320f0a37962ba64d1de.camel@acm.org> <87y34y4w81.fsf@web.de> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Thu, 28 Mar 2019 13:33:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <87y34y4w81.fsf@web.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34781 Cc: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= , 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 3/28/19 12:47 PM, Michael Heerdegen wrote: > AFAIU the patch only corrects an optimization (use `memq' instead of > `member') that doesn't work for bignums. This can never be harmful. Isn't it harmful if a 64-bit Emacs decides that the optimization is safe for the fixnum 1000000000 and thus generates the faster code, but the code is put into an .elc file and then loaded by a 32-bit emacs that treats 1000000000 as a bignum? (An alternative to this annoying most-positive-portable-bignum business would be to require --with-wide-int on all platforms. :-) From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 17:30:58 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 21:30:59 +0000 Received: from localhost ([127.0.0.1]:34823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9cby-0007cr-Me for submit@debbugs.gnu.org; Thu, 28 Mar 2019 17:30:58 -0400 Received: from mout.web.de ([217.72.192.78]:47143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9cbx-0007ce-28 for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 17:30:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1553808636; bh=mDZm1AZxDZxLtCyXrHTdTLOiVRsw8b6PDZTk2ngs/z8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=RD4iSFf8gI7coC+J5ZPefBlyNTWyPy0gY2IcwhcO87O6xCrxzWfy4z5aEBRhPx5La gio9iBY2hZ8iixJuDubDc0MzG2JB3BoPeGSPpbug69+f/nSihfj2NoFXPiWwRgCZR0 zT+HpPouvoPImXLz79ixDdma95nkeOHXOOemqBTo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([188.99.160.30]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MN4Gi-1h2zpL3gy0-006dov; Thu, 28 Mar 2019 22:30:36 +0100 From: Michael Heerdegen To: Paul Eggert Subject: Re: bug#34781: 27.0.50; integer in pcase sometimes compared by eq References: <0def6336a8d4cc8a769e9320f0a37962ba64d1de.camel@acm.org> <87y34y4w81.fsf@web.de> Date: Thu, 28 Mar 2019 22:30:33 +0100 In-Reply-To: (Paul Eggert's message of "Thu, 28 Mar 2019 13:33:45 -0700") Message-ID: <87pnqa4rgm.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:YT53HcPYuaJo2ww9zbFdN4x/Dua060Pdu10C5eB3jSaF6YM1h/W hZkKX5oQ1ysNScq+qyEuxA2B967saSTCoKyOAbsu0mkwthmt6Is2e69Y6v9CgK+3h0a3GUn D7b4wNXCUXWlh2ZceaGi/MAKFfnQIpkEM8HO2FVN8UYubpDTWXR0/0DgGPM8dcOGQSRG7um Xmqp/1ySJzWT7+hY9zdJw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Bq/BFkwk3zA=:G5EcZz58CW7Enjk7cytDFP W29mgGy68hmv2r4VdrqAUXEYR5DsGqQfQTKHekBLwje66Qc3RTm+R2VZtNjAi4K+A5izhwOvK bHnmSHUghkqAaEFhkFeMU0ZEL9qpC4eu2rVOUxRjXT4e4MEVjw7JNaO95ACWg4D/CX1aMpoqG CE7ngeUU540eqfDxK6JEThv/+rNvJFMpeOG7NsqXSvuM7JlE0HZOWLnUT4YJx/Ru1YdnPa6Wl K8OQeLbdzgqrR0MFwneoLQVfq68DlRwYEK3P57V5ZHkMhir937r7LqLfylN2cCRlxm/ov44rf FkFIvSlbPEZ3fgj/g+2ykwWaXfIQOl0HuQoZuv+qKAgZCJotKaGjBgjrShIIsXVWZ1ydK8sJW Ari+VMDrnMuhyBmm8SycdQvoGDbtiAXD0kldKOhGttfYOirseXuvqVcMsASNtu5K5hV/IaU3Z bfSlRpe0XmsmnLZ3iIOVPqYlUpEty9LIy9K9Dxp4ikXLtwuvqYGN//UKXBZnMUEGnJPO54sv+ qugEwBn/cJdTNuLj7eAId06pfO9JTgO4n/oEho+D48gIHLn98nV32Z0pwYJPdlL8nj+NGdl6+ 6Rb44bmkCawQUyPZYMMe68kVo/vBhc73KvpWLPsFVk/vR4YnT+YGGGfi16dKUmOQp+hTdhl4/ ZCI769qAlsvD2+5NUN4CKLD/B9lvNqMsjfxjRSByBX7NIamwR7hUyJgC6BsNABvWFPsbjkKNC +m7X5RKjbLbL7tngMOQNVWcypZ7yzkgyR8/rd0Lhyr5GX+Z4ljFHXR+BXmntZMJbLKdnSgo3a GUlMNArxhz3WmutQL+8AJptHpdUN3uDB92/lhBmilbTWfb8o/QLAUCD0xMbP4D1ES656zwR/v YopN9jtqEZNKBLhisInrqeOsdaH4WGfBlCv5nOacO2DCuhAXMfKIwdD5MPsBYrMjNhFcD3OuD YcRGzbPILcw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34781 Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Paul Eggert writes: > On 3/28/19 12:47 PM, Michael Heerdegen wrote: > > AFAIU the patch only corrects an optimization (use `memq' instead of > > `member') that doesn't work for bignums. This can never be harmful. > > Isn't it harmful if a 64-bit Emacs decides that the optimization is safe > for the fixnum 1000000000 and thus generates the faster code, but the > code is put into an .elc file and then loaded by a 32-bit emacs that > treats 1000000000 as a bignum? Ah ok - yes, I guess that would indeed happen. Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 17:51:59 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 21:51:59 +0000 Received: from localhost ([127.0.0.1]:34832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9cwI-000882-Sr for submit@debbugs.gnu.org; Thu, 28 Mar 2019 17:51:59 -0400 Received: from mail78c50.megamailservers.eu ([91.136.10.88]:45356 helo=mail70c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9cwF-00087o-KE for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 17:51:57 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1553809903; bh=udy3gQKZBZ9NYXAliVl5VR1jHV57fZ+wSz1crRzb6Ho=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=aNrNsEAS8ADenfh6ixn6jEMs2WD7e/Sn55LB4gjNRyHdeDaLMjgO03ouAMy0ciVDA gmIhiJMxSAwzZ9QQPGW3lltdu7qWMsCH5WfrXrCESyfY+m8rqWJ7hDFKiWbQ/iLnBW bSdewooAeqPNQFxg5UQc58ZBfZHijZKWDe0yA7Iw= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2SLpess019679; Thu, 28 Mar 2019 21:51:42 +0000 Message-ID: <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> Subject: Re: 27.0.50; integer in pcase sometimes compared by eq From: Mattias =?ISO-8859-1?Q?Engdeg=E5rd?= To: Paul Eggert Date: Thu, 28 Mar 2019 22:51:39 +0100 In-Reply-To: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> References: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> Content-Type: multipart/mixed; boundary="=-AOiI8Ohza01MDt/SfLjj" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CTCH-RefID: str=0001.0A0B0215.5C9D41EF.004F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ILcs9DnG c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=YOfWFl7_368a6ZubdKQA:9 a=QEXdDO2ut3YA:10 a=N54-gffFAAAA:8 a=xhwwM7WeRl4MOssa6hUA:9 a=QkB6_ECVOe0PgzL0:21 a=n5_xJ0sec4NCX8cQ:21 a=B2y7HmGcmWMA:10 a=5-gSI8tS0pKN6Ju09W4A:9 a=6l0D2HzqY3Epnrm8mE3f:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34781 Cc: monnier@iro.umontreal.ca, 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-AOiI8Ohza01MDt/SfLjj Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit tor 2019-03-28 klockan 13:30 -0700 skrev Paul Eggert: > If we have the bounds, then portable-fixnum-p is merely a > convenience, no? Yes. We can drop it if you prefer it to be open-coded in pcase and elsewhere, but I thought the predicate would make sense. > I'd prefer the names most-negative-portable-fixnum and > most-positive-portable-fixnum. Their documentation should make it > clear > what the portability test is for. Presumably the test applies just to > this version of Emacs, since future versions might change the > portable > fixnum bounds. Here is a patch for that, and an updated pcase patch. --=-AOiI8Ohza01MDt/SfLjj Content-Disposition: attachment; filename*0=0001-Add-bounds-for-portable-fixnums-and-portable-fixnum-.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Add-bounds-for-portable-fixnums-and-portable-fixnum-.patch"; charset="UTF-8" RnJvbSBmNWZlNWQ5ODcwOTBlNjliMGY3NDM4NDM1ZjY5YzZhYWI0MjE1ZTVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFRodSwgMjggTWFyIDIwMTkgMjI6MTI6MzcgKzAxMDAK U3ViamVjdDogW1BBVENIIDEvMl0gQWRkIGJvdW5kcyBmb3IgcG9ydGFibGUgZml4bnVtcywgYW5k IHBvcnRhYmxlLWZpeG51bS1wCgpUaGVzZSBhcmUgdXNlZnVsIGZvciBtYWNyb3MgdGhhdCBuZWVk IHRvIGRldGVjdCB3aGV0aGVyIGEgbnVtYmVyIGlzIGEKZml4bnVtIG9uIGFueSBtYWNoaW5lLCBz byB0aGF0IHRoZSBieXRlY29kZSBiZWNvbWVzIHBvcnRhYmxlIChCdWcjMzQ3ODEpLgoKKiBzcmMv bGlzcC5oIChMRUFTVF9FTUFDU19JTlRfTUFYLCBNT1NUX1BPU0lUSVZFX1BPUlRBQkxFX0ZJWE5V TSwKTU9TVF9ORUdBVElWRV9QT1JUQUJMRV9GSVhOVU0pOgoqIHNyYy9kYXRhLmMgKG1vc3QtcG9z aXRpdmUtcG9ydGFibGUtZml4bnVtLCBtb3N0LW5lZ2F0aXZlLXBvcnRhYmxlLWZpeG51bSk6Ciog bGlzcC9zdWJyLmVsIChwb3J0YWJsZS1maXhudW0tcCk6Ck5ldy4KKiBldGMvTkVXUyAoTGlzcCBD aGFuZ2VzKTogTWVudGlvbiBwb3J0YWJsZS1maXhudW0tcC4KLS0tCiBldGMvTkVXUyAgICAgfCAg NCArKysrCiBsaXNwL3N1YnIuZWwgfCAgNiArKysrKysKIHNyYy9kYXRhLmMgICB8IDE4ICsrKysr KysrKysrKysrKysrKwogc3JjL2xpc3AuaCAgIHwgMTIgKysrKysrKysrKysrCiA0IGZpbGVzIGNo YW5nZWQsIDQwIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdT CmluZGV4IDc0ODZkNmJjZmUuLmEyOTMzZmJiZDMgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBi L2V0Yy9ORVdTCkBAIC0xNDI0LDYgKzE0MjQsMTAgQEAgbGlrZSAnZmlsZS1hdHRyaWJ1dGVzJyB0 aGF0IGNvbXB1dGUgZmlsZSBzaXplcyBhbmQgb3RoZXIgYXR0cmlidXRlcywKIGZ1bmN0aW9ucyBs aWtlICdwcm9jZXNzLWlkJyB0aGF0IGNvbXB1dGUgcHJvY2VzcyBJRHMsIGFuZCBmdW5jdGlvbnMg bGlrZQogJ3VzZXItdWlkJyBhbmQgJ2dyb3VwLWdpZCcgdGhhdCBjb21wdXRlIHVzZXIgYW5kIGdy b3VwIElEcy4KIAorU2luY2UgdGhlIHNpemUgb2YgZml4bnVtcyB2YXJpZXMgYmV0d2VlbiBwbGF0 Zm9ybXMsIHRoZSBuZXcgcHJlZGljYXRlCisncG9ydGFibGUtZml4bnVtLXAnIGNhbiBiZSB1c2Vk IHRvIGRldGVybWluZSB3aGV0aGVyIGEgbnVtYmVyIGlzCithIGZpeG51bSBvbiBhbnkgbWFjaGlu ZSBydW5uaW5nIHRoZSBjdXJyZW50IEVtYWNzIHZlcnNpb24uCisKICsrKwogKiogQWx0aG91Z2gg dGhlIGRlZmF1bHQgdGltZXN0YW1wIGZvcm1hdCBpcyBzdGlsbCAoSEkgTE8gVVMgUFMpLAogaXQg aXMgcGxhbm5lZCB0byBjaGFuZ2UgaW4gYSBmdXR1cmUgRW1hY3MgdmVyc2lvbiwgdG8gZXhwbG9p dCBiaWdudW1zLgpkaWZmIC0tZ2l0IGEvbGlzcC9zdWJyLmVsIGIvbGlzcC9zdWJyLmVsCmluZGV4 IGYxYTFkZGRkODEuLjk1MGEwYjU4ZTMgMTAwNjQ0Ci0tLSBhL2xpc3Avc3Vici5lbAorKysgYi9s aXNwL3N1YnIuZWwKQEAgLTM3Niw2ICszNzYsMTIgQEAgYmlnbnVtcAogICAiUmV0dXJuIHQgaWYg T0JKRUNUIGlzIGEgYmlnbnVtLiIKICAgKGFuZCAoaW50ZWdlcnAgb2JqZWN0KSAobm90IChmaXhu dW1wIG9iamVjdCkpKSkKIAorKGRlZnVuIHBvcnRhYmxlLWZpeG51bS1wIChvYmplY3QpCisgICJS ZXR1cm4gdCBpZiBPQkpFQ1QgaXMgYSBmaXhudW0gb24gYW55IG1hY2hpbmUgcnVubmluZyB0aGUg Y3VycmVudAorRW1hY3MgdmVyc2lvbi4iCisgIChhbmQgKGludGVnZXJwIG9iamVjdCkKKyAgICAg ICAoPD0gbW9zdC1uZWdhdGl2ZS1wb3J0YWJsZS1maXhudW0gb2JqZWN0IG1vc3QtcG9zaXRpdmUt cG9ydGFibGUtZml4bnVtKSkpCisKIChkZWZ1biBsc2ggKHZhbHVlIGNvdW50KQogICAiUmV0dXJu IFZBTFVFIHdpdGggaXRzIGJpdHMgc2hpZnRlZCBsZWZ0IGJ5IENPVU5ULgogSWYgQ09VTlQgaXMg bmVnYXRpdmUsIHNoaWZ0aW5nIGlzIGFjdHVhbGx5IHRvIHRoZSByaWdodC4KZGlmZiAtLWdpdCBh L3NyYy9kYXRhLmMgYi9zcmMvZGF0YS5jCmluZGV4IDE1YjYxMDZjZmUuLjI5NjlmMmRmODIgMTAw NjQ0Ci0tLSBhL3NyYy9kYXRhLmMKKysrIGIvc3JjL2RhdGEuYwpAQCAtNDExMCw2ICs0MTEwLDI0 IEBAIFRoaXMgdmFyaWFibGUgY2Fubm90IGJlIHNldDsgdHJ5aW5nIHRvIGRvIHNvIHdpbGwgc2ln bmFsIGFuIGVycm9yLiAgKi8pOwogICBWbW9zdF9uZWdhdGl2ZV9maXhudW0gPSBtYWtlX2ZpeG51 bSAoTU9TVF9ORUdBVElWRV9GSVhOVU0pOwogICBtYWtlX3N5bWJvbF9jb25zdGFudCAoaW50ZXJu X2Nfc3RyaW5nICgibW9zdC1uZWdhdGl2ZS1maXhudW0iKSk7CiAKKyAgREVGVkFSX0xJU1AgKCJt b3N0LXBvc2l0aXZlLXBvcnRhYmxlLWZpeG51bSIsCisgICAgICAgICAgICAgICBWbW9zdF9wb3Np dGl2ZV9wb3J0YWJsZV9maXhudW0sCisgICAgICAgICAgICAgICBkb2M6IC8qIFRoZSBncmVhdGVz dCBpbnRlZ2VyIHRoYXQgaXMgcmVwcmVzZW50ZWQgZWZmaWNpZW50bHkKK29uIGFueSBtYWNoaW5l IHJ1bm5pbmcgdGhpcyB2ZXJzaW9uIG9mIEVtYWNzLgorVGhpcyB2YXJpYWJsZSBjYW4gYmUgdXNl ZCB0byBlbnN1cmUgcG9ydGFiaWxpdHkgb2YgYnl0ZWNvZGUgdGhhdCB3b3Jrcword2l0aCBmaXhu dW1zLiAgSXQgY2Fubm90IGJlIHNldDsgdHJ5aW5nIHRvIGRvIHNvIHdpbGwgc2lnbmFsIGFuIGVy cm9yLiAgKi8pOworICBWbW9zdF9wb3NpdGl2ZV9wb3J0YWJsZV9maXhudW0gPSBtYWtlX2ZpeG51 bShNT1NUX1BPU0lUSVZFX1BPUlRBQkxFX0ZJWE5VTSk7CisgIG1ha2Vfc3ltYm9sX2NvbnN0YW50 IChpbnRlcm5fY19zdHJpbmcgKCJtb3N0LXBvc2l0aXZlLXBvcnRhYmxlLWZpeG51bSIpKTsKKwor ICBERUZWQVJfTElTUCAoIm1vc3QtbmVnYXRpdmUtcG9ydGFibGUtZml4bnVtIiwKKyAgICAgICAg ICAgICAgIFZtb3N0X25lZ2F0aXZlX3BvcnRhYmxlX2ZpeG51bSwKKyAgICAgICAgICAgICAgIGRv YzogLyogVGhlIGxlYXN0IGludGVnZXIgdGhhdCBpcyByZXByZXNlbnRlZCBlZmZpY2llbnRseQor b24gYW55IG1hY2hpbmUgcnVubmluZyB0aGlzIHZlcnNpb24gb2YgRW1hY3MuCitUaGlzIHZhcmlh YmxlIGNhbiBiZSB1c2VkIHRvIGVuc3VyZSBwb3J0YWJpbGl0eSBvZiBieXRlY29kZSB0aGF0IHdv cmtzCit3aXRoIGZpeG51bXMuICBJdCBjYW5ub3QgYmUgc2V0OyB0cnlpbmcgdG8gZG8gc28gd2ls bCBzaWduYWwgYW4gZXJyb3IuICAqLyk7CisgIFZtb3N0X25lZ2F0aXZlX3BvcnRhYmxlX2ZpeG51 bSA9IG1ha2VfZml4bnVtKE1PU1RfTkVHQVRJVkVfUE9SVEFCTEVfRklYTlVNKTsKKyAgbWFrZV9z eW1ib2xfY29uc3RhbnQgKGludGVybl9jX3N0cmluZyAoIm1vc3QtbmVnYXRpdmUtcG9ydGFibGUt Zml4bnVtIikpOworCiAgIERFRlNZTSAoUXdhdGNoZXJzLCAid2F0Y2hlcnMiKTsKICAgREVGU1lN IChRbWFrdW5ib3VuZCwgIm1ha3VuYm91bmQiKTsKICAgREVGU1lNIChRdW5sZXQsICJ1bmxldCIp OwpkaWZmIC0tZ2l0IGEvc3JjL2xpc3AuaCBiL3NyYy9saXNwLmgKaW5kZXggMTc4ZWViZWQyYS4u YmYxZjBhMGJmNSAxMDA2NDQKLS0tIGEvc3JjL2xpc3AuaAorKysgYi9zcmMvbGlzcC5oCkBAIC0x MTIsNiArMTEyLDEzIEBAIGVudW0geyBFTUFDU19JTlRfV0lEVEggPSBMTE9OR19XSURUSCwgRU1B Q1NfVUlOVF9XSURUSCA9IFVMTE9OR19XSURUSCB9OwogIyBlbmRpZgogI2VuZGlmCiAKKy8qIFRo ZSBzbWFsbGVzdCBwb3J0YWJsZSB2YWx1ZSBvZiBFTUFDU19JTlRfTUFYLiAgKi8KKyNkZWZpbmUg TEVBU1RfRU1BQ1NfSU5UX01BWCAyMTQ3NDgzNjQ3ICAgLyogMioqMzEgLSAxICovCisKKyNpZiBF TUFDU19JTlRfTUFYIDwgTEVBU1RfRU1BQ1NfSU5UX01BWAorIyBlcnJvciAiRU1BQ1NfSU5UX01B WCBsZXNzIHRoYW4gTEVBU1RfRU1BQ1NfSU5UX01BWCIKKyNlbmRpZgorCiAvKiBOdW1iZXIgb2Yg Yml0cyB0byBwdXQgaW4gZWFjaCBjaGFyYWN0ZXIgaW4gdGhlIGludGVybmFsIHJlcHJlc2VudGF0 aW9uCiAgICBvZiBib29sIHZlY3RvcnMuICBUaGlzIHNob3VsZCBub3QgdmFyeSBhY3Jvc3MgaW1w bGVtZW50YXRpb25zLiAgKi8KIGVudW0geyAgQk9PTF9WRUNUT1JfQklUU19QRVJfQ0hBUiA9CkBA IC0xMTQ2LDYgKzExNTMsMTEgQEAgZW51bSBNb3JlX0xpc3BfQml0cwogI2RlZmluZSBNT1NUX1BP U0lUSVZFX0ZJWE5VTSAoRU1BQ1NfSU5UX01BWCA+PiBJTlRUWVBFQklUUykKICNkZWZpbmUgTU9T VF9ORUdBVElWRV9GSVhOVU0gKC0xIC0gTU9TVF9QT1NJVElWRV9GSVhOVU0pCiAKKy8qIExhcmdl c3QgYW5kIHNtYWxsZXN0IHZhbHVlcyB0aGF0IGFyZSBndWFyYW50ZWVkIHRvIGJlIHJlcHJlc2Vu dGFibGUKKyAgIGFzIGZpeG51bXMgb24gYW55IG1hY2hpbmUuICBUaGVzZSBhcmUgdGhlIEMgdmFs dWVzLiAgKi8KKyNkZWZpbmUgTU9TVF9QT1NJVElWRV9QT1JUQUJMRV9GSVhOVU0gKExFQVNUX0VN QUNTX0lOVF9NQVggPj4gSU5UVFlQRUJJVFMpCisjZGVmaW5lIE1PU1RfTkVHQVRJVkVfUE9SVEFC TEVfRklYTlVNICgtMSAtIE1PU1RfUE9TSVRJVkVfUE9SVEFCTEVfRklYTlVNKQorCiAjaWYgVVNF X0xTQl9UQUcKIAogSU5MSU5FIExpc3BfT2JqZWN0Ci0tIAoyLjIwLjEKCg== --=-AOiI8Ohza01MDt/SfLjj Content-Disposition: attachment; filename="0002-Don-t-match-integers-with-memq-in-pcase.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0002-Don-t-match-integers-with-memq-in-pcase.patch"; charset="UTF-8" RnJvbSA1MDU0YWMyMWI2YmRiNTIyNDM3ZDk3ZGIyYTUxNGE1M2Q4Y2U3NzczIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFR1ZSwgMTIgTWFyIDIwMTkgMTM6MTk6MzUgKzAxMDAK U3ViamVjdDogW1BBVENIIDIvMl0gRG9uJ3QgbWF0Y2ggaW50ZWdlcnMgd2l0aCBgbWVtcScgaW4g YHBjYXNlJwoKKiBsaXNwL2VtYWNzLWxpc3AvcGNhc2UuZWwgKHBjYXNlLS11MSk6ClVzZSBwb3J0 YWJsZS1maXhudW0tcCBpbnN0ZWFkIG9mIGludGVnZXJwIGFzIGNyaXRlcmlvbiBmb3IgbWVtcSAo QnVnIzM0NzgxKS4KKiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9wY2FzZS10ZXN0cy5lbCAocGNhc2Ut dGVzdHMtbWVtYmVyKTogVGVzdCB0aGUgYWJvdmUuCi0tLQogbGlzcC9lbWFjcy1saXNwL3BjYXNl LmVsICAgICAgICAgICAgfCAyICstCiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9wY2FzZS10ZXN0cy5l bCB8IDYgKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9wY2FzZS5lbCBiL2xpc3AvZW1hY3Mt bGlzcC9wY2FzZS5lbAppbmRleCA5ZGUyNDAxNTQ5Li5hMTM2OTRlZDMzIDEwMDY0NAotLS0gYS9s aXNwL2VtYWNzLWxpc3AvcGNhc2UuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3BjYXNlLmVsCkBA IC03OTIsNyArNzkyLDcgQEAgcGNhc2UtLXUxCiAgICAgICAgICAgICAgICAgICAgKGxldCAoKHVw YXQgKGNkZHIgYWx0KSkpCiAgICAgICAgICAgICAgICAgICAgICAoZXEgKGNhci1zYWZlIHVwYXQp ICdxdW90ZSkpKQogICAgICAgICAgICAgICAobGV0ICgodmFsIChjYWRyIChjZGRyIGFsdCkpKSkK LSAgICAgICAgICAgICAgICAodW5sZXNzIChvciAoaW50ZWdlcnAgdmFsKSAoc3ltYm9scCB2YWwp KQorICAgICAgICAgICAgICAgICh1bmxlc3MgKG9yIChwb3J0YWJsZS1maXhudW0tcCB2YWwpIChz eW1ib2xwIHZhbCkpCiAgICAgICAgICAgICAgICAgICAoc2V0cSBtZW1xLW9rIG5pbCkpCiAgICAg ICAgICAgICAgICAgKHB1c2ggKGNhZHIgKGNkZHIgYWx0KSkgc2ltcGxlcykpCiAgICAgICAgICAg ICAocHVzaCBhbHQgb3RoZXJzKSkpKQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VtYWNzLWxpc3Av cGNhc2UtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZW1hY3MtbGlzcC9wY2FzZS10ZXN0cy5lbAppbmRl eCAxZTlkMzdmYmZhLi4yOWYwMmNiYWE5IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZW1hY3MtbGlz cC9wY2FzZS10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZW1hY3MtbGlzcC9wY2FzZS10ZXN0cy5l bApAQCAtNTYsNiArNTYsMTIgQEAgcGNhc2UtdGVzdHMtZ3JlcAogICAgICAgICAgICAnbWVtYmVy IChtYWNyb2V4cGFuZC1hbGwgJyhwY2FzZSB4ICgob3IgImEiIDIgMykgYm9keSkpKSkpCiAgIChz aG91bGQtbm90IChwY2FzZS10ZXN0cy1ncmVwCiAgICAgICAgICAgICAgICAnbWVtcSAobWFjcm9l eHBhbmQtYWxsICcocGNhc2UgeCAoKG9yICJhIiAyIDMpIGJvZHkpKSkpKQorICAoc2hvdWxkIChw Y2FzZS10ZXN0cy1ncmVwCisgICAgICAgICAgICdtZW1iZXIgKG1hY3JvZXhwYW5kLWFsbCAnKHBj YXNlIHggKChvciAjeDEwMDAwMDAwMCAyIDMpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGJvZHkpKSkpKQorICAoc2hvdWxkLW5vdCAocGNhc2UtdGVzdHMt Z3JlcAorICAgICAgICAgICAgICAgJ21lbXEgKG1hY3JvZXhwYW5kLWFsbCAnKHBjYXNlIHggKChv ciAjeDEwMDAwMDAwMCAyIDMpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgYm9keSkpKSkpCiAgIChsZXQgKChleHAgKG1hY3JvZXhwYW5kLWFsbAogICAg ICAgICAgICAgICAgICAgICAgICcocGNhc2UgeAogICAgICAgICAgICAgICAgICAgICAgICAgICgi YSIgYm9keTEpCi0tIAoyLjIwLjEKCg== --=-AOiI8Ohza01MDt/SfLjj-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 18:10:25 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 22:10:25 +0000 Received: from localhost ([127.0.0.1]:34854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9dE8-0000A5-MB for submit@debbugs.gnu.org; Thu, 28 Mar 2019 18:10:24 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9dE6-00009n-2t for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 18:10:23 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A2D54160F0B; Thu, 28 Mar 2019 15:10:15 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id WjOhO8ImRPmA; Thu, 28 Mar 2019 15:10:14 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BF9F8160F16; Thu, 28 Mar 2019 15:10:14 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uNxp8QJUnlA9; Thu, 28 Mar 2019 15:10:14 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9F847160EEC; Thu, 28 Mar 2019 15:10:14 -0700 (PDT) Subject: Re: 27.0.50; integer in pcase sometimes compared by eq To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= References: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Thu, 28 Mar 2019 15:10:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34781 Cc: monnier@iro.umontreal.ca, 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > +Since the size of fixnums varies between platforms, the new predicate > +'portable-fixnum-p' can be used to determine whether a number is > +a fixnum on any machine running the current Emacs version. The news item should also mention most-negative-portable-fixnum etc. Try to be terser; e.g., "can be used to determine" -> "determines". > > +(defun portable-fixnum-p (object) > +=C2=A0 "Return t if OBJECT is a fixnum on any machine running the curr= ent > +Emacs version." The usage message can fit on one line. > +=C2=A0 (and (integerp object) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (<=3D most-negative-portable-fixn= um object > most-positive-portable-fixnum))) integerp -> fixnump > +=C2=A0 DEFVAR_LISP ("most-positive-portable-fixnum", > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 Vmost_positive_portable_fixnum, > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 doc: /* The greatest integer that is represented > efficiently > +on any machine running this version of Emacs. Try to have the first line explain things tersely. Something like "The largest integer representable as a fixnum on any platform." More details can be in later lines, if needed. > +=C2=A0 Vmost_positive_portable_fixnum =3D > make_fixnum(MOST_POSITIVE_PORTABLE_FIXNUM); Space before parenthesis (elsewhere, too). > > diff --git a/src/lisp.h b/src/lisp.h > index 178eebed2a..bf1f0a0bf5 100644 > --- a/src/lisp.h > +++ b/src/lisp.h These changes should be in data.c not lisp.h, since only data.c needs them and it's not likely any other code will need them. > > +/* The smallest portable value of EMACS_INT_MAX.=C2=A0 */ > +#define LEAST_EMACS_INT_MAX 2147483647=C2=A0=C2=A0 /* 2**31 - 1 */ There's no need to make it a macro. Also, the LEAST_* prefix and *_MAX suffix are confusing: which takes priority? I suggest sticking to suffixes, since that seems to be the convention. Something like =C2=A0 int EMACS_INT_MAX_MIN =3D 2147483647; as a local in the only function that needs it, and similarly for the related macros. Although you can use 'verify' to check that EMACS_INT_MAX_MIN <=3D EMACS_INT_MAX, I'm not sure I'd bother as we're going to add overflow checking to make_fixnum at some point anyway. This stuff should be documented in the manual, too, next to the documentation of most-positive-fixnum and fixnump respectively. Thanks again for taking this on. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 18:11:47 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 22:11:47 +0000 Received: from localhost ([127.0.0.1]:34860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9dFT-0000CO-3c for submit@debbugs.gnu.org; Thu, 28 Mar 2019 18:11:47 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:50715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9dFQ-0000C7-IZ for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 18:11:46 -0400 Received: from lechazo.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x2SMBNDP016177; Thu, 28 Mar 2019 18:11:23 -0400 Received: by lechazo.home (Postfix, from userid 20848) id 3783C63E74; Thu, 28 Mar 2019 18:11:23 -0400 (EDT) From: Stefan Monnier To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Subject: Re: 27.0.50; integer in pcase sometimes compared by eq Message-ID: References: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> Date: Thu, 28 Mar 2019 18:11:23 -0400 In-Reply-To: <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Thu, 28 Mar 2019 22:51:39 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6513=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6513> : inlines <7045> : streams <1817053> : uri <2821538> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34781 Cc: Paul Eggert , 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > (let ((upat (cddr alt))) > (eq (car-safe upat) 'quote))) > (let ((val (cadr (cddr alt)))) > - (unless (or (integerp val) (symbolp val)) > + (unless (or (portable-fixnum-p val) (symbolp val)) > (setq memq-ok nil)) > (push (cadr (cddr alt)) simples)) > (push alt others)))) Really? I think the better option is below (since I think we should generally move away from `eq` and replace it with `eql`). Actually, the hunk below should have been installed at the same time I replaced `eq` with `eql` when testing against an integer. It was a mere oversight. Stefan diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el index 9de240154..d9a20b1ff 100644 --- a/lisp/emacs-lisp/pcase.el +++ b/lisp/emacs-lisp/pcase.el @@ -802,7 +802,7 @@ pcase--u1 ((> (length simples) 1) (pcase--u1 (cons `(match ,var . (pred (pcase--flip - ,(if memq-ok #'memq #'member) + ,(if memq-ok #'memql #'member) ',simples))) (cdr matches)) code vars From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 18:20:59 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 22:20:59 +0000 Received: from localhost ([127.0.0.1]:34867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9dON-0002RG-Ii for submit@debbugs.gnu.org; Thu, 28 Mar 2019 18:20:59 -0400 Received: from mail232c50.megamailservers.eu ([91.136.10.242]:54086 helo=mail37c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9dOK-0002R6-CL for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 18:20:57 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1553811646; bh=Hi7Q9WK/vtrRQVJtVeGLOKgVkdXAdIGHKw0N8bmf1B8=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=nXj2ov/QJ9A1FDckloCFdalveHhjQOV4rU9a+TvjDruqVkXsc2YWwllD5eLWT2/is GCA1TmmBefZcA7gKR+MagnX7JK/F1ISrYwNGr3NFxaZxneM1Rvq3pTkDC6bXgKDX7K j4s3QPD6wiG/tYA99ZXYAUlFGkQctNv2CwtnE03U= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2SMKioX025720; Thu, 28 Mar 2019 22:20:45 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: 27.0.50; integer in pcase sometimes compared by eq From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Thu, 28 Mar 2019 23:20:43 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> To: Stefan Monnier X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0209.5C9D48BE.0014, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=J+uEEjvS c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=iRZporoAAAAA:8 a=dYhmZKDN-mizJlkKm4UA:9 a=CjuIK1q_8ugA:10 a=NOBgFS-JBQ2l-kSd6-zu:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34781 Cc: Paul Eggert , 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 28 mars 2019 kl. 23.11 skrev Stefan Monnier : > Actually, the hunk below should have been installed at the same time > I replaced `eq` with `eql` when testing against an integer. It was > a mere oversight. And all this work just because I didn't know we had memql. Serves me = right. Thank you Stefan, I'll do the obvious (unless you beat me to it). I can still think of cases when portable-fixnum-p would be useful. I can = clean up the patch (according to Paul's comments), or just sit on it. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 18:38:57 2019 Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 22:38:57 +0000 Received: from localhost ([127.0.0.1]:34871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9dfl-0002tX-6q for submit@debbugs.gnu.org; Thu, 28 Mar 2019 18:38:57 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9dfi-0002tH-Vx for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 18:38:56 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A6DA6160873; Thu, 28 Mar 2019 15:38:48 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 1CK3SzyBCCz8; Thu, 28 Mar 2019 15:38:48 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EF22E160F33; Thu, 28 Mar 2019 15:38:47 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NmngGeA-Q78G; Thu, 28 Mar 2019 15:38:47 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D4830160873; Thu, 28 Mar 2019 15:38:47 -0700 (PDT) Subject: Re: 27.0.50; integer in pcase sometimes compared by eq To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= , Stefan Monnier References: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <96bb53d6-c1dc-097a-fadd-252aa1a81313@cs.ucla.edu> Date: Thu, 28 Mar 2019 15:38:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34781 Cc: 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 3/28/19 3:20 PM, Mattias Engdeg=C3=A5rd wrote: > I'll do the obvious (unless you beat me to it). When you do that, please also change the name of the local from memq-ok to memql-ok, for clarity. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 19:03:14 2019 Received: (at 34781-done) by debbugs.gnu.org; 28 Mar 2019 23:03:14 +0000 Received: from localhost ([127.0.0.1]:34886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9e3F-0005aK-N9 for submit@debbugs.gnu.org; Thu, 28 Mar 2019 19:03:14 -0400 Received: from mail158c50.megamailservers.eu ([91.136.10.168]:57262 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9e3D-0005a8-1Z for 34781-done@debbugs.gnu.org; Thu, 28 Mar 2019 19:03:12 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1553814185; bh=tmhWRK4tKmRUAg8Ksjxs0n0HLuGXHmL5tG68fvOAZFk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=P+0MjK+xeK8qbB5p3CHQmV4BvVk2sd4pglMMUD7ctCi3yEdm0LCMwGsYz4PjaWYjs QgJTm8n1UgK/eRoDVughHblg3gA3RkQkWOGptClBa00XlTHU7svG2dGju9IuDs3TJ0 5KeZc6/ilL4NdjRmB+vPv+4RC3q7mIwRo75K9qnU= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2SN32nh020687; Thu, 28 Mar 2019 23:03:04 +0000 Message-ID: <821c6aaec1660201230fe27a7e11105c70ccfe4f.camel@acm.org> Subject: Re: 27.0.50; integer in pcase sometimes compared by eq From: Mattias =?ISO-8859-1?Q?Engdeg=E5rd?= To: Paul Eggert , Stefan Monnier Date: Fri, 29 Mar 2019 00:03:01 +0100 In-Reply-To: <96bb53d6-c1dc-097a-fadd-252aa1a81313@cs.ucla.edu> References: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> <96bb53d6-c1dc-097a-fadd-252aa1a81313@cs.ucla.edu> Content-Type: multipart/mixed; boundary="=-D6eVshSVBH2Wfv84dpTl" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CTCH-RefID: str=0001.0A0B0214.5C9D52A9.0001, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=a8seC3aF c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=uRpLYGgG48skAcfiyREA:9 a=QEXdDO2ut3YA:10 a=N54-gffFAAAA:8 a=VHc5oxmVatJqw9GWTC0A:9 a=z_NbR0onJZBUx5gw:21 a=Fi5E_JMxm2_FdcgX:21 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34781-done Cc: 34781-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-D6eVshSVBH2Wfv84dpTl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit tor 2019-03-28 klockan 15:38 -0700 skrev Paul Eggert: > On 3/28/19 3:20 PM, Mattias Engdegård wrote: > > I'll do the obvious (unless you beat me to it). > > When you do that, please also change the name of the local from memq- > ok > to memql-ok, for clarity. Thanks. Done. Thanks for your help! I'm attaching the mostly cleaned-up patch (minus the necessary doc changes), in case someone will see some use for it. --=-D6eVshSVBH2Wfv84dpTl Content-Disposition: attachment; filename*0=0001-Add-bounds-for-portable-fixnums-and-portable-fixnum-.pat; filename*1=ch Content-Type: text/x-patch; name="0001-Add-bounds-for-portable-fixnums-and-portable-fixnum-.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBhNjBlNzhiZTVkZmMyMTcyMzQ1ZDE0MGYyY2Q4ZGYwYTc3YmVhMGExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFRodSwgMjggTWFyIDIwMTkgMjI6MTI6MzcgKzAxMDAK U3ViamVjdDogW1BBVENIXSBBZGQgYm91bmRzIGZvciBwb3J0YWJsZSBmaXhudW1zLCBhbmQgcG9y dGFibGUtZml4bnVtLXAKClRoZXNlIGFyZSB1c2VmdWwgZm9yIG1hY3JvcyB0aGF0IG5lZWQgdG8g ZGV0ZWN0IHdoZXRoZXIgYSBudW1iZXIgaXMgYQpmaXhudW0gb24gYW55IG1hY2hpbmUsIHNvIHRo YXQgdGhlIGJ5dGVjb2RlIGJlY29tZXMgcG9ydGFibGUgKEJ1ZyMzNDc4MSkuCgoqIHNyYy9kYXRh LmMgKG1vc3QtcG9zaXRpdmUtcG9ydGFibGUtZml4bnVtLCBtb3N0LW5lZ2F0aXZlLXBvcnRhYmxl LWZpeG51bSk6CiogbGlzcC9zdWJyLmVsIChwb3J0YWJsZS1maXhudW0tcCk6Ck5ldy4KKiBldGMv TkVXUyAoTGlzcCBDaGFuZ2VzKTogTWVudGlvbiBwb3J0YWJsZS1maXhudW0tcC4KLS0tCiBldGMv TkVXUyAgICAgfCAgNSArKysrKwogbGlzcC9zdWJyLmVsIHwgIDUgKysrKysKIHNyYy9kYXRhLmMg ICB8IDI0ICsrKysrKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCA3NDg2ZDZi Y2ZlLi4yYWIzYzViNGJiIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAt MTQyNCw2ICsxNDI0LDExIEBAIGxpa2UgJ2ZpbGUtYXR0cmlidXRlcycgdGhhdCBjb21wdXRlIGZp bGUgc2l6ZXMgYW5kIG90aGVyIGF0dHJpYnV0ZXMsCiBmdW5jdGlvbnMgbGlrZSAncHJvY2Vzcy1p ZCcgdGhhdCBjb21wdXRlIHByb2Nlc3MgSURzLCBhbmQgZnVuY3Rpb25zIGxpa2UKICd1c2VyLXVp ZCcgYW5kICdncm91cC1naWQnIHRoYXQgY29tcHV0ZSB1c2VyIGFuZCBncm91cCBJRHMuCiAKK1Np bmNlIHRoZSBzaXplIG9mIGZpeG51bXMgdmFyaWVzIGJldHdlZW4gcGxhdGZvcm1zLCB0aGUgbmV3 IHByZWRpY2F0ZQorJ3BvcnRhYmxlLWZpeG51bS1wJyBkZXRlcm1pbmVzIHdoZXRoZXIgYSBudW1i ZXIgaXMgYSBmaXhudW0gb24gYW55CittYWNoaW5lIHJ1bm5pbmcgdGhlIGN1cnJlbnQgRW1hY3Mg dmVyc2lvbi4gVGhlIGNvcnJlc3BvbmRpbmcgYm91bmRzCithcmUgJ21vc3QtbmVnYXRpdmUtcG9y dGFibGUtZml4bnVtJyBhbmQgJ21vc3QtbmVnYXRpdmUtcG9ydGFibGUtZml4bnVtJy4KKwogKysr CiAqKiBBbHRob3VnaCB0aGUgZGVmYXVsdCB0aW1lc3RhbXAgZm9ybWF0IGlzIHN0aWxsIChISSBM TyBVUyBQUyksCiBpdCBpcyBwbGFubmVkIHRvIGNoYW5nZSBpbiBhIGZ1dHVyZSBFbWFjcyB2ZXJz aW9uLCB0byBleHBsb2l0IGJpZ251bXMuCmRpZmYgLS1naXQgYS9saXNwL3N1YnIuZWwgYi9saXNw L3N1YnIuZWwKaW5kZXggZjFhMWRkZGQ4MS4uZWZhOWNkNDA2NSAxMDA2NDQKLS0tIGEvbGlzcC9z dWJyLmVsCisrKyBiL2xpc3Avc3Vici5lbApAQCAtMzc2LDYgKzM3NiwxMSBAQCBiaWdudW1wCiAg ICJSZXR1cm4gdCBpZiBPQkpFQ1QgaXMgYSBiaWdudW0uIgogICAoYW5kIChpbnRlZ2VycCBvYmpl Y3QpIChub3QgKGZpeG51bXAgb2JqZWN0KSkpKQogCisoZGVmdW4gcG9ydGFibGUtZml4bnVtLXAg KG9iamVjdCkKKyAgIlJldHVybiB0IGlmIE9CSkVDVCBpcyBhIGZpeG51bSBvbiBhbnkgbWFjaGlu ZSBydW5uaW5nIHRoaXMgRW1hY3MgdmVyc2lvbi4iCisgIChhbmQgKGludGVnZXJwIG9iamVjdCkK KyAgICAgICAoPD0gbW9zdC1uZWdhdGl2ZS1wb3J0YWJsZS1maXhudW0gb2JqZWN0IG1vc3QtcG9z aXRpdmUtcG9ydGFibGUtZml4bnVtKSkpCisKIChkZWZ1biBsc2ggKHZhbHVlIGNvdW50KQogICAi UmV0dXJuIFZBTFVFIHdpdGggaXRzIGJpdHMgc2hpZnRlZCBsZWZ0IGJ5IENPVU5ULgogSWYgQ09V TlQgaXMgbmVnYXRpdmUsIHNoaWZ0aW5nIGlzIGFjdHVhbGx5IHRvIHRoZSByaWdodC4KZGlmZiAt LWdpdCBhL3NyYy9kYXRhLmMgYi9zcmMvZGF0YS5jCmluZGV4IDE1YjYxMDZjZmUuLjZkNTBhMTRi ZGUgMTAwNjQ0Ci0tLSBhL3NyYy9kYXRhLmMKKysrIGIvc3JjL2RhdGEuYwpAQCAtNDExMCw2ICs0 MTEwLDMwIEBAIFRoaXMgdmFyaWFibGUgY2Fubm90IGJlIHNldDsgdHJ5aW5nIHRvIGRvIHNvIHdp bGwgc2lnbmFsIGFuIGVycm9yLiAgKi8pOwogICBWbW9zdF9uZWdhdGl2ZV9maXhudW0gPSBtYWtl X2ZpeG51bSAoTU9TVF9ORUdBVElWRV9GSVhOVU0pOwogICBtYWtlX3N5bWJvbF9jb25zdGFudCAo aW50ZXJuX2Nfc3RyaW5nICgibW9zdC1uZWdhdGl2ZS1maXhudW0iKSk7CiAKKyAgLyogVGhlIHNt YWxsZXN0IHBvcnRhYmxlIHZhbHVlIG9mIEVNQUNTX0lOVF9NQVguICAqLworICBpbnQgbGVhc3Rf ZW1hY3NfaW50X21heCA9IDIxNDc0ODM2NDc7ICAgLyogMioqMzEgLSAxICovCisKKyAgLyogTGFy Z2VzdCBhbmQgc21hbGxlc3QgdmFsdWVzIHRoYXQgYXJlIGd1YXJhbnRlZWQgdG8gYmUgcmVwcmVz ZW50YWJsZQorICAgICBhcyBmaXhudW1zIG9uIGFueSBtYWNoaW5lLiAgKi8KKyAgaW50IG1vc3Rf cG9zaXRpdmVfcG9ydGFibGVfZml4bnVtID0gbGVhc3RfZW1hY3NfaW50X21heCA+PiBJTlRUWVBF QklUUzsKKyAgaW50IG1vc3RfbmVnYXRpdmVfcG9ydGFibGVfZml4bnVtID0gLTEgLSBtb3N0X3Bv c2l0aXZlX3BvcnRhYmxlX2ZpeG51bTsKKworICBERUZWQVJfTElTUCAoIm1vc3QtcG9zaXRpdmUt cG9ydGFibGUtZml4bnVtIiwKKyAgICAgICAgICAgICAgIFZtb3N0X3Bvc2l0aXZlX3BvcnRhYmxl X2ZpeG51bSwKKyAgICAgICAgICAgICAgIGRvYzogLyogVGhlIGxhcmdlc3QgaW50ZWdlciByZXBy ZXNlbnRhYmxlIGFzIGEgZml4bnVtIG9uIGFueSBwbGF0Zm9ybS4KK1RoaXMgdmFyaWFibGUgY2Fu IGJlIHVzZWQgdG8gZW5zdXJlIHBvcnRhYmlsaXR5IG9mIGJ5dGVjb2RlIHRoYXQgd29ya3MKK3dp dGggZml4bnVtcy4gIEl0IGNhbm5vdCBiZSBzZXQ7IHRyeWluZyB0byBkbyBzbyB3aWxsIHNpZ25h bCBhbiBlcnJvci4gICovKTsKKyAgVm1vc3RfcG9zaXRpdmVfcG9ydGFibGVfZml4bnVtID0gbWFr ZV9maXhudW0gKG1vc3RfcG9zaXRpdmVfcG9ydGFibGVfZml4bnVtKTsKKyAgbWFrZV9zeW1ib2xf Y29uc3RhbnQgKGludGVybl9jX3N0cmluZyAoIm1vc3QtcG9zaXRpdmUtcG9ydGFibGUtZml4bnVt IikpOworCisgIERFRlZBUl9MSVNQICgibW9zdC1uZWdhdGl2ZS1wb3J0YWJsZS1maXhudW0iLAor ICAgICAgICAgICAgICAgVm1vc3RfbmVnYXRpdmVfcG9ydGFibGVfZml4bnVtLAorICAgICAgICAg ICAgICAgZG9jOiAvKiBUaGUgbGVhc3QgaW50ZWdlciByZXByZXNlbnRhYmxlIGFzIGEgZml4bnVt IG9uIGFueSBwbGF0Zm9ybS4KK1RoaXMgdmFyaWFibGUgY2FuIGJlIHVzZWQgdG8gZW5zdXJlIHBv cnRhYmlsaXR5IG9mIGJ5dGVjb2RlIHRoYXQgd29ya3MKK3dpdGggZml4bnVtcy4gIEl0IGNhbm5v dCBiZSBzZXQ7IHRyeWluZyB0byBkbyBzbyB3aWxsIHNpZ25hbCBhbiBlcnJvci4gICovKTsKKyAg Vm1vc3RfbmVnYXRpdmVfcG9ydGFibGVfZml4bnVtID0gbWFrZV9maXhudW0gKG1vc3RfbmVnYXRp dmVfcG9ydGFibGVfZml4bnVtKTsKKyAgbWFrZV9zeW1ib2xfY29uc3RhbnQgKGludGVybl9jX3N0 cmluZyAoIm1vc3QtbmVnYXRpdmUtcG9ydGFibGUtZml4bnVtIikpOworCiAgIERFRlNZTSAoUXdh dGNoZXJzLCAid2F0Y2hlcnMiKTsKICAgREVGU1lNIChRbWFrdW5ib3VuZCwgIm1ha3VuYm91bmQi KTsKICAgREVGU1lNIChRdW5sZXQsICJ1bmxldCIpOwotLSAKMi4yMC4xCgo= --=-D6eVshSVBH2Wfv84dpTl-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 29 04:48:16 2019 Received: (at 34781) by debbugs.gnu.org; 29 Mar 2019 08:48:16 +0000 Received: from localhost ([127.0.0.1]:35034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9nBP-0005iZ-M8 for submit@debbugs.gnu.org; Fri, 29 Mar 2019 04:48:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9nBN-0005iN-OQ for 34781@debbugs.gnu.org; Fri, 29 Mar 2019 04:48:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9nBH-0005e3-2L; Fri, 29 Mar 2019 04:48:07 -0400 Received: from [176.228.60.248] (port=3561 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h9nBG-0002P0-88; Fri, 29 Mar 2019 04:48:06 -0400 Date: Fri, 29 Mar 2019 11:48:07 +0300 Message-Id: <83bm1ujcc8.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-reply-to: <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Thu, 28 Mar 2019 22:51:39 +0100) Subject: Re: bug#34781: 27.0.50; integer in pcase sometimes compared by eq References: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34781 Cc: eggert@cs.ucla.edu, monnier@iro.umontreal.ca, 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Mattias Engdegård > Date: Thu, 28 Mar 2019 22:51:39 +0100 > Cc: monnier@iro.umontreal.ca, 34781@debbugs.gnu.org In addition to Paul's comments: > +Since the size of fixnums varies between platforms, the new predicate > +'portable-fixnum-p' can be used to determine whether a number is > +a fixnum on any machine running the current Emacs version. This entry lacks a header. NEWS is viewed in Outline mode, so it should have headers that start with one or more '*' characters. Please add a header for this item, and please make it short enough to fit on a single line. Also, it is advisable to accompany user-visible changes with suitable changes in documentation, in this case the ELisp manual. If you do provide patches for the manuals, the NEWS entry should be marked with "+++" to indicate that all the documentation will have been updated when the patch is pushed. > +(defun portable-fixnum-p (object) > + "Return t if OBJECT is a fixnum on any machine running the current > +Emacs version." Suggest to rephrase: "Non-nil if OBJECT is a fixnum on any platform. The value will be nil if OBJECT is not a number, or if its value needs more bits than a fixnum can support on some platforms." > + DEFVAR_LISP ("most-positive-portable-fixnum", > + Vmost_positive_portable_fixnum, > + doc: /* The greatest integer that is represented efficiently > +on any machine running this version of Emacs. The first line of any doc string must not be a complete sentence. This is because apropos commands only display the first line of the doc string. So I suggest to reword: The largest integer representable as fixnum on any platform. > + DEFVAR_LISP ("most-negative-portable-fixnum", > + Vmost_negative_portable_fixnum, > + doc: /* The least integer that is represented efficiently > +on any machine running this version of Emacs. Similarly here. Thanks for working on this. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 29 05:52:47 2019 Received: (at 34781) by debbugs.gnu.org; 29 Mar 2019 09:52:47 +0000 Received: from localhost ([127.0.0.1]:35057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9oBr-00011Y-4C for submit@debbugs.gnu.org; Fri, 29 Mar 2019 05:52:47 -0400 Received: from mail226c50.megamailservers.eu ([91.136.10.236]:54838 helo=mail36c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9oBo-00011M-AP for 34781@debbugs.gnu.org; Fri, 29 Mar 2019 05:52:45 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1553853152; bh=12hnRn+ybVq9miIk3Bz/yDV3bLrkJM5On2iQzOTi9hA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=eFm0L88e0hBTICILwxr4VC0CH9hIEm+A9+lG7HtxBCpOO6/TUxh3j6Qy74tEVVXw1 U77gpCqp0Nw9iw/e8RNDyMZeOIIjEW16xLWwGNRR0SzkNhFZvYXUuW41DyB62BeHX6 c6xhq8n71oJyGzVkz6sAwUMm2JKs8Ro5eeTGo/go= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail36c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2T9qTQC004806; Fri, 29 Mar 2019 09:52:31 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: bug#34781: 27.0.50; integer in pcase sometimes compared by eq From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83bm1ujcc8.fsf@gnu.org> Date: Fri, 29 Mar 2019 10:52:28 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> <83bm1ujcc8.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0201.5C9DEAE0.008B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=XOQetzpE c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=1nWaLn1d9_zNbAjQBPUA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34781 Cc: Paul Eggert , monnier@iro.umontreal.ca, 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 29 mars 2019 kl. 09.48 skrev Eli Zaretskii : >=20 > In addition to Paul's comments: Eli, thanks for your kind review. Since portable-fixnum-p turned out not = to be necessary for this bug after all, I decided not to go ahead with = the patch. If you think it is still valuable enough on its own, say so = and I'll polish it according to your notes. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 29 08:34:14 2019 Received: (at 34781) by debbugs.gnu.org; 29 Mar 2019 12:34:14 +0000 Received: from localhost ([127.0.0.1]:35087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9qi6-0007OD-Ep for submit@debbugs.gnu.org; Fri, 29 Mar 2019 08:34:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9qi3-0007Nz-EB for 34781@debbugs.gnu.org; Fri, 29 Mar 2019 08:34:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9qhv-0006Dv-LQ; Fri, 29 Mar 2019 08:34:04 -0400 Received: from [176.228.60.248] (port=1708 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h9qhs-0000ZW-WC; Fri, 29 Mar 2019 08:34:03 -0400 Date: Fri, 29 Mar 2019 15:33:49 +0300 Message-Id: <835zs1kggi.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-reply-to: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Fri, 29 Mar 2019 10:52:28 +0100) Subject: Re: bug#34781: 27.0.50; integer in pcase sometimes compared by eq References: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> <83bm1ujcc8.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34781 Cc: eggert@cs.ucla.edu, monnier@iro.umontreal.ca, 34781@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Mattias Engdegård > Date: Fri, 29 Mar 2019 10:52:28 +0100 > Cc: Paul Eggert , monnier@iro.umontreal.ca, > 34781@debbugs.gnu.org > > 29 mars 2019 kl. 09.48 skrev Eli Zaretskii : > > > > In addition to Paul's comments: > > Eli, thanks for your kind review. Since portable-fixnum-p turned out not to be necessary for this bug after all, I decided not to go ahead with the patch. If you think it is still valuable enough on its own, say so and I'll polish it according to your notes. I do think that something like that would be useful in the long run, yes. Not terribly important, though, so if you have better uses for your time, I won't push. Thanks. From unknown Thu Jun 19 14:04:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Apr 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator