GNU bug report logs - #34776
27.0.50; Some questions about choose-completion-string-functions

Previous Next

Full log

Message #17 received at 34776 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Glenn Morris <rgm <at> gnu.org>, 34776 <at> debbugs.gnu.org
Subject: Re: bug#34776: Acknowledgement (27.0.50;
 Some questions about choose-completion-string-functions)
Date: Tue, 09 Apr 2019 20:03:17 -0400

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> So never mind! But I'd still like to add something like the attached, as
> functions following the current docstring will raise an error.
>
> Eric
>
> diff --git a/lisp/simple.el b/lisp/simple.el
> index d4ae5ebb1f..0274bdb459 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -8188,6 +8188,9 @@ choose-completion-string-functions
>  BUFFER - the buffer in which the choice should be inserted,
>  BASE-POSITION - where to insert the completion.
>  
> +Functions should also accept and ignore a potential fourth
> +argument, passed for backwards compatibility.
> +

Looks good to me.  And it can go to emacs-26 since it's a doc fix.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.